GitLab

Probably an unintentional paste.
Introduced by https://chromium-review.googlesource.com/1080985

TBR=atotic@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie937b6886ed2ff0301d192354f0e7bc64b012453
Reviewed-on: https://chromium-review.googlesource.com/1092691
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565610}

This CL is needed to make the preconnect predictor work with the Network
Service. The CL removes the LoadingPredictorObserver class that has been
notified by the ChromeResourceDispatcherHostDelegate and introduces instead the
LoadingPredictorTabHelper which implements the WebContentsObserver to notify
the predictor about resource loads.

All uses of the net::URLRequest and predictors::URLRequestSummary was replaced
by using the predictors::NavigationID or the content::mojom::ResourceLoadInfo.

The WebContentsObserver::ResourceLoadComplete() should work with and
without the Network Service, so we don't have to keep the old path.

Bug: 809583
Change-Id: I05c0aa97cfab1d773285633e6c5c3ef6a91367ca
Reviewed-on: https://chromium-review.googlesource.com/1039526
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565609}

This reverts commit c6e6fea4.

Reason for revert: Breaks WebRTC tests.

Original change's description:
> Setting dcheck_always_on for all chromium.webrtc.fyi bots.
> 
> We recently discovered DCHECK errors when WebRTC was rolling into
> Chromium, but they should have been caught by the chromium.webrtc.fyi
> waterfall.
> 
> Using dcheck_always_on in chromium.webrtc.fyi seems a good idea to
> reduce this kind of failures.
> 
> Bug: None
> Change-Id: Ibab78987f83cbacf2583c2a081b28082171c105b
> Reviewed-on: https://chromium-review.googlesource.com/1065733
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565580}

TBR=phoglund@chromium.org,dpranke@chromium.org,mbonadei@chromium.org

Change-Id: Ibf20c38a4e79ea5a21264bd5c6d09440044eb1c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/1092713Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565608}

Implement an initial MVP of the modal dialog that is shown during
WebAuthn requests. See the screenshot here: crbug.com/849323#c2.

The dialog is not yet interactive, even the `x` button does not yet
cancel the WebAuthn request (it does hide the dialog).

Bug: 849323
Change-Id: I3e1d9148f0727e33fb54e9bd1b747b84caa3c827
Reviewed-on: https://chromium-review.googlesource.com/964448
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565607}

https://chromium.googlesource.com/angle/angle.git/+log/81970bc..4b06c1e


git log 81970bc..4b06c1e --date=short --no-merges --format='%ad %ae %s'
2018-06-08 jiajia.qin@intel.com Add a test to expose boolean uniform bug on Intel windows


Created with:
  gclient setdep -r src/third_party/angle@4b06c1e

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:843369
TBR=geofflang@chromium.org

Change-Id: Idd424c050f3de1bd4b8bc9ae1c5330c210b67bba
Reviewed-on: https://chromium-review.googlesource.com/1092590Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565606}

Currently, you get CSSUnparsedValues when iterating entries on the
.computedStyleMap(), even for properties which are registered with a
type. However, if you do .computedStyleMap().get(...) with a registered
property, you _do_ get the correct type.

This is because ComputedStyleCSSValueMapping::Get properly looks up the
typed values on the ComputedStyle, but ::GetVariables does not; instead it
directly returns the CSSVariableData for everything, regardless of
registrations.

This patch changes the behavior of iteration to use the same code path
as .get(). This ensures that we either create a CSSCustomProperty-
Declaration on the fly for unregistered properties, or we re-use the
existing (and typed) CSSValue for registered properties.

Note: I initially wanted to do a nested iterator thing here, but dropped
      it because we would anyway need a temp HashSet to avoid potential
      duplicates from the StyleInheritedVariables-root.

Note: One caller of GetVariables() just wants the size. It's possibly a
      little overkill to create entire HashMap just to count something,
      but I don't want to resolve that here in the same patch.

R=futhark@chromium.org, haraken@chromium.org

Bug: 850072
Change-Id: I64bfb3cc22a377cf956420a9e64d47ca3daac1e2
Reviewed-on: https://chromium-review.googlesource.com/1090848Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565605}

Using wpt-import in Chromium 0798fbc3.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."
c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order."
4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19206

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=foolip

No-Export: true
Change-Id: I6ce9e1a0602b15eb19b18ac6609b447597be7753
Reviewed-on: https://chromium-review.googlesource.com/1092512
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565604}

Verified fix using a BrowserTest.

Verifying the fix properly meant fleshing out FakeConciergeClient with
settable response protos for all methods.

Found an invalid DCHECK of |state_| in CrostiniInstallerView when testing.

Guard CrostiniRestarterService::Abort.
There used to be a DCHECK, but it shouldn't be. It is a legitimate possibility
to cancel the install flow right when the the container startup was complete.

Bug: 850281
Change-Id: I0cf6bcef1f4f043d9c7e40f3a8baa458fb6f6ba7
Reviewed-on: https://chromium-review.googlesource.com/1089600Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565603}

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I67ba4fa23bebfb13d48791e089618907350c96e1
Reviewed-on: https://chromium-review.googlesource.com/1085061
Commit-Queue: Eric Noyau <noyau@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565602}

The remapping is no longer needed after
https://chromium-review.googlesource.com/1074750, which guarantees that
session IDs do not collide across restarts of the browser.

This reduces the number of IO operations, makes the sync protocol itself
more robust, and greatly simplifies a code that is believed to be
problematic.

Bug: 823798
Change-Id: I6f9192bdb1c2860136279d918e575748dd4e48af
Reviewed-on: https://chromium-review.googlesource.com/1086944
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565601}

This reverts commit 76b9b42d.

Reason for revert: no improvement observed via UMA.

Original change's description:
> Restrict deduping logic to syncable windows
> 
> Partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1062030
> 
> We've seen a recent spike in UMA metric Sync.SesssionsDuplicateSyncId
> due to recent changes in components/sync_sessions, which can by explain
> by a) an actual regression in the deduping logic or b) the broader
> counting of duplicates introduced in the patch.
> 
> We revert the latter here to investigate further.
> 
> Bug: 843554
> Change-Id: I509662956f54f755388605dc0c55bb889e0fbe37
> Reviewed-on: https://chromium-review.googlesource.com/1075333
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562269}

TBR=treib@chromium.org,mastiz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843554
Change-Id: I6cb3f0361b0a614618c7dbdcfcde70f95f9c99d6
Reviewed-on: https://chromium-review.googlesource.com/1092471Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565600}

Extension APIs can be called early before its Service Worker is in
running state. This CL queues up external requests from extension APIs
until the worker reaches EmbeddedWorkerStatus::RUNNING state.

Currently without the CL, FinishExternalRequest request before the
worker reaches RUNNING state results in killing the extension renderer process
from ExtensionServiceWorkerMessageListener. This is also responsible for
test flakiness

Bug: 850786
Change-Id: I353d72f7ce9b81354b29db050e1b69faa3d29841
Reviewed-on: https://chromium-review.googlesource.com/1088243
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565599}

We need to know in DataTypeManager why we stopping.
It will helps us determine if we need to clear sync metadata on data type stop.

This is first CL in sequence.

Bug: 823721
Change-Id: I7c20febbfc8ed820018f583f6de16bf3e269333a
Reviewed-on: https://chromium-review.googlesource.com/1091752
Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565598}

We want to simplify the code as much as possible to enable sandboxing.
DXDiag seems like something that we won't give access to by default.

Bug: 850878
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I450cb6b6caf64c4299d286b8c38940fbe65e1432
Reviewed-on: https://chromium-review.googlesource.com/1092495Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565597}

enable password generation if UiFood flag is on

Bug: None
Change-Id: Idb3054cba314b9d63eb4b5434d0969be604b7261
Reviewed-on: https://chromium-review.googlesource.com/1078108
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565596}

As a replacement for the EDK peer connection API, this CL adds a
notion of isolated Mojo invitations by supporting a new flag on
MojoSendInvitation and MojoAcceptInvitation. Isolated invitations
allow two processes to communicate via Mojo without joining each
others' process graph.

A follow-up change will convert all uses of PeerConnection to the
new API.

Bug: 844763
Change-Id: I5966f83c4077da28bce8b2b3224d4f4efe9a4c3d
Reviewed-on: https://chromium-review.googlesource.com/1090233
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565595}

This reverts commit 1eea870b.

Reason for revert: Consistent failures on Mac10.10 Tests in
BrowserWindowTouchBarUnitTest.BackForwardCommandUpdate
BrowserWindowTouchBarUnitTest.TouchBarItems
BrowserWindowTouchBarUnitTest.ReloadOrStopTouchBarIte
since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32927 which introduced this change.

Original change's description:
> Remove Cocoa Dependency from BrowserWindowTouchBar
> 
> To make the BrowserWindowTouchBar available to MacViews,
> modify the class so that it no longer depends on Cocoa
> code to receive updates for the touch bar item states.
> 
> This CL converts BookmarkTabHelperDelegate to
> BookmarkTabHelperObserver so that BrowserWindowTouchBar
> can observe the current web contents for starred changes.
> 
> Overview CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/1086867
> 
> Bug: 841714
> Change-Id: Id8944ad085d87288bcda767a53bb1abfe5c0eab9
> Reviewed-on: https://chromium-review.googlesource.com/1090315
> Commit-Queue: Sarah Chan <spqchan@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565570}

TBR=ellyjones@chromium.org,spqchan@chromium.org

Change-Id: Ib94fb94b70fbbd103ea73c570577e728e4e96b2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 841714
Reviewed-on: https://chromium-review.googlesource.com/1092538Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565594}

With https://crrev.com/c/1070158, base::Bind() supports
block so convert uses of base::BindBlockArc() to instead
use base::BindOnce() or base::BindRepeating().

Fix new usages introduced after https://crrev.com/c/1085459.

Bug: 701275
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I39d3cb4d63a2df8918fe5640231209916544ec31
Reviewed-on: https://chromium-review.googlesource.com/1090911Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565593}

With https://crrev.com/c/1070158, base::Bind() supports
block via base::RetainBlock(). Converts uses of the now
deprecated base::BindBlock().

Bug: 701275
Change-Id: I29af785c8768b5d738ed80aff0724f0d71df5434
Reviewed-on: https://chromium-review.googlesource.com/1090913Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565592}

adds a pc.close() to all RTCPeerConnections in promise_test
and async_test. This is codemod-powered by this:
https://github.com/fippo/webrtc-codemods/blob/e844b2467cbb76a231c113366b2451cf248f53bc/wpt-rtcpeerconnection-no-helpers

BUG=836871

Change-Id: Iee84ef938bf477a55612b6012c6de464c6aea55b
Reviewed-on: https://chromium-review.googlesource.com/1049983
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565591}

Create TestEntryCapabilities and store it in TestEntryInfo, which will
store the capabilities for a file or folder entry.
This is pre-work to support capabilities in browser tests.

Bug: 719959
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9708217333bdd775b6e75b94697b6002db244aca
Reviewed-on: https://chromium-review.googlesource.com/1081771
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565590}

Bug: chromium:840789
Change-Id: I03c307038cb5c2a6bdea1d821e347128e5368125
Reviewed-on: https://chromium-review.googlesource.com/1092216
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565589}

The way to handle '_' in identifier is described Web IDL spec.
We don't need a confusing comment as if it comes from our IDL compiler implementation.
https://heycam.github.io/webidl/#idl-names


Bug: 820353
Change-Id: Iba6c851daa6ae0dc6d690b220a5c757d507e4dc7
Reviewed-on: https://chromium-review.googlesource.com/1092217Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565588}

This CL enables the PasswordRequirementsSpecFetcherImpl to deal with
interleaved requests: For example during browser startup there may be may
lookups to the same destination that are triggered before the server can
respond. This CL ensures that only one request is sent per destination.

Bug: 846694
Change-Id: If1a8df39b2f32945f7fb6eb24374d0db2f1de8e9
Reviewed-on: https://chromium-review.googlesource.com/1090715
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565587}

Starting main controller creates some WebStateListObservers.
Overriding tab models after that will randomly crash as some observer
keep a zombie version of the webStateList.
Reverse the order of these steps in URLOpenerUnittests

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ida7fe67d39ee9724a9946eea8220ea4f7a21cf21
Reviewed-on: https://chromium-review.googlesource.com/1090849
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565586}

win-annotator-rel is failing as it cannot build all of the build targets
for network traffic annotation tests on Windows. The set is reduced to
Chrome binary and will be increased later to cover all required targets.

Bug: 844014
Change-Id: I9826e977717ec3789e1bab68eb8e0310c9359827
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1090927Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565585}

One of IdentityProvider's clients' use cases is to fetch access tokens
for the active account. IdentityProvider currently provides no explicit
mechanism for this, instead letting clients directly interact with the
underlying OAuth2TokenService instance via GetTokenService(). However,
it's necessary to decouple IdentityProvider from OAuth2TokenService at
an interface level in order to allow for porting ProfileIdentityProvider
to be backed by IdentityManager.

This CL adds an explicit interface for clients of IdentityProvider to
request access tokens for the active account. This interface is
currently implemented directly in IdentityProvider itself, as it is
common to ProfileIdentityProvider and DeviceIdentityProvider. Before
porting ProfileIdentityProvider to be backed by IdentityManager we
will move this implementation out into those two derived classes,
temporarily duplicating it. However, we will only do that when we are
just at the point of porting ProfileIdentityProvider away from using
ProfileOAuth2TokenService.

Bug: 809452
Change-Id: I402af0cb19b5e0057edc3870ca2a8f564f4f8e10
Reviewed-on: https://chromium-review.googlesource.com/1089051Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565584}

This reverts commit 6a0b1fb9.

Reason for revert: Is it possible that with this fix an unconditional initialization became an occasional uninitialized use?

Details:
Consistent failues on Linux ChromiumOS MSan Tests of Service/GLES2DecoderTest.CreateAbstractTexture since the first build with this CL: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7503
FindIt also suspected this CL to be the cause with 91% chance.

Original change's description:
> Fixed |service_id| for validating decoder's AbstractTextures.
> 
> For some reason, we were setting the service ID to 1 unconditionally
> when creating an AbstractTexture in the validating decoder.
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I809e1aa2c23d6bebe999dae7abd70eb4cbfba719
> Reviewed-on: https://chromium-review.googlesource.com/1091647
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565483}

TBR=liberato@chromium.org,piman@chromium.org

Change-Id: I3675c3b89959cc2799a5123c6a6173f64d0c70ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1092570Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565583}

    *-dbg packages are deprecated in favor of *-dbgsym
    (cf https://wiki.debian.org/AutomaticDebugPackages)
    Some *-dbg packages may have conflicting version requirements,
    which would cause the script to abort.
    That's another good reason to favor -dbgsym version.

R=dpranke@chromium.org

    the fix to all libraries via refactorization (50 lines saved).
    BTW, this leads to more debug-symbols packages to be detected and installed.

NB: it has already been fixed for libglib2 and libpixman, but this extends
Change-Id: I13f252b05ab95fb17eb8851d3b5a2b1b7a7d6295
Reviewed-on: https://chromium-review.googlesource.com/1080607Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#565582}

This extends VideoFrame to be able to use the new shared memory API. It
does not remove support for the legacy API, so that clients can be
migrated individually.

Bug: 849207
Change-Id: Ibd80588c57bf65143dd249edd8d2b4ef620c9132
Reviewed-on: https://chromium-review.googlesource.com/1084485Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565581}

We recently discovered DCHECK errors when WebRTC was rolling into
Chromium, but they should have been caught by the chromium.webrtc.fyi
waterfall.

Using dcheck_always_on in chromium.webrtc.fyi seems a good idea to
reduce this kind of failures.

Bug: None
Change-Id: Ibab78987f83cbacf2583c2a081b28082171c105b
Reviewed-on: https://chromium-review.googlesource.com/1065733
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565580}

This is required to allow us to roll to a Fuchsia SDK revision with the
new paths, update Chromium dependencies, and then this extra path will
be removed.

TBR: sergeyu
Change-Id: Ib4c7b8f874a8fdc5bbac85f0cd7c06e505002829
Reviewed-on: https://chromium-review.googlesource.com/1092312Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565579}

Change-Id: Iabd0565de1e044290a444e734a6d79ccb1c20faa
Reviewed-on: https://chromium-review.googlesource.com/1092490Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565578}

This change overrides the bounds change reason to be snapped over
drag_move. Otherwise, when drag a window into snapped mode, the
drag to reposition reason will override the snap reason for bound
change. The server will then send the incorrect reason to ARC++ side.

With this change, ARC++ N and P will correctly turn into snapped mode
when drag a window to side.

Bug: 848626
Change-Id: I0174ea36166ad378f2ba6d935d3ab32b5ece98ae
Reviewed-on: https://chromium-review.googlesource.com/1084574
Commit-Queue: Yunfan Chen <yunfanc@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565577}

This reverts commit 738c6fa6.

Reason for revert: Failed Linux Chromium OS ASan LSan Tests (1) every time since being enabled.
First bad build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27807

Original change's description:
> Enable NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks on ChromeOS.
> 
> The test failed because rendering the NTP was blocked on loading
> machine statistics, which was done from a TaskPriority::BACKGROUND
> task. The priority of that task was changed to
> TaskPriority::USER_BLOCKING in
> https://chromium-review.googlesource.com/c/chromium/src/+/1082608, so
> the test can be enabled.
> 
> The test is still disabled when Mash is enabled, because the
> non-empty paint signal isn't fired in this case (even when background
> tasks aren't disabled).
> 
> Bug: 831835
> Change-Id: Ie847b152b057883f62bef060c6294a427980c838
> Reviewed-on: https://chromium-review.googlesource.com/1082609
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565421}

TBR=avi@chromium.org,fdoray@chromium.org

Change-Id: I7f045845726b0075c639f4708ff183a741d60a1e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831835
Reviewed-on: https://chromium-review.googlesource.com/1092530Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565576}

https://pdfium.googlesource.com/pdfium.git/+log/1c06e11..e4d73cb


git log 1c06e11..e4d73cb --date=short --no-merges --format='%ad %ae %s'
2018-06-08 rharrison@chromium.org Update comments in SUPPRESSIONS for xfa_specific


Created with:
  gclient setdep -r src/third_party/pdfium@e4d73cb

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ibb595c2cec9bf8824aa3c1b93f43e67fa9fe0989
Reviewed-on: https://chromium-review.googlesource.com/1092100Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565575}

Make sure forward declaration is not used to just avoid
declaring dependencies in the common/BUILD.gn.

That is, DrmDevice is a drm platform's class, which shouldn't be known
by the ozone/common.

To fix this, return GbmDeviceLinux instead and add AsGbmDeviceLinux method
to the DrmDevice class to return downcasted pointer to self, and move
ScanoutBufferGenerator to drm/gpu as long as it's not needed by the
Wayland with dmabuf approach at this stage.

Bug: 820047
Change-Id: I25703db41234275e0c0cb5aaefe0e61964a50e83
Reviewed-on: https://chromium-review.googlesource.com/1088690Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#565574}

Web IDL spec allows hyphen since August 2014.
https://heycam.github.io/webidl/#idl-grammar
This CL follows the update.


Bug: None
Change-Id: I695eed71417b524755b980f3efed5107bc7d29bf
Reviewed-on: https://chromium-review.googlesource.com/1092219Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565573}

These tests are flaky on this bot. Disable them for now so that we do
not block the CQ.

Bug: 793426
Test: Disable tests
Change-Id: I12cd105bd2c57a44156a04e33f1a456f4492a996
Reviewed-on: https://chromium-review.googlesource.com/1092311Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565572}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d993e197..739f5abc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7260a9a26406022cdfd1e4c0908da26996e391f3
Reviewed-on: https://chromium-review.googlesource.com/1091952Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565571}