- 07 Jul, 2020 40 commits
-
-
Cammie Smith Barnes authored
https://chromium-review.googlesource.com/c/chromium/src/+/2264857 caused a performance regression when adding a metric to measure when frames are first eligible to be painted. This CL is to fix that regression by adjusting the new metric's implementation. TBR=johnidel@chromium.org Bug: 1100404 Change-Id: Ia730bc69a7ac5669c1c7b8c291baa6abb96c5929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276674 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#785695}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4147.51-1593425684-benchmark-85.0.4183.11-r1 to 86-4147.51-1593427277-benchmark-86.0.4190.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia4c25e02991c850fdf9213df628c89940f25a026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785694}
-
arthursonzogni authored
There are 4 headers: - Cross-Origin-Opener-Policy: 3 values. - Cross-Origin-Opener-Policy-Report-Only: 3 values. - Cross-Origin-Embedder-Policy: 2 values. - Cross-Origin-Embedder-Policy-Report-Only: 2 values. I was asked to produces tests about the different configurations. There are up to 24 possibilities. Currently, we are producing a new test file for every combinaison, like: page_with_coop_and_coep.html{,mock-http-headers} If we want to test further, the number of files is going to grow quickly. Moreover we would have to produce very complex name: page_with_coop_ro_same_origin_allow_opener_coop_same_origin_coep.html It would be better if we could specify the headers to use in tests. This is possible thanks to the "/set-headers?" handler. The file above can be replaced by the path: "/set-headers?" "Cross-Origin-Opener-Policy: same-origin-allow-popups&" "Cross-Origin-Opener-Policy-Report-Only: same-origin&" "Cross-Origin-EmbedderPolicy: require-corp" This is much more readable and flexible. This patch deletes all the current files we have and use "/set-header?" instead. Bug: chromium:1090273 Change-Id: I67195f0940c4bb1a873014fe69c49321dcf76774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279803Reviewed-by:Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785693}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9585c468a280..92554d75f354 2020-07-06 rharrison@chromium.org Update path of third_party/spirv-tools to SPIRV-Tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0e04f22134b2d6437934142a45672509bb6bf0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284080Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I284183d571b9119a5a8268cf26dbaaea1a94d383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284695Reviewed-by:
-
Denis Kuznetsov authored
This CL introdces WizardContext object that would be used to pass data between screens in a unified way. Due to implementation complexities, ErrorScreen might get null context now, it will be resolved later. Also this CL updates mocking syntax to a new approach that does not require to specify number of arguments. Bug: 1102342 Change-Id: I38ed842c9450cc87d2c0d0ac0dc925525280dac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282928 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785690}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5a61ad5add24..b4c97323611f 2020-07-07 nigi@chromium.org Change the parameter type for DrawFillStrokePath() and DrawCosmeticLine(). 2020-07-07 nigi@chromium.org Make DrawTextPath() use CFX_FillRenderOptions struct as a parameter. 2020-07-07 thestig@chromium.org Add checkout_google_benchmark GN variable to DEPS. 2020-07-06 thestig@chromium.org Roll build/ 1077afd5c..29bc35230 (34 commits) 2020-07-06 thestig@chromium.org Use GetDecoderArray() in CPDF_ImageRenderer::HandleFilters(). 2020-07-06 thestig@chromium.org Roll build/ 20016b0d4..1077afd5c (1 commit) 2020-07-06 thestig@chromium.org Roll build/ 414118826..20016b0d4 (23 commits) 2020-07-06 thestig@chromium.org Roll build/ d4fe00fc1..414118826 (1 commit) 2020-07-06 thestig@chromium.org Remove obsolete SkFontHost_mac.cpp entry in skia/BUILD.gn. 2020-07-06 thestig@chromium.org Roll third_party/skia/ c14701a51..1e6460d55 (486 commits) 2020-07-06 thestig@chromium.org Roll third_party/skia/ 7c1f3fabf..c14701a51 (1 commit) 2020-07-06 tsepez@chromium.org Perform more cleanup in FXGCScopedHeap destruction. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1537f1a1758f36a92c760a126b164ef480760178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284268Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 85-4176.0-1593430899-benchmark-85.0.4183.11-r1 to 86-4176.0-1593427948-benchmark-86.0.4190.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia81183a471ce5766345527d7481bd4e4bc9a5347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284786Reviewed-by:
-
Ehimare Okoyomon authored
Make the page info subpages also dismiss when there is a click on the outside part of the screen. Bug: 1077766 Change-Id: Ie4e1c7131ee3c169e819bd48cdea1d32584538b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283746Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#785687}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I29761ca2be9fd31e88a909b20f75252115c4c49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282755 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#785686}
-
Maksim Ivanov authored
Improve the test coverage for the ChallengeResponseAuthKeysLoader class by modeling a few error scenarios. Bug: 1052404 Change-Id: Ifd20fede1eff9f308ae4e9c2094b6d7b1cc7bc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270154Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#785685}
-
Peter Kasting authored
* Remove CustomFrameView::Init() and pass the widget to the constructor. * Make various NonClientFrameView Widget pointer members const to make it clear they are set at construction and never changed. * DCHECK those pointers at construction to make it clear they are never null. * Move the DCHECK in Widget::SetContentsView() up and remove conditionals around it to make it clear it always holds and no action need be taken. * Simplify some unittest code slightly. * Improve comments, including removing unnecessary (and not prevailing style) "section divider" comments and making the example code in callback_list.cc actually compile. Bug: none Change-Id: I2ff353e4a650307f7facbb680188eb0cbb26df67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282893 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#785684}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bd2a9ea85210..6a4da9da4215 2020-07-06 jaebaek@google.com Debug info preservation in copy-prop-array pass (#3444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I25ad2850f52216cd12c20893a22f7edc1cba21ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284628Reviewed-by:
-
Christian Dullweber authored
Use default constructors and range based for loops. Change-Id: I7f79f3da4329528c33de871edd6e9d64f3fb0cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283312 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#785682}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81923d6d2cc6..ce1375c5f044 2020-07-06 vadimsh@chromium.org [lucicfg] Update to v1.18.1. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If95b70c809232166afcd4c73a5459e037ad41ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284022Reviewed-by:
-
Mugdha Lakhani authored
This extends UrlBarOptions to enable setting a clicklistener and a longclicklistener which the embedder calls to override the click listeners set by WebLayer. The new UI that adds long click functionality to WebLayerShellActivity while keeping short click functionality intact, can be seen here: https://drive.google.com/file/d/1N_Jtz7ftK9LlDcee3PZBlVlwyMEkEner/view?usp=sharing Note that it's important to allow setting both long click and (short) click listeners, because merely setting a long click listener also causes the UrlBarView to consume click events and they're not passed up to the parent view. If the parent view would like to handle both, they should (and now can) set both listeners on the UrlBarView. Bug: 1097723 Change-Id: I8ddd8df29f9be37e25e956106bb484b47bd83497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274888Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#785680}
-
Ethan Jimenez authored
1. Refactoring `NGGridTrackRepeater` to store the `GridTrackSize` of its specified track definition; updating `NGGridTrackList::AddRepeater` to take the track sizes as a parameter and implicitly handle repeater indexes, which were unnecessarily specified by the caller. Adding grid track sizes in `NGGridTrackList` unit tests. 2. Fixing a bug in `NGGridBlockTrackCollection::FinalizeRanges` where ranges spanning implicit tracks after the explicit grid didn't resolve their respective repeater offsets correctly. 3. Introducing the concept of a "set" with the `NGGridSet` class; any range from the new algorithm collection is composed of distinct track definitions which compose a "set", see the class's definition for a detailed explanation of how these sets work. 4. Introducing `NGGridLayoutAlgorithmTrackCollection` - builds ranges and their respective sets from the `NGGridBlockTrackCollection` to be used in the track sizing algorithm in `NGGridLayoutAlgorithm`. 5. Adding unit tests for the new `NGGridLayoutAlgorithmTrackCollection` constructor and `NGGridLayoutAlgorithmTrackCollection::SetIterator`. Bug: 1045599 Change-Id: I31036f0cf91a958ed74ada31f5dce5d9087faf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272126 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785679}
-
Peter Kasting authored
Caching was introduced in 2014, when computing the preferred size involved repeatedly changing the text on the member label, laying it out, and computing a bunch of text metrics. All of that is gone now, and computing the preferred size should be reasonably performant; it can be made even more performant in the future by switching to a proper layout manager. In the meantime, this caching code not only complicates the code, it makes it fragile; the existing implementation has places that reset the cached value without actually firing PreferredSizeChanged(), for example, which looks bogus. Bug: none Change-Id: I9cda6ba526d9fceda7a86b07a1475a844c6cbae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283897Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#785678}
-
Mugdha Lakhani authored
This moves over the browser test that verifies incognito behavior from prerender_browsertest.cc to NoStatePrefetch browser tests. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: If40b001c1ef2fc772ad8726649ec8c8da47b314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282517Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#785677}
-
Christian Dullweber authored
Add a histogram to track deletion tasks from StoragePartition that take more than three minutes to complete. Bug: 1100260 Change-Id: I971dc05bf71012f7e67f9c24554d0ad0e2c36972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279897Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#785676}
-
Arthur Hemery authored
This patch introduces a new flag to gate SiteInstance and processes modifications in development for the crossOriginIsolated javascript property. Bug: 1055779 Change-Id: I87d894adda3d8e737b4233abaf04e4aa22bf6038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257324Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#785675}
-
Virender Singh authored
Page object data that PdfAccessibilityTree receives have |index_in_page| property. It is basically the index on that page object in the list of that type of page object. For e.g. |page_in_index| of a link is the index of the link in vector of links. The validation implemented in this change is to check that |index_in_page| is with in bounds of the page object vector. Change-Id: Ic3ccf0aa2d988adbe1f6e8dd373b0852c96cb4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279250 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785674} -
Rune Lillesveen authored
The CSS UI spec[1] says a negative outline-offset value should not shrink the rendered outline beyond twice the computed value of the outline-width in either direction. The calculations here happen in integer space (computed outline offsets are always integers) and an odd width/height will leave a single pixel distance between opposite outline edges. [1] https://drafts.csswg.org/css-ui/#outline-offset Bug: 1102024 Change-Id: I0a82d62278cac47a595c8d3b57158a3d2d141b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283584Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#785673}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85757b5481af..0b6df3ba1a45 2020-07-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-07 almuthanna@google.com Add E2E tests for Breakpoint test cases 2020-07-07 changhaohan@chromium.org Fix typos and use Set for lookup in ComputedStyleWidget 2020-07-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-07-06 aerotwist@chromium.org [TypeScript] TypeScript-ify formatter_worker/JavaScriptOutline.js 2020-07-06 jalyn@microsoft.com Instrument all actions for shortcut telemetry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1096230,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibec116602667437626c24dcf38f6096b7a095dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284624Reviewed-by:
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/18bGaUJgUnLlOepkFNhcaL1dfCJGOnHMw/view?usp=sharing Bug: 1063856 Change-Id: I85c2ed37f84b941a052af604623db44615832a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277810 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#785671}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I9d29ebbb3e40a9d5c51636363dda035234ee8747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279815Reviewed-by:
-
Wojciech Dzierżanowski authored
Exposing MediaSessionControllersManager implementation details to the unit test breaks encapsulation. Tests should not need updating if the implementation changes without a change in behavior. This is done in preparation for MediaSessionControllersManager refactoring in issue 1091203. Bug: 1091203 Change-Id: I75ed0967d3598b5e317a45a9241f392b2171b594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279873Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#785669}
-
nancylingwang@google.com authored
This is the preparing for removing the flag kAppServiceContextMenu. The AppService context menu feature has been enabled for a few release, and the flag is expired, so it can be removed in M86 release. There will be a few follow up CLs to remove the flag from other parts of the code. BUG=1016159 Change-Id: I2512bc661d8eefa8ef0e44c48d90a2372ec04f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280770 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
With this CL, LacrosManager starts using Mojo disconnection as a signal of lacros-chrome termination. There can be a scenario that lacros-chrome is still alive but Mojo error happens. However, even in the case, because there's no way for ash-chrome to communicate with lacros-chrome, lacros-chrome needs to be terminated anyways. To handle async operations, introduces State. Bug: 1091863 Test: Run locally in a device. Change-Id: Ic566dbaeaeed387d931a737a2b4946d020cd82c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276411 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#785667}
-
Roman Sorokin authored
To get rid of warning logs: GetUserLastInputMethod: no input method for this user Bug: none Change-Id: I52ab722bf2d50d69aa3392ae8a178a2742842b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282751 Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#785666}
-
K. Moon authored
Adds PPCompletionCallbackFromResultCallback() to wrap a base::OnceCallback as a pp::CompletionCallback. Note that due to differences in lifetime management between base::OnceCallback and pp::CompletionCallback, the resulting pp::CompletionCallback must be run exactly once to avoid resource leaks. Also defines ResultCallback as a convenient alias for a base::OnceCallback<void(int32_t)>. This callback signature appears in most asynchronous Pepper APIs. Bug: 1101169 Change-Id: Ica13eaea5085eccc419d6d05fcdec301c0ba82bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278231Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Rainhard Findling authored
This is a reland of 9d1db5b8 Fixes the missing import and constant. Original change's description: > Safety check: add tests for the Chrome cleaner child backend > > * Test that each possible CCT status results in the corresponding > safety check child status and display string. > * Test that CCT being enterprise managed is handled correctly. > > Bug: 1087263 > Change-Id: I84d93408800cb4fbe8d138578c586a0ae89dbfc9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249980 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Rainhard Findling <rainhard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783942} Bug: 1087263 Change-Id: Iddb785080835e437517c7adba7eacaec20356ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279752Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#785664}
-
Timothy Loh authored
Bug: b:151096611 Change-Id: Id6f99845ec2c1b9b466e3731347ff9cdea9a5267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283034Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#785663}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I063da221adcb770a97c98b9ef79cb34231569c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276763 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785662}
-
nancylingwang@google.com authored
This is the preparing for removing the flag kAppServiceContextMenu. The AppService context menu feature has been enabled for a few release, and the flag is expired, so it can be removed in M86 release. There will be a few follow up CLs to remove the flag from other parts of the code. BUG=1016159 Change-Id: I52c549e2300a579f0059f25ae35bb808e81cb64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279261 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamSource. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. CL also converts CreateMediaStream() in mediarecorder/media_recorder_unittest.cc. BUG=704136 R=guidou@chromium.org Change-Id: I8b461bcb3f00faec9e168f2b04d0fc4189e50179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283389Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#785660}
-
Alexander Hendrich authored
TBR=beaufort.francois@gmail.com Bug: 1070810 Change-Id: I502d44af5e5c1904332a55efea1f0bfe63f7eac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284484Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#785659}
-
Josip Sokcevic authored
This reverts commit f8a724c6. Reason for revert: https://crbug.com/1102063 Broke codesearch-gen for chromiumos Original change's description: > Reland "Remove references to cacheinvalidation from BUILD.gn files" > > This reverts commit ecc77be3. > > Reason for reland: ChromeOS compile failure should be resolved by > crrev.com/c/2276282 > > Original change's description: > > Revert "Remove references to cacheinvalidation from BUILD.gn files" > > > > This reverts commit 24f7513d. > > > > Reason for revert: This broke compilation on a chromeos bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/166646 > > > > Original change's description: > > > Remove references to cacheinvalidation from BUILD.gn files > > > > > > The cacheinvalidation library is deprecated, not used anymore, and will > > > be deleted soon. > > > > > > Bug: 1099672 > > > Change-Id: Ic8467c611b4d99294e06e0e5c848059ff77c3e26 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270151 > > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > > Commit-Queue: Marc Treib <treib@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#784345} > > > > TBR=treib@chromium.org,jochen@chromium.org > > > > Change-Id: I98e328e146aef8375ba58e2cd3bdedd1c64ef068 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1099672 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274611 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#784354} > > TBR=jochen@chromium.org > > Bug: 1099672 > Change-Id: Ie5c748f9bf3d17b1bad23621dd7a18d805301236 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276280 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785004} TBR=treib@chromium.org,jochen@chromium.org,dullweber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1099672 Change-Id: Ie88bcfb14355bfb55d20000140c7b566179859bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283734 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#785658}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I00cce8f4936234779bf3051e14ce0f1014f03b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284625Reviewed-by:
-
Chloe Pelling authored
Intended for use by sommelier; see https://crrev.com/c/2251280 Pressing the Search key will show the shelf regardless. Bug: 1084408, b/156401195 Change-Id: Icbeb7a37d74cfa4cf1543699b5695fc7c6960220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208159 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#785656}
-
