- 23 Sep, 2019 40 commits
-
-
Akihiro Ota authored
This change adds a hotkey in ChromeVox that allows the user to get the phonetic disambiguation for the current word in the node's name. If the user is on a node, then we speak the first word in the node's name. Upon activation, ChromeVox speaks each character in the word, followed by its phonetic disambiguation. Change-Id: I1a88c3256cf1084a971f6fc7fc47d5bfe847ab11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811988Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#699057}
-
Tarun Bansal authored
Add a navigation predictor keyed service that is notified of the new predictions about the next navigations. The keyed service exposes Observer interface which allows other observers to subscribe to the notifications from the keyed service. The next CL would add observers that would listen to the notifications and take actions. Change-Id: I8ded320cdf15c1d0120a64c2434f7b0d5d7b7da9 Bug: 1004465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816905Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699056}
-
Robert Ogden authored
Functionality is now subsumed by the original feature Bug: 1005295 Change-Id: Ia9894cbdcc33d37e1f9de53952443e53afe9f83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819819Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#699055}
-
Alex Moshchuk authored
Bug: 1004371 Change-Id: I62c91186f046b6701c8fdd1fded90f38d45188c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817286Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699054}
-
Anastasia Helfinstein authored
This addresses a bug in Switch Access (go/cros-switch) where users got stuck in editable text fields. The root cause was that the physical key events were perceived to be virtual key events by the Switch Access event handler. The solution is to more precisely identify which key events come from physical devices. Bug: 996893 Change-Id: Id39130ce7edc7f933c1be43f434b5a08f909f19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804395 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699053}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d239d4d3493a..55783c1d0403 git log d239d4d3493a..55783c1d0403 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 chiur@google.com Merge "Add gpu_track_tracker to prevent repeated GPU tracks" Created with: gclient setdep -r src/third_party/perfetto@55783c1d0403 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I851bfc054b0b8c88d2ff53de887fd7c0c0e116ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699052}
-
Matt Mueller authored
Provides a more concise method for creating an X509Certificate with the necessary intermediate(s). Change-Id: I20d1cedbc7ee177b27871e460b1db56aec8f4e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815994 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699051}
-
Kurt Catti-Schmidt authored
The following CL set up a pipeline to send a map of the system colors from the browser process to the render process: https://chromium-review.googlesource.com/c/chromium/src/+/1728056 This change takes those system colors and uses them in LayoutThemeWin::SystemColor(). This replaces the old logic of making API calls to get the system colors. LayoutThemeWin accesses the system colors stored in NativeTheme through WebThemeEngineDefault. Unit tests were added for conversions between Blink and NativeTheme types. This required pulling the static conversion methods into their own header. Bug: 970285 Change-Id: I842e5224aa3a97852eda13c3d86f90396262fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793742 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699050}
-
Alexei Filippov authored
There's no change to semantics. - got rid of ref-counted MostVisitedThreadSafe - made extensive use of movable vectors BUG=1006830 Change-Id: Iba70c2955f01ceaeac8771ca93af2258829f02a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819037Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#699049}
-
Yuly Novikov authored
deqp/functional/gles3/shaderstruct.html Flaky on Linux NVIDIA GL passthrough as well. TBR=kbr Bug: 965648 Change-Id: I6baa0c314a4aa2839cd9c9ae59470720cc7c5c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819519Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699048}
-
Esmael El-Moslimany authored
In this CL: - changed cr-icon-button to use -webkit-mask-image instead of background-image to make it easy to change the color of image icons - added an attribute 'a11y-enhanced' to <html> for settings, bookmarks, history, extensions, print preview and downloads when the WebUIA11yEnhancements flag is enabled - removed the style that hides 'subpage-arrow' and 'icon-external' since it is not really used and causes issues with the cr-icon-button (it sets the display to block instead of inline-flex) - fixed cr-link-row where it was using that no longer available 'iconClass' property - moved the background image icon inside of cr-icon-button because when it is used as a mask on the :host, the ripple would also be masked - when 'a11y-enhanced' attribute is set on <html>, make the cr-icon-button ripple opaque and change the color of the icon to the background color when a ripple is shown Bug: 1001742 Change-Id: Ia6d7f7c951003e440e7bca1cccf81ab849d98732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769586Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699047}
-
Michael Thiessen authored
Note that this is a speculative fix as I was unable to repro, but see the bug for context - I'm pretty certain this will fix the crash. This introduces NavigationController::RemoveForwardEntries which will attempt to remove any forward navigation entries (without crashing :)). Bug: 963783 Change-Id: Ic375e0e4fd89d4ded3a5229bf82ccb932e10ab5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775070 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#699046}
-
Yao Xiao authored
Add kThirdPartyServiceWorker, kThirdPartySharedWorker and kThirdPartyBroadcastChannel to opt_in_features list Bug: 976866 Change-Id: Ic3c4424dc2703234440c4e490d3b84dfed7a04ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808017Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#699045}
-
Peter Kasting authored
This also attempts to update the example code to match current style and be as short as possible. Bug: 82078 Change-Id: If068c395472f6a1243cb5e59dc2d7a8aa9e9cc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816294 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699044}
-
Kristi Park authored
The command_id for devices in the tab submenu were not incremented by index. Bug: 1005389 Change-Id: Ie22a3a9c54aed1056c0401d720eff907cea1281a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812237 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699043}
-
George Steel authored
Move all such tests into parsing. Eliminate duplicate tests and manual versions of automated tests. Change-Id: I0ef507a1832c9ce113ed1a855653af7fd22bb0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809508 Commit-Queue: George Steel <gtsteel@chromium.org> Auto-Submit: George Steel <gtsteel@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699042}
-
Jiawei Li authored
Previously, bindings_manager_cast target was guarded by is_linux. This should be available for all non-fuchsia builds. Bug: internal b/141398875 Test: CQ Change-Id: I21d95c65040956dd4446eff61dbd50acbb3f4e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815949Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#699041}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I313fd48f7c9384e4ae7af02ffc57dad83591bf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819645Reviewed-by:
-
Peter Kasting authored
Also takes advantage of initializer_list for vectors. Bug: 82078 Change-Id: Ic94d1971254f45fb6ec1925e30622e90f42224ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817414 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699039}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/341482072a19..49fd27d9af5f git log 341482072a19..49fd27d9af5f --date=short --no-merges --format='%ad %ae %s' 2019-09-23 jmadill@chromium.org Fix SwiftShader to use data_deps. 2019-09-23 jmadill@chromium.org Temporarily disable SwiftShader on Windows 7. 2019-09-23 jmadill@chromium.org Disable non-portable include path warning. 2019-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f7a48b153f2a..973d0e538292 (1 commits) 2019-09-21 jmadill@chromium.org Re-land "Vulkan: SwiftShader integration." Created with: gclient setdep -r src/third_party/angle@49fd27d9af5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:995046,chromium:None,chromium:b/140251624 Change-Id: I0e6bf53898368820c533de9f42964f60e1cc9e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819333Reviewed-by:
-
Alex Cooper authored
When a frame is requested from the runtime, a frame has to be submitted back to the runtime. Even if that frame is a "missing" frame, without any updated data. This change refactors the logic around requesting a frame to ensure that a frame isn't requested unless the callbacks would be serviced. If the state changes in the middle of a frame, then some base layer should still be present to end the frame/submit the missing frame back before it is removed. If these conditions aren't met, the frame loop could stall out and never be in a recoverable state. This change also adds some tests around these conditions. Bug: 1001730 Change-Id: I3b97322a7a8b1c15b37743c873382755fca7ec42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814102Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#699037}
-
Kevin Qin authored
Reverse the order of xrlocatespace so we can get the correct transform from local to stage Bug: 1000808 Change-Id: Ie6aa7b644ea2c6b730a17e5544995051d5f471cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816291Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Zheng Qin <zheqi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699036}
-
Evan Stade authored
Bug: 998625 Change-Id: I239558c07ce10166b82a2b886ef08a1d4ede56f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817333Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d166d2e62f3b..b3542d95da65 git log d166d2e62f3b..b3542d95da65 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 scroggo@google.com Rename SkOrientationMarker.cpp 2019-09-23 egdaniel@google.com Fix TEST_BUILDER name in perf recipe. 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-23 brianosman@google.com Minor SkSL cleanup 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-23 nigeltao@google.com Update Wuffs version 2019-09-23 egdaniel@google.com Remove Vulkan Nexus5x bot. 2019-09-23 bsalomon@google.com Make GrGpuResource ref counting atomic. 2019-09-23 fmalita@chromium.org [skottie] Fix motion blur asserts 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-23 brianosman@google.com Interpreter: Add bitwise operators Created with: gclient setdep -r src/third_party/skia@b3542d95da65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I003d226c9c7bb5336de4b8c2cc382a4c766eac58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819647Reviewed-by:
-
Adam Ettenberger authored
|LowestCommonAnchor| is always cheaper than |LowestCommonAncestor| when the ancestor position data is not needed. AXPlatformNodeTextRangeProviderWin::GetChildren does not use the position information, all information is available on the AXNode from calling |LowestCommonAnchor|. Bug: 928948 Change-Id: I48075202dca0172bfd6deea9188d3d636f996ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815224 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
-
Adam Ettenberger authored
|LowestCommonAnchor| is always cheaper than |LowestCommonAncestor| when the ancestor position data is not needed. AXPlatformNodeTextRangeProviderWin::ExpandToEnclosingUnit for TextUnit_Page only needs the |LowestCommonAnchor| to know the result of |AXNode::OwnerTree()->HasPaginationSupport|. Bug: 928948 Change-Id: Ida1926da0c1d54b2a9b57abd1867862daa4b4984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815350 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/770af0ab..37dd8faa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I94e2f86a702f79992a3b5c3c5328c38d187f04c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819596Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699031}
-
Mathieu Binette authored
Updating the celab package - important changes since the last version: - https://crrev.com/c/1808402: Install PackageManagement on all machines. - https://crrev.com/c/1804276: Always install latest sysinternal. - https://crrev.com/c/1738716: Making UI tests work on nested VM. + Removed duplicate webdriver create code in some tests (already in test_util). This fixes all new failing tests after the last WinServer2012 GCE image update: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=celab_tests Before: https://cr-buildbucket.appspot.com/build/8902049557331501056 After: https://cr-buildbucket.appspot.com/build/8901992308375043184 Change-Id: Ia626751ba97b2d54e155bb1cee4ee5fee261dd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808345 Commit-Queue: Mathieu Binette <mbinette@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699030}
-
Ben Kelly authored
In crrev.com/c/1699373 BEST_EFFORT tasks were changed to delay until after browser startup. This unfortunately seems to also delay any storage API access that is managed by quota since quota initialization uses a BEST_EFFORT task. This change modifies the quota sub-system to use a USER_VISIBLE task so that initialize can complete prior to browser startup completing. This is an appropriate priority since storage APIs like cache_storage can block loading which is a user visible action. Bug: 1006546,1005983,1004041 Change-Id: I7fd0659855f26d0f3c1caf0185f2e9723c55c483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819595Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#699029}
-
Ben Joyce authored
When transitioning to androidx, android_core and androidx_core have conflicting manifests, so we need be able to skip including one. Bug: 1006427 Change-Id: I4fc4fac5e27cad7a3574773a62aaf0978f33f4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817335 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699028}
-
manuk authored
Currently, the doc provider returns at most provider_max_matches_ docs, dropping any additional docs returned from the server. With this CL, the provider returns the remaining docs with a score of 0 so that they are displayed only if deduped with history, shortcut, or bookmark matches. This CL does not affect how many or which suggestions are displayed. It only helps format doc suggestions from other providers (e.g. 'Omnibox doc - 01/01/1991 - Google Docs'). Bug: 941548 Change-Id: I173b3f62d3af33f83a6531e086a0ecd0985db986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819629Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#699027}
-
Toni Barzic authored
With kEnableSearchBoxSelection feature, the focus stays within the search box while the selected result changes (instead of individual search results getting focused as selection changes) - this means that scroll view used by search results page does not handle selection changes automatically. This cl adds a callback to ResultSelectionController that SearchResultPageView can use to detect selection changes, and update the scroll bar to ensure the selected result is visible in the scroll view. Change-Id: Icf24b85174a12cac0b62592a080898cff6375da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819329Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#699026}
-
kylechar authored
Plumb callback and results between viz compositor and gpu threads. Bug: 982842 Change-Id: I1225757d42f4fc80a35ee556a76f401137971ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819621Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699025}
-
Manu Cornet authored
This reverts commit c113475d. Reason for revert: Didn't really serve its purpose. Reverting. Original change's description: > CrOS app list: skip visibility changes in an in valid display > > This is mostly useful for tests where the display ID starts off as this > invalid ID. > > Not adding a unit test in this change because after CL 1814222 at least > two tests will fail if this regresses. > > Bug: 982512 > Change-Id: Ie447aa88fda66794a722d7e9cf478749ff4f8398 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816734 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698656} TBR=xiyuan@chromium.org,newcomer@chromium.org,manucornet@chromium.org Change-Id: I4353f0ee3b10d481de13ab96be4b8c2b0801e8a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 982512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819636Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#699024}
-
Henrique Ferreiro authored
Convert the implementation and all users of the add_supervision::mojom::AddSupervisionHandler interface. Bug: 955171 Change-Id: Ic9acc52ff87ea9950fd782081d90aee9e973eab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805665Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#699023}
-
Peter Kotwicz authored
This CL removes the VIBRATE permission from the WebAPK manifest. The permission was needed for delegating notifications to the WebAPK in Jellybean. See crbug.com/773663 The permission is no longer needed because Chrome no longer supports Jellybean. This CL also: - Increments the minSdkVersion to KitKat - Deletes WebAPK/Webapp Jellybean-specific code BUG=923518 Change-Id: I167867b2ad32e94dd894dea7f2b61279aacdd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818598 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699022}
-
Matt Menke authored
This code was used to prevent preconnecting multiple times to a proxy server that was known to support H2, but with the advent of storage isolation, this can potentially leak information between NetworkIsolationKeys. This CL removes that code. Another option would be to cache information on a per-NetworkIsolationKey basis, but unfortunately, since what servers support H2 must be scoped within a NIK, that would make the feature much less useful. QUIC proxies don't have this issue, fortunately. Bug: 993517 Change-Id: I55a584c37a929aeb59ca6260ea175b0200072086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815913Reviewed-by:
-
Andrew Xu authored
|last_visible_index_| of the main shelf view is updated in CalculateAppCenteringStrategy. However, when the scrollable shelf is enabled, |last_visible_index_| may be accessed before that function is called. As a result, an illegal index value may be used. Given that in scrollable shelf, |last_visible_index_| is always the index of the last shelf item. So updates |last_visible_index_| when a shelf item is added/removed. Bug: 1006165 Change-Id: I4bc13e204835828bb1d5f77024ce274b9899ced0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816142Reviewed-by:
-
Piotr Bialecki authored
Start using util::IdType from base. Change-Id: I1419a4a1065d99493e2d51f9e220cf20828716e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795895Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#699019}
-
Lei Zhang authored
Change the GURL parameter from base::Optional to a pointer, per guidance in docs/optional.md. Also simplify some related code and fix lint errors. Change-Id: I899f3877370a916ff8dc30402b2325351390286e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817660 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#699018}
-
