- 03 Nov, 2020 26 commits
-
-
Evan Stade authored
CastOptionsProvider is moved back into //chrome and Chrome's base java module. A copy is also made for WebLayer shell. Bug: 1144240 Change-Id: Ieed443a573ef8c2361f48dd4915a92569dd5a9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512808 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823384}
-
Daniel Rubery authored
The previous metric in this space, SafeBrowsingBinaryUploadRequest.AdvancedProtectionScanVerdict was removed by https://crrev.com/c/2505943, so take this opportunity to re-implement it in a slightly more robust way, based on the trigger rather than inspection of the Request. Change-Id: Ib5418d3cba4eadb110503ca48d81aff7fe2e78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506572Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#823383}
-
Tibor Goldschwendt authored
Fixed: 1140261 Change-Id: I3048004ebe36c0562028f2034d94bf4245736e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510715 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#823382}
-
chrome://downloadsJames Cook authored
Clicking on an item in the download shelf or in chrome://downloads attempts to open it in the OS-native application for that file type. For example, it might open a video player or image viewer. This needs to be handled by ash, so wire it through the crosapi::mojom::FileManager API. In the future we will need to show error messages for files that fail to open. The new methods return a result enum. We also need this for the existing ShowItemInFolder method, so deprecate the old one and introduce an updated version. This implementation isn't perfect. In some cases the file should be routed back to the browser for display in a tab. Right now some files that can't be opened in an app end up opening in an ash-chrome tab. In the future we will need to wire up the ash file_manager code to make "open in browser" redirect back to lacros-chrome. Bug: 1141616 Test: added to lacros_browser_tests Change-Id: I8cd4166bc594bf83a3ce9458d7c1d767bbb8c041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511589 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823381}
-
Zhaoyang Li authored
Move some private methods of Xcode(11)LogParser to public, and call these at tear down of test_runner module for GTests running as XCTests. To avoid duplicate logic where touched, this change also: - Added using_xcode_11_or_higher() to xcode_util module. - Added get_parser() to xcode_log_parser module. - Renamed coverage_util to file_util and added in an archiving utility. Bug: 1047704 Change-Id: Id66ebd7a4ca1b2f7ea494eda66c015240f581c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496345 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823380}
-
Meredith Lane authored
This reverts commit 530c8fd2. Reason for revert: caused tree closer due to missing mojom file: https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-rel/39820? Original change's description: > [Media Session] Convert interface from mojo to CPP > > Context: https://crrev.com/c/2485850 > > This converts the MSS interface to CPP since it does > not need to be mojo. > > BUG=1140215 > > Change-Id: I595bef21cddf755bc0fb423f87db9e620227d3e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503393 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823358} TBR=avi@chromium.org,xiyuan@chromium.org,dcheng@chromium.org,beccahughes@chromium.org Change-Id: I729b898ef30c220c779be615b0b6eb6abf8cfed5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515502Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823379}
-
Renjie Tang authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007792 Change-Id: I16c66d31f3c95b179288d2586682d981d0b4f7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505946 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#823378}
-
Meilin Wang authored
Previously if user revokes the notification access they granted earlier from the phone, notification set up UI cannot show up again unless you close and reopen the bubble. This CL fixes this by observing the change of notification access and update the view's visibility accordingly. BUG=1141610, 1106937 TEST=unittested. Change-Id: Ife8f19e7e5b8c2ec9ea12a7cc9e0e2cc739af72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508398 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#823377}
-
Joel Hockey authored
*.trashinfo files require 2 async operation to first create the file, and then write to it. This can cause issues if removeOldFiles_() is running concurrently. Hopefully this fixes test flakes. Bug: 953310 Change-Id: Ib6d192122a97f956ba79ec11a8f5e099f4d418c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515499 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823376}
-
Liquan (Max) Gu authored
Context: Before, we planned to remove ChromePaymentRequestService completely, so we created PaymentRequestLifecycleObserver in order for PaymentRequestService to call into PaymentUiService directly. Now that we believe that ChromePaymentRequestService will keep existing as a glue between the UI service and the PRService, the observer becomes unnecessary. Changes: * Removed PaymentRequestLifecycleObserver as a middle man between PaymentRequestService and PaymentUiService; changed to use ChromePaymentRequestService as a middle man instead. * Created PaymentUiService#close() to encapsulate the closing logic. Bug: 1144527 Change-Id: Ib87234e6d2ed98d68586983da9779ba74a62abaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514481 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823375}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dffd20efe95c..753c1b336802 2020-11-02 csmartdalton@google.com Add helpers to GrPathUtils for converting lines and quads to cubics 2020-11-02 robertphillips@google.com Fill in the GrTriangulatingPathRenderer::onPrePrepareDraws 2020-11-02 johnstiles@google.com Replace ProgramElement dehydrated count with an elements-done command. 2020-11-02 csmartdalton@google.com Add GrVx.h 2020-11-02 johnstiles@google.com Add test cases to function-prototype golden outputs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: bsalomon@google.com Change-Id: I8f2049007d8d2202d4e7a2e8214c2bddf2db2f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823374}
-
Danan S authored
It wasn't shown because the online screen is the default currentScreen value. Bug: 1123218,1143409 Change-Id: I6f881115a0ae9e9f38c8cd17bd9fbad8c4ed0cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505942 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Meredith Lane authored
This reverts commit df9e203b. Reason for revert: Suspected culprit of tree closer on win-asan: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/17873? Original change's description: > Only pass executable sections to OnDllLoaded for patching > > On recent Windows insider builds GetModuleHandleExW loads sections for > inspection as non-executable images, rather than as files. This leads > to our hooks detecting the SEC_IMAGE attribute and potentially patching > functions (e.g. for user32.dll). > > This caused content_browsertests to fail as it pinned user32.dll in some > processes. With this change, the tests run again. > > See crbug.com/1143397 for a full discussion. > > Bug: 1143397 > Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823354} TBR=wfh@chromium.org,ajgo@chromium.org Change-Id: Ia164ea218daf7771f025dfa57a3a4bf25c41eac2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515501Reviewed-by:
-
Adam Rice authored
The web platform test xhr/responsexml-document-properties.htm is flaky. Mark it as such in TestExpectations. BUG=1144537 Change-Id: Ic7de8bb61f7646127c4094a9f88c066895189b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515419 Commit-Queue: Adam Rice <ricea@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#823371}
-
Max Curran authored
state of Translate. At the beginning of a page load, Translate looks at many different signals to determine if: 1) the page should automatically be translated, 2) the translate UI should be shown, or 3) nothing should be done related to translate. These new metrics record which signal caused the initial state (called trigger decision). In the event that multiple signals were true, only the first value is recorded. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing More details on trigger decision: https://docs.google.com/document/d/11TJqU_YyJoxJE1huEqKECBa_OZ05O4WESXMJ2WeT4F0/edit?usp=sharing Bug: 1114868 Change-Id: I48d296cacc157741124db09db166a253a95b37be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490676Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#823370}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fcca1a51..037ccdfb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3f9f1d348ec888e1910effc13383b68a2acd81e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514621Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823369}
-
Peter Kasting authored
Bug: 772945 Change-Id: I310fd814ff948e30d433de28fe83df206d7ecbd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508177 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#823368}
-
Tommy Martino authored
This CL rolls DEPS to the latest version of text-fragments-polyfill, which fixes a few known issues: - Link generation should fail if the range includes a block boundary. - No highlight should be shown if the fragment is ambiguous (i.e., if it could correspond to multiple different places on the page). This version changes the return type of a util function we are using, so a small update to the Chromium-side JS is needed. (The function now returns a list of ranges, rather than a list of <mark>s, and Chromium is responsible for invoking the code to wrap these in <mark> tags.) Bug: 1136043 Change-Id: Icf9c79dc0d9b9fca23f2826438e3c17c07340bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511429Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#823367}
-
Eugene But authored
App used to crash because BreadcrumbPersistentStorageManager did not exist during synthetic crash report generation. This CL moves BreadcrumbPersistentStorageManager creation from ApplicationContextImpl::OnAppEnterForeground to ApplicationContextImpl::PreMainMessageLoopRun, so that Storage Manager is available in MobileSessionShutdownMetricsProvider::ProvidePreviousSessionData Bug: 1143779 Change-Id: I2673cdc0383a52b87b2e041d4413c9348f2f8b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508636 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#823366}
-
Ana Salazar authored
Bug: 1123585 Change-Id: Ib78099d248720689054bb4d24c81bf2022af36bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510691Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#823365}
-
Chris Cunningham authored
We don't really care about the exact thread, so SingleThreadTaskRunner is too specific. The specific files migrated here are all in the tree of dependencies under webcodecs audio|video_decoder_broker. This allows a follow up CL to grab a random *offloading* SequencedTaskRunner from the pool in cases where the media thread is not available via GpuFactories(). Bug: 1095786, 1144329 Change-Id: I29332418fd11054b6b2fa63feb26e93401aeb0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500424Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#823364}
-
Yuchen Liu authored
This reverts commit 1eef2a38. Reason for revert: This causes screen flickering. We'll make a platform fix to handle the playback stall. Original change's description: > [Chromecast] Disable SurfaceControl and AImageReader for Android build > > For Q+ devices, SurfaceControl and AImageReader may cause some video > playback stall. Temporarily disable them. > > Bug: internal b/162803423 > Test: Bug is not repro > Change-Id: I4ce7e42fd87433464dfe4a6b29b816cb41ce7138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493091 > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Yuchen Liu <yucliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820070} TBR=zmo@chromium.org,liberato@chromium.org,seantopping@chromium.org,yucliu@chromium.org,csbubbles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/162803423 Change-Id: Icdf7b5ede25bdd9b3ae0062d23ee6b43b5c30c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511752Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823363}
-
My Nguyen authored
Adding flag to extension so we can direct users correctly when opening edit dictionary page. Bug: 1144084 Change-Id: I6b8993f5d5e466c57aa0cead209139c631f9c17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513305 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#823362}
-
Xing Liu authored
There is some effort to migrate the DFM declaration to downstream. This CL adds an initialization function in ChimeDelegate. Also polish the comment and make ChimeDelegate a class instead of interface. Bug: 1136305 Change-Id: I9e5e3c0f9bc029d38793767dc9293478c8ee1a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514588Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823361}
-
chinsenj authored
This CL adds metrics for capture mode entry points, i.e. tracks all the different ways users enter capture mode. Visit go/capture-mode-metrics to see the other planned metrics. Tests in later CL. Test: manual Bug: 1140182 Change-Id: I2d980bc69dec83dddd0d5f2ab26b3904f7e22970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500321 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#823360}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/552f47beb892..68ff27c5daea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tommycli@google.com,rogerm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088 Tbr: tommycli@google.com,rogerm@google.com Change-Id: Ic44123f9bbcc201a818cb71ac1897085be8d2aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823359}
-
- 02 Nov, 2020 14 commits
-
-
Becca Hughes authored
Context: https://crrev.com/c/2485850 This converts the MSS interface to CPP since it does not need to be mojo. BUG=1140215 Change-Id: I595bef21cddf755bc0fb423f87db9e620227d3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503393 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823358}
-
rbpotter authored
Bug: 1132403 Change-Id: I2d4fcc058d236a7c4e43350965e36b10c820738f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510352Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#823357}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/11789f5ed0cf..d4e59f416fc9 2020-11-02 patrick.brosset@microsoft.com Flex: Adding support for flex adorners in the Elements tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1144090 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic71e2617c20e78eda65352e5f9416f3623bedfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514370Reviewed-by:
-
Mohamed Heikal authored
chime is a downstream only DFMs, it should be defined downstream only and not reference clank from the chromium repo. This reverts commit ba4e63fc. Reason for reland: all chime references downstream are either removed or guarded behind use_chime_android_sdk which will be set to false in this cl. Bug: 1142775,1143787 Change-Id: I0f988af70dbbf120d1954b47ca697b0ebf36cde6 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514359 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Alex Gough authored
On recent Windows insider builds GetModuleHandleExW loads sections for inspection as non-executable images, rather than as files. This leads to our hooks detecting the SEC_IMAGE attribute and potentially patching functions (e.g. for user32.dll). This caused content_browsertests to fail as it pinned user32.dll in some processes. With this change, the tests run again. See crbug.com/1143397 for a full discussion. Bug: 1143397 Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#823354}
-
Adam Langley authored
Far from complete, but a little more standard and now using layout XMLs, like the rest of the code. BUG=1002262 Change-Id: I2f9334fab4fc46374b76606d1e5acc29232a6793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511973Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823353}
-
Findit authored
Revert "NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/" This reverts commit 8436de62. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 823349 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg0MzZkZTYyYmRhYzBkNDBlZDRjMThjZTdlMjk0NzNjNDBhNjAzMjQM Sample Failed Build: https://ci.chromium.org/b/8864700989267188736 Sample Failed Step: compile Original change's description: > NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/ > > This is mechanical rename other than changes in OWNERS and > flag-metadata.json. > > Change-Id: I9020d87a81ccad25aaa1ac5881f8cfdb52cce25f > Bug: 1144577 > Tbr: fgorski@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512486 > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823349} Change-Id: Ib41c8fee9d588e6bff9ee548f0ae9388fb6994b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1144577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515559 Cr-Commit-Position: refs/heads/master@{#823352}
-
Tomasz Wiszkowski authored
This interface was conceived to support modularization efforts of the Autocomplete system for Chrome. This effort has been postponed indefinitely in 2019, and the interface is not very helpful, specifically with ongoing LocationBar modernization efforts. We anticipate the interface to be different as a result of the above efforts and to prevent additional methods from creeping in to the interface, as well as to make room to correctly address other dependency issues when the right time comes, i would like to propose we drop this for now. Omnibox and Autocomplete modularization will follow the completion of refactoring efforts and modularization of the LocationBar. Bug: 966424 Change-Id: Ia568830f53a3872394bfce025ad30bc93372c2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508326Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#823351}
-
Tomasz Wiszkowski authored
This change is part of topic change. the change helps eliminate apparent rewrite of the AutocompleteCoordinator.java file in subsequent patch. Bug: 966424 Change-Id: Iff92f7c70cd4a7d631abb83bf9c780839dac29ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508800Reviewed-by:
-
Hiroki Nakagawa authored
This is mechanical rename other than changes in OWNERS and flag-metadata.json. Change-Id: I9020d87a81ccad25aaa1ac5881f8cfdb52cce25f Bug: 1144577 Tbr: fgorski@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512486 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Adam Langley authored
Nulling out the permissions delegate would cause a crash if the user started scanning a QR code, abandoned, and then tried again. BUG=1002262 Change-Id: I5cd3345d312dc80588e5e8a7df67d613fca83318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511972 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
David Tseng authored
As of https://chromium-review.googlesource.com/c/chromium/src/+/2510736 the tts service, which runs a prebuilt containing tensorFlow, now asks for sysinfo. R=mpdenton@chromium.org Test: patch the above change and makes sure the tts works. Change-Id: If578d0bb6617390a5919ac33b4b04970a33da317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514759Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823347}
-
Meilin Wang authored
- Removes mobile provider label. - Fixes spacing inconsistency. - Hides sparator if there's no preceding content, i.e. in interstitial views. Screenshots: https://screenshot.googleplex.com/4ZSfevJhMoUZbZE.png https://screenshot.googleplex.com/8oncKmfXsKrJRfp.png BUG=1144232,1142885,1106937 Change-Id: I01e761c1507675a6d674481615c480348c76583c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511756 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#823346}
-
Sammie Quon authored
Skips the reposition if the window is not dropped into overview on drag end. Test: added test, manual Change-Id: I80635aa657e8a2017b72b06992a1f98181754bed Fixed: 1049206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496192 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#823345}
-
