GitLab

This reverts commit 6ceb3883.

Reason for revert: New tests have memory leaks.

https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27171

Original change's description:
> Use user preferences for TTS speech rate, pitch and volume if not set.
> 
> Bug: 823359
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I772e1fa78e0f3f7ed3a6ab858f4855f65f18513f
> Reviewed-on: https://chromium-review.googlesource.com/1014491
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552826}

TBR=thakis@chromium.org,dtseng@chromium.org,jochen@chromium.org,katie@chromium.org

Change-Id: I8702500882bf4e8a499c7798306976bd18ad260b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823359
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1025290Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552929}

The erase icon that appears on editing the omnibox in touch mode is too small.
Update its size.

Bug: 832113
Change-Id: I64768a9e1d6e91eec03a03b22863d1a4d8cf2ff2
Reviewed-on: https://chromium-review.googlesource.com/1023623Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552928}

Previous version had white "=(" which wouldn't work well for incognito
after tinting to white (smiley and folder would both be white-ish). With
a transparent smiley the underlying dark-grey tab renders through as
dark eyes for a light-grey folder.

Bug: chromium:834645
Change-Id: I1c4f80004ee7a7227fef231d9b136a4a8c5ee566
Reviewed-on: https://chromium-review.googlesource.com/1022744Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552927}

This provides an ability to programmatically grant media access permission
for a guest view, which is a desired feature on certain devices.

Bug: b/78193883
Test: Build
Change-Id: If733c28125e4228a1c50baf11f9715c7d876da67
Reviewed-on: https://chromium-review.googlesource.com/1021599Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552926}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=battre@chromium.org

Bug: 825327
Change-Id: I09f2ec144a8cd311d705ad3cfe3ac6da75cc4ca8
Reviewed-on: https://chromium-review.googlesource.com/1024319
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552925}

Original CL got reverted because the num of landmarks aren't updated in services
tests that aren't checked on GPU FYI.

This is a reland of 5e1aa79b

Original change's description:
> ShapeDetection: Parse landmarks of the detected face on Mac Vision
>
> Update the mojom interface definition of landmark to match the Spec, and adjust
> the usage in services/blink/LayoutTests.
> Export eyes and mouth landmarks that detect with Mac Vision Framework, the points
> are normalized to the bounding box of the detected face, with the origin at the
> bounding box of the detected face's lower-left corner.
>
> Link Mac 10.13 build bots [1] and Face Detection demo[2] here.
>
> [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
> [2] https://codepen.io/miguelao/pen/PmJWro
>
> BUG=799319
>
> Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80
> Reviewed-on: https://chromium-review.googlesource.com/982579
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Junwei Fu <junwei.fu@intel.com>
> Cr-Commit-Position: refs/heads/master@{#552217}

TBR=mark@chromium.org

Bug: 799319
Change-Id: Id521f2a92dd3e1c6d8ac29d571bc1c58cfdb020e
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1023181
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552924}

This CL is a refactor with no intended behavior change.

Previously, the method took a raw pointer. Now, the method takes a
std::unique_ptr.

Change-Id: I20135ca41335facbf3dd734445804daa314fe9fe
Bug: 832879
Reviewed-on: https://chromium-review.googlesource.com/1022291
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552923}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: If1cb03849e1d18149cce178c45f44e7f764fea72
Reviewed-on: https://chromium-review.googlesource.com/1022186Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552922}

R=primiano@chromium.org
CC=tzik@chromium.org
PRESUBMIT=TRUE
BUG=752720

Change-Id: I0f4c5540fb58b1df000e2fcbe75a93f110cef39e
Reviewed-on: https://chromium-review.googlesource.com/1024398Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552921}

Use protected. Don't abbr the template parameter (use MODE).

No change in behavior, no new tests.

Bug: 833834
Change-Id: I1fd84e01fbb22ed93b2951986afeb408c448e281
Reviewed-on: https://chromium-review.googlesource.com/1023680Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552920}

Bug: 826799
Change-Id: Ibf6b452aee7256cbb45d7d214729529c09acb5ab
Reviewed-on: https://chromium-review.googlesource.com/1012186Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552919}

Using wpt-import in Chromium c00fe466.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."
3f388f1c "Allow column-width:0."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16184

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=ajuma

No-Export: true
Change-Id: I33ced44d390c2471795a51e7dff79a95db44b7d4
Reviewed-on: https://chromium-review.googlesource.com/1024300
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552918}

code.

Cache (and sanitize) the last received power info in PowerManagerClient;
query that instead of ash::PowerStatus.

Add test coverage for ArcMigrationGuideNotification.

TBR=sky@chromium.org

Change-Id: Id3560886b847f383a73b12799a83eb68af37582b
Reviewed-on: https://chromium-review.googlesource.com/1015779Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552917}

Bug: 803825
Change-Id: I9387a91cdc2a86520fcf9b09cf75c0950f11078d
Reviewed-on: https://chromium-review.googlesource.com/1019734Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552916}

Bug: 784495
Change-Id: Ib2b5da041eb483c45fc67f1da9ac364e85142df4
Reviewed-on: https://chromium-review.googlesource.com/1008416Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552915}

https://pdfium.googlesource.com/pdfium.git/+log/dd2a629f9ede..4e4147eccd25

$ git log dd2a629f9..4e4147ecc --date=short --no-merges --format='%ad %ae %s'
2018-04-23 dsinclair Make CFX_SeekableStreamProxy a subclass of IFX_SeekableReadStream
2018-04-23 dsinclair Change CFX_XML Save to take a write stream
2018-04-23 thestig Validate the Size dictionary entry in CPDF_SampledFunc.
2018-04-23 dsinclair Revert "Change CFX_XML Save to take a write stream"
2018-04-23 dsinclair Revert "Make CFX_SeekableStreamProxy a subclass of IFX_SeekableReadStream"
2018-04-23 dsinclair Make CFX_SeekableStreamProxy a subclass of IFX_SeekableReadStream
2018-04-23 dsinclair Change CFX_XML Save to take a write stream
2018-04-23 hnakashima Create FPDFPageObjMark_GetParamStringValue().
2018-04-23 tsepez Disable JavaScript entirely if no JSPlatform passed by embedder.
2018-04-23 tsepez Provide double-byte terminator in Windows font variant name.
2018-04-23 hnakashima Create API to get PageObject mark parameters.
2018-04-23 thestig Fix some nits in CPDF_SampledFunc().
2018-04-23 thestig Add more image size checks in CJBig2_Context.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:835184,chromium:834557


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib1c912e3943955d045f467a5885127d02d6ecac5
Reviewed-on: https://chromium-review.googlesource.com/1024884
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552914}

The Tracing format documentation does not make it clear if cat and args fields are mandatory.
There are writers in the wild that do not generate these fields. Also trace viewer is capable of reading files with the fields omitted.

Drive-by: do not spam user console with missing CPU profile samples.

Change-Id: I7ab58fc132c2abc565296465924edb8a4fd07d07
Reviewed-on: https://chromium-review.googlesource.com/1022183
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552913}

- adds a net::MockProxyClientSocket allows consumer to specify connect errors
  through MockConnect.
- adds a CreateProxyClientSocket to net::ClientSocketFactory, so test
  factory impl can mock out that function.
- Use MockProxyClientSocket in ReconsiderProxyAfterError so we test error
  fallback correctly. Please see linked bug for more info.

BUG: 826570
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0c7e858c0bce128fa92293e3a47de530025e4c45
Reviewed-on: https://chromium-review.googlesource.com/1011119Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552912}

Adding scoped sys trace events to get a more complete breakdown of
webview startup time.

There is no logic change otherwise.

Bug: 817644

Change-Id: I399560e75c70159f2593928fd78341c198d0bd4c
Reviewed-on: https://chromium-review.googlesource.com/1022124Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552911}

- Adds functionality for Edit, Cancel.
- This CL doesn't add Delete or show CBD functionality.

Screenshots:
https://drive.google.com/open?id=1Vemnn74-tx8vyyiVQ9JgwiqwkIMYF4Mo
https://drive.google.com/open?id=1KClaorF_W3QDOhBgjn8Ij9ozme01VUnJ

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idfbb8baf15887de377a66c5be70d484f21b41324
Reviewed-on: https://chromium-review.googlesource.com/1018494
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552910}

to resolve some differences between chromium and internal versions.
Also various cleanups to end_to_end_test.cc

Merge internal change: 193703843

Change-Id: I3bc92c6057d37c97948229d499c2cc9c279923b4
Reviewed-on: https://chromium-review.googlesource.com/1022511
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552909}

TBR=smut

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I09558dfae0b9b01e308a7ed5258099906972d50f
Reviewed-on: https://chromium-review.googlesource.com/1024696
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552908}

Also replace NULL with nullptr throughout FocusManager and
FocusSearch.

Bug: 764918
Change-Id: Ic90607c470130ac53375b26e601c1226c34a501a
Reviewed-on: https://chromium-review.googlesource.com/1024990Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552907}

Bug: 822469
Change-Id: Id244e5120962a7ee5e7bdcb25e46221aad868d8a
Reviewed-on: https://chromium-review.googlesource.com/1024405Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552906}

This CL fixes a bug in sizing the entity images where they would be sized
too large if shown after an Answer result (such as weather). This
occurred because the old height for the answer result was being used in
the entity sizing.

Bug: None
Change-Id: Ia372c142a011657af150eb651403a61aeab2943d
Reviewed-on: https://chromium-review.googlesource.com/1024926Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552905}

NG did not traverse children, which are needed for Focus rings.

Bug: 835484
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I33a326b18da85b65f76b5035634d9b8151431313
Reviewed-on: https://chromium-review.googlesource.com/1022979
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552904}

This is a reland of b3fdac1b

Original change's description:
> skia: Add workaround header define
> 
> Chromium-side changes for:
> https://skia-review.googlesource.com/c/skia/+/120608
> 
> Bug: 829614
> Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f
> Reviewed-on: https://chromium-review.googlesource.com/1008924
> Reviewed-by: Brian Salomon <bsalomon@chromium.org>
> Commit-Queue: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551370}

Bug: 829614
Change-Id: I206bed834a1819aea819648ba1f3ca486af94657
Reviewed-on: https://chromium-review.googlesource.com/1024310Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552903}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=morlovich@chromium.org

Bug: 825327
Change-Id: Ifaba7bb17406a913293c2ba918334d28da4cbc3c
Reviewed-on: https://chromium-review.googlesource.com/1024790Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552902}

Makes the mojo_core shared library a data dependency of the chrome
binary target on Chrome OS to ensure that it gets built whenever chrome
gets built. A follow-up change to chromite will cause this to be
included in device deployments.

Also adds a linker script to ensure that symbol exports are limited to
MojoGetSystemThunks.

Bug: 822034
Change-Id: Iad03f28377ecc5094c2019b22c723d7705242230
Reviewed-on: https://chromium-review.googlesource.com/1024750Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552901}

In the unlikely event that a remote instance deletes our local session,
either via garbage collection or by the user manually requesting a
deletion from the UI, restore a consistent state once a local change
is observed.

This mimics the analogous logic in SessionsSyncManager.

Bug: 681921
Change-Id: Ie3171852abb9a9f1b350535317b73a3fcb907cb6
Reviewed-on: https://chromium-review.googlesource.com/1024036
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552900}

Keeping things consistent in Bijou Phase 1

https://drive.google.com/file/d/14nkloZ4PX0UD0HnXZgMLKYo6-iUzn5kt/view?usp=sharing


Bug: 833623
Change-Id: Ie5aeaac7c3787775d4845aa6cb030236b6de9c2f
Reviewed-on: https://chromium-review.googlesource.com/1022173
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552899}

Bug: 782057
Change-Id: Ib7d35e227414f4f9980c5cf70bb3d767c9961029
Reviewed-on: https://chromium-review.googlesource.com/1013984Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552898}

Replace with std::move(foo).

Change-Id: I7b2db906e9643fd70eb5188143f564cd4899baf5
Reviewed-on: https://chromium-review.googlesource.com/1014375
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552897}

Moving the backend & frontend code to their own folders. This CL contains no
functional changes.

Bug: 830931
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia6147c93063214143c8de29ca945cc3df8892bfa
Reviewed-on: https://chromium-review.googlesource.com/1023114Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552896}

MessageLoopRunner is deprecated and should use RunLoop instead. This CL
should not introduce any behavior change.

Bug: None
Change-Id: I1df20af20e14b828596b755b5aaa308c082d86b8
Reviewed-on: https://chromium-review.googlesource.com/1012195Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552895}

linked_ptr is long deprecated, used unique_ptr instead.


Bug: 556939
Change-Id: Ibfd38af13cd5646265bdfa4570e6e30c05db1ab2
Reviewed-on: https://chromium-review.googlesource.com/1020521Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552894}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=tguilbert@chromium.org

Bug: 825327
Change-Id: I2f85f18902de98bcb47125595e31379eb3c11169
Reviewed-on: https://chromium-review.googlesource.com/1024757
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552893}

Use ChromeViewsDelegate/WidgetObserver combination to ensure that all
widgets are tested for accessibility as they become hidden or visible
in a browsertest.

The test goes through the View entire subtree and ensure any focusable
View has an accessible name.

TBR=sky@chromium.org,tapted@chromium.org

CQ_INCLUDE_TRYBOTS: master.tryserver.chromium.linux:linux_chromium_msan_rel_ng,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng

Bug: 819350
Change-Id: I001d4cd2eac566445ec65c0228100e5323610765
Reviewed-on: https://chromium-review.googlesource.com/981937Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552892}

Canceling a single request is currently linear in the number of
requests, making the overall behavior quadratic. Fix it to be linear, so
we scale well and avoid upsetting the fuzzer.

Bug: 834578
Change-Id: Ieb17b106b0a8308b7b5a882fa1f61f899ee4dbcd
Reviewed-on: https://chromium-review.googlesource.com/1020022Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552891}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=boliu@chromium.org

Bug: 825327
Change-Id: If410a2423e1780c769a768ea4dd533b37cc39488
Reviewed-on: https://chromium-review.googlesource.com/1024655
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552890}