- 13 Mar, 2018 40 commits
-
-
Kristian H. Kristensen authored
In preparation for hardware plane underlay support in ChromeOS, we need to allow for RGBA primary framebuffers. When using an underlay, we cut out a transparent rectangle in the primary framebuffer to allow the underlay to show through, while still allowing for RGBA content on top of the underlay (for example, video controls or annotations). When not using an underlay, the primary framebuffer will be displayed as RGBX (opaque) to avoid unnecessary blending in the display controller. Bug: 789288 Change-Id: I2fc94e524e250ec9b7e11cd6801e1c8308046a10 Reviewed-on: https://chromium-review.googlesource.com/801974Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542877}
-
Chong Zhang authored
We want to move |SharedURLLoaderFactory| to make it available to consumers that doesn't depend on content/. This CL is mostly mechanical changes and doesn't affect behaviors. TBR=jam@chromium.org (for fairly mechanical changes of callsites in chrome/). Bug: 796425 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icdaccce5323c7585e26f742e9d0433f0fa1aea4b Reviewed-on: https://chromium-review.googlesource.com/959617Reviewed-by:
Chong Zhang <chongz@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#542876}
-
Tao Bai authored
Bug: 821225 Change-Id: Ifc2d019efb48beb31a3db7fd474e619f33559e82 Reviewed-on: https://chromium-review.googlesource.com/959577Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542875}
-
Harald Alvestrand authored
This is in turn fed (in a few cases) from the RTCError passed back in callbacks from the WebRTC layer. This is a first step towards getting proper error codes passed up from WebRTC to Blink. Bug: 589455 Change-Id: I4ae2412ce238c5e17ba14fb1aa9b4eab2ccd7659 Reviewed-on: https://chromium-review.googlesource.com/956122Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#542874}
-
Elly Fong-Jones authored
Before, this was trying to use the Cocoa TaskManager for these Views-specific tests, which is wrong. This change also makes polychrome always use the Views task manager window when in Views browser mode. Bug: 817408 Change-Id: Ie3ab2e5fd6ca1752aff4f601e2cf920a3762fefe Reviewed-on: https://chromium-review.googlesource.com/961161Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542873}
-
Ramin Halavati authored
Network traffic annotation is passed from HttpRequestInfo to Websocket HTTP2 Handshake. Bug: 656607 Change-Id: Ib8c40a734ec598346457a32d75f3e2caeb8cbad0 Reviewed-on: https://chromium-review.googlesource.com/959008 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#542872}
-
https://chromium.googlesource.com/catapult.git/+log/c6434b02c577..3b4e1d958fac $ git log c6434b02c..3b4e1d958 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 perezju [Telemetry] --browser android-chrome should use Monochrome.apk in N+ Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I775a50bd41d5ec3f95ea25a82f2afa49bed357ad Reviewed-on: https://chromium-review.googlesource.com/960881Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542871}
-
Kim Paulhamus authored
Adds the tighter restrictions detailed in https://fidoalliance.org/specs/fido-v2.0-ps-20170927/fido-client-to-authenticator-protocol-v2.0-ps-20170927.html#using-the-ctap2-authenticatormakecredential-command-with-ctap1-u2f-authenticators where: 1) a create() call must not require user verification or resident keys 2) a get() call must not require user verification in order to dispatch to u2f authenticators. Bug: 803832 Change-Id: Ib9cf9d3bcf0b71f0d32fec76f1aaf175278a02ef Reviewed-on: https://chromium-review.googlesource.com/949453Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#542870}
-
Marijn Kruisselbrink authored
These factories don't support download_to_file anyway, so make sure nobody is trying to call them with download_to_file set to true. Also fix the one place where download_to_file was set to true despite the code not actually expecting the callbacks that that should result in, if download_to_file would have been implemented. Bug: 791702 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2f31d2a45c59ba4b15e92cfe18718ed4eb69847b Reviewed-on: https://chromium-review.googlesource.com/957708Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#542869}
-
Elly Fong-Jones authored
These tests just need to use a Cocoa profile chooser when in Cocoa mode or they crash. This change also disables one test in polychrome: NoProfileChooserOnOutsideUserDataDirProfiles, which is documented to be broken on Mac. Three other tests fail with ViewsBrowserWindows enabled, which are the three LockProfile tests. I don't yet know why. Bug: 817408 Change-Id: I753fa8cdcbcfa6da254b835db4b9c801ed539131 Reviewed-on: https://chromium-review.googlesource.com/960441Reviewed-by:
-
Dominic Mazzoni authored
Bug: 816529 Tbr: tsepez@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I89646a49d23a5591b5f564412450832893bb3cb3 Reviewed-on: https://chromium-review.googlesource.com/936454Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542867}
-
Derek Cheng authored
This fuzzer test will cover CastFramer, which consumes bytes received from cast devices over the network and converting it into protobuf. Added 3 corpuses which are generated MessageFramer::Serialize() and dummy messages. (See cast_framer_unittest.cc) Bug: 796717 Change-Id: I4a9feae3f1451d101387943517594d89d2cf0473 Reviewed-on: https://chromium-review.googlesource.com/950410 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Adam Michalik <xyzzyz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542866}
-
Nick Carter authored
Write a test of mouse_lock_widget_ cleanup. Fix WebContentsImpl so that it passes. Bug: 820593, 821187 Change-Id: I99cd6b8c728f7e4501205574db8d17b206f2856e Reviewed-on: https://chromium-review.googlesource.com/957479 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542865}
-
Henrique Nakashima authored
Bug: 821301 Change-Id: I573f5f90fa896f92f91ca63bfda2588469ab5aab Reviewed-on: https://chromium-review.googlesource.com/960594Reviewed-by:
-
Albert Chaulk authored
app_shell has updated to move a lot of load and init code into ExtensionRegistrar Change-Id: Iaf8b1c4c50dd0a526f7dfc7a0a8aba759f55fe6c Reviewed-on: https://chromium-review.googlesource.com/941548 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#542863}
-
Seth Hampson authored
We are deprecating the use of label() and changing to id() for consistency with the spec. This is part of the effor to support multiple media stream ids in webrtc. Bug: webrtc:8977 Change-Id: I54dc2bd1af26c31147dd5570790f5d371fb40fb1 Reviewed-on: https://chromium-review.googlesource.com/959229 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542862}
-
Xiaoqian Dai authored
Bug: 807106 Change-Id: I8ff4939634f919f7566b499985af89960fd6ab09 Reviewed-on: https://chromium-review.googlesource.com/954346 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542861}
-
Malay Keshav authored
This patch performs 2 important tasks: - It moves the logic to compute the display zoom levels for a display from display.js to display manager util. - It also enables the keyboard shortcut to modify the display zoom. Adds the necessary unittest to test all new code paths implemented. display IDL, accelerator Bug: 790723 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5169119918e1efc9b439c8a62ba72f371ff2966b Component: DisplayManager, display util, display settings, system Reviewed-on: https://chromium-review.googlesource.com/956618Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#542860}
-
edchin authored
This CL uses a separate crbug for device failures vs. simulator. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia1474880fd3236868a4f52354611aff4605cb359 Reviewed-on: https://chromium-review.googlesource.com/960970Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Menglu Huang <huangml@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#542859}
-
Evan Stade authored
arranging new Browser windows. This also reinstates some logic for Mash that doesn't depend on code in ash/. With this flag passed, or when running in Mash, ash::WindowPositioner won't be used for placing new Windows. Some other Chrome OS specific code, like maximizing the first run window according to policy, is retained. Bug: 764009 Change-Id: I7563b0b0648e2470ec4a601805d2b351b6d64bb0 Reviewed-on: https://chromium-review.googlesource.com/958030 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#542858}
-
Samuel Huang authored
(Use "git log --follow" to see older revisions of files). /components/ is the most logical place to put Zucchini, which only depends on /base and /testing/gtest. This move also enables Zucchini to be used by the Component Updater. Details: - Move all files; run the following to change deps and guards: sed 's/chrome\/installer/components/' *.cc *.h -i sed 's/CHROME_INSTALLER/COMPONENTS/' *.cc *.h -i - Sorting works out pretty well! - Change all 'chrome/installer/zucchini' to 'components/zucchini' throughout other parts of the repo; sort if necessary. - Fix 6 'git cl lint' errors. - Change 1 Bind() usage to BindRepeated(). - Update OWNER. Bug: 729154 Change-Id: I50c5a7d411ea85f707b5994ab319dfb2a1acccf7 Reviewed-on: https://chromium-review.googlesource.com/954923Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#542857}
-
Eugene But authored
This CL has the following changes: - VerticalAnimationContainer does not set width constraint anymore - LanguageSelectionController anchors its width to superview width - DownloadManagerController uses different width constrait depending on user interface size (compact vs. regular and superview width). Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0bb8a72a1f70f8d3ce2d1216407a30f86f9a68c9 Reviewed-on: https://chromium-review.googlesource.com/957593Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#542856}
-
Xiaohan Wang authored
This reverts commit 290bce09. Now the proper fix is landed in 996b4eb8, we do not need this trick any more. Bug: 821114 Change-Id: Icc061572f36514c55d81e81000d085ce23833ea3 Reviewed-on: https://chromium-review.googlesource.com/959700Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542855}
-
https://skia.googlesource.com/skia.git/+log/fd6ed022db18..98ad5b7a4bca $ git log fd6ed022d..98ad5b7a4 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 ethannicholas Fixed some shader cache issues 2018-03-13 scroggo Remove calls to computeOutputColor- Type and Space 2018-03-12 benjaminwagner Unomit Win Intel Vulkan tests that seem to pass now. 2018-03-12 bungeman IWYU for some test files starting with 'C'. 2018-03-13 halcanary scripts to generate [m]skps, documentation 2018-03-13 caryclark fix fiddle with blur 2018-03-13 bsalomon Add testing-only backend render target support to GrVkGpu. 2018-03-13 caryclark avoid divide by zero 2018-03-13 brianosman Remove use of deprecated MakeFromIRect 2018-03-13 mtklein minor style guide updates and editing Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ie205e4fee46dabeee21c09d15b48a8284503fc2a Reviewed-on: https://chromium-review.googlesource.com/960882 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542854}
-
https://chromium.googlesource.com/angle/angle.git/+log/f0b30dd8bd2b..4ea3b4505abb $ git log f0b30dd8b..4ea3b4505 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 lucferron run_code_generation.py: Add gen_load_functions_table.py to the list Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I1ee496fedcc7da883defe3da6344e5212fe31ea1 Reviewed-on: https://chromium-review.googlesource.com/960962Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542853}
-
Paul Miller authored
These are being rewritten according to the "Finch Seed Dissemination in WebView" design doc. BUG=733857 Change-Id: Ie573c6aeebe7b37450c3a40c57f746f9fad96367 Reviewed-on: https://chromium-review.googlesource.com/959620Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542852}
-
Rohit Rao authored
Callers can use this styler object to set a background color on the tableview. If that color is opaque, it can be adopted by each individual cell as well. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I03d43c9c2c5dcbdd896e9fcdc0b6e56c1ea191fa Reviewed-on: https://chromium-review.googlesource.com/959144Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542851}
-
Michael Achenbach authored
Prepares for: https://chromium-review.googlesource.com/c/v8/v8/+/960034 The v8_snapshot target should never be built when V8 uses external startup data. V8 doesn't depend on it in this case, neither should Chromium. Bug: v8:7441 Change-Id: Ic949c15458e3dc49cd6319034e73540739e2b90e Reviewed-on: https://chromium-review.googlesource.com/960033Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I7c69f70489fe78c8b88748293032ba1fab22b25f Reviewed-on: https://chromium-review.googlesource.com/961086Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542849}
-
Carlos IL authored
Added mojo interface to handle interstitial commands and implemented it in SupervisedUserNavigationObserver which passes the commands to SupervisedUserInterstitial when committed interstitials are enabled. In a future CL an extra class will be added which will listen to JS commands from the interstitial and passes them via mojo to the observer. Bug: 817099 Change-Id: I5285e1fdaa16ee4e96ec7167d470b8ada9b73685 Reviewed-on: https://chromium-review.googlesource.com/950413 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542848}
-
Sarah Hu authored
Bug: 820128 Change-Id: I56c775c6da5d26b3904bce9e755c7eb22b012229 Reviewed-on: https://chromium-review.googlesource.com/956082Reviewed-by:
-
Kurt Horimoto authored
BVC only listens for fullscreen progress when it's visible and active. This CL updates BVC for the current fullscreen progress when being shown so that any updates that occur while the BVC is not visible are immediately reflected. Bug: 820174 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id9447065a30c3c8bb627afe7213cb4a623d8c5fb Reviewed-on: https://chromium-review.googlesource.com/958484 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542846}
-
Bence Béky authored
Net.WebSocket.HandshakeResult histogram has been broken since https://crrev.com/304093003, because WebSocketStream::Delegate::OnResponseStarted() has not been called upon failure any longer. This CL restores this histogram by moving logging into WebSocketHandshakeStreamBase and its two derived classes. It also refines the histogram by protocol (whether the handshake is over HTTP/2 or not), and provides a more gradual reason for failure as well. Bug: 801564 Change-Id: Iefa977703124df2bfcf77bc48e05f3ac594c2f50 Reviewed-on: https://chromium-review.googlesource.com/951746 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Scott Violet authored
This reverts commit 6c097bb5. Reason for revert: I'm reverting the revert as the dependent change has cycled through the bots https://chromium.googlesource.com/chromium/src/+/a5ea6086a54429ad2770cf28a3898413866e1bdd Original change's description: > Revert "Adds WindowService-ChromeOS fieldtrial" > > This reverts commit b4603176. > > Reason for revert: Reverting as one of the fixs for an interactive_ui_test failure got reverted. > > Original change's description: > > Adds WindowService-ChromeOS fieldtrial > > > > I'm not sure on the name here. I went with WindowService-ChromeOS as > > at some point we will launch the WindowService on other platforms, but > > that won't be anytime soon and is likely to be very different. So, I'm > > thinking later on we have the field trial WindowService-Desktop. > > > > BUG=814898 > > TEST=none > > > > Change-Id: I5bf45c2a463de0fefaeb06939429977e36c3681e > > Reviewed-on: https://chromium-review.googlesource.com/932821 > > Commit-Queue: Scott Violet <sky@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542680} > > TBR=sky@chromium.org,rkaplow@chromium.org > > Change-Id: Id63c00a90c6fd05ff74f0ffaa6ed738a98bd74e3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 814898 > Reviewed-on: https://chromium-review.googlesource.com/959763 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542713} TBR=sky@chromium.org,rkaplow@chromium.org Change-Id: I5a7259e6d6ce0ddafb516c22f847e6f662ad57b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814898 Reviewed-on: https://chromium-review.googlesource.com/960937Reviewed-by:
-
Daniel Bratell authored
A completely unused object file in a static library will be ignored by the linker, but with jumbo builds unused cc files will be grouped with used cc files and the object file will no longer be ignored. If the cc file contains code that is bad it can then trigger followup linker errors which happened in this case where debug component windows builds had too many constructors and destructors for WebAssociatedURLLoader when building webkit_unit_tests.exe Change-Id: I16a0332b9e16903481c2995f2176e59a1ba8e53e Reviewed-on: https://chromium-review.googlesource.com/955850Reviewed-by:
-
Daniel Cheng authored
Change-Id: I96f3a6a7e777066b87d9277c8a238bab40b4e94d Reviewed-on: https://chromium-review.googlesource.com/959682Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Robert Sesek authored
This adds a new use_crash_key_stubs GN argument that effectively disables the crash key subsystem. Bug: 811308 Change-Id: Ie0fba2c9af4c1514cc7dabc12ca012736a3d5422 Reviewed-on: https://chromium-review.googlesource.com/914708Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#542841}
-
Rintaro Kuroiwa authored
- It keeps breaking and requires updating. - So build it by default, the feature is still behind a runtime flag. - GN files are cleaned up so that "mojo_media_host" is set with clearer logic. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic78d4c949e0c8d57707f1d7f213c3b2fabd4b689 Reviewed-on: https://chromium-review.googlesource.com/959446 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#542840}
-
Yang Guo authored
Changes to v8::ScriptCompiler::CompileFunctionInContext observably affects debug stepping. R=haraken@chromium.org Bug: v8:7172 Change-Id: Iff4c43475e8e1f80a77557a5ffe6eab24b9a5471 Reviewed-on: https://chromium-review.googlesource.com/960904Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542839}
-
Patrick Monette authored
This is made possible now that the MTA is initialized on every sequenced task runner of the Task Scheduler. It also fixes the possible hangs on the UI thread when the automation thread was joined on destruction. Bug: 819789 Change-Id: I8964275d97c3302eaa7888e9c827d5e954c2b9eb Reviewed-on: https://chromium-review.googlesource.com/955673 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
