- 25 Jan, 2019 40 commits
-
-
Morten Stenshorne authored
So HandleNewFormattingContext() doesn't need that parameter. Change-Id: I6cffdc158b748cd31c6c9cdd709162788de87a76 Reviewed-on: https://chromium-review.googlesource.com/c/1436363Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#626081}
-
Alexandre Frechette authored
Bug: 850947 Change-Id: I5dc5cd129f5755006f55df12ec83c97c21a57c72 Reviewed-on: https://chromium-review.googlesource.com/c/1426059Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#626080}
-
Oskar Sundbom authored
Bug: 925325 Tbr: andreasbutler@google.com Change-Id: I9318ec953363252d54236686683c5d23221df0ff Reviewed-on: https://chromium-review.googlesource.com/c/1436370Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626079}
-
Oskar Sundbom authored
This reverts commit 051153e8. Reason for revert: The new tests hit a use-of-uninitialized-value on MSAN bots see: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/10910 Bug: 925333 Original change's description: > Fix chromevox state transition announcement > > - When ChromeVox is enabled, launcher state transitions to peeking or > fullscreen are now announced. > - This fix also removes the ability to focus on the expand arrow while > in fullscreen. > > Bug: 779687 > Change-Id: I942737bed53c258272aaea1a379cb7dd4053f605 > Reviewed-on: https://chromium-review.googlesource.com/c/1423741 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625756} TBR=dmazzoni@chromium.org,dtseng@chromium.org,weidongg@chromium.org,mmourgos@chromium.org Change-Id: I9309c3e6e194163faca077c0fb36a42434ca5dce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779687 Reviewed-on: https://chromium-review.googlesource.com/c/1436373Reviewed-by:
-
Richard Knoll authored
This makes sure that we forward the close event when a user clicks on the close button we show in native linux notifications for cinnamon. Bug: 924478 Change-Id: I490d9250c85dbaaca1132bc75a273e2c070c2ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1429044 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#626077}
-
Robbie Gibson authored
This CL fixes a bug in the ClipboardURLProvider text suggestion when the copied text matches the url of the current page. The text suggestion appears, when it should be suppressed, like the url suggestion. It also slightly changes the suggested_url_count logic. Before, if the omnibox was opened and the clipboard was empty, the url would be reset. Now, that no longer happens (because it's difficult to tell if the match failed because the both the url and the text clipboard were empty or if the current element on the clipboard was filtered out for some other reason [e.g. the url matched the current page's url]). Bug: 924127 Change-Id: I7f327fd68689cf0fa7b8ee73ec46109e77ecf9ac Reviewed-on: https://chromium-review.googlesource.com/c/1426689 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#626076}
-
Camille Lamy authored
This CL is part of a series of CLs that removes members from NavigationHandleImpl and queries them from NavigationRequest instead. This CL removes the CSPDisposition, RequestContextType, WebMixedContentContextType and SourceLocation. Bug: 1377855 Change-Id: I76480e496dd19685ad826e6e0caf1055eb513033 Reviewed-on: https://chromium-review.googlesource.com/c/1411345 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626075}
-
Gauthier Ambard authored
This CL is changing the style of the different Settings panels. Bug: 922511 Change-Id: I9df156a9e7f7ffebeea27687f913f66347969071 Reviewed-on: https://chromium-review.googlesource.com/c/1433246Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#626074}
-
Stephane Zermatten authored
Before this change, the source of truth for the status message and the details was in the Java layer. The native layer would even call GetStatusMessage when it needed to keep the status message to restore it after some operations, such as running interrupts or asking for confirmation about inconsistent details. After this change, the Controller keeps track of the status message and and details and the UI layer know about changes by calling OnStatusMessageChange and OnDetailsChange. Logic for confirming the details is pushed down to the ShowDetails and separates displaying the details from asking for confirmation. This change is a step towards keeping enough state in the controller to be able to attach and detach a Controller to or from the UI layer, as part of the effort to run Autofill Assistant on any tab. This is a refactoring. It should not change existing behavior. Bug: 806868 Change-Id: Ifb5e9f4ac3228d2473a90400e1c3020fa1e2ffed Reviewed-on: https://chromium-review.googlesource.com/c/1426690 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626073}
-
Aditya Keerthi authored
In order to determine the best approach to removing cancelled tasks from the DelayedTaskManager, it is necessary to collect metrics regarding the number of cancelled tasks that remain in the heap, as well as the percentage tasks in the heap that are cancelled. Given these metrics, we hope to deduce the number and percentage of cancelled tasks at which the benefits of cleaning up cancelled tasks outweigh the cost. Bug: 900191 Change-Id: Ibecf6aff5c5176deba0059607945e9b2c6dbfbf8 Reviewed-on: https://chromium-review.googlesource.com/c/1423159 Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#626072}
-
Lutz Justen authored
This reverts commit b0afc521. Reason for revert: Didn't realize that the Chrome OS protofiles ebuild and libbrillo still used components/policy/proto/install_attributes.proto. Pointing libbrillo to the system_api version caused build failures for Tael. Going for a different solution now: Make all of Chrome OS use the Chrome version of the file. Original change's description: > Use install_attributes.proto from system_api > > Gets rid of Chrome's own copy of install_attributes.proto and uses the > one from system_api instead, which was recently moved there by > CL:1402785. > > BUG=chromium:775087 > TEST=Tryjobs > > Change-Id: I5e9166eaee380d9f0e47c3312f4f19cb4ef62d72 > Reviewed-on: https://chromium-review.googlesource.com/c/1402876 > Commit-Queue: Lutz Justen <ljusten@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624055} TBR=stevenjb@chromium.org,rsorokin@chromium.org,ljusten@chromium.org,poromov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:775087 Change-Id: Ic56cfecdf94fd9d2dfe0c41c46158120e7149cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1436048Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#626071}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4efdd402d48..ab68058ef255 Created with: gclient setdep -r src-internal@ab68058ef255 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I01de6129f3e7e5d3a25e37721478c0d76d4ab167 Reviewed-on: https://chromium-review.googlesource.com/c/1436999Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626070}
-
Henrique Ferreiro authored
This CL changes OAuth2LoginVerifier to use IdentityManager::Observer callbacks. Bug: 921002, 921499 Change-Id: I80696fdcfb3d778fdb2b90fc3f1c598d16e78f24 Reviewed-on: https://chromium-review.googlesource.com/c/1409198Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#626069}
-
Anthony Vallee-Dubois authored
If the conditions for hrefTranslate are met but the originator of the navigation isn't the default search engine, show the translate UI instead. This CL doesn't make it so that the target language is the hrefTranslate value, as that requires a bigger, wider change. Bug: 900586 Change-Id: Iea8481fc263c36c3a0123007625505a8a05653b7 Reviewed-on: https://chromium-review.googlesource.com/c/1434915 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#626068}
-
Mohamed Amir Yosef authored
Recently introduced methods in PasswordStoreSync interface are implemented in PasswordStoreDefault. However, this implementation isn't compatible with PasswordStoreX. This overrides such methods in PasswordStoreX with a NOTIMPLEMENTED() implementation to make sure they aren't called by mistake. This should be OK because those methods are only used in Sync code base which doesn't use PasswordStoreX. In addition, PasswordStoreX will be deprecated. Similarly implementation in used in TestPasswordStore because it doesn't support primary key for forms. This is also OK because Sync unittest is using a mock PasswordSyncStore rather than a TestPasswordStore. Bug: 902349 Change-Id: Id795f3f6ae6b0efa75bbb22dc1675f3c12210692 Reviewed-on: https://chromium-review.googlesource.com/c/1429964 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626067}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d04daa05f551..11455bfdc0c5 git log d04daa05f551..11455bfdc0c5 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 lalitm@google.com Merge "probes: add raw_syscall/sys_{enter,exit} format and generated protos" 2019-01-25 lalitm@google.com Merge "trace_processor: fix dcheck failure" Created with: gclient setdep -r src/third_party/perfetto@11455bfdc0c5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I617b7e77e83874cad47610777db6af1f59ed9e45 Reviewed-on: https://chromium-review.googlesource.com/c/1436998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626066}
-
Anders Hartvoll Ruud authored
* Short circuit early if we don't have tagnames/ids at all. * Don't use Backing::Iterator for invalidation. The overhead of setting this up is big enough to be noticed on the AttributeDescendantSelector benchmark. FindAnyClass/Attribute have been introduced instead. Note that FindAnyClass iterates through SpaceSplitString and checks the HashSet for each entry. (Versus the previous approach, which did it the other way around). This is slightly faster in the ClassInvalidation test. R=futhark@chromium.org Bug: 924722 Change-Id: I5ee5c51574bda17df84a539f634a0d999a1d8db6 Reviewed-on: https://chromium-review.googlesource.com/c/1433766Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#626065}
-
Mohamed Amir Yosef authored
This is partial revert for the https://crrev.com/c/1424941 that broke Passwords Sync on Liux. Bug: 925302 Change-Id: I8c19a1c8507cb9ec57f32012aad7e99e8e8b9b0d Reviewed-on: https://chromium-review.googlesource.com/c/1436364Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Donna Wu authored
Bug: 716628 Change-Id: Iae964c7876d8228fde273a289d75b49b5a75b161 Reviewed-on: https://chromium-review.googlesource.com/c/1424737Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#626063}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9c68d43a63..d4efdd402d48 Created with: gclient setdep -r src-internal@d4efdd402d48 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0923b93eeef97bc7beb62bcedf7ce18e56cbdb71 Reviewed-on: https://chromium-review.googlesource.com/c/1436997Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 06486b38. With Chromium commits locally applied on WPT: 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" c0781deb "Trusted Types: Implement Origin Trial (TrustedDOMTypes)" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 7ac4f74b "Revert "[animation-worklet] Basic pause implementation"" 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I884d60676576c0e80089182c69334e02061a9f0c Reviewed-on: https://chromium-review.googlesource.com/c/1436593Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626061}
-
iOS Autoroller authored
TBR=smut Change-Id: Id2cb8c3fa1cf1840bbb399bcf2789098259ae40d Reviewed-on: https://chromium-review.googlesource.com/c/1436936Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#626060}
-
Hiroki Nakagawa authored
Before this CL, the test expects that a 404 failure on shared worker script fetch doesn't fire an error event. However, this doesn't obey the HTML spec (see below), and actually Chrome and Firefox fail the test [1]. Note that Edge and Safari haven't been implemented shared workers. This CL changes the test to expect that the failure fires an error event. <HTML spec from [2]> 12. Obtain script by switching on the value of options's type member: - "classic": Fetch a classic worker script given url, outside settings, destination, and inside settings. (...snip...) If the algorithm asynchronously completes with null, then: - Queue a task to fire an event named error at worker. - Run the environment discarding steps for inside settings. - Return. </HTML spec> <Fetch spec from [3]> To fetch a classic worker script given a url, a fetch client settings object, a destination, and a script settings object, run these steps. The algorithm will asynchronously complete with either null (on failure) or a new classic script (on success). (...snip...) 4. If response's type is "error", or response's status is not an ok status, asynchronously complete this algorithm with null, and abort these steps. </Fetch spec> [1] https://wpt.fyi/results/workers/semantics/run-a-worker/003.html?run_id=5697959937179648&run_id=5733815918002176&run_id=5135009983758336&run_id=5639735062036480 [2] https://html.spec.whatwg.org/multipage/workers.html#run-a-worker [3] https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-script Bug: 655458, 924041 Change-Id: Ia4dc694e5bff5daed9a80a963e6316293c86c8bc Reviewed-on: https://chromium-review.googlesource.com/c/1436276 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#626059}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e7605db01b24..d04daa05f551 git log e7605db01b24..d04daa05f551 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 lalitm@google.com trace_processor: add error handling capabilites to filtering columns Created with: gclient setdep -r src/third_party/perfetto@d04daa05f551 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Icc43d630831797b3046e6bd73cab905c2114c267 Reviewed-on: https://chromium-review.googlesource.com/c/1436996Reviewed-by:
-
Ioana Pandele authored
The current behavior disables the Passwords menu item when saving passwords is disabled by policy, however users should still be able to view previously saved passwords. Linking to the Google Password Manager will be disabled if saving passwords is managed. Bug: 925036, 923137 Change-Id: Ie94bf3ea0ce6703aa9f1fd67ed26ad513c780d87 Reviewed-on: https://chromium-review.googlesource.com/c/1433241Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#626057}
-
Stephane Zermatten authored
This patch introduces the concept of a Controller state. This allows grouping multiple methods from UiController into one, OnStateChanged, to control: - the overlay - whether keyboard is available - pulsing - entering the graceful shutdown state - whether the bottom bar should be expanded The goal of this change is to make it possible to figure out what the UI should look like given a Controller, when switching tabs and Controllers. This change also refactors the way partial overlays are handled at the end of a script. With this change, at the end of a script if there's no touchable area defined, it defines a touchable area that covers the whole screen. This allows the new PROMPT state to always correspond to a partial overlay, while other state always correspond to either no overlay or a full overlay. This change also removes support for the now unused show_overlay option of the autofill action. This is meant to be a refactoring. It should not change any visible behavior. Bug: 806868 Change-Id: Ida5b12f6eaf9b81a0cb06b75ccebe9380d71ae9b Reviewed-on: https://chromium-review.googlesource.com/c/1432856 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36f64175b11d..ed9c68d43a63 Created with: gclient setdep -r src-internal@ed9c68d43a63 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7c8b6b573cfca57a932bba4738f10c057ab73024 Reviewed-on: https://chromium-review.googlesource.com/c/1436995Reviewed-by:
-
Sami Kyostila authored
Make the MessageLoop to use SequenceManager as its default backend. Note that we are also launching a separate Finch trial to evaluate the performance and stability of the SequenceManager relative to MessageLoopImpl. Bug: 891670 Change-Id: If968033bbbbda0037dae2c2715f3827a13afcdc8 Reviewed-on: https://chromium-review.googlesource.com/c/1379763 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#626054}
-
Sami Kyostila authored
This patch adds a workaround for an issue in the iOS message pump in the following scenario: 1. The message pump timer slack is set to maximum. 2. A delayed task is posted for far in the future (e.g., 1h). 3. The system goes idle at least for a few seconds. 4. Another delayed task is posted with a much smaller delay. It appears the setting the tolerance for a CFRunLoop timer *after* setting the next fire time, it has no effect and the previous tolerance remains active. In the above scenario it means the task posted in step #4 actually runs in about half the delay set in step #2. This bug was causing a net_unittest to fail because the TaskScheduler's periodic task to adjust the number of active threads wasn't running, causing the system to grind to a halt because all worker pool threads were blocking on a lock. The workaround is to always set the timer tolerance before adjusting the timer fire time. Bug: 891670 Change-Id: I82e97fe993bbb8a71c417f01f4d6131cce0667ad Reviewed-on: https://chromium-review.googlesource.com/c/1434276 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#626053}
-
jdoerrie authored
This change updates base::win::RegKey's API to work on base::string16 and base::char16 instead of std::wstring and const wchar_t*. Furthermore, its implementation and tests are updated, so that they will continue to compile once base::string16 is std::u16string. Bug: 911896, 23581 Change-Id: I2c3479fbec55717e2065bd7398a2b696a81fcca8 Reviewed-on: https://chromium-review.googlesource.com/c/1426710 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626052}
-
Jérôme Lebel authored
Replacing |manageSyncSettingsViewControllerWasPopped:| by: |manageSyncSettingsTableViewControllerWasPopped:|, to match class name: |ManageSyncSettingsTableViewController|. This should have been done in crrev.com/c/1416522 Change-Id: Ic9824abc939921c18a1d96152f5b62c83351a88d Reviewed-on: https://chromium-review.googlesource.com/c/1434318Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#626051}
-
Jérôme Lebel authored
Adding the "Sync your Chrome data" switch. https://screenshot.googleplex.com/2x4W9Bzr8oJ Bug: 914059 Change-Id: Ie638b158e6e8733cad078076ea7fd833b750804c Reviewed-on: https://chromium-review.googlesource.com/c/1420837 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
OverrideBlockPercentageResolutionSize is shorter, and should be descriptive enough. The old name caused a lot of weird wrapping in the code. Also documented the concept. Change-Id: I5e7317bcb924858f49aafbadc2c225197f44a005 Reviewed-on: https://chromium-review.googlesource.com/c/1433245Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/49ccf380bb4e..e7605db01b24 git log 49ccf380bb4e..e7605db01b24 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 lalitm@google.com Merge "tools: append time to test_data and automagically update build-deps" Created with: gclient setdep -r src/third_party/perfetto@e7605db01b24 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3c9272511ac7b227312e2a14fed492d40cecfb85 Reviewed-on: https://chromium-review.googlesource.com/c/1436994Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 13990 14002 14007 14011 14016 14023 14030 14046 14062 14077 14091 14098 14106 14111 14115 14119 14129 14146 14155 14167 14169 14173 14182 14198 14206 14215 14221 14229 14233 7 lines were removed and 0 lines were deflaked by consecutive results since 14146. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I5944cc25aa8d76e6baa1931ba1365c1bacff31b3 Reviewed-on: https://chromium-review.googlesource.com/c/1425837Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626047}
-
Oskar Sundbom authored
This reverts commit 13a256be. Reason for revert: All chromedriver tests seem to fail after the bump to M74. Running locally with this version check disabled seems to clear it up. Original change's description: > [ChromeDriver] Check Chrome and ChromeDriver versions compatibility > > Checking if Chrome version is compatible with ChromeDriver version.. > > Change-Id: Ib7f9be9133e69b2c670b94fc6fec20a9598aed65 > bug: chromedriver:2685 > Reviewed-on: https://chromium-review.googlesource.com/c/1363687 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614741} TBR=johnchen@chromium.org,khachatryan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 925256 Change-Id: I1f070f5e6705a526b7346ad95f3709fb69b19076 Reviewed-on: https://chromium-review.googlesource.com/c/1436043 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1b405c7c793..36f64175b11d Created with: gclient setdep -r src-internal@36f64175b11d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0a7f0eaa238e9f8ec28a588423dc3617cdda44ea Reviewed-on: https://chromium-review.googlesource.com/c/1435767Reviewed-by:
-
Lowell Manners authored
The deleted factory was created a FakeGaiaCookieManagerService which was just a passthrough wrapper around GaiaCookieManagerService. Since FakeGaiaCookieManagerService was only acting as a pass-through the net effect of creating it was zero. Bug: 907782 Change-Id: I45453afbdd21584c96e328cdd24136072bce83ff Reviewed-on: https://chromium-review.googlesource.com/c/1421999Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626044}
-
Jan Krcal authored
This is needed because we are not launching the USS implementation by default in M73. Bug: 853688 Change-Id: Ia884892d618c4f8e9bc8391b89e32e276c98945a Reviewed-on: https://chromium-review.googlesource.com/c/1433769 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#626043}
-
Mikel Astiz authored
The protocol requires the sync client (chromium) to remember the last bag-of-chips returned from the server, and provide it back to the server in following GetUpdates cycles. This patch introduces the first integration tests that exercise such feature, including the required instrumentation in the fake server. This also works as regression tests recent DCHECK failures in crbug.com/924144. Bug: 924144 Change-Id: Ida483131a25adca1a13465cad82d8a377419e7b4 Reviewed-on: https://chromium-review.googlesource.com/c/1430006 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
