GitLab

This test is now timing out on all platforms

Bug: 1053870, 1016456
Change-Id: I9e8010a73ffdd6d2794a8e461293b8d3970195a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071097
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744467}

Add support for using zircon handles rather than file descriptors for
memory object & semaphore import/export. This is needed on Fuchsia.

Bug: 766360

Change-Id: If8fd761e2f4bb6bb4084127d25dd494151b3d96e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642277Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744466}

https://skia.googlesource.com/skia.git/+log/f8ef81b35e8f..0941b6e91bed

git log f8ef81b35e8f..0941b6e91bed --date=short --first-parent --format='%ad %ae %s'
2020-02-25 brianosman@google.com Use SkTPin in magnifier filter to avoid integer overflow with NaN
2020-02-25 bsalomon@google.com Add GrContextOption for GL error checking, shader, and program success.
2020-02-25 bsalomon@google.com Manual ANGLE roll. Update to our BUILD.gn to gen ANGLE's commit.h

Created with:
  gclient setdep -r src/third_party/skia@0941b6e91bed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1040186,chromium:1054887
Tbr: jlavrova@google.com
Change-Id: I65f1fdf0f0f6ddc1d338dc79361043eee7f1661e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744465}

Class to check an external server for whether the user is
is in a dogfood trial.

This code is not active as it is not yet called by any other code.

Bug: 1010366
Change-Id: I1f5063dbd46db3cc34092cb1575fd830fdf3f277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833167Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744464}

When navigating with Narrator using Scan Mode, Narrator gets stuck on
images surrounded by text inside a link.
E.g.: <a href="#">hello<svg></svg>world</a>

This issue is caused by AXPosition::AbortMoveAtParagraphBoundary that
should return true when a position is inside of an embedded object
(e.g., an image). Scan Mode uses paragraph navigation to jump from one
element to the next/previous.

This CL fixes it. I also added two tests:
  1. A unit test for AXPosition::AtStart/EndOfParagraph, which directly
     depends on AXPosition::AbortMoveAtParagraphBoundary.
  2. A browser test to test paragraph navigation in this specific
     example. This one is testing the end user experience.

Bug: 928948
Change-Id: Iccd5a67c50a2b0360a749e5cecb12d60b5f5e74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069027
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744463}

- inconsistent application (e.g. tooltip didn't get delays applied)
- inconsistent application of RuleStr.write (used for developer logging)
- within a single output rendering (i.e. .go()), each hint got delayed; only delay the first
- refactor hint_ into separate functions to clearly show the intent of the two groups (ordinary hints, and delayed hints); the former can more easily be added to for future authors
- clean up debt (lots of repeated code, unneeded params)

Test: existing browser_tests and a new test to show both ordinary and delayed hints together.
Change-Id: I5c5c261fb013b6f33a8fa3620e9669b48e957c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069841
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744462}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/137ae16f4e3f..8e87fcb858e8

git log 137ae16f4e3f..8e87fcb858e8 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 gbiv@google.com cbuildbot: use goma for latest_toolchain builds
2020-02-25 khmel@chromium.org arc: Increase timeout for master-pi-android-pfq.
2020-02-25 vapier@chromium.org osutils: WriteFile: support append+sudo using dd
2020-02-25 vapier@chromium.org autotest_quickmerge: migrate to python3 only
2020-02-24 vapier@chromium.org scripts: convert random standalone programs to python3 only
2020-02-24 vapier@chromium.org cros_build_lib: _Popen: workaround Python 3.4.1+ subprocess locking bug
2020-02-24 tbegin@google.com packages: use ebuild chroot path in uprev ebuild from pin
2020-02-24 vapier@chromium.org cros_build_lib: run: drop combine_stdout_stderr backwards compat
2020-02-24 tcwang@google.com afdo: Add verifiers to publish 4.14 and 4.19 kernel profiles.
2020-02-24 tcwang@google.com afdo: Stop updating kernel 3.14 AFDO profiles in legacy PFQ.
2020-02-24 richardfung@google.com Remove kevin-arcnext
2020-02-24 vapier@chromium.org portage_util: add more fields used by licensing
2020-02-23 vapier@chromium.org licensing: simplify CLI API
2020-02-23 vapier@chromium.org cros_sdk: fix hiding of failed commands
2020-02-23 vapier@chromium.org licensing: drop obsolete packages
2020-02-22 dburger@chromium.org Only run TestSimpleChromeWorkflowStage on canary release.
2020-02-22 pprabhu@chromium.org chromeos_config: Reduce CTS/GTS hardware test timeout
2020-02-22 vapier@chromium.org cros: switch to python3 only
2020-02-21 chrome-bot@chromium.org Update config settings by config-updater.
2020-02-21 vapier@chromium.org cbuildbot: stop importing cros_vm_test
2020-02-21 dburger@chromium.org Advance REEXEC_API_MINOR so that --chrome-preload-dir may be used.
2020-02-21 vapier@chromium.org image_lib_unittest: add missing cleanups of images

Created with:
  gclient setdep -r src/third_party/chromite@8e87fcb858e8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I8dbe8910b163f43a3279d1281956411c36a9e380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072296Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744461}

To support more media controlling features, mainly Bluetooth media
controllers and HID keyboards, new VKEYs have been added. Including:
VKEY_MEDIA_PAUSE, VKEY_MEDIA_PLAY, and VKEY_MEDIA_STOP. This patch
update the accelerator support for these new keys. Furthermore, to help
Bluetooth device to be qualified for AVRCP (Audio/Video Remote Control
Profile), add support for "Fast Forward" and "Rewind".

BUG=b:147366755, b:147364903, b:147364132, b:147367726

Change-Id: Ifc8975b05ab237ad379d3c4ae389a89459e0857e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068251
Commit-Queue: Michael Sun <michaelfsun@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744460}

https://chromium.googlesource.com/angle/angle.git/+log/5b7ce876b01c..27cb806ca819

git log 5b7ce876b01c..27cb806ca819 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 capn@google.com Update DEPS for SPIRV-Tools and SwiftShader
2020-02-25 jmadill@chromium.org Vulkan: Use new APIs in BufferHelper::copyFromBuffer.
2020-02-25 jmadill@chromium.org Vulkan: Fix padding out Buffer allocations on AMD.

Created with:
  gclient setdep -r src/third_party/angle@27cb806ca819

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: I9503ff2324cc4fb72db246698c787f7a043e9b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072847Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744459}

Folders are handled by scanning all of their internal files. This is
done in a different thread to avoid blocking.

Bug: 1055296
Change-Id: I60971add2555e54cbe6107151e75b4af36df404c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068836Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744458}

https://dawn.googlesource.com/dawn.git/+log/6c1d646ee9d4..227568451b44

git log 6c1d646ee9d4..227568451b44 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 rharrison@chromium.org Add in --no-use flags for spvc features
2020-02-25 natlee@microsoft.com ObjectStorage Allocate nullptr when id is 0
2020-02-25 cwallez@chromium.org infra: Use macOS 10.15 and newer OSX SDK.

Created with:
  gclient setdep -r src/third_party/dawn@227568451b44

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1052673
Tbr: cwallez@google.com
Change-Id: I1934a02923299712855dcc6bfc3e14ce3747cf2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072850Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744457}

Allow cc_unittests to use manifest with permissions to access Scenic and Presenter.
Disable tests using GL renderer, enable ones that use Vulkan.
Filter out tests that are crashing.

Bug: 1047032
Change-Id: I8b028a8e01728fd6765b01b745ceec308f2e1a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042539
Commit-Queue: Chong Gu <chonggu@google.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744456}

We don't expect the MenuListInnerElement is editable. This CL makes
it read-only.

Bug: 1055097
Change-Id: I61abfc0335fed90cc6d2c9eb619a50999585496a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071527
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744455}

It includes the images for android 23, 28, and 29

Bug: 1048781, 922145
Change-Id: I35863e1aa57537d7f37aff2f430e7100cddc53d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072656Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#744454}

This is a further step in the direction of controlling re-layouts in
a top-down manner instead of letting components at the bottom of the
tree trigger re-layouts when they change, which leads to a lot of
extra work and redraw.

Remove the "ShelfUpdatedWhenStatusAreaChangesSize" test which doesn't
make much sense any longer: the shelf is sizing itself to match the
various components' needs, children and target bounds, not just when
one of them happens to artificially change its bounds.

Bug: 1042918, 1047012
Change-Id: Ib0408aac401b32a2adcc306f3012f3943c05e220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070825
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744453}

When a swipe happens, an ET_GESTURE_SCROLL_END is not sent. This would
cause the tab strip to get stuck partially open in some cases.

With this CL, the tab strip will always fully open after a swipe. This
also adds ET_GESTURE_END handling to avoid similar bugs if an
unsupported gesture is sent.

Bug: 1043374
Change-Id: I98397e7557eb3e40fb1de04f429866925c60daed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070969
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744452}

The validation layers in ANGLE are necessary for security reasons and to
support the robust client memory extension required by client-side GL
contexts. But it can be avoided for the service-side GL context used by
skia with OOPR and SkiaRenderer.

R=geofflang@chromium.org

Bug: 1028418
Change-Id: Ia1f59752e0f5aed2fc8542cc5b3fb2ba81922c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057563
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744451}

Returning early from the function if the service is null to guard
against a potential race condition affecting beta.

Bug: 1055274
Change-Id: Ibb419037e67b2bce7cc31b3f0371ed1264ca01fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070823
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744450}

These two dialogs will use Extension install prompt dialog with
different text.

User can confirm extension request dialog for requestable extension to
upload request.
Extension request pending dialog is for information only.

When either dialog is shown, the
webstorePrivate.beginInstallWithManifest3 function will returns user
cancel to stop extension installation.

This dialog will be used till CWS lands the button change. UI has been
approved by UX team.

These two dialogs are temporary solution for extension request feature
as CWS team can't migrate to the new webstorePrivate.requestExtension
API in time. The dialogs will be deprecated once the migration is done.

Screenshots:
https://drive.google.com/file/d/1rFp4sc-C-MyDLTS1wAHrolf1gdYK6TLs/view?usp=sharing
https://drive.google.com/file/d/196GO6xUgMZMNmOv5maopDP5MgYd_bVRH/view?usp=sharing

Bug: 1006899
Change-Id: If9b439d2cf2e9d4eabf0d146e45b9df3a5adcf93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065594
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744449}

Some frames like srcdoc frames inherit URLLoaderFactories from their
parents and can make network requests before a corresponding commit.
Hence if the parent frame is allowlisted, this CL allowlists the child
frame as well when the child frame is created (as opposed to waiting for
a commit in DidFinishNavigation).

This also fixes another bug where a frame which underwent multiple
navigations didn't have the correct allowAllRequests frame action
associated with it. This was because std::map::insert doesn't insert if
the corresponding key already exists in the map. We correct this by
always erasing the key before inserting in
RulesetMatcherBase::OnDidFinishNavigation.

BUG=1050536

Change-Id: I59d809b160ff534c100cfc7b44b82965a236b48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069023
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744448}

This CL update the function DeleteDataForOriginOnFileTaskRunner to use
dedicated Origin type instead of GURL.

Bug: 598424
Change-Id: I597a2d31944ad41427b2c8b42586f069c5478e45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071522Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#744447}

This will make it easier to check for new issues when running `git cl
lint`.

Bug: 1053888
Change-Id: Ib3199e868ddda532198f84070a155ff5ffa85fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063000Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#744446}

Getting display from the WindowManager may raise errors in future
versions of android because the API implies it supports multi-display
but it actually depends on the Context being used. Application context
definitely will not support multi display.

Instead retrieve the default display from DisplayManager does not have
this limitation and also makes it clear in code that this code is not
multi-display aware.

Note an earlier version of this to use DisplayAndroid was reverted
because this code does not run on the UI thread.
https://chromium-review.googlesource.com/c/chromium/src/+/2026354

Bug: 1042063
Change-Id: I1066c9f5b7dfed572c47ece72acd012329a863c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070331Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744445}

All ContextFactoryPrivate implementations are also ContextFactory
implementations. Move the two remaining ContextFactoryPrivate functions
into ContextFactory and clean up usage.

Bug: 1042259
Change-Id: I48063717cd6e51ccfc94e0a160d50d95d7629388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047728
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744444}

This metric stores the same values as
Variations.FirstRun.SeedFetchResult, but stores results for all WebView
seed requests, rather than Clank's first-run request.

See doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw for more details.

Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'AwVariationsSeedFetcherTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedLoaderTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedServerTest#*'
Test: Manually verified correct metrics were being recorded by adding
Test: logging when recording the metrics.
Bug: 1047536
Change-Id: I3f216084844198ed8828695d615a359bb83c41e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067275Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744443}

Bug: 1054843
Change-Id: I6ea53913579f94b6725902f7038c214dea05c9bc
Fixed: 1054843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071046
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744442}

Bug: 634140
Change-Id: Ied0092d83f179dc47130c9bf882cc43aca647da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066477Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744441}

AppServiceAppIconLoader should replace the ArcAppIconLoader, so update
arc_app_unittest to use AppServiceAppIconLoader.

Fix the unit tests failures:
1. AppServiceAppIconLoader should support ARC shelf id, so add
shelf_app_id_map_ to record the map from app_id to shelf id.

2. Move GetAppFromAppOrGroupId from ArcAppIcon to arc_app_utils, because
AppService icon loader calls that function to get the app id from the
ARC group id.

3. Update the unit tests, WaitForIconUpdates, the expected callback
on OnAppImageUpdated should be once:
From:
delegate.WaitForIconUpdates(scale_factors.size());
To:
delegate.WaitForIconUpdates(1);

Because AppService will callback once when all supported scale factor is
loaded:
https://cs.chromium.org/chromium/src/chrome/browser/apps/app_service/arc_icon_once_loader.cc?l=101

4. Update AppService icon loader to call ArcAppIcon to generate the
default icon in case the icon load failed.

BUG=1016159

Change-Id: I1c8ebc018eab3becb37351f51116f63a395f6f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050143
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744440}

Disables AccessibilityInputDateWithPopupOpenMultiple
and XmlInIframeCrash on all platforms.

Bug:1055764
Change-Id: I5f048849bcea1f400e69a65bae9bbedfa97d5f55

TBR=vicfei@microsoft.com

Change-Id: I5f048849bcea1f400e69a65bae9bbedfa97d5f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072931Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744439}

Experiment has expired and we currently don't want to pursue this.

Change-Id: I434333da5980be149f1f61fd74aa267ce9653ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071858Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744438}

Worth it to only have to review all of these once a year.

Bug: 1055383
Change-Id: I6948ea46796dc0a6891e017a59fac0ce86cb36e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070831Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744437}

It used to be |has_audio| to differentiate audio message and non-audio
message. But now we have one more type of message, i.e., metadata
message. Meanwhile, add new util method to populate metadata message.

Merge-With: eureka-internal/357770
Bug: internal: 140736325
Test: On device. Unittests.
Change-Id: Ic89ffb293b75ce303631dda08ace720f949c318c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049025Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Kehuang Li <kehuangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744436}

Clunky commands:
find chrome/browser/ -type d \( -wholename '*java/src' -or -wholename '*junit/src' -or -wholename '*javatests/src' \) | sort | sed -e 's/\(.*\)$/    <classpathentry kind="src" path="\1"\/>/gm'
find components/ -type d \( -wholename '*java/src' -or -wholename '*junit/src' -or -wholename '*javatests/src' \) | sort | sed -e 's/\(.*\)$/    <classpathentry kind="src" path="\1"\/>/gm'

BUG=

Change-Id: I3fca1ab27b5c52bf62b5d048c782bba95ce5c06c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072875Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744435}

This CL adds a new bucket to the Download.InitiatedByWindowOpener
histogram. The new bucket records if the opener (the tab that
initiated the download) or the openee (the tab on which the download
was initiated) is a non-HTTP or HTTPs URL such as about:blank.

Bug: 121259
Change-Id: Ic45a82df693422419a15849a19027002697e0838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072678
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744434}

Apply the 'Fuchsia x64' CI and fuchsia-fyi-arm64-rel FYI builder
exceptions to the 'Fuchsia ARM64' CI builder.

This is being done before tests are enabled on the 'Fuchsia ARM64' CI
builder.

Bug: 1042512
Change-Id: Ie439d47b14d60a548335489e21ab47f4f9e10c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071368Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#744433}

This reverts commit 756673ee.

Reason for revert: <INSERT REASONING HERE>
interactive_ui_tests fails
BrowserFocusTest.PopupLocationBar
PasswordBubbleInteractiveUiTest.AutoSigninNoFocus
OmniboxFocusInteractiveTest.NtpReplacementExtension_LocationAssignment
BrowserFocusTest.FocusOnReload
...26 more failure(s) (30 total)...
on Builder Linux TSan Tests
https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests

Original change's description:
> Enable WebUITabStrip in fieldtrial_testing_config.json
> 
> Bug: 1009881
> Change-Id: I0c784e4ac16bb14e5515b95680adfea3b5e3148c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069499
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Collin Baker <collinbaker@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744385}

TBR=jwd@chromium.org,collinbaker@chromium.org

Change-Id: I8be4824fcc9e2ccb873807d44faee7105d865dbd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1009881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073159Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744432}

This lets test authors put their HTML and JS content in an external file
instead of inlining it into the LoadHTML call.

Also update MetricIntegrationTest.LayoutInstability to use this
capability.

Bug: 1045064
Change-Id: I7b8de053b468f5cf82747a875a2730242665891d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067348Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744431}

Consistently use 'const Module' rather than 'Module' in the interface.
Modules are not to be mutated by the ModuleCache or its users.

Rename InjectModuleForTesting to InjectNativeModuleForTesting to be
clearer about what it does.

Have GetModules() return both native and non-native
modules to make the behavior consistent with the function
name. The only current user of GetModules(),
content::protocol::MemoryHandler::GetBrowserSamplingProfile(), does
not add any non-native modules to the ModuleCache so returning
non-native modules from the function will not affect it.

Bug: 1035855
Change-Id: Ie1cd38e081ee48297df3c7a15b8e4997d1df1589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062883
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744430}

This reverts commit 38ee3ee4.

Reason for revert: UX would like a complete review before making this change.

Original change's description:
> Compute omnibox background color from toolbar color.
> 
> This makes the omnibox/toolbar contrast ratio 1.3 by default.
> Theme authors can manually override the default colors.
> 
> Bug: 878664
> Change-Id: I24b95e8d225fd375b573b48e403fbf147013e940
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986244
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#730295}

TBR=pkasting@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 878664
Change-Id: I1fb8a3c7cfd1b8cd57a260cc9d7f00aa8131e024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070601Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744429}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4be48f5a3603..be4da4f63d35


Created with:
  gclient setdep -r src-internal@be4da4f63d35

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1054683,chromium:1055510
Tbr: jbudorick@google.com
Change-Id: I864092390084e0c4c586a5c77467f9fdb2ce8522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072843Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744428}