- 30 Aug, 2018 40 commits
-
-
Javier Fernandez authored
The new Baseline Alignment algorithm states that items with sizing cyclic dependencies must be excluded from any baseline context they participate in. One of these cyclic dependencies can happen with intrinsic sized grid areas and relative items. The grid spec states [1] that flex-sized tracks should be considered as content-sized when the grid container has an indefinite size. We were using the AvailableSize(direction) function to determine whether the grid container is indefinite or not. However, this function may provide different results during the different phases of the grid layout logic. This issue causes assert violations like the one described in the bugs listed below. The new Baseline Alignment logic is now integrated in the Grid Track sizing algorithm. Hence, we need to ensure that an item that participates in any baseline alignment context during the track sizing also does during the alignment phase, at the end of the grid layout logic. In order to achieve that, this CL forces a new computation of the Baseline offsets during the step 3 of the Grid sizing algorith, since during this step the available space is not indefinite anymore. It's worth mentioning that this change assumes the issue grid items being excluded and included of Baseline Context during the different phases of the Grid sizing algorithm, which I hope we can clarify in the issue [2] I filed for the CSS WG. [1] https://drafts.csswg.org/css-grid/#fr-unit [2] https://github.com/w3c/csswg-drafts/issues/3046 Bug: 867833, 874861, 876593 Change-Id: I668d399b920c9280a8e20b3e8362f562eded4770 Reviewed-on: https://chromium-review.googlesource.com/1177757Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#587799}
-
Tarun Bansal authored
UI network quality estimator service no longer needs to implement network quality provider since we now have network quality tracker. This CL simplifies the logic in UI network quality estimator service by removing the unnecessary code. Bug: 878844 Change-Id: I7d97bc29452a73d5a6f522b58cca3c67e5368e77 Reviewed-on: https://chromium-review.googlesource.com/1196005Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#587798}
-
Alan Cutter authored
Bubble widgets no longer have a visible arrow, this simplifies the bounds layout calculation. This CL removes redundant constants that are either 0 or equal to other constants in BubbleBorderTest.GetBoundsOriginTest. Bug: 877032 Change-Id: Icb886704647f926acbf29c23df0695ea36cd9b5b Reviewed-on: https://chromium-review.googlesource.com/1195244Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#587797}
-
Max Morin authored
ProcessedLocalAudioSource is changed to either create a MediaStreamAudioProcessor or an AudioServiceAudioProcessorProxy depending on whether the WebRtcApmInAudioService flag is set. AudioServiceAudioProcessorProxy proxies GetStats and AECDump calls to the remote audio processor. Although the JavaScript getStats call is asynchronous, we currently collect stats synchronously inside Chrome. Ideally, this would be changed. For now, the proxy overcomes this mismatch by polling the remote audio processor for stats at regular intervals. It uses a heuristic to determine the rate at which the user is calling getStats and tries to match that, within some reasonable limits. 878764 has been filed to fix this. For AECDumps, we already get a file-handle from the browser, so it can just be sent along to the audio service. So the audio service does not need to be able to create files for this to work. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. No-try since the test timing out is unrelated. No-Try: true Bug: 851959, 878764, 879133, 879243, 879296 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7473c068aa691d69f6ba90dce2550534c9cb3d8a Reviewed-on: https://chromium-review.googlesource.com/1169471 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587796}
-
Sujie Zhu authored
In this CL, we create a new autofill_private api function in order to trigger migration from settings page. We have to construct autofill_client, payments_client, personal_data_manager and local_card_migration_manager in the api for triggering migration and uploading the cards. The following CL will be use the added IsMigratable, syncStatus and experimental flag to check the migration requirement and trigger this api when meets the requirements. Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i Bug: 852904 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I75a4a952efaf33c3f9187348a6e39f3abd4471a4 Reviewed-on: https://chromium-review.googlesource.com/1178683Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#587795}
-
Sammie Quon authored
Refactor the launcher overview animation to share some code. Test: manual Bug: 873394 Change-Id: I6c94719a559eea04e354d2bc131efc4cf14650df Reviewed-on: https://chromium-review.googlesource.com/1196910Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#587794}
-
Kevin Strohbehn authored
Bug: 860119 Change-Id: I1545e820cd53d46ef6a20b6d923d33f727070901 Reviewed-on: https://chromium-review.googlesource.com/1195897Reviewed-by:
-
Max Morin authored
Similar to the output CL, processing settings are plumbed into the audio service. InputControllers join the processing group and get notified by the appropriate output controller is started. It can then reconfigure itself as necessary; to either start monitoring the output stream or to ask what device it is using and call SetOutputDeviceForAec on its AudioInputStream. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I138cd290295821467e836a7e7e6eb7d7ad364bdc Reviewed-on: https://chromium-review.googlesource.com/1174835 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Maks Orlovich authored
~NetworkService happens before task scheduler shutdown, and so some tasks in things like cookies and disk_cache can outlive it, and those want to use the NetLog sometimes --- so the NetLog can't be destroyed in ~NetworkService Bug: 878428 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I53f89982f6683ff2ab326198691670627e7fbbb8 Reviewed-on: https://chromium-review.googlesource.com/1195549Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#587791}
-
Sujie Zhu authored
Add Google Payments account check. We only offer credit card migration when user already has a Google Payments account. We get the PrefService from the Profile and then we can get whether user has a google payments accout from the PrefService. Bug: 852904 Change-Id: I06d326417cdc4fded5a15635f8883ebabbe0a1f5 Reviewed-on: https://chromium-review.googlesource.com/1196013Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
-
Jennifer Apacible authored
Change-Id: I29fd4a91e943ecbda810c1ae4085a5476896e3f8 Reviewed-on: https://chromium-review.googlesource.com/1197288Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#587789}
-
Jennifer Apacible authored
The buttons on other platforms handle the space key as well. This change only adds the handling to toggle play/pause to Mac. The close button is not handled since tabbing is not handled and there are no visual affordances for which button is focused on Mac. These exist on other platforms. Bug: 879139 Change-Id: I40135a7c70fd8d737a2b3b368bfad968d0eeb225 Reviewed-on: https://chromium-review.googlesource.com/1196931Reviewed-by:
-
Tom Anderson authored
The new instruction bubble's recommendation to "press Alt+F" won't work on non-browser windows, so don't show the instructions unless the focused window is a browser window and has a toolbar. BUG=243164 R=sky Change-Id: I1ab550ff57134009a2cbb0a1ee612775c1323e88 Reviewed-on: https://chromium-review.googlesource.com/1197343Reviewed-by:
-
Tom Anderson authored
The message always used to say "Press Alt+F followed by X to exit". The "X" comes from the menu option "Exit". But the accelerator may be different in non-English languages. This CL internationalizes the accelerator. BUG=243164 R=sky Change-Id: I695979eef5ea15f1764b891611b2c513302c4c0e Reviewed-on: https://chromium-review.googlesource.com/1194976Reviewed-by:
-
Alexei Filippov authored
BUG=878604 Change-Id: I20d281d9b03fbb41c2cac72586a60949fc73a860 Reviewed-on: https://chromium-review.googlesource.com/1197269Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#587785}
-
Sahel Sharify authored
This reverts commit fa22a78c. Reason for revert: I reverted the initial cl to prove that crash reports in crbug.com/868849 are not caused by it. Relanding it now since the crashes still happened after the revert. Original change's description: > Revert "Clean up DidStopFlinging IPC" > > This reverts commit 7cb247dd. > > Reason for revert: Check to see if the crash report in crbug.com/868849 goes away or not. > > Original change's description: > > Clean up DidStopFlinging IPC > > > > This cl also removes TouchscreenFlingInProgress function that is no > > longer needed. > > > > Bug: 249063 > > Change-Id: Icc939d654cdfe0cf38c843933f2fd469f843b74c > > Reviewed-on: https://chromium-review.googlesource.com/1145784 > > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#578410} > > TBR=kenrb@chromium.org,pdr@chromium.org,dtapuska@chromium.org,sahel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 249063 > Change-Id: Iee7200d3c4e388fccbc2dc6b86997a07a3a03f0a > Reviewed-on: https://chromium-review.googlesource.com/1155169 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579166} TBR=kenrb@chromium.org,pdr@chromium.org,dtapuska@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 249063 Change-Id: I47b3d00615ebb29b643aa03ef73b523381c092c6 Reviewed-on: https://chromium-review.googlesource.com/1197334Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587784}
-
Vladislav Kaznacheev authored
- show auto-hide related menu option in tablet mode - respect auto-hide bit in tablet mode if it is set in clamshell mode - update test accordingly ash_unittests --gtest_filter=Shelf* Bug: 878039 Test: manual, ash_unittests --gtest_filter=TabletModeWindowManagerTest*, Change-Id: I8a8688e794e243e4b2da026803dff9e136f3c1f1 Reviewed-on: https://chromium-review.googlesource.com/1196142 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#587783}
-
Kevin Marshall authored
This CL adds support for touch/gesture input (touch, swipe, pinch, etc.) to the ContextProvider service. Also included in this CL: * Adds input focus event handling. * Populate Screen/Display dimensions on window size events. * Miscellaneous IWYU fixes. Bug: 876933, 878439,829980 Change-Id: Ic4e5a8123bac2360e40f2affe6e1ec1e242260d4 Reviewed-on: https://chromium-review.googlesource.com/1194973 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#587782}
-
Wez authored
Temporarily add some values to minidumps, to help diagnose crash reports under SkDraw::drawPaint and related signatures. Bug: 870663 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I84f3aed1c50c8e44bc882e6655688bd26c0e4edc Reviewed-on: https://chromium-review.googlesource.com/1196226Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#587781}
-
Johann authored
Cherry pick rtcd-related changes and re-run cmake_update.sh This allows the linker to remove unused C code when an sse2 version is available. See discussion on libvpx: https://chromium-review.googlesource.com/c/chromium/src/+/1195800 R=tomfinegan@chromium.org Change-Id: I419a87e6d0b4f9166754aaaedf6b9c8cd1834dae Reviewed-on: https://chromium-review.googlesource.com/1197466Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#587780}
-
Trent Apted authored
A call to __CFPasteboardDeallocate is triggering "BUG IN CLIENT OF LIBDISPATCH: Semaphore object deallocated while in use" when it invokes _dispatch_semaphore_dispose. This appears to happen under ~UniquePasteboard in Chrome. Try moving ownership of the NSPasteboard the autorelease pool to avoid triggering the call to -[NSPasteboard dealloc] deep in the drag-tracking stack. Bug: 877979 Change-Id: I0f5ff067da31870fd62591ccdd9c3731377d73e2 Reviewed-on: https://chromium-review.googlesource.com/1192865Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#587779}
-
Sujie Zhu authored
We should not include the prompt experiment here because local card migration doesnot have the required messaging to show the shorten tos. Bug: 852904 Change-Id: I4c3c7a9bcee1d24a97dbd23dea2924cd3eef1a3b Reviewed-on: https://chromium-review.googlesource.com/1197370 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587778}
-
Ryan Cui authored
Verified functionality on an Eve. This will need to be revisited for Mash. BUG: 796366 Change-Id: I7b32728ff2440a8f5cda9b5ac0c28ad30182b145 Reviewed-on: https://chromium-review.googlesource.com/1197367Reviewed-by:
-
Thomas Tangl authored
The following methods are renamed to make the difference between opt-in and feature-enabled more clear: * IsUnifiedConsentEnabled() -> IsUnifiedConsentFeatureEnabled() * IsUnifiedConsentBumpEnabled() -> IsUnifiedConsentFeatureWithBumpEnabled() Note: For checking the unified consent opt-in UnifiedConsentService::IsUnifiedConsentGiven must be used. Bug: 878659 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1ff2342abb0ebb058ac6ba787c95ddba33d53be5 Reviewed-on: https://chromium-review.googlesource.com/1194370Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#587776}
-
Jeffrey Kardatzke authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/71adbf6a5686..a71cda985de2 $ git log 71adbf6a5..a71cda985 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 semenzato system_api: dbus: add metrics_event protobuffer 2018-08-16 jkardatzke Add protobuf for mime type mappings in Crostini. 2018-08-22 chirantan seneschal: Update proto comments 2018-08-07 emaxx diagnostics: API for bootstrapping Mojo to browser Created with: roll-dep src/third_party/cros_system_api Bug: N/A Change-Id: I7e5d49f74f31b8c959788cd3edd5a079f87ee315 Reviewed-on: https://chromium-review.googlesource.com/1197362Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#587775}
-
Luna Lu authored
The CL https://chromium.googlesource.com/chromium/src/+/bd4c33b5e81d495ecdac66b0375924d9565330cb did not handle responsive images correctly. This CL resets overridden_intrinsic_size_: When source is chosen using W descriptor, 'sizes' sets the new width of the overridden_intrinsic_size_, and the new height is calculated by the aspect ratio defined by the intrinsicSize attribute. Bug: 874629 Change-Id: I16b2f6c2fb9ae741144ba509c57f1e033c8cdc17 Reviewed-on: https://chromium-review.googlesource.com/1195801 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#587774}
-
Michael Giuffrida authored
Import sample photos from the Demo Mode Resources image into the Downloads directory. This makes browsing File Manager a little more interesting and provides pre-populated images for the Google Photos app. Tested by adding media/photos/{foo,bar,baz}.jpg into the offline resources component and installing on a device in Demo Mode. Bug: 870855 Change-Id: I77b4a664d5714cef1f8aeb524863afe70e891800 Reviewed-on: https://chromium-review.googlesource.com/1196223 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#587773}
-
Christopher Cameron authored
Create a new component //ui/views_bridge_mac for the Cocoa parts of the Cocoa implementation of views. Move the interface views::BridgedNativeWidgetPublic from being a C++ pure virtual interface to the mojo interface BridgedNativeWidget in views_bridge_mac. Note that the concrete implementation of this interface, views::BridgedNativeWidget is to be renamed to BridgedNativeWidgetImpl, and moved to cocoa_viewer. Bug: 859152 Change-Id: I3d97502285e81d603948672e9789366cd09d6b3d Reviewed-on: https://chromium-review.googlesource.com/1194498 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#587772}
-
Xianzhu Wang authored
BoxModelObjectPainter::PaintTextClipMask() is called from Paint() method of some painter which has already adjusted for paint offset and paint properties, so we should not go back to call box_model_.Paint() again, but should call LineBoxListPainter instead. This fixes an old FIXME which was too bad before we switched to SPv175 paint offsets. Bug: 878685 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I78f3a82a133b14eb56dbeaf2b8b5f81041c0c59e Reviewed-on: https://chromium-review.googlesource.com/1197462Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#587771}
-
Fabio Tirelo authored
This CL replicates on Android the following changes already done on other platforms: - Replace the Autofill toggle with two new toggles, one for credit cards and one for addresses, and add them to the corresponding pages in Settings; - Update the strings for titles, toggles, and toggle descriptions; - Delete deprecated strings. This takes up crrev.com/c/1135514, which was abandoned. Comments initially added there have also been addressed here. A follow-up CL will get rid of the "Autofill and payments" page and move the "Addresses" and "Payments" page to the top Settings page. Screenshots and video (Googlers only): https://drive.google.com/open?id=1ZZr2lbX9q48DAxiTSVq6dZCImchqz-yA Bug: 860526 Change-Id: I613f3badfb655532228ee1b6b6029eac06f1d42f Reviewed-on: https://chromium-review.googlesource.com/1194474 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#587770}
-
Devlin Cronin authored
Update the context menu strings to the new spec. The submenu title is exceptionally long, but it's the best we have. Bug: 876779 Change-Id: I0d97caa14061b722c958e82e2a189c7b5f6588f2 Reviewed-on: https://chromium-review.googlesource.com/1195940Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587769}
-
Tommy Steimel authored
This reverts commit 936898b9. Reason for revert: The null checks are not solving the crash. Must be a deeper issue where the style object is garbage Original change's description: > [Media Controls] Reland Prevent ComputedStyleRef crash > > This CL re-adds the null checks for internal_button_ and > GetComputedStyle on the overlay play button. These were added to > prevent a crash, then removed when the crash was not fixed and replaced > with a different null check. However, it looks like we actually need > these too, so we're adding them back. > > Bug: 870490 > Change-Id: I1c6ad4b3f1dc36c7a2149a06c4f42f8ca00fb589 > Reviewed-on: https://chromium-review.googlesource.com/1187710 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585719} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870490 Change-Id: I93d49a3a2071ce5fcca99b68f8cbaf2c3720f889 Reviewed-on: https://chromium-review.googlesource.com/1197346Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587768}
-
Mustafa Emre Acer authored
The current code uses NavigationEntryCommitted, but it should have used DidNavigationFinish instead. Bug: 843361, 847662 Change-Id: Ie16016844e636a14c2114450a6e3b2a94cd2529b Reviewed-on: https://chromium-review.googlesource.com/1197083Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587767}
-
David Black authored
See associated CL and description details in: https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/669327 Bug: b:113541754 Change-Id: Icbab2c753c0e3b0c3f3797a5a85f52fb210e9cf3 Reviewed-on: https://chromium-review.googlesource.com/1196222Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#587766}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I69369c19a93e11f408240705c6aa3af803775ef5 Reviewed-on: https://chromium-review.googlesource.com/1197622Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#587765}
-
Meilin Wang authored
- Fix the corner radius of minimized Assistant UI mode. - Paint shadow around the rounded rectangle border while resizing. Test: local compile and manually test. Bug: b/112312304 Change-Id: Ibf07d06564b6fa82790fcc5ac7f656c45e4ac7da Reviewed-on: https://chromium-review.googlesource.com/1188899 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
-
David Bertoni authored
This CL integrates the new enhanced keepalive data into the JSON output for the chrome://extensions-internals page. Bug: 695711 Change-Id: I7cc3b09dbccd2fef9379f2cb68939f4e029136cf Reviewed-on: https://chromium-review.googlesource.com/1196169 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Gordana Cmiljanovic authored
This will fix compilation error: ../../third_party/libdrm/src/tests/modetest/modetest.c:388:11: error: format specifies type 'unsigned long long' but the argument has type '__u64' (aka 'unsigned long') [-Werror,-Wformat] prop->enums[i].value); ^~~~~~~~~~~~~~~~~~~~ Change-Id: Id9881f6ae1831812e851f0d1e62998c383355430 Reviewed-on: https://chromium-review.googlesource.com/1194068Reviewed-by:Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587762}
-
Peter Kotwicz authored
This CL moves the Android Manifest generation via manifest_processor_template into the webapk_tmpl GN template. This CL is in preparation to adding a new webapk_tmpl() GN target for generating a WebAPK which shows the splash screen within the WebAPK's activity. BUG=817263 Change-Id: I83b1292da2869dc1d8de784d137cba75962633c6 Reviewed-on: https://chromium-review.googlesource.com/1183814 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#587761}
-
Alexey Kozyatinskiy authored
One of the next V8 rolls will contain fix for source location of end of source syntax error. We need to disable to temporary disable ProxyResolverV8Test.ParseError test. R=eroman@chromium.org Bug: v8:8092 Change-Id: I93ad80167c5af4bca8f1d768b42cbea0b7833e55 Reviewed-on: https://chromium-review.googlesource.com/1196863 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
