- 15 Oct, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
This is class is unused following crrev.com/c/2470877. This CL removes, together with the Commit*::CleanUp() methods which are now unnecessary. Fixed: 1137896 Change-Id: I75a7e4b64da970cc8f84966c57d1225693737103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470528Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#817576}
-
Ian Wells authored
Bug: 1056751 Change-Id: Id517413e180ad7cc2f7688d47038587f2a3ecb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458853Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#817575}
-
Miriam Zimmerman authored
This improves on the previous a11y fix in a few ways: 1. It only reads the error text once, as opposed to twice. 2. It indicates to the user that the description is required when they first see it. 3. It marks the description field as "invalid" when the user doesn't fill it out. This change also cleans up the error if the user correctly populates the description field. BUG=chromium:1107656 TEST=Open feedback, ensure chromevox says "required" when first reading\ field. Then, click "send" and ensure focus returns to the text box\ and reads both error message and description. TEST=Artificially induce a later failure in sendReport(), enter text \ in the description textarea, click send, and verify alert is \ cleared. Change-Id: I9f56bb1e0377a04d2c23cf99b6fad012d3a7c4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473138 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#817574}
-
Keren Zhu authored
Bug: 1121399 Change-Id: Ib334ab3a11a3c980a182c593d50b0a5f64f3155c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472339Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817573}
-
Dave Tapuska authored
The only user is the TestRunner and it can call SetIsActive directly on the associated WebView. SetIsActive doesn't need to be called when setting focus on a widget to true as that is implicitly done inside blink. BUG=1097816 Change-Id: I4887342653b62dddfcda8628bdd1045cb10fa510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464042Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817572}
-
Tanmoy Mollik authored
Increase the expiry of the histogram to M89 Bug: 1138396 Change-Id: I9690dbd9d90281ab59b144bc8670f547778c7f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470880 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#817571}
-
ckitagawa authored
A number of updates to the Paint Preview README as part of efforts to polish the API. Change-Id: Ia07f47ab8c65cae2ecd211f944f2dbfbb24d327b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475977 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#817570}
-
Greg Daniel authored
This is a reland of f2038e2b Original change's description: > Fill in usage flags and sample fields on skia GrVkImageInfo. > > Change-Id: I1da7035e84173f5e9d8021ec3d2639f2ba96bf89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469261 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Greg Daniel <egdaniel@google.com> > Cr-Commit-Position: refs/heads/master@{#817141} Change-Id: I698bd77637392d3ea48cae69b271a80715bf4bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475534Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Cr-Commit-Position: refs/heads/master@{#817569}
-
Kevin Ellis authored
The underlying source of the test flakes was likely addressed in recent changes to the handling of play and pause for scroll-linked animations. https://chromium-review.googlesource.com/c/chromium/src/+/2386339 This patch also contains a cleanup to remove the unnecessarily convoluted way of hiding the scrollbar for the clamped offset test. Tested with 1000+ retries of the two tests in a virtual threaded environment. Bug: 1080609 Change-Id: If9097b0a2017a9c87a359b61ba93f35bae56b512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475935Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#817568}
-
Prakhar authored
Reference: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2472980 Bug: 1024915 Change-Id: I88fea2732cfca7f99c658beeb87c562de07518fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476694 Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#817567}
-
Claude van der Merwe authored
This CL adds a new Wifi Sync icon asset ands replaces the placeholder in the multidevice feature item. Screenshot: https://screenshot.googleplex.com/uPEbzfJ8UX2RKpw Bug: 1117619 Change-Id: I09095622fa95cfc29b521804a8de0049e2313a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472939 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#817566}
-
Chris Harrelson authored
In the presence of rare bugs, it is apparently possible to have a graphics layer but no LocalBorderBoxProperties. Bug: 1137883 Change-Id: I17d65c6ca04d15254efe9b2d13e3de905b59567e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474918 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817565}
-
Alex Gough authored
Bug: 1130762 Change-Id: Ied886fdf383eea4a8cdf733ae71996b7df6bd6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464147Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817564}
-
Russell Davis authored
See the updated test in FindBarPlatformHelperMacTest for repro steps. As part of the fix, this also cleans up some logic in FindTabHelper and FindBarView. Dealing with a find of an empty string (which causes the search to be cleared) no longer has to be special cased at each call site. Instead, the logic is handled in FindTabHelper::StartFinding where it belongs. That also removes a footgun where you might supply an empty string (from, e.g., a user) and end up unintentionally getting a no-op or a search of the previous string. The only places that relied on that behavior were a few tests, which now use a better way of doing that. Change-Id: Ide3260c3c4ce122d7e0ca9a1de521b84402bce4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465205 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817563}
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=reillyg@chromium.org Change-Id: I788d0ba88662c41a2bbe2f1feccd1558afe9cdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475034 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817562}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie8ff293834bcf956c9a73ca34a60909ccdf6ac36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817561}
-
Scott Violet authored
The fix for this landed in 88, not 87. BUG=1075744 TEST=test only change Change-Id: If1fd318cf5c6f151549dff042dd6c288a146870e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476914 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817560}
-
Jesse McKenna authored
This change removes histogram suffixes PageLoad.PaintTiming.NavigationToFirstContentfulPaint.OnBattery and PageLoad.PaintTiming.NavigationToFirstContentfulPaint.NotOnBattery, which allowed the filtering of FirstContentfulPaint measurements by whether the system was on battery or wall power during page load. This was used to filter FirstContentfulPaint regressions for battery-specific Finch experiment SlowDCTimerInterruptsWin, which is now on Stable. Because the experiment is finished and I'm not aware of any other users, this histogram can be removed. Change-Id: I78a6a2026596cb9aaa0783129ee3f4d8034fc039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468337Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#817559}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/ff267ca60e14..53380f9ed76f 2020-10-15 sarahmashay@google.com [validation] remove tests that have landed in cts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: enga@google.com Change-Id: I412da03b8f2af4c360d5a063fc53936c997a5e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817558}
-
Amin Hassani authored
Also mark other histograms in installer as obsolete as they have been replaced by UpdateEngine onces long time ago. BUG=None TEST=None Change-Id: Id5698e75d9f152f142f131b53ccaadc45ee899a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472595 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#817557}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: I160ad5d61ad05f5e95f63188c40f9084b6e816e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369659 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#817556}
-
Viktor Semeniuk authored
This change adds Password Edit feature to testing config. Bug: 377410 Change-Id: I9a950611f1462d43b8c6770f90b2f62da53b297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474875Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#817555}
-
Xiqi Ruan authored
Records the Chrome browser usage time of Chrome OS users to UMA at the beginning of the first session on the next day. It helps us understand users' usage on Chrome OS and improve family users' experience. Metrics from abnormally terminated sessions will be skipped. Bug: 1114849 Change-Id: Ia2d51161937492cea034c75aa98b077b56445af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410619 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817554}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6b4ce00..029d567d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2cd171a1ac824d2b5e1864de8b5a1d5832a38fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475307Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817553}
-
Xiqi Ruan authored
The feature launched more than half a year ago, so it's a high time to cleanup. Also removed code in other files that is related to this feature flag. Bug: 1120085 Change-Id: Ia64376339f6aebbf20b7d494cda4e6d26a7785a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469234 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817552}
-
Gayane Petrosyan authored
Bug: 1129652 Change-Id: Ice49fcc2ec98f3a975f2ae5dfd113af98ba2ef5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472262Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#817551}
-
Sophey Dong authored
Bug: 1138750 Change-Id: I0cf69bfad56ed24704d0e2e02050537c2fbea73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473804Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#817550}
-
Dominik Röttsches authored
Change-Id: I541eca7671cc2904e71b3ab959058cc5881c52dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476153 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817549}
-
Maggie Chen authored
GPU.WatchdogThread.ExtraThreadTime GPU.WatchdogThread.ExtraThreadTime.Init GPU.WatchdogThread.ExtraThreadTime.PowerResume GPU.WatchdogThread.ExtraThreadTime.Normal GPU.WatchdogThread.ExtraThreadTime.Foregrounded GPU.WatchdogThread.ExtraThreadTime.NumOfUsers GPU.WatchdogThread.WaitTime GPU.WatchdogThread.WaitTime.Foregrounded GPU.WatchdogThread.WaitTime.Normal GPU.WatchdogThread.WaitTime.PowerResume GPU.WatchdogThread.WaitTime.Init GPU.WatchdogThread.WaitTime.NumOfUsers GPU.WatchdogThread.WaitTime.ProgressAfterWait Bug: 1138404, 1138386 Change-Id: Ic84509ea6ec13acf0d54dc874d7738eb3d015ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473431 Auto-Submit: Maggie Chen <magchen@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#817548}
-
Toni Barzic authored
BUG=1137452 Change-Id: Ifb3caf122cb8a0600b2ee5b7a61ed4596a9b91ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472609Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#817547}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd09d6e2ef11..41fc174d7967 2020-10-15 robertphillips@google.com Restore cpu execution of async* GMs 2020-10-15 fmalita@chromium.org [svg] Relocate out of experimental If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I382f4bae0b490605b93dabea700c1299e8759ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817546}
-
Muhammad Hasan Khan authored
In this change we're adding a test that simulates the same condition that was addressed in https://crrev.com/c/2389060 i.e. we ensure that ArcInstanceStopped is not called on new instances of arc_vm_client_adapter if they're created during handling of ArcInstanceStopped event. BUG=b:164816080 TEST=components_unittests --gtest_filter='ArcVmClientAdapterTest*' TEST=revert the fix and ensure that the test fails Change-Id: Icd90da53f832d13893f20bb017fdc793e14af628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469813Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#817545}
-
Peter Boström authored
Replaces BubbleDialogDelegate::SetFixedWidth with DialogDelegate::set_fixed_width(). Removes ClientView::set_fixed_width in favor of fetching the values directly from DialogClientView::CalculatePreferredSize which is where the DialogDelegate margins are also fetched. This is done so that set_fixed_width() can be used for non-bubbles to remove additional CalculatePreferredSize calls where the end result is expected to be a fixed width. Bug: 1128500 Change-Id: I8164b2348d5945ffc5b3985120e2102e62b0f066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472910Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#817544}
-
Jeremy Roman authored
This reverts commit 9b1cb285. Reason for revert: Appears to break linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41980 In particular, the test says this: #if defined(OS_LINUX) && defined(OS_CHROMEOS) // QueryOutputProtectionStatus() is known to fail on Linux Chrome OS builds. std::string expected_title = kEmeUnitTestFailure; #else std::string expected_title = kUnitTestSuccess; #endif The condition becomes impossible after this CL. It's not obvious to me whether defined(OS_CHROMEOS) is the right fix here, because the comment specifically refers to Linux Chrome OS. Hence reverting so that this can be sorted out with media folks before relanding. Original change's description: > Undefine OS_LINUX for Chrome OS. > > Bug: 1110266 > Test: Built and took diff of the executable via objdump. > Change-Id: I80832fb472e6cc78d1e967f6216b1c33cc79ba73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475013 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817475} TBR=thakis@chromium.org,hidehiko@chromium.org Change-Id: I42d0ff74a7f640edd2b9d986628329dcff6c5d4e No-Presubmit: true Bug: 1110266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477033Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817543}
-
Min Qin authored
And also fixes some of the exiting arms BUG=1096224 Change-Id: Ibbc50ea023d9f6dc426e1ec6c001e613b5fedf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469458Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817542}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7b30cd95fed..acbaac2aa7cd 2020-10-15 bmgordon@chromium.org cros_sdk: Add explicit --use-image option 2020-10-14 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I33708b5cdea802e6d7cb9084d58ffe4222b8e6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817541}
-
Alex Gough authored
This is only read from: https://source.chromium.org/chromium/chromium/src/+/master:components/web_package/web_bundle_parser_factory.cc;drc=0e22286ee95d2bd711f81d73f1178343fbacc890;l=29 Bug: 1130762 Change-Id: I1859ab3cf91f8131190883479735fd1ca9acb608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464205Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817540}
-
Morten Stenshorne authored
No code changes required. Bug: 294205 Change-Id: I39a0bc14e444a9bbff70f57a9866acda8a9c0c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472040Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#817539}
-
Ben Pastene authored
The filter file exists on both branches: https://chromium.googlesource.com/chromium/src/+/refs/branch-heads/4240/testing/buildbot/filters/chromeos.ozone_unittests.filter https://chromium.googlesource.com/chromium/src/+/refs/branch-heads/4280/testing/buildbot/filters/chromeos.ozone_unittests.filter So just needs the cmd-line arg specified. Bug: 968349 Change-Id: Idf88d88e11f1bf03ab6d93e354c14844b1b43482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472208Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817538}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ad2ec763873b..a39689cc986e 2020-10-15 hta@webrtc.org Separate PC resources required at runtime from PCfactory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I62bbfc9b8099b491fe8bb4572e76e85a124a20cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475009Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817537}
-