Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 04 Oct, 2018 3 commits
    • Thomas Guilbert's avatar
      Cleanup on RemotePlayback stop · 491305e0
      Thomas Guilbert authored 
      Currently, successfully starting/stopping/starting RemotePlayback runs
into a DCHECK, because we never properly clean up on RemotePlayback
stop. This CL fixes the issue and gets rid of a TODO.

Bug: 790766
Change-Id: Ieca32cd175741e5c1ae7e55879ae4a224d67b76c
Reviewed-on: https://chromium-review.googlesource.com/c/1260282Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596435}
      491305e0
    • Devlin Cronin's avatar
      [Extensions Cleanup] Constify ExtensionBuiler::Build() · 8e5892fb
      Devlin Cronin authored 
      In practice, Extension objects are pretty much always const. Update
ExtensionBuilder::Build() to return a const Extension object, rather
than a mutable one.

TBR=tapted@chromium.org (c/b/apps, c/b/ui, c/b/web_applications)
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/notifications)
TBR=dalecurtis@chromium.org (c/b/media)
TBR=holte@chromium.org (c/b/metrics)
TBR=vakh@chromium.org (c/b/safe_browsing)
TBR=treib@chromium.org (c/b/supervised_user)
TBR=raymes@chromium.org (c/c/pepper_permission_util_unittest.cc)

Bug: 889925
Change-Id: I7da674b29e209540803acfd40576c7daba3da2a3
Reviewed-on: https://chromium-review.googlesource.com/c/1256167
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596434}
      8e5892fb
    • Jun Choi's avatar
      Add preference to store address of paired FIDO BLE device · a457f5ca
      Jun Choi authored 
      WebAuthN BLE UI flow should guide the user through pairing UX if no FIDO
BLE devices have been paired with the system previously. If there is at
least one FIDO BLE device that is paired beforehand, we should default
to "activate BLE security key" flow. As so, implement logic to store
address of BLE security keys.

Bug: 877344
Change-Id: I5d376311fc2dc4b73ceab0ed43ef5b8fbd0ffdbc
Reviewed-on: https://chromium-review.googlesource.com/c/1253065
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596433}
      a457f5ca
  3. 03 Oct, 2018 37 commits