- 09 Apr, 2018 40 commits
-
-
Vasilii Sukhanov authored
TBR=hbos@chromium.org Bug: 829401 Change-Id: I112346b87535c6f78303da8e7b7ece905f4d6b0f Reviewed-on: https://chromium-review.googlesource.com/1001900Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549169}
-
Christian Dullweber authored
The change to allow non-secure cookies if https is allowed from https://crrev.com/c/926369/5/components/content_settings/core/browser/cookie_settings.cc still needs to be applied to properly match cookies for www.example.com against a rule like https://[*.]example.com. Bug: 775080 Change-Id: I50f5b28663e816016e0d047b5dbceb16352667aa Reviewed-on: https://chromium-review.googlesource.com/1002554Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#549168}
-
Fredrik Söderquist authored
Change-Id: I07129786b29acb7eea5fd1946e9301a370472125 Reviewed-on: https://chromium-review.googlesource.com/1002556Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#549167}
-
Eric Seckler authored
Testing basic canvas + svg support. Bug: 787197 Change-Id: I854a841da46123aafc4828c3de3ff2f10c819859 Reviewed-on: https://chromium-review.googlesource.com/985986 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#549166}
-
Guido Urdaneta authored
Thanks to recent changes in audio device enumerations, it is possible that USB audio devices report their vid/pid in enumeration results similarly to video input devices. This CL extends the heuristic to guess associations between video and audio devices by looking at coincidences in the VID/PID, if available. Also, this CL excludes the default and communications device entries from the heuristics since they could be incorrectly detected as duplicates. Bug: 627793 Change-Id: I870a033c1dff358025c5da7332ac90004f1d7f5a Reviewed-on: https://chromium-review.googlesource.com/992292 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#549165}
-
Gauthier Ambard authored
This CL fixes the callback of thedismissal of the popup menu. It was failing because the DCHECK assertion was wrong, as the presenter is reset at the begining of the dismissal. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idb6e487c111521220c63e03738c69da24962bce1 Reviewed-on: https://chromium-review.googlesource.com/1000775Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#549164}
-
Vasilii Sukhanov authored
TBR=junov@chromium.org Bug: 816045 Change-Id: Ie637acc5cdc50aab55882969b1489c0965f9eac3 Reviewed-on: https://chromium-review.googlesource.com/1001895Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549163}
-
Lutz Justen authored
The destructor calls g_browser_process->IsShuttingDown(), but that's not hit in certain situations (see bug). Adding an additional check for browser_shutdown::IsTryingToQuit() solves this (see bug comment #9). BUG=chromium:823738 TEST=Enrolled with Chromad domain, which triggers a restart after enrollment, and it didn't crash. Change-Id: Ifc4430012da40ec729d8337a0c7b3be2f44eafb2 Reviewed-on: https://chromium-review.googlesource.com/980852Reviewed-by:Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#549162}
-
Mark Cogan authored
This CL makes the GridConsumer protocol not depend on the state of the items list that it reports changes for. To do this, it only uses list indexes as parameters for destinations (of insertions or moves). In all other cases, the mutations specified by the protocol are expressed in terms of the IDs of the items that are changed, including the selected item. GridViewController now keeps track of the ID of the selected item, and determines (finds) its index dynamically. Bug: 986379 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id2465c9740e505be659126068bc2c0e0cbf8a8d3 Reviewed-on: https://chromium-review.googlesource.com/999712 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549161}
-
Kenichi Ishibashi authored
It sometimes crashed before but it seems it's no longer flaky. I ran the tests under external/wpt/service-workers/service-worker 10 times each but I couldn't observe crashes (with dcheck_always_on = true). $ run-webkit-tests --release --iterations=10 --additional-driver-flag=--enable-features=NetworkService external/wpt/service-workers/service-worker/ Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I019c942b6caf98223205b9b66cea0ba926838a4e Reviewed-on: https://chromium-review.googlesource.com/1002792Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549160}
-
Oskar Sundbom authored
Before a stream has been added to an <audio> tag, its gain is set to 1.0. Once a stream gets attached to an <audio> tag, its volume is set to zero until the tag starts playing. Since remote streams are mixed in WebRTC before being passed on to Chrome, streams that haven't been added to a tag can still be audible, if only one other stream has. This CL attempts to fix this by setting the initial gain of WebRTC remote streams to 0. Bug: chromium:810848 Change-Id: I08b0acbd78d3f0bd06adbb70f62d42b66146a9f5 Reviewed-on: https://chromium-review.googlesource.com/925266 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#549159}
-
stkhapugin@chromium.org authored
Adds a new flag for the new location bar. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaf34e9fcfb05d01ee26a213428633d96d4bb3cbd Reviewed-on: https://chromium-review.googlesource.com/1000454Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549158}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80bcf1b0..f0600b8c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6af49b665a91b45db5dd6e6c2afd1b99a1e17782 Reviewed-on: https://chromium-review.googlesource.com/1001700Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549157}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. As the first step, this CL renames kUnspecedLoading to kInternalLoading simply as the current kUnspecedLoading usages are related to loading. Bug: 830489 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I674ca3b5842502a376731de921629f6f79dcd225 Reviewed-on: https://chromium-review.googlesource.com/1002719Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549156}
-
David Roger authored
Before this CL, the only way to remove a secondary account from Chrome is to do a signout on the web. However, this requires being signed-in, which is not always possible, and results in accounts that are impossible to remove. This changes automatically removes the secondary accounts from Chrome when they are not logged in, as part of account reconciliation. Bug: 820073 Change-Id: I01961df9a960e75950afea812db8cab6dd131e80 Reviewed-on: https://chromium-review.googlesource.com/995532 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#549155}
-
Fredrik Söderquist authored
Since <text> can have descendants that may both differ in visibility as well as fill/stroke, we can't evaluate pointer-events in LayoutSVGText, but should rather let LayoutBlock (and SVGInlineTextBox et al) handle the hit query. This makes LayoutSVGText somewhat similar to the same method on LayoutSVGContainer. Bug: 828930 Change-Id: I2767ed149705289e770d5ae165efd910c2c7ff15 Reviewed-on: https://chromium-review.googlesource.com/998352 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549154}
-
Kent Tamura authored
Now we use Chromium-style include guard even in Blink. Update check-webkit-style so that it doesn't accept WebKit-style include guard. Bug: 768828 Change-Id: Iea94b1857fc735fc8767b86c56156110ad6c2364 Reviewed-on: https://chromium-review.googlesource.com/1002344 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549153}
-
Hans Wennborg authored
In 329493, Clang's -Wself-assign warning started also firing on overloaded assignment operators. The suggested way to suppress it is to use *& on the right-hand side. This fixes the instances that fire during a debug build on Linux. TBR=jochen Bug: 830338 Change-Id: I5198ff8171462b78d55b84f58358588caf3f7fa2 Reviewed-on: https://chromium-review.googlesource.com/1000856 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549152}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: I359671de2e2081338c6d838c193ecc3a8092490b Reviewed-on: https://chromium-review.googlesource.com/1002720Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549151}
-
Mattias Nissler authored
Make sure the download directory is within a legit location. Switch a couple unit tests that used a random download location to use an override for the default download directory instead. BUG=chromium:818138 TEST=Unit tests Change-Id: I6edd0c82891be3d05b0009dc4eb5a393d0f1cad6 Reviewed-on: https://chromium-review.googlesource.com/948852 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549150}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: I7b417e79ba205dc15a83f7ab768f1f47c1840221 Reviewed-on: https://chromium-review.googlesource.com/1002553 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549149}
-
Takashi Toyoshima authored
To make changes following to support OOR-CORS understandable, join split CORS code paths again. DocumentThreadableLoader still has |out_of_blink_cors_| flag to switch behaviors. At this point, it differentiates response handling since CORS checks in OOR-CORS mode are always performed in Network Service side. This patch should not change any behavior in both CORS modes. Bug: 803766 Change-Id: Iffd4e56be95df0ce70afb94a2bfe8ca77001f684 Reviewed-on: https://chromium-review.googlesource.com/999460 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#549148}
-
https://chromium.googlesource.com/angle/angle.git/+log/6816d84382d5..6c59e4a156c3 $ git log 6816d8438..6c59e4a15 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 pwnall Migrate from <tr1/tuple> to <tuple> types. Created with: roll-dep src/third_party/angle BUG=chromium:829773 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I00cb193a7ef81f6800d8f1f2c879716e62546bb3 Reviewed-on: https://chromium-review.googlesource.com/1002632Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549147}
-
Eduardo Cordeiro authored
Bug: b/77234786 Change-Id: Ieb06e82dfa9fc2a5affce9299c84db75d5b4acbb Reviewed-on: https://chromium-review.googlesource.com/999798Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Eduardo Cordeiro <escordeiro@chromium.org> Cr-Commit-Position: refs/heads/master@{#549146}
-
Benoit Lize authored
Adds a UMA histogram for parallel requests. Records whether the feature was requested, and whether the request started. In case of failure, records the reason. Bug: 816837 Change-Id: I9e32abc609bed426113a28b7701d1462466e77b0 Reviewed-on: https://chromium-review.googlesource.com/993052 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549145}
-
Lei Zhang authored
This refcounted class was not being held in a scoped_refptr. BUG=260806 Change-Id: Ie32550f28ed220b76d2e9498204a050b4e0763d9 Reviewed-on: https://chromium-review.googlesource.com/987117 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549144}
-
Vasilii Sukhanov authored
The case when there was no omnibox wasn't handled properly. The bubble should be top-center aligned with the window. Bug: 821347 Change-Id: I6af3395da3cbf6f399625c4020015941c5e0b092 Reviewed-on: https://chromium-review.googlesource.com/998163Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549143}
-
Thomas Tangl authored
When Dice is enabled and the profile is in an auth error state, the user menu displays a "sync paused" UI. Additionally, the avatar button contains a sync-paused icon instead of an error icon. Screenshot: https://drive.google.com/file/d/1JwI9-MxoiMoSCYTJoHNBkz877lnwu75r/view?usp=sharing Bug: 825533 Change-Id: I36760bedd2eb1f2e9875b570a3d90b3bfae8476a Reviewed-on: https://chromium-review.googlesource.com/998112Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#549142}
-
Dominic Battre authored
This CL introduces low entropy hashes of password form signatures and URLs. This allows us to distinguish different forms on a page as well as different pages for which we cannot record the full URL in UKM. Bug: 732846 Change-Id: Ie98ef254286890310f6b6b5a2e3026260b65b676 Reviewed-on: https://chromium-review.googlesource.com/977904Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#549141}
-
Alexandre Courbot authored
linked_ptr is deprecated. Convert it to the more suitable unique_ptr. BUG=None TEST=Checked that VDA unittest was still passing on hana. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iedb039ab308416d6903974ce56eb8caba110bc43 Reviewed-on: https://chromium-review.googlesource.com/994852 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549140}
-
Noel Gordon authored
According to the flakiness dashboard, this test works in release mode, and on the much slower ASAN and MSAN bots. Re-enable on the debug bots to gather new data about issue 804364 and related. Bug: 804413, 804364 Change-Id: Ifc3f1f383ca8b4b385ec65412e070748047683da Reviewed-on: https://chromium-review.googlesource.com/1002345Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549139}
-
Quentin Fiard authored
rather than where it is used. This is a preliminary cleanup for go/chrome-no-searchdomaincheck. Bug: 825255 Change-Id: I6e56d45f0edf4a1850965dabe99972098ed8235f Reviewed-on: https://chromium-review.googlesource.com/999517 Commit-Queue: Quentin Fiard <qfiard@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#549138}
-
Bernhard Bauer authored
Bug: 814365 Change-Id: Idc8ec39f4b01d2aa28bee87ad6f24d40b7784614 Reviewed-on: https://chromium-review.googlesource.com/983952 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549137}
-
Florian Uunk authored
This tracker reports the time that the user spent actively using chrome, with their associated sync and sign-in state. Definition of syncing: Having opted in to sync, and sync not being in an "error" state because of a content-area sign-out. Definition of signed in: The user is signed in to the content area. These metrics will let us track: - How long on average users spend being signed in to the content area - How long users on average spend syncing - Which proportion of a user's time is being spent signed in - Which proportion of a user's time is being spent syncing Bug: 820188 Change-Id: I7c5c965d8ba0debf970158f77ae5b69675bdee27 Reviewed-on: https://chromium-review.googlesource.com/960005 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#549136}
-
Zhuoyu Qian authored
This change adds an overloaded GetSelectionTextFromBody() function in EditingTestBase. It returns text of Selection().GetSelectionInDOMTree(). This can simplify the test code and improve code health. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I5548e4f168176a0e9921d2c4798fdf9126661b75 Reviewed-on: https://chromium-review.googlesource.com/1000655Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549135}
-
Tatsuhisa Yamaguchi authored
A file passed to Zip Archiver for packing may be removed before starting to zip it. It happens, for example, when multiple fils are passed to Zip Archiver and user removed the file while preceding files are processed. Bug: 830317 Test: Manually tested by the repro steps in the bug. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4c8682ddf21abc7e11c0e9e7d427890b7093c233 Reviewed-on: https://chromium-review.googlesource.com/1002434 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#549134}
-
Daniel Bratell authored
There were two GetExtensionView functions which clashed in jumbo build experiments where they ended up in the same translation unit. This patch makes them member functions which removes the need to supply an argument, which in turn makes the code a bit simpler and easier to read. Bug: 803406 Change-Id: I09fad295de900d6d78092397654314e757761226 Reviewed-on: https://chromium-review.googlesource.com/997774Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#549133}
-
Leszek Swirski authored
Ensure that a resource fetched by a service worker has a non-null source origin before creating its CachedMetadataSender -- otherwise, use the null sender. Bug: chromium:828838 Change-Id: Ice176848b6cdb9c288df9294dcee9e2d55026359 Reviewed-on: https://chromium-review.googlesource.com/999655 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#549132}
-
Lei Zhang authored
Modernize code as well. BUG=714018 Change-Id: I7dd5330e094c190328ea9c6dd9faa042510962e5 Reviewed-on: https://chromium-review.googlesource.com/1001032Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#549131}
-
Ramin Halavati authored
Network traffic annotation in ProxyResolutionService was wrongly set in cases where proxy info was fetched through completely synchronous method, causing flaky test failures. The bug is fixed and tests are re-enabled. Bug: 822975 Bug: 826744 Bug: 823077 Change-Id: Ic63301ff053fc9160b1a96372af1ee289342396c Reviewed-on: https://chromium-review.googlesource.com/997656Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#549130}
-