GitLab

Won't really do anything until we get macOS 11.0 bots, but this is
a requisite step for enabling on the beta channel.

Bug: 1103432
Change-Id: Ia9feafd622ce2f55c0c4905789a45c69e1e5d80a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382220
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803320}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I3b56ca4ea0a4d4dac8bdae935a3eb114457f37a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382598Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803319}

Before this CL, histograms could incorrectly report an "OK" request
response code if a manifest fetch failed, but for a reason other
than HTTP_RESPONSE_CODE_FAILURE. This data should not be
reported in the histogram for HTTP response codes as we actually faced
some network error. We report these error code in case of
MANIFEST_FETCH_FAILED error and CRX_FETCH_FAILED error.

The following histograms are used for reporting HTTP response codes:
Extensions.ForceInstalledManifestFetchFailedHttpErrorCode
Extensions.ForceInstalledHttpErrorCode

This is a small fix in the way the metrics are gathered, so we do
not need to remove the old histograms.

Bug: 1120310
Change-Id: Icdabe5f225cae0cd40341630a1bc1c4c3f85aef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368592Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#803318}

This CL adds the following histograms and user actions for the profile
picker:

Histograms:
- ProfilePicker.UiVisited

User actions:
- ProfilePicker_AddClicked
- ProfilePicker_RemoveOptionClicked
- ProfilePicker_ThreeDottedMenuClicked

Fixed: 1123040
Change-Id: I565df25b446073d4938c03e5d108b4598e411988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379719
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803317}

SetContentsView() has a new API to accept a unique_ptr, which makes the
ownership clearer. Convert most of the rest of cases to use the new API.

Bug: none
Change-Id: I6078074260e6584cc97a0e7dc625feeff4fd7f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382207Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803316}

Update some missing strings, CSS, and fileManagerPrivate API.

Bug: 1111393
Change-Id: I2cfcf722fa0982899b89b404a8eb030255251e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374188Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803315}

Remove the unnecessary brackets.

TBR=jamescook@chromium.org

Bug: 938501
Change-Id: I30b90d411d9686e9ebd883cbcfa4e864d4af0485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380140Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803314}

This CL follows up on crrev.com/c/2358509 to add the command-line flag
to startup.mobile benchmarks.

Bug: 1122611
Change-Id: I3dacb532da3a11a98209dff1d8ecdb13cdecfb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386538Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#803313}

Holding space keyed service retrieves download history from the download
manager after it is initialized.

Any completed downloads are added to the model. The holding space keyed
service will observe in progress downloads and add them to model when
completed.

Bug: 1111995
Change-Id: Ib4cd9426f58b8f255441d22758a5616a0169de83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385779
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#803312}

When a reference space's origin is reset, an event is dispatched to the
page. This allows additional javascript to run, which could request a
new reference space. Depending on the timing of this new reference space
request returning, it would cause the reference_spaces_ list to be
modified, and thus invalidate the iterators.

Fix this by iterating over a copy of the list.

Fixed: 1123522
Change-Id: I121a5fa3dde1cfc18abbef579148a2ace86f73f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385885
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803311}

This CL removes BaseBrowserTaskExecutor::GetCurrentThreadID() and its
overrides, which are no longer used.

Bug: N/A
Change-Id: I913eb7e01ecf50693e8281f3bb216d006e5a21f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386655
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803310}

Bug: 1100412
Change-Id: I24d1480408f0d72e19335b9936b85d05f0a4e223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385758Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803309}

Remove command-line flags --websocket-read-buffer-size and
--websocket-renderer-receive-quota-max which are no longer needed as the
performance investigation has finished.

Also replace the kReceiveQuotaThreshold constant in websocket_channel.cc
with a kReceiveDataPipeCapacity constant in websocket.cc, which better
reflects its current usage.

Change the types of kReadBufferSize and kReceiveDataPipeCapacity to
reflect the types at the points where they are used.

Also mark WebSocketBasicStream as final, as its destructor calls the
Close() virtual method and it would not behave correctly in a subclass.

Also change some constants from "const" to "constexpr".

BUG=865001

Change-Id: I761bd08de534ef27a77a9523c86ea6f1a61b9266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383396Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803308}

Rename the `label` attribute to `summary` for variant tag as it's more
intuitive. We've already used `variants` as both an attribute (in the
token) and a tag (the <variants> tag) so it should be fine.

Bug: 758782
Change-Id: Iea19b3ee0e3736a013edfece8d05debc2a01b37a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380889
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803307}

This reverts commit 3bd3ee29.

Reason for revert: Suspecting as culprit of crbug.com/1123736

Original change's description:
> Add public side implementation of "frameless" module
> 
> Using the frame on the NTP to load the data is too
> slow for what we want to do so this removes the frame
> and does the fetching in C++ instead. The deserialization
> and business logic is still handled by the JS but on
> the NTP instead of in a child frame.
> 
> BUG=1121360
> 
> Change-Id: Idad8c9403fd51cccaf4a8edff31d244ac2642432
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373384
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803181}

TBR=dcheng@chromium.org,msramek@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: I1e43e53436a55f00d9e071fd30a649a3d4d6d7df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1121360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386936Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803306}

Change-Id: I2eff6643d4a9e1c1faace2d1bd4babb8b475ec24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363949
Commit-Queue: Mehrdad Hessar <mehrdadh@google.com>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803305}

This CL allows the internal code to set the page-name attribute on the
CrToolbarElement.

Bug: b:166811061
Change-Id: Ibe209f080b08f3426d9c9ff33ace7206e147cc75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386279
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Auto-Submit: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803304}

TBR=benmason@chromium.org

Change-Id: I1437e3f5ec9225981aaa10cf1661e15aab27dab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386341Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803303}

Logic was added to select the right package, based on packages available
within the distro, but the final dev list assignment overwrote what was
selected based on distro.  This results in a breakage for Ubuntu based
builders that still utilize the older package.

Bug: 1122846
Test: './install-build-deps on Ubuntu'
Change-Id: Ia96d29c2b2767bb3a22b002cfba97a9525d246e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386659
Commit-Queue: Mike Nichols <mikenichols@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803302}

GetGamepad will soon require Secure Context and Permission Policy. This
CL adds a warning to developers to update applications accordingly.

Bug: 1099544
Change-Id: I548f31104aa1e5d9fd2984c49556a49c7098ca98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382217
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803301}

Introduce a new class which updates overview widgets with the ideal
a11y next and previous widgets. Still need some a11y related work but
this is a start.

Test: manual, added test
Bug: 853589
Change-Id: I239cb6d7a9649068dd13af0c745a651a31c889dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382713
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803300}

https://skia.googlesource.com/skia.git/+log/39616ec7c974..3913d3e137ed

2020-08-31 jvanverth@google.com Set Metal semantics for SkSL point size.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: Ifab7accd13c3cac22c81dfa7cf67d737cfe7758c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803299}

This is a reland of 76c5ef2b

Fixed assistant_device_settings_delegate_unittest

Original change's description:
> [Switch Access] Move code out from behind flag
>
> AX-Relnotes: Launch Switch Access on Chrome OS.
> Bug: 1016200,1121357
> Change-Id: I464abbeaeb50c8c40adbac4ce51d7d9f038430fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373368
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#801947}

Bug: 1016200
Bug: 1121357
Change-Id: I9174e5c60d4cf05086b4fe90af3dcb24f313f57a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381910
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803298}

These have been failing consistently on all CrOS bots for a few days.
This disables them while crbug.com/1123300 works on a fix.

Bug: 1123300
Change-Id: I3694b6a36b083649e9b498c4db4e6bbf5ab28125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386599
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803297}

With the changes to make the window cycle list more interactive, the
window cycle event filter checks whether mouse events occur within the
window cycle view. However, if the cycle view does not exist, it will
crash.

This CL makes it so IsEventInCycleView() returns false if the cycle
view does not exist.

      MouseEventWhenCycleViewDoesNotExist

Test: InteractiveWindowCycleControllerTest.
Bug: 1067327
Change-Id: I9eae1f60c2a58e5c5e8b3eba751f003249358a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380551
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803296}

Enables threaded compositing and cross-origin iframe layerization to allow WPTs to pass.

Bug: 910421
Change-Id: Id79d93eb23c36181c0091a7ee8b4164387ea9308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380813Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#803295}

Same-document navigations (such as history.pushState() calls) cause
associated DidStartNavigation() and DidFinishNavigation()
calls. However, since this isn't considered a load,
DocumentOnLoadCompletedInMainFrame() is sensibly not called.

ThumbnailReadinessTracker assumed DidStartNavigation eventually lead
to a DocumentOnLoadCompletedInMainFrame call (or an error). This meant
that pages using history.pushState(), such as YouTube, had
never-ending thumbnail capture.

This CL fixes the never-ending capture.

Bug: 1120940
Change-Id: Ia298d384b44bcc2b860260826952898972daf480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382426Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803294}

Bug: b/1105579
Change-Id: I4386bf3189ad395921086a2f876d79adfd8e6224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366154
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803293}

pkl@ left the team. eugenebut@ is familiar with this metric.

Bug: None
Change-Id: I729cc98e1db0b4974bcfbf5c12fa2149546fc2bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381071
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803292}

Will always try to check for LUCI_CONTEXT to have a sink and upload if
it does.

Bug: 1104238
Change-Id: I37d7de2a6e9ea72d43b5ef17874b11f2eca242cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382892
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803291}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c37d40bb531..473462adb6b1

2020-08-31 ddoman@chromium.org [resultdb] move the cipd pin of infra/tools/rdb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1121678
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I51b681d8af7a00bfb0f5b94878b46a189f4ca005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386255Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803290}

WrapPositionVector was not wrapping the position around when it equaled
the end of the buffer.  This caused an extra zero value to be output
in this case.

Examination of WrapIndexVector also indicates a related logic error
because there's no >= intrinsic, so we used < but got the logic wrong.

The NEON version appears to be correct, so just added additional
comments to match the SSE2 version.

Added one test to make sure the delay is correct (based on the bug
report).

Bug: 1123023
Test: the-delaynode-interface/delay-test.html
Change-Id: Ibcb09573c53d62e926a332307d07601110b91aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382656Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803289}

In cros, if a user swipes upward with three fingers on their touchpad
it opens overview mode.

As an ongoing effort to improve the interactivity of the window cycle
list, this CL makes it so the aforementioned gesture closes the window
cycle list if it is open.

Test: InteractiveWindowCycleListGestureHandlerTest.VerticalScroll
Bug: 1067327
Change-Id: Ic8ea6f9d39b0df065c836fc9155aaa6b77446f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382330
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803288}

https://chromium.googlesource.com/angle/angle.git/+log/7b5439987f75..e1e6f2940c25

2020-08-31 sugoi@google.com Make copyTexImage2D robust when source area is out of bounds
2020-08-31 tobine@google.com Vulkan: Add transient flag to command pool
2020-08-31 cwallez@chromium.org Suppress flaky failure on Win Intel OpenGL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: Ia1fb1ed9fceb3eefc0404eb7b33c5369490abeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386080Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803287}

This method was just introduced in a recent uprev.

Change-Id: I00b853c2f1f6540a7e84f487ee44ba5125678ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382677Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803286}

Android 11 by default restricts package status queries:
https://developer.android.com/preview/privacy/package-visibility

Add explicit <queries> entries to declare this dependency.

Bug: 1122210
Change-Id: I51c9457b85031c089da40854d10a1ad3b4abe918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378735
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803285}

ModalDialogManager.dismissDialog() may call onLastDialogDismissed()
even if nothing was hidden. BrowserViewController was assuming this
never happened. This matters on
BrowserViewController.onLastDialogDismissed() assumed mTab was non-null.
The fix is to add a null check to BrowserViewController.

BUG=1121388
TEST=covered by test

Change-Id: I2c806018a635d9434bf10c653b2615ea645b8e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382880
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803284}

Test for encryption failure now also moved to storage_unittest and
storage_queue_unittest.

Also, record digest has been removed from report_queue and not added
to Storage yet: will do it later.

Bug: b:153649905
Change-Id: Iaa75c86b76a1accaf1fe2b8d6aba71d109c42f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385783
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#803283}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I9183ee204a4e775c25f1e4a5d60628b4e8adb794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383013Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803282}

Record user actions on the password check view, as well as where the
password check view was opened from.

Bug: 1123019
Change-Id: I7004dedade8d85c3490580476ff2721a82f7057f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379902
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803281}