GitLab

BUG=446638

Review URL: https://codereview.chromium.org/824073005

Cr-Commit-Position: refs/heads/master@{#310198}

BUG=446312
NOTRY=true

Review URL: https://codereview.chromium.org/838633002

Cr-Commit-Position: refs/heads/master@{#310197}

All the places that use this function are checking whether there are any app
windows from the point of view of the user.

BUG=442280

Review URL: https://codereview.chromium.org/800473006

Cr-Commit-Position: refs/heads/master@{#310196}

"Report a bug" -> "Report a content bug"
Cleanup of old CSS

BUG=

Review URL: https://codereview.chromium.org/836833002

Cr-Commit-Position: refs/heads/master@{#310195}

BUG=446695
TBR=benjhayden@chromium.org

Review URL: https://codereview.chromium.org/838703002

Cr-Commit-Position: refs/heads/master@{#310194}

This change originally landed in crrev.com/577273003, but was reverted
in crrev.com/750093009 due to poor scrolling performance during
browser-composited animations. The issue has since been resolved, so
reland the change with some minor refactoring.

BUG=437603, 437932

Review URL: https://codereview.chromium.org/833283003

Cr-Commit-Position: refs/heads/master@{#310193}

R=mkearney@chromium.org

Review URL: https://codereview.chromium.org/721033003

Cr-Commit-Position: refs/heads/master@{#310192}

Previously, insecure CSP directive values caused refusal of Chrome to
load the Chrome extension. Now, insecure values are stripped from the
CSP, and a list of detailed warnings is printed at the extensions page.

Renamed ContentSecurityPolicyIsSecure to SanitizeContentSecurityPolicy
and let it return a string (the sanitized CSP) instead of a boolean
that tells whether the CSP was considered secure.

BUG=434773
R=kalman@chromium.org
R=mkwst@chromium.org
TEST=extensions_unittests=ExtensionCSPValidator.*
     unit_tests=ContentSecurityPolicyManifestTest.*:PlatformAppsManifestTest:PlatformAppContentSecurityPolicy

Review URL: https://codereview.chromium.org/747403002

Cr-Commit-Position: refs/heads/master@{#310191}

BUG=407966
TEST=covered by unit test.

Committed: https://crrev.com/deecdafa38a9effc737acde28e82a32cc527a1b5
Cr-Commit-Position: refs/heads/master@{#309272}

Review URL: https://codereview.chromium.org/778283002

Cr-Commit-Position: refs/heads/master@{#310190}

Update import history code to support tracking locally copied files (and their destinations). Tracking destination is necessary as we'll eventually need to do lookups against destinations in order to mark items as imported when they are fully synced to the cloud.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/837563002

Cr-Commit-Position: refs/heads/master@{#310189}

This CL also introduces the web::PageLoadCompletionStatus enum.
This was done to support future WebStateObserver subclasses that
require notifications of failed page loads.

BUG=none

Review URL: https://codereview.chromium.org/835203002

Cr-Commit-Position: refs/heads/master@{#310188}

Popup windows don't have bookmark bars, so check for supportsBookmarkBar
before trying to position the sheet next to the bookmark bar.
Fix incorrect use of defaultSheetRect.size.height, it has no meaning according
to AppKit docs.

BUG=436959

Review URL: https://codereview.chromium.org/836173002

Cr-Commit-Position: refs/heads/master@{#310187}

Revert of Use Surfaces on Windows, Linux, and Mac OS (try #3) (patchset #1 id:1 of https://codereview.chromium.org/786243003/)

Reason for revert:
May be causing some browser_tests to flake:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34159
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34157
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34156
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34152
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34150
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34149

Original issue's description:
> Use Surfaces on Windows, Linux, and Mac OS (try #3)
>
> Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.
>
> BUG=334090
> TBR=piman@chromium.org
>
> Committed: https://crrev.com/7fa9d3f715573c22081f11238a4ccf44bc0efb19
> Cr-Commit-Position: refs/heads/master@{#309998}

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=334090

Review URL: https://codereview.chromium.org/840673002

Cr-Commit-Position: refs/heads/master@{#310186}

BUG=445307

Review URL: https://codereview.chromium.org/833263003

Cr-Commit-Position: refs/heads/master@{#310185}

The API was renamed a while ago, but the doc template was never
updated.

BUG=None
TBR=kalman@chromium.org
TBR=rkc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/829333005

Cr-Commit-Position: refs/heads/master@{#310184}

BUG=445396

Review URL: https://codereview.chromium.org/838553003

Cr-Commit-Position: refs/heads/master@{#310183}

The data reduction proxy is used only if the effective proxy
configuration resolves to DIRECT for the requested URL. This
works by allowing the ProxyService to choose an effective proxy
configuration and to decide on the prioritized list of proxies
to use for a URL given that configuration. Just before the list
is
used, the DataReductionProxyNetworkDelegate's OnResolveProxy()
method provides an opportunity to change that list, which it
does, only if that list begins with DIRECT.

BUG=429826,444169

Review URL: https://codereview.chromium.org/792803007

Cr-Commit-Position: refs/heads/master@{#310182}

The test is a private key for P-256, using PKCS8 as the input format. The private key is exactly equal to order (max valid private key is n-1).

BUG=445679

Review URL: https://codereview.chromium.org/838573003

Cr-Commit-Position: refs/heads/master@{#310181}

This allows menus to fully unwind after MenuController::CancelAll() is
called, without any additional events processed through the nested
dispatcher.

In particular, tests that cancel their menu cannot hang at the very end
of the test when there are no more events left to dispatch. Before, we
relied on some event - ANY event - getting through nested dispatch in
order to continue unwinding. This could cause hangs in test code when
there weren't any more events.

If a test calls MenuController::CancelAll() and then terminates its
outer RunLoop, the program should terminate. This change ensures that.

BUG=432576, 446335
TEST=interactive_ui_tests

Review URL: https://codereview.chromium.org/831413002

Cr-Commit-Position: refs/heads/master@{#310180}

They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE().

BUG=None
R=sadrul@chromium.org

Committed: https://crrev.com/f62e152bb7a13135a597d9766eb79551d3a24a73
Cr-Commit-Position: refs/heads/master@{#309252}

Review URL: https://codereview.chromium.org/801953002

Cr-Commit-Position: refs/heads/master@{#310179}

BUG=437116

Review URL: https://codereview.chromium.org/828063004

Cr-Commit-Position: refs/heads/master@{#310178}

BUG=

Review URL: https://codereview.chromium.org/843433002

Cr-Commit-Position: refs/heads/master@{#310177}

This icon size is needed for Mac. Now is consistent with icon sizes for
packaged apps.

BUG=445039

Review URL: https://codereview.chromium.org/836053002

Cr-Commit-Position: refs/heads/master@{#310176}

This CL
1. Relaxes the CursorShapeIsValid() check on ClientControlDispatcher
   to allow cursors with empty dimensions.
2. Modifies MouseCursorMonitorAura to sends an empty cursor when the
   cursor is ui::kCursorNone or when the cursor bitmap cannot be loaded.
3. Initializes the CursorShapeInfo with empty data on the VideoScheduler
   as it is a required field.

Review URL: https://codereview.chromium.org/833693002

Cr-Commit-Position: refs/heads/master@{#310175}

Chromecast platform has multiple binaries that each link in the data
file; this results in some wasted disk footprint.

R=lcwu@chromium.org,thakis@chromium.org
BUG=446387

Review URL: https://codereview.chromium.org/833183004

Cr-Commit-Position: refs/heads/master@{#310174}

Pulls in the following fixes:
b9d631d avformat/utils: Clear pointer in ff_alloc_extradata() to avoid leaving a stale pointer in memory
7575fa1 avfilter/buffer: use av_freep() to avoid leaving stale pointers in memory
0aa6981 avformat/matroskadec: Use av_freep() to avoid leaving stale pointers in memory
e860c4c avformat/mov: use av_freep() to avoid leaving stale pointers in memory
c61fcd2 avformat/mov: Clear array to prevent potential out of array read from av_dlog()
a6dd29c avformat/mov: fix integer overflow in mov_read_udta_string()
878627f mov: Fix negative size calculation in mov_read_default().
c179d68 mov: Fix overflow and error handling in read_tfra().

BUG=444533,444522,444539,444546
TEST=regression tests, test cases no longer crash
TBR=scherkus

Review URL: https://codereview.chromium.org/838653002

Cr-Commit-Position: refs/heads/master@{#310173}

R=hugo.holgersson@sonymobile.com,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/835163003

Cr-Commit-Position: refs/heads/master@{#310172}

stream where available.

BUG=403138

Review URL: https://codereview.chromium.org/816193003

Cr-Commit-Position: refs/heads/master@{#310171}

This is one of the top 20 histogram by used data
size, but is unowned (thus doesn't show up on
the dashboard by default) and the data for it
has 99% of of samples fall under 3ms.

BUG=387734

Review URL: https://codereview.chromium.org/836233002

Cr-Commit-Position: refs/heads/master@{#310170}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2ad2a0a..4cdbe42

TBR=dglazkov@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/839643002

Cr-Commit-Position: refs/heads/master@{#310169}

The rotation lock tray was in an incorrect position within the system tray. This change moves it to be above the Settings item.

TEST=Have a device in maximize mode, open the system tray.
BUG=443654

Review URL: https://codereview.chromium.org/813353004

Cr-Commit-Position: refs/heads/master@{#310168}

BUG=444957

Review URL: https://codereview.chromium.org/831283002

Cr-Commit-Position: refs/heads/master@{#310167}

These events have been enabled during the M-41 dev cycle and are ready
to be enabled for M-41 stable.

BUG=442543

Review URL: https://codereview.chromium.org/835993003

Cr-Commit-Position: refs/heads/master@{#310166}

BUG=442514

Review URL: https://codereview.chromium.org/821693003

Cr-Commit-Position: refs/heads/master@{#310165}

The deleting of the temporary accent character will cause the pending accent
to be cleared so we have to keep it around for the keypress and separately
record what the new pending-accent will be once we're done.

BUG=230921

Review URL: https://codereview.chromium.org/834293002

Cr-Commit-Position: refs/heads/master@{#310164}

BUG=396626
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/835423002

Cr-Commit-Position: refs/heads/master@{#310163}

AutofillAgent::FrameDetached is no longer necessary because form_cache_ only holds the forms for a single frame.
AutofillAgent::FrameWillClose is only called on the actual closing frame (which might be a parent frame).
AutofillAgent::FrameDetached can't take the place of AutofillAgent::FrameWillClose because the RenderFrame disables sending IPCs during detachment.

Therefore, move the automatic closing of rAc from the renderer (autofill_agent.cc) to the browser (chrome_autofill_client.cc).

For PasswordAutofillAgent, add FrameDetached to RenderFrameHost.

BUG=433486

Review URL: https://codereview.chromium.org/796493004

Cr-Commit-Position: refs/heads/master@{#310162}

It's not enough to know what version of the shared module is installed, we
also need to know the language, since the web store splits up crxs by
language/platform tuples. The only way to find out which language is
installed is by looking at what files are available. In our case,
looking at the contents of the _platform_specific directory.

Review URL: https://codereview.chromium.org/804193003

Cr-Commit-Position: refs/heads/master@{#310161}

RenderWidgetHost::GetView() may return NULL, e.g. if the renderer has
crashed. MessageService::OpenChannelToNativeApp() wasn't handling this
case properly.

BUG=374778

Review URL: https://codereview.chromium.org/787253009

Cr-Commit-Position: refs/heads/master@{#310160}

BUG=428729

Review URL: https://codereview.chromium.org/833403002

Cr-Commit-Position: refs/heads/master@{#310159}