- 13 Jul, 2017 40 commits
-
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/70c95fa..3ec7568 BUG=:angleproject:2101,740426 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I302d09829846c705e5e337ff071098fc91bc96e5 Reviewed-on: https://chromium-review.googlesource.com/570379Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#486413}
-
Reza.Zakerinasab authored
This CL adds color settings to ImageData and ImageBitmap serialization code. Bug: 670703, 671356, 735976 Change-Id: I854723eb8fa563bdd8755a002f182092b3f903b3 Reviewed-on: https://chromium-review.googlesource.com/552822 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486412}
-
Mike Dougherty authored
Bug: 739359 Change-Id: I9c720471e7a4214fb30e93eefc8ae84503c7aa5b Reviewed-on: https://chromium-review.googlesource.com/559980Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486411}
-
Aleks Totic authored
Bug: 635619 Change-Id: I57ce8f3a225d09fed054ffa102968c86d83c08f4 Reviewed-on: https://chromium-review.googlesource.com/568715 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#486410}
-
Mike Dougherty authored
Reland of https://chromium-review.googlesource.com/c/556394 which was reverted due to failure of the analyze step. The analyze step failed locally with the input file as described in #c0 of crbug.com/739469. After modifications to manage.py and gn_isolate_map.pyl, the analyze step passes successfully. The configuration also moved to screen_size_dependent_tests.json. Bug: 738092 Change-Id: I29b96e57ab193c2dd7045f91199a5f87f2621e2f Reviewed-on: https://chromium-review.googlesource.com/559945Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486409}
-
Ian Vollick authored
Previously, we'd done our texture updates in UiElement::OnBeginFrame. This virtual function was also responsible for doing texture update throttling. It turns out that neither of these are good things to do. Throttling turns out to be unnecessary and OnBeginFrame is the wrong time in the frame lifecycle to update our textures as input processing has not yet happened. This CL introduces PrepareToDraw which happens just before rendering the elements and is the correct time to update textures to ensure we never draw a dirty element. Bug: None Change-Id: Ic099a9b64d656f584e7d12783338e6552d082d21 Reviewed-on: https://chromium-review.googlesource.com/569991Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#486408}
-
Miriam Gershenson authored
I'm not sure if this will fix the flake, since I can't repro locally, but it seems plausible. BUG=740207 Change-Id: Icd423f4221b460bedc31299ec8a69d002d3a9db1 Reviewed-on: https://chromium-review.googlesource.com/570358Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486407}
-
Alex Clarke authored
Bug: Change-Id: Ice4fb3a54005fa18568ae0be94cfa2b58750e775 Reviewed-on: https://chromium-review.googlesource.com/570166Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486406}
-
Mounir Lamouri authored
This is also doing a couple of other cleanups. The main reason to do this is to simplify the implementation of the CTR for media controls. Bug: None Change-Id: I74670719ca576228a0bdca2ca28a809a6237bca4 Reviewed-on: https://chromium-review.googlesource.com/567157Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#486405}
-
Max Morin authored
Currently, the origin for the device request is looked up for every equest. However, we don't actually need it for the default device, so we defer looking up the origin to AudioOutputAuthorizationHandler. When using the default device, this removes hops the the UI thread completely. For nondefault devices, looking up the origin is consolidated with checking permissions, removing one thread hop. Note that this change changes the behaviour of the code when using AudioRendererHost, as it is currently using the origin passed over IPC. For ease of reviewing, I produced a diagram showing the flow of a call through AudioOutputAuthorizationHandler: https://docs.google.com/drawings/d/1S-eCMTqq4dzAXMVAkCrt4sJcc3rprphLQpFKNfsqGkE/edit BUG=425368 Change-Id: I4533e12e22b67e21a1e12f5c7036881b4d48fd9f Reviewed-on: https://chromium-review.googlesource.com/567006 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486404}
-
Dan Zhang authored
There are no flags to be updated. Deprecate FLAGS_quic_reloadable_flag_quic_bbr_slow_recent_delivery in the disabled state. Merge internal change: 161298821 https://chromium-review.googlesource.com/c/567479/1 Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes. Merge internal change: 161235354 https://chromium-review.googlesource.com/c/567335/1 Add explicit #include for waitable_event.h. Merge internal change: 161231994 https://chromium-review.googlesource.com/c/567330/1 Remove a redundant QUIC_FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_enable_pcc. n/a (flag metadata) Merge internal change: 161228561 https://chromium-review.googlesource.com/c/567398/1 When enabled, adds up to 1.5x the previously measured ack aggregation in bytes to the CWND, but reduces that amount by 1/2 the bytes acked since the queue was drained. Protected by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes3. Merge internal change: 161123535 https://chromium-review.googlesource.com/c/567268/1 deprecate FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2 Merge internal change: 161114930 https://chromium-review.googlesource.com/c/567321/2 Disable support for the packets-based QUIC congestion control algorithms now that they're basically unused. Protected by FLAGS_quic_reloadable_flag_disable_packets_based_cc Merge internal change: 161038619 https://chromium-review.googlesource.com/c/565441/1 Disable QUIC v36 as it's no longer being used. Protected by FLAGS_quic_reloadable_flag_quic_disable_version_36 Merge internal change: 160986423 https://chromium-review.googlesource.com/c/565640/1 Replace //net/quic/... uses of std::unordered_{map,set} with QuicUnordered{Map,Set}. No behavior change. Merge internal change: 160957726 https://chromium-review.googlesource.com/c/565639/2 Add QuicUnorderedMap and QuicUnorderedSet types to QUIC platform API. Add new type aliases QuicUnordered{Map,Set}. No behavior change. Merge internal change: 160942739 https://chromium-review.googlesource.com/c/565541/1 In QUIC, wrap pacing sender around PCC sender. Merge internal change: 160688357 https://chromium-review.googlesource.com/c/565301/1 Bug: Change-Id: I9caa01ee5cf8db011031320c0fedda0ae6955ca7 Reviewed-on: https://chromium-review.googlesource.com/568802Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486403}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/dac0038997b8..6daeed6d7311 $ git log dac003899..6daeed6d7 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 adithyas Remove Blink_ prefix from counters 2017-07-13 xunjieli [wpr-go] Use nil req.Body as appropriate for outgoing requests in http.Transport.RoundTrip() Created with: roll-dep src/third_party/catapult BUG=724543 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5323b8aee971a46a37e81103ce6dfa76d41efa6e Reviewed-on: https://chromium-review.googlesource.com/570267 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486402}
-
kylechar authored
On Mac there is a special task runner that runs when the main task runner is blocked on resize. The main task runner blocks until a CompositorFrame arrives, and we need HostFrameSinkManager and FrameSinkManagerImpl to continue processing messages during this time. The original CL http://crrev.com/c/563860 conflicted with http://crrev.com/c/562216 which moved the MessageLoop out of HostFrameSinkManagerTest. Get the TaskRunner from helper function instead of from MessageLoop directly. Bug: 657959 Change-Id: I9488d5ca38827e9ba72431c144f9a8ea69f7b66c TBR: piman@chromium.org,fsamuel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/568999 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486401}
-
Michael van Ouwerkerk authored
https://screenshot.googleplex.com/hPzcX8ian2N Bug: 739664 Change-Id: I03bd2aeff34c7f9172042524c1a2d3d60897cd25 Reviewed-on: https://chromium-review.googlesource.com/568030 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486400}
-
Peter K. Lee authored
Button titles coming in from XIB needs to have both Normal and Highlighted states set in code. Otherwise, the default non-translated strings in the XIB file is displayed during Highlighted state. Also done some refactoring to reduce verbosity. Bug: 741944 Change-Id: I4eb45deabd75d695f665565deb5ab6370097e0e1 Reviewed-on: https://chromium-review.googlesource.com/569339 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#486399}
-
Roman Sorokin authored
Chromad: Refresh the Kerberos ticket-granting-ticket for Active Directory enrolled devices on the lock screen Bug: 676337 Change-Id: I3ceebfcb25d961fa2d25c96d843028a54c6dec05 Reviewed-on: https://chromium-review.googlesource.com/516990 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#486398}
-
zpeng authored
Revert of Deduplicate Monochrome locale .paks (patchset #4 id:180001 of https://codereview.chromium.org/2933343002/ ) Reason for revert: Chrome is now missing 5 locale strings. The reason is that these strings are believed to be in WebView locales because they're whitelisted, but since WebView uses multiple whitelists to pack its locale strings, these strings are actually not contained by WebView Original issue's description: > Deduplicate Monochrome locale .paks > > This CL removes WebView strings from Chrome locale .paks in Monochrome > using a generated resource whitelist. While WebView's locale resource > logic remains the same, Chrome in Monochrome now loads a secondary > locale pack file as a fallback when a string cannot be found in the > primary locale pack file. > > This CL reduces binary size by over 400KB. > > BUG=724110 > > Review-Url: https://codereview.chromium.org/2933343002 > Cr-Commit-Position: refs/heads/master@{#485635} > Committed: https://chromium.googlesource.com/chromium/src/+/08ba6b7c7e7edb3f7c8851eb7ddc1d2ea64497e6 TBR=agrieve@chromium.org,dpranke@chromium.org,thestig@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724110, 741798 Review-Url: https://codereview.chromium.org/2980773002 Cr-Commit-Position: refs/heads/master@{#486397}
-
chrisha authored
This defines the format in which whitelist/blacklist information will be distributed. BUG=690166 Review-Url: https://codereview.chromium.org/2965063003 Cr-Commit-Position: refs/heads/master@{#486396}
-
Ken MacKay authored
We reference AudioDecoderConfig from mojom files within chromecast code; those mojom files declare things in the chromecast.<etc>.mojom module, so the generated code is put within the chromecast:: namespace. Since there is a chromecast::media:: namespace, if we don't fully qualify 'media::AudioDecoderConfig', then files that include the generated mojom.h (that also include chromecast/media/ headers) will fail to build because the compiler tries to lookup AudioDecoderConfig in the chromecast: :media:: namespace and can't find it. Change-Id: I30cdb1e46e2d08976789a4383a84708ce645c61c Reviewed-on: https://chromium-review.googlesource.com/569490Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#486395}
-
Ramin Halavati authored
A typo is corrected in network traffic annotation of: rlz/lib/financial_ping.cc Bug: 656607 Change-Id: Ic707d088f0a4a30568ccd722e821105d2cfaf536 Reviewed-on: https://chromium-review.googlesource.com/565262Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#486394}
-
lanwei authored
We want to add a flag and implement updating hover effect when a layout is changed behind this flag. Bug=488886 Review-Url: https://codereview.chromium.org/2956023004 Cr-Commit-Position: refs/heads/master@{#486393}
-
vakh authored
Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 Review-Url: https://codereview.chromium.org/2450963002 Cr-Commit-Position: refs/heads/master@{#486392}
-
Randall Raymond authored
The added HTML file and JS file have been downloaded from here: https://rsolomakhin.github.io/pr/multi/ And thus do not need to be thoroughly reviewed. The only changes made to these files are as follows 1) In the html file an "id" attribute is added to the "buy" button, the 2016 copyright is changed to 2017, and the stylesheet and favicon links are removed. 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName" is added to options on line 106, the JSLint directives are removed from the top of the file, and the long line on line 137 was changed into two lines. Bug: 734571 Change-Id: Ib27f0e9398d3ce8922018138ad98e0e93aa6e15b Reviewed-on: https://chromium-review.googlesource.com/567215 Commit-Queue: Randall Raymond <rayraymond@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486391}
-
gambard authored
Bug: 742349 Change-Id: I35c8b668a9fecdcc84d9e9fbd8e7cbb4057968b9 Reviewed-on: https://chromium-review.googlesource.com/570244Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#486390}
-
Michael Thiessen authored
Updating VR Support Level takes anywhere from 3-10ms on Pixel phones. In most cases we can skip this work. Bug: 741823 Change-Id: I8747fb19aea00444ceef1fb245f869b022a67e61 Reviewed-on: https://chromium-review.googlesource.com/568811Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486389}
-
Boris Sazonov authored
This CL adds a user action that is recorded whenever a dialog is shown in response to Google Play services recoverable error (usually this dialog requests an update). Bug: 739917 Change-Id: I5077a123080c59a054abe32cd232ab2ab490093a Reviewed-on: https://chromium-review.googlesource.com/568483Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#486388}
-
Quinten Yearsley authored
Change-Id: I4cdaa39a0832ad368d282967cc7375756a06238c Reviewed-on: https://chromium-review.googlesource.com/569065Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486387}
-
Alexander Timin authored
R=eseckler@chromium.org BUG=615047 Change-Id: I27cca41d2ea79b07f34d48c1bc1091cfd6caa9d9 Reviewed-on: https://chromium-review.googlesource.com/570242Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486386}
-
gambard authored
The fake omnibox displayed on the NTP is slightly missaligned with the real omnibox. This CL makes then aligned by increasing the height of the fake omnibox image by one pixel and moving the shadow below it by one pixel. The transparent pixels around the image have been removed. Bug: 742312 Change-Id: I99406a9d012a06f500b5f20675de0b75cd440a1a Reviewed-on: https://chromium-review.googlesource.com/569968Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#486385}
-
arthursonzogni authored
This is a reland of https://codereview.chromium.org/2973433003/ It was reverted for compilation error. Original CL description: > Redirects toward renderer-debug urls (chrome://crash, javascript:[...], > ...) were not expected to happen in the NavigationHandleImpl. It caused > WebContentsObserver::DidFinishNavigation not being called and > consequently, bugs in some WebContentsObservers. > > This CL blocks any redirects to renderer-debug urls. One test is added. > > The blocking of the URL was moved (and partially removed) in: > https://crrev.com/2436253002 > This CL tries to restore the previous behavior. BUG=736658,704892 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Change-Id: I1e82511b88acfabcb29e4fad102a5efa32ddca9a Reviewed-on: https://chromium-review.googlesource.com/569878Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#486384}
-
Ramin Halavati authored
Syntax errors in network traffic annotations of the following two files corrected: content/browser/indexed_db/indexed_db_internals_ui.cc content/browser/payments/payment_instrument_icon_fetcher.cc Bug: 656607 Change-Id: I09c8e51646e66963a9e1ef43015bd55b0bcc5131 Reviewed-on: https://chromium-review.googlesource.com/570158Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#486383}
-
Michael Thiessen authored
We used to check isDaydreamCurrentViewer in onResume to know if we were paused due to headset insertion, which was important because we used to exit VR in onPause. We no longer exit VR in onPause, so headset insertion while in VR doesn't cause us to exit VR since it only pauses then resumes us, so we just need to make sure not to exit VR in onResume in this case. This saves around 20-30ms in onResume. Bug: 741823 Change-Id: Ie8836554057170f953e73a3db5434024fe5fcf6f Reviewed-on: https://chromium-review.googlesource.com/569015Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486382}
-
lizeb authored
This CL allows early trace events to show thread time in addition to wall clock time. For instance, on a Nexus 5X running N, this shows that the first framework-created "android.view.Choreographer$FrameHandler" task is largely spent blocked. Also, on Android >= JB MR1, improve the resolution of timings from ms to us. For JB, keep the same resolution. Review-Url: https://codereview.chromium.org/2967023002 Cr-Commit-Position: refs/heads/master@{#486381}
-
Marc Treib authored
When the --local-ntp-reload flag is enabled, strip out the integrity placeholders from the html file. (They're inconvenient to compute, and not required in this case, since CSP is already disabled.) Bug: 740964 Change-Id: I4a93c97db480ee92eb049b320f112b9ddfd2bc7d Reviewed-on: https://chromium-review.googlesource.com/568141 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#486380}
-
John Chen authored
If a web page navigates by setting window.location, and the target URL results in a file download instead of a full navigation, ChromeDriver can time out waiting for a page load event that never comes. This CL fixes the error by explicitly setting the load event fired flag. BUG=chromedriver:1293 Change-Id: Id677adcf27ab237988f01d24dbb666aec8ce1b35 Reviewed-on: https://chromium-review.googlesource.com/569202Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486379}
-
Yipeng Wang authored
Since JNI registration is automatic now, we start deleting manual registration code. This CL deletes base_jni_registrar.cc and functions it calls. Also deletes base_jni_registrar.h and RegisterJni function everywhere. Bug: 683256 Change-Id: I7ce6d6222782c4a1e88278aeffb566f939e1ac9a Reviewed-on: https://chromium-review.googlesource.com/568282Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#486378}
-
stkhapugin@chromium.org authored
Purging configuration is needed for clearing visited links, and it is not a prerequisite for cookie clearing. Purging configuration is the last operation during browsing data clearing, so there is no need to wait until WKWebViewConfiguration is deallocated. Bug: None Change-Id: Ia4dda7ab9b8b67434fba939d03112a01f96104a1 Reviewed-on: https://chromium-review.googlesource.com/569965 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#486377}
-
Mike Dougherty authored
The old NSAllowsArbitraryLoads key is still required for backwards compatibility when running on old iOS versions. EarlGrey test targets need to download insecure images from browsingtest.appspot.com so add it as an exception domain in EarlGreyAddition+Info.plist. Bug: 622747 Change-Id: Ide26330939035cd8a876612dc659c48a6e2bd9fc Reviewed-on: https://chromium-review.googlesource.com/568791Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486376}
-
Hajime Hoshi authored
When SharedMemory::Close is called, SharedMemoryHandle is cleared and losts its ID. This means SharedMemory(Handle)'s ID is not available after closing. In DiscardableSharedMemory, shared memory is closed without unmmap-ing just to save file descriptor resources, and this makes SharedMemoryTracker confused since SharedmemoryTracker tracks mmap-ed (and not unmmap-ed) shared memory regions, and tries to get IDs of those regions. The problem is that sometimes SharedMemoryTarcker fails to get such IDs. This CL fixes this problem by adding SharedMemory::mapped_id() to make the id available even after Close is called. Bug: 604726, 740781 Change-Id: I5dbf6bd133d8a1e935adad53604f3f40da3c4a6f Reviewed-on: https://chromium-review.googlesource.com/566353Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486375}
-
Marc Treib authored
This reverts commit da208668. Reason for revert: Still perf regressions, though fewer of them. See crbug.com/741856 Original change's description: > Fieldtrial testing config for CaptureThumbnailOnLoadFinished > > This is mostly a reland of https://chromium-review.googlesource.com/548719 > which was reverted because of perf impact. In the meantime, > https://chromium-review.googlesource.com/558924 has landed which hopefully > improves performance. > > It also adds the CaptureThumbnailDependingOnTransitionType feature, since > the two will likely launch together (and that might also alleviate the > perf impact). > > Bug: 718413, 737396 > Change-Id: I0ef909f0015d07a3f908d0ba3dc52f6a897a53b1 > Reviewed-on: https://chromium-review.googlesource.com/563202 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485568} TBR=isherman@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 718413, 741856 Change-Id: Ic2479ad7c0e3e32c7621a2e80385d64da5029aea Reviewed-on: https://chromium-review.googlesource.com/570218Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#486374}
-