GitLab

BUG=477050

Review URL: https://codereview.chromium.org/1088903003

Cr-Commit-Position: refs/heads/master@{#325562}

container_ if we are destroying the instance.

BUG=476590

Review URL: https://codereview.chromium.org/1085423004

Cr-Commit-Position: refs/heads/master@{#325561}

When the DnsConfigServicePosix finishes its initial reading of the
system DNS config, it normally triggers a NetworkChangeNotifier (NCN)
OnDNSChanged() signal.  This can cause in-flight network requests to
abort with ERR_NETWORK_CHANGED.  Avoid aborting requests by:
1. Adding a new NCN signal, OnInitialDNSConfigRead which indicates
   the initial DNS config reading completed but does not represent
   a change in DNS config.
2. Modify HostResolverImpl to not abort requests upon this new
   signal (like it does for the OnDNSChanged signal).
3. Add logic to NetworkChangeNotifierAndroid to emit this new
   signal when safe to do so.  Network requests begin being issued
   immediately after the NCN (and hence DnsConfigService) is
   initialized, so we need to be sure no network change signals
   are missed between NCN initialization completing and the
   OnInitialDNSConfigRead signal.  This is tricky because the
   NCN (and hence DnsConfigService) is initialized on threads
   where file I/O is not allowed.  Were file I/O allowed we could
   simply slurp up the DNS config and hosts file.  Instead we
   start listening for network changes (which is our trigger signal
   for DNS changes on Android) on the initialization thread and
   record the current time to later compare against the hosts
   file's last-modified time to check for changes to the file.
   Actual loading of the DNS config and hosts file is done on
   another thread that allows file I/O.

BUG=470897

Review URL: https://codereview.chromium.org/1047103002

Cr-Commit-Position: refs/heads/master@{#325560}

... which weren't specifying android builds :).

R=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1090053002

Cr-Commit-Position: refs/heads/master@{#325559}

This is due to 2 reasons:
+ Page specific logic should belong to page, not page test.
+ Simplify the repaint measurement control code, which make
it easier to port repaint to TimelineBasedMeasurement.

Trybot link for repaint.gpu_rasterization.key_mobile_sites_repaint:
https://codereview.chromium.org/1098543002

BUG=444703, 455391

Review URL: https://codereview.chromium.org/1089223003

Cr-Commit-Position: refs/heads/master@{#325558}

This patch makes it possible to control BluetoothDiscoveryFilter assigned to discovery sessions through BluetoothEventRouter router.

BUG=407773
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/1083163002

Cr-Commit-Position: refs/heads/master@{#325557}

Revert of [Chromoting] Enable remoting webapp main.html GN build. (patchset #5 id:80001 of https://codereview.chromium.org/1082083005/)

Reason for revert:
Suspected of breaking the build.  For details, see https://code.google.com/p/chromium/issues/detail?id=477869

Original issue's description:
> [Chromoting] Enable remoting webapp main.html GN build.
>
> The previous remoting webapp GN build files were not enabled and at
> least 6 months out of date. This cl fixes the problem by bringing
> the build rules up to date and enables the webapp build.
>
> It also starts to move all the remoting-specific build rules into
> the remoting dir rather than having them in the main build.gn file.
>
> BUG=
>
> Committed: https://crrev.com/62ee8a9cfebbc8bdc037aaa3b37ebfbb45e02472
> Cr-Commit-Position: refs/heads/master@{#325551}

TBR=dpranke@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1090023004

Cr-Commit-Position: refs/heads/master@{#325556}

BUG=477844
TBR=kundaji@chromium.org

Review URL: https://codereview.chromium.org/1097623002

Cr-Commit-Position: refs/heads/master@{#325555}

BUG=477840
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1089923003

Cr-Commit-Position: refs/heads/master@{#325554}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9c79820..fd0ecf4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1097523002

Cr-Commit-Position: refs/heads/master@{#325553}

BUG=476211

Review URL: https://codereview.chromium.org/1060743003

Cr-Commit-Position: refs/heads/master@{#325552}

The previous remoting webapp GN build files were not enabled and at
least 6 months out of date. This cl fixes the problem by bringing
the build rules up to date and enables the webapp build.

It also starts to move all the remoting-specific build rules into
the remoting dir rather than having them in the main build.gn file.

BUG=

Review URL: https://codereview.chromium.org/1082083005

Cr-Commit-Position: refs/heads/master@{#325551}

This CL adds support for plumbing BeginFrames to
VideoFrameProviderClientImpl if it opts into it. This is required for
upcoming video rendering changes to improve video smoothness.

BUG=456991

Review URL: https://codereview.chromium.org/1039533002

Cr-Commit-Position: refs/heads/master@{#325550}

Implement the developer mode warning on mac.
Instead of creating yet-another-bubble-class, refactor the bubble we used for
the toolbar redesign. This includes:
- Expanding ToolbarActionsBarBubbleDelegate.
- Moving the logic for showing the redesign bubble into a new class.
- Updating the redesign bubble to have a more flexible UI (and renaming it to
  ToolbarActionsBarBubble).
Hook up the ToolbarActionsBarBubble for use with ExtensionMessageBubbles, and
implement the highlighting on the toolbar.

Note that this does *not* turn the feature on for mac.

TBR=benwells@chromium.org (OWNERS file change)

BUG=474092

Review URL: https://codereview.chromium.org/1086973004

Cr-Commit-Position: refs/heads/master@{#325549}

BUG=477498
TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1092823002

Cr-Commit-Position: refs/heads/master@{#325548}

This is for simplifying https://codereview.chromium.org/1010183002/

This also removes 'if (key == kProgramKey) ...' check from
JsonManifest::ResolveKey. This is safe because kProgram key was
never passed to the function before the change.

BUG=nativeclient:3802
TEST=git cl try, manually checked that both ARC and PNaCl demo still work

Review URL: https://codereview.chromium.org/1070233007

Cr-Commit-Position: refs/heads/master@{#325547}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/97a4012..e49d160

TBR=dcheng@chromium.org,johnme@chromium.org

Review URL: https://codereview.chromium.org/1049983004

Cr-Commit-Position: refs/heads/master@{#325546}

This is because GCC also uses the -B search path at link time to find
"as", and our bundled "as" can only target x86. See also the discussion at
https://codereview.chromium.org/1084133002/

(I also tried adding this condition around line 858, but this won't work
because of scoping issues ("clang" is not defined here)).

R=thakis@chromium.org,fdegans@chromium.org
BUG=469376

Review URL: https://codereview.chromium.org/1096553002

Cr-Commit-Position: refs/heads/master@{#325545}

Previously if a target depended on a source set and that source set had
data deps, building the target would not force the data dep target to be
built.

This patch hooks up the dependencies such that this happens as expected.

BUG=477104

Review URL: https://codereview.chromium.org/1095673002

Cr-Commit-Position: refs/heads/master@{#325544}

Lean on ICU for month names and abbreviations rather than hardcoding
English ones.

BUG=none

Review URL: https://codereview.chromium.org/1080883002

Cr-Commit-Position: refs/heads/master@{#325543}

Original cl
https://codereview.chromium.org/1035983003/

In order for ChromeVox to queue up utterances, we can separate each attribute or rule into its own spannable. Each spannable is then sent to tts (queueing as needed).

BUG=477492
TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/1094463003

Cr-Commit-Position: refs/heads/master@{#325542}

This matches the gn name and is less confusing with use_openssl and
use_openssl_certs both existing. The preprocessor flag will follow
in another CL. For now, the old name is still defined, but not used
within Chromium.

A follow-up CL will remove deprecated use_nss and USE_NSS #defines
together which will then cause downstream churn. Though from a grep
of known downstreams, the churn seems to be fairly minimal. The
removal is split from this CL so that, if we need to revert, the
CL to revert is small.

BUG=462040
TBR=wez@chromium.org

Review URL: https://codereview.chromium.org/1085923002

Cr-Commit-Position: refs/heads/master@{#325541}

TBR=phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1095743002

Cr-Commit-Position: refs/heads/master@{#325540}

I can't reproduce a MemoryError locally or on the try bots, and the original bug only shows MemoryErrors on the top_25 pageset.

Successfult tryjobs:
https://codereview.chromium.org/1086243002/

BUG=463111

Review URL: https://codereview.chromium.org/1097573002

Cr-Commit-Position: refs/heads/master@{#325539}

Currently fixed-size views dialogs on Mac don't initialize properly.
(And, e.g., WebDialogBrowserTest.SizeWindow fails because of it).
Desktop Linux has a similar issue.

On desktop Linux, NativeWidgetPrivate::OnRootViewLayout triggers a call
to UpdateMinAndMaxSize. OnRootViewLayout happens during Widget::Init()
but the X11 window is not yet mapped, so this was resulting in a no-op.
For Linux, fix by explicitly calling UpdateMinAndMaxSize after the
window is mapped.

Mac needs to do a similar thing during Init. However, Mac was calling
OnSizeConstraintsChanged() before Widget::Init() had set the non-client
view, so Widget::GetMinimumSize() returned invalid sizes. For Mac, move
the OnSizeConstraintsChanged() call to OnRootViewLayout(), similar to
Linux.

Then, add a cross-platform test. Mac was not clamping to the size
constraints in SetBounds(), so do that.

For the test itself, collapse the testing WidgetDelegates in
widget_unittest.cc into one helper class rather than adding yet another
WidgetDelegate. Then, provide a way to query the OS for the minimum
window size to fill the gaps required for testing the propagation of
size constraints to the window server.

BUG=454698, 447086

Review URL: https://codereview.chromium.org/1059853007

Cr-Commit-Position: refs/heads/master@{#325538}

BUG=475715
BUG=477060

Review URL: https://codereview.chromium.org/1061063005

Cr-Commit-Position: refs/heads/master@{#325537}

Revert of Send resize event when the screen info changes. (patchset #5 id:80001 of https://codereview.chromium.org/1078123002/)

Reason for revert:
Suspected as cause of flaky failures for
WebViewInteractiveTest.PopupPositioningBasic  WebViewInteractiveTest.PopupPositioningMoved.  For details, see https://code.google.com/p/chromium/issues/detail?id=477783

Original issue's description:
> Send resize event when the screen info changes.
>
> This is a regression from https://codereview.chromium.org/953233002
>
> BUG=475939
>
> Committed: https://crrev.com/6e3582ad1a058af30aa44ca7fae2113b050aa437
> Cr-Commit-Position: refs/heads/master@{#325494}

TBR=danakj@chromium.org,jochen@chromium.org,piman@chromium.org,sadrul@chromium.org,sievers@chromium.org,mlamouri@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475939

Review URL: https://codereview.chromium.org/1093713002

Cr-Commit-Position: refs/heads/master@{#325536}

to ensure that the callback function is set before ConnectChannel()
is called. This prevents a potential race condition that could occur
if messages were pending when ipc_adapter->ConnectChannel() is called.

TEST=git cl try, ARC still works, PNaCl demo still works
BUG=nativeclient:3802

Review URL: https://codereview.chromium.org/1090043002

Cr-Commit-Position: refs/heads/master@{#325535}

TBR=vabr@chromium.org
BUG=477812

Review URL: https://codereview.chromium.org/1096483003

Cr-Commit-Position: refs/heads/master@{#325534}

As of https://codereview.chromium.org/1008873006 it no longer does
anything.

BUG=426442,318217

Review URL: https://codereview.chromium.org/1045593002

Cr-Commit-Position: refs/heads/master@{#325533}

TBR=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1062823006

Cr-Commit-Position: refs/heads/master@{#325532}

Convert the BadHTTPS and URLFetcher reuse tests to use the shared test
fixture.  As a bonus, make sure the reuse test actually updates the
response body between requests.

BUG=471069

Review URL: https://codereview.chromium.org/1091073003

Cr-Commit-Position: refs/heads/master@{#325531}

This allows an overloaded version of the function to be added to Blink.

BUG=460945

Review URL: https://codereview.chromium.org/1090863002

Cr-Commit-Position: refs/heads/master@{#325530}

unrecoverable_error_set and one of the InitialSyncEndedForType overloads
are only called by Directory so they can be made private.

Remove name accessor as it's never called.

BUG=475557

Review URL: https://codereview.chromium.org/1096543002

Cr-Commit-Position: refs/heads/master@{#325529}

- SessionRestore now exposes IsLoadingActiveTabsOnly
- Fixed 2 browser tests that were failing with new behavior
- One last telemetry test still failing, will be addressed in a separate CL

Notes:
- First patchset inverts the default behavior to show tests succeeding
- Second patchset restores default behavior

BUG=

Review URL: https://codereview.chromium.org/1087063003

Cr-Commit-Position: refs/heads/master@{#325528}

The hacks are:  HTTP/0.9 support, allowing bonus characters before
HTTP responses, and accepting a truncated set of HTTP headers.

Also rename the confusingly named "ParseResponseHeaders" and
"DoParseResponseHeaders" methods.

BUG=472762

Review URL: https://codereview.chromium.org/1074263003

Cr-Commit-Position: refs/heads/master@{#325527}

Revert of Created new URLRequestContext for secure proxy check (patchset #20 id:380001 of https://codereview.chromium.org/981633002/)

Reason for revert:
This is breaking all the tests again:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27288/

Original issue's description:
> Created new URLRequestContext for secure proxy check.
>
> The new URLRequestContext disables alternate protocols
> to ensure that the Data Reduction Proxy secure proxy check
> request goes out over vanilla HTTP so that it can be
> intercepted by middleboxes.
>
> Also, secure proxy check is now done on IO thread.
>
> BUG=437080
>
> Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198
> Cr-Commit-Position: refs/heads/master@{#325302}
>
> Committed: https://crrev.com/afc53166cb6a0ed561f416403ab68261eae4427b
> Cr-Commit-Position: refs/heads/master@{#325464}

TBR=sclittle@chromium.org,rch@chromium.org,bengr@chromium.org,mmenke@chromium.org,sgurun@chromium.org,jeremyim@chromium.org,tbansal@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437080

Review URL: https://codereview.chromium.org/1089443003

Cr-Commit-Position: refs/heads/master@{#325526}

BUG=chrome-os-partner:37102

Review URL: https://codereview.chromium.org/1085973002

Cr-Commit-Position: refs/heads/master@{#325525}

Previously for <input> with autocomplete="off", we send a synthesized keyCode.
This CL disables this feature to send 229 instead (however, backspace still
generates 8).

BUG=476497

Review URL: https://codereview.chromium.org/1082823002

Cr-Commit-Position: refs/heads/master@{#325524}

BUG=476592
TBR=sullivan@chromium.org

Review URL: https://codereview.chromium.org/1089843003

Cr-Commit-Position: refs/heads/master@{#325523}