- 03 Apr, 2018 40 commits
-
-
yiyix authored
In draw occlusion algorithm, the total area of drawing is calculated to measure the effectiveness of draw occlusion. However, the integer multiplication in the area calculation has caused the integer overflow crash with huge draw quads. In this patch, I used GetCheckedArea() to check for the resulting area before assigning. Bug: 826727 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I667b458ca6f7d477ba13036868536dd842e59068 Reviewed-on: https://chromium-review.googlesource.com/991121 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#547856}
-
Siddhartha authored
The UNW_INDEX table has 2 columns: address and index. This table is represented column wise so that binary search uses lesser number of pages and it is easier to represent the memory map as arrays of primitive types. BUG=819888 Change-Id: I7f3245cfc1526425aed414fe89ee01661b914a40 Reviewed-on: https://chromium-review.googlesource.com/985151 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#547855}
-
Min Chen authored
Bug: 826005 Change-Id: I237dbf4ae50b02a225110fa72dc0bb0c0127535f Reviewed-on: https://chromium-review.googlesource.com/993755 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547854}
-
lgcheng authored
As request by khmel@ After we add new content to Arc opt-in flow, we should at least make legacy code not broken or crashed as long as we have not removed it. Note: Do not merge to M66. Legacy code is not running in product. Bug: b/73452374 Bug: 826927 Test: Manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1a1431c8afd11898cdd7e4b21dfe1ca6bfc09aad Reviewed-on: https://chromium-review.googlesource.com/993708Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#547853}
-
Kai Ninomiya authored
* transform_feedback/switching-objects.html - Mac/NVIDIA * transform_feedback/switching-objects.html - Linux/AMD * clipping-wide-points - Win/NVIDIA (ANGLE GL backend) TBR=kbr@chromium.org NOTRY=true Bug: 828572, 828579 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6e62daa01635fe00f94e7943d5c7647c5d1a7bc6 Reviewed-on: https://chromium-review.googlesource.com/994185 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547852}
-
bsheedy authored
Adds a new OWNERS file for the shared preference file directory. The files in here are simple, test-only config files, so it's set to allow any commiter to provide a rubber stamp. Change-Id: Ib858380befc6103a615cb84259bcc1dbc813bda3 Reviewed-on: https://chromium-review.googlesource.com/994143Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547851}
-
Ian Clelland authored
The recent Jinja2 update from 2.8 to 2.10 included a change to the indent filter which introduced a large number of newlines to the generated bindings files. This CL returns the templates to roughly the old behaviour, by trimming the leading and trailing whitespace from template variables before indenting them. Change-Id: I5c24bc9441f96752a74914f1c2cac896a55e4edf Reviewed-on: https://chromium-review.googlesource.com/992752Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#547850}
-
https://pdfium.googlesource.com/pdfium.git/+log/232b918d1f0f..4c22dd5690cd $ git log 232b918d1..4c22dd569 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 dsinclair Use Optional to determine if appearance stream as font Created with: roll-dep src/third_party/pdfium BUG=chromium:827430 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I30faeebc027568db41b6c9bf5e4d7240cec7dc0d Reviewed-on: https://chromium-review.googlesource.com/993697 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547849}
-
Jun Cai authored
Currently in the DeviceOrientation and DeviceMotion unit tests and browser tests, each fake sensor creates a new shared memory handle. While in the production code, only one shared memory handle is created and all sensors share it, and write data to that shared memory using different offset. This CL updates the FakeSensor and FakeSensorProvider to match the behavior of production code. Bug: 824591 Change-Id: I545d73b0d864a3b7093a387d007cab26fb912d91 Reviewed-on: https://chromium-review.googlesource.com/978856 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547848}
-
Koji Ishii authored
This test does not pass because of a typo in the ref file. Change-Id: I2673137789267359544a50e126d3ba16b728770b Reviewed-on: https://chromium-review.googlesource.com/989455 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#547847}
-
Jinsuk Kim authored
The method is used for ContentView only. Moved the logic to ContentView, and deleted the interface from InternalAccessDelegate. Bug: 598880 Change-Id: Ic07e2545b070e11d5653fd135d7396c65721cf71 Reviewed-on: https://chromium-review.googlesource.com/991620Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#547846}
-
Jingkui Wang authored
Remove the code rounding nacl input event to integers. BUG=chromium:828486 Change-Id: Icd60c7c8e133e8bd0143712a779feb24059ac62d Reviewed-on: https://chromium-review.googlesource.com/993152 Commit-Queue: Jingkui Wang <jkwang@google.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#547845}
-
Xiaoqian Dai authored
Per PM's request, disable splitscreen on M66 stable channel. This CL will be merged back to M66 and then reverted later on tot. TBR=xiyuan@chromium.org Bug: 827322 Change-Id: I0040d7a8e98841fee1808fe3a0589dd3c8b384ef Reviewed-on: https://chromium-review.googlesource.com/993472Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#547844}
-
Dirk Pranke authored
This moves the new isolated-script-based installer test to run on Win10 as an experiment, rather than running locally on Win Fast Ring (also fixing the gtest misconfiguration). No-Try: true Bug: 827546 Change-Id: I687a763d81c7095c88a6c879156ff2043336a863 Reviewed-on: https://chromium-review.googlesource.com/988260Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#547843}
-
Marijn Kruisselbrink authored
This makes sure that no race conditions exist between navigating to a blob URL and revoking it. Currently only implemented for the network service code path. Also add one more navigation-then-revoke WPT test, as the existing tests didn't cover the NavigationScheduler code-path. Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv Further navigation cases are handled in https://chromium-review.googlesource.com/c/chromium/src/+/899508. Bug: 800901 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icf9a4725526b4329a2841626977292802ad2fa7a Reviewed-on: https://chromium-review.googlesource.com/898009Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#547842}
-
Robert Ogden authored
Bug: 823569 Change-Id: If226bd56a981e78aa2fe9da89e144b930a064502 Reviewed-on: https://chromium-review.googlesource.com/991074Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@google.com> Cr-Commit-Position: refs/heads/master@{#547841}
-
Adrienne Walker authored
Signals in the TileManager are somewhat muddled. Prior to this patch: * PrepareTiles resets the signals. * When a task set completes (draw/activate/all), it sets the signal and then schedules CheckAndIssueSignals * CheckAndIssueSignals unconditionally calls CheckPendingGpuWorKTiles * CPGWT clobbers the value of ready to draw and ready to activate based on whether or not there is pending gpu work. * If not in smoothness mode, then there are no pending gpu work tiles and so finishing activate tiles calling CheckAndIssueSignals will also set ready to draw, but the THIRD IsReadyToDraw check will fail and so it never does anything. * Sending a signal to the client also unsets ready to draw / activate / etc. This patch separates out tile task completion from gpu work completion, which means that no values are ever unset except for PrepareTiles and we only do ready to draw/activate checks when both the tile work and the gpu work is done. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I77db37729761d99daa7ce747a4b3809a6d033363 Reviewed-on: https://chromium-review.googlesource.com/993157Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547840}
-
Fredrik Hubinette authored
For future reference, the correct "order" of monitors in X11 is the one given by xrandr --listmonitors Bug: 822068 Change-Id: I6ceedc8db1d381ab3955af584fd365a764910ea7 Reviewed-on: https://chromium-review.googlesource.com/972547 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Cr-Commit-Position: refs/heads/master@{#547839}
-
Bernhard Bauer authored
If the trusted CDN publisher is not available, fall back to parsing the URL. Bug: 814365 Change-Id: I8c51cf33f015ba251de492d336bdc50cdc6cd822 Reviewed-on: https://chromium-review.googlesource.com/983413Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#547838}
-
Vladimir Levin authored
This patch makes it possible to request a copy output before the first frame has been submitted. These requests are queued and are processed when the frame is received. Also, this ensures to read the surface id which is at or greater than the requested surface id. This patch is a part of the work to make OOPIF pixel dumps work in layout tests. Specifically, we're transitioning from using non-production code that synchronously composites and reads back the surface to using the copy output / readback from surface code. However, because of the sensitive timing, it is likely that the layout test driver would issue a request before the latest frame has been processed. R=fsamuel@chromium.org Bug: 667551 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibc1a79cf38db54b34853e41e19d6721475371220 Reviewed-on: https://chromium-review.googlesource.com/978870 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#547837}
-
Mohsen Izadi authored
Browser needs information about selection to be able to show selection touch handles. When Viz display compositor is enabled, browser does not receive CompositorFrameMetadata which contains this info and it needs to be added to RenderFrameMetadata. BUG=777882 TEST= content_browsertests: - TouchSelectionControllerClientAuraScaleFactorTest.* - TouchSelectionControllerClientAuraTest.* cc_unittests: - LayerTreeHostImplTest.SelectionBoundsPassedToRenderFrameMetadata Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8d1d03efb22d308048bfa8939af57658cee28b15 Reviewed-on: https://chromium-review.googlesource.com/980583Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547836}
-
Sami Kyostila authored
BUG=824964 Change-Id: I4a3fb472361b8548317c42afbe09b117e25fd178 Reviewed-on: https://chromium-review.googlesource.com/984879 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#547835}
-
Kevin Bailey authored
The tab switch button won't show background changes after being hidden and re-shown. This is to work-around that, by recreating it on each set match that needs it. (Creating it is needed if the match type is a tab switch and the tab switch button behavior was enabled.) This change also restores the strategy of not creating a tab switch button unless and until needed. Bug: 825372 Change-Id: I0b808969ee5e9b91e3ca292fa929447da148d75c Reviewed-on: https://chromium-review.googlesource.com/992356 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#547834}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9e0153d9. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15341 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=ajuma No-Export: true Change-Id: I1b0e3210a1a333a3e010c3cad13c3dd6ebcf1d74 Reviewed-on: https://chromium-review.googlesource.com/993035 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547833}
-
Elad Alon authored
Bug: 828584 Change-Id: Ib1ceebf2c486c424ad71e4ca84bac1c94b0a3aba NoTry: true Reviewed-on: https://chromium-review.googlesource.com/993932Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#547832}
-
Guido Urdaneta authored
The group ID for the default/communications input device should be based on the device ID of the corresponding real device. This was working correctly for input devices that had an associated output device, but it was using the default ID instead of the real ID when there was no associated device. Bug: 828377 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id3ff8d30dc6857d73beb55f216fbe52d89b9f2c0 Reviewed-on: https://chromium-review.googlesource.com/992319Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#547831}
-
Justin DeWitt authored
OfflinePageTabHelper implements a Mojo service that is notified of the URL and creation date of the MHTML main resource at the time that the MHTML document is installed by ResourceLoader. The information is discovered during MHTML parsing. OfflinePageTabHelper records that the metadata was derived from the MHTML content of an archive and that it should not be trusted. Change-Id: I4890c003caf3687777917743f02b48c2b315ca4b Reviewed-on: https://chromium-review.googlesource.com/946729 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#547830}
-
Adrienne Walker authored
Bug: 790915 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3f1455a61d27e59ac2b5dc49da049044119b6245 Reviewed-on: https://chromium-review.googlesource.com/990236 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#547829}
-
Filip Gorski authored
Bug: 824182 Change-Id: I928f8c010ab4b2f51efb9d5599c4a48fcca4b30b Reviewed-on: https://chromium-review.googlesource.com/993593Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#547828}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7d0b34084e5..668c1d8d1f1a $ git log c7d0b3408..668c1d8d1 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 agable Reland "Remove Rietveld support from presubmit" Created with: roll-dep src/third_party/depot_tools BUG=chromium:770408 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I53ce76b816ba6f936c0e1bbf43218203325f1cca Reviewed-on: https://chromium-review.googlesource.com/992856Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547827}
-
Christopher Grant authored
If a file URL has a hostname, treat it like an http/https hostname. In other words, don't special-case the file scheme, and ensure we show the rightmost portion of the hostname if present. BUG=805026 Change-Id: I609198db5523d0ec9085e4a4942e7276ee2c273e Reviewed-on: https://chromium-review.googlesource.com/993496Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#547826}
-
khmel@google.com authored
This replaces external reference of Play Store logo in ARC OOBE OptIn to internal static icon. Test: Manually Bug: 824952 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I351967a7b8738dbc1a7bd64adf0cf8c4d6b68926 Reviewed-on: https://chromium-review.googlesource.com/991470 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547825}
-
James West authored
Stop calling a second AppendExtraCommandLineSwitches() method from CastContentBrowserClient::AppendExtraCommandLineSwitches(). Bug: 67735190 Test: None Change-Id: Ifc045882cb48c92a67631bec60a3ddb6044cb34e Reviewed-on: https://chromium-review.googlesource.com/969623Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#547824}
-
Jao-ke Chin-Lee authored
BUG=790709,790645 Change-Id: Id016975e6dc286b8b48d368980e5d27c7e273d59 Reviewed-on: https://chromium-review.googlesource.com/993352Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#547823}
-
sebsg authored
Bug: 827797 Change-Id: Ib5e0e272844961704d1565293e4401bec8c1077c Tbr: mathp@chromium.org Reviewed-on: https://chromium-review.googlesource.com/993693Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547822}
-
Klaus Weidner authored
The WebVR frame lifecycle transition from "animating" to "processing" was confusing due to use of deferred SubmitFrame. Add a new ProcessWebVrCall at the end of SubmitFrame that can be deferred if needed. A frame counts as "animating" until that executes. Refactor VSync logic. WebVrCanAnimateFrame checks if all necessary resources are available. All the places that provide resources call WebVrTryStartAnimatingFrame which runs SendVSyncNow if CanAnimateFrame returns true. Resources include pending_vsync_ and get_vsync_callback_ along with the ShouldSkipVSync heuristics and the ui_->CanSendWebVrVSync() check. It should be generally equivalent, but with reduced wait time if not VSync aligned since it now reschedules after webvr_deferred_start_processing_ becomes false instead of waiting for the next OnVSync. Change-Id: I32f920d3147b0032037b03f72b18df6cf7195751 Reviewed-on: https://chromium-review.googlesource.com/985652 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547821}
-
Min Chen authored
animation after 'Power off' item has focused for a while after showing. focus related spec: https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view changes in this cl, - Set pre_shutdown_timer_ in PowerButtonController to start the cancellable pre-shutdown animation after power menu has been shown for 650ms. And remove the previous shutdown_timer_ which will start the clean shutdown after pressing power button for 3s. - Add power button menu item focus. Focus on the 'Power off' item after menu is shown. - Since we add the cancellable pre-shutdown animation back in this cl. Add the related tests in LockStateControllerTest back which removed in the previous cl https://chromium-review.googlesource.com/c/chromium/src/+/916838 - Modify related tests. Bug: 826064 Change-Id: Ibefb22067f5bd37849eb1b8c3fb3143f5d3b8dc8 Reviewed-on: https://chromium-review.googlesource.com/991398 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547820}
-
Robert Liao authored
ProfileHelperTest.DeleteInactiveProfile and UkmBrowserTest.HistoryDeleteCheck need the waiting thread to process tasks or they will deadlock. BUG=749312 Change-Id: I9d18fd55647d32e6e6a33a72be2a0fa8fcd89524 Reviewed-on: https://chromium-review.googlesource.com/988243 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#547819}
-
Leonard Grey authored
The right command key shares a key code with the windows context menu key. For key event purposes, we don't want to collapse it together with the left command key in case users have remapped it. Instead, disable the entire keyboard context menu code path, since neither of those shortcuts should work on Mac. Bug: 827618 Change-Id: I05123bde9cd43cf5ba01aaf33d406d8300cbe27b Reviewed-on: https://chromium-review.googlesource.com/988392 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547818}
-
Stephen Martinis authored
Bug: 818832 Change-Id: If7ff297aeed7f138fbf79769d04981bfbb5f6d47 Reviewed-on: https://chromium-review.googlesource.com/985193 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#547817}
-