GitLab

Change NGInlineItemSegments::ShapeText to shape all segments together by
using a new HarfBuzzShaper::Shape API that takes a vector of ranges over
a single one at a time. This avoids repeated calls to Shape which allows
bounds computations to happen once instead of per range. It also removes
the need for the costly CopyRange operation with the copying, iteration,
re-ordering, and bounds computation steps as none of this is needed now.

Bug: 636993
Change-Id: I1cb3e7046e8b74b1dd6c2584714ad19912aa6771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524533Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642271}

https://chromium.googlesource.com/catapult.git/+log/93bbf937f838..501edb72f469


git log 93bbf937f838..501edb72f469 --date=short --no-merges --format='%ad %ae %s'
2019-03-19 crouleau@chromium.org [Telemetry] Print fewer Chrome startup logs


Created with:
  gclient setdep -r src/third_party/catapult@501edb72f469

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:943650
TBR=sullivan@chromium.org

Change-Id: Ifbaa853a81e920816d14e9c568736aae62b326ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531272Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642270}

This patch fixes localizability errors found by via
https://chromium-review.googlesource.com/c/chromium/src/+/1524993.

Change-Id: Ie55f153e8621efcfb47d26bac40447cbf72566c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526662
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642269}

For a couple of releases, we have been getting the customer number (BCN) from
sync data (PaymentsCustomerData) instead of priority prefs. This cleans up the
code.

There's also an opportunity to remove the PrefService getter on PaymentsClient.

TBR=dpapad

Bug: 942597
Change-Id: Ic8d684bbd26612dcb8cea16c184114d800a81317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524983
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#642268}

VSYNC events do not belong to any buffer and should be displayed for all
buffers. This CL adds rendering VSYNC events over the Android top events
band and over each set of buffers per view.

This also changed to layout of elements.

Before it was:
  Collapsible title section:
     band1 svg
     ...
     bandN svg
Now it is chnaged
  Collapsible title secion
     container svg
        band1
        ...
        bandN

This makes it possible to add events over the set of bands and is more
flexible for upcoming UI markup as junk detection.

TEST=Manually
BUG=b:122555793

Change-Id: Ib7da08dfc530dd435192c6f86d28cd32d5cb15c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531004
Commit-Queue: Yury Khmel <khmel@chromium.org>
Auto-Submit: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642267}

This change adds a use counter to measure the number of page loads which
use the IdleDetector feature. In another patch this will be enabled for
UKM so that we can follow-up in a year and see what popular sites
are using this.

Bug: 937896
Change-Id: If9d0f111c96da4cbb19e109d19e8a5c7823e6a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512541Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642266}

BUG=943847
TBR=peconn@chromium.org

Change-Id: I4618867aaa88621bcc9c18a12c93f88f006b3d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531645
Auto-Submit: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642265}

- unsigned long -> uint64_t for buffer amount to make a consistence with //blink & //ppapi
- unsigned short -> uint16_t, size_t -> unsigned
- Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types

Bug: 930252
Change-Id: Ia5cc8df0fc109ccfc86c208474bb36f3f7e95aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530212Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642264}

https://chromium.googlesource.com/angle/angle.git/+log/4bcba62aba7b..c2074b14014e


git log 4bcba62aba7b..c2074b14014e --date=short --no-merges --format='%ad %ae %s'
2019-03-19 spang@chromium.org Fuchsia: Remove use of deprecated API Presenter::Present2
2019-03-19 spang@chromium.org Fuchsia: Remove use of deprecated header <lib/fdio/util.h>


Created with:
  gclient setdep -r src/third_party/angle@c2074b14014e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:943604,chromium:941770
TBR=jmadill@chromium.org

Change-Id: I8810c838a5014ff2484300a5d456f8b1a1cbc7c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531271Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642263}

- Update read/write functions and tests to be closer to the future intended API
surface, as described by the explainer:
https://docs.google.com/document/d/1lpi3-9vBP_1b7hZc2xBs0s_HaACJ6UigZZqHlJSNeJg/edit

- Remove uniqueness checks, as the JS dictionary type will enforce this.

Bug: 150835
Change-Id: I8735b89b3d84496722812900d094987d819c30c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529127
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642262}

This CL is meant to precede crrev.com/c/1522787 to make the changes in AuthenticatorCommon clearer.

Bug: 941873
Change-Id: If8c523e07db05f98516c443bc75f1d4b92bcab44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531469
Commit-Queue: Manas Verma <manasverma@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642261}

The current set of histograms related to decode swap chain don't say
anything about how often it's used compared to regular blit mode.  Add
a DecodeSwapChainUsed histogram for that.

Also mark a couple of histograms obsolete since they don't provide
useful information any longer.

Bug: 848093
Change-Id: Iad7383af4e1690cb3fcd1f13344aeb8b3d727408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518732
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642260}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4dd012f7e9a9..6893e71405a3


git log 4dd012f7e9a9..6893e71405a3 --date=short --no-merges --format='%ad %ae %s'
2019-03-19 saklein@chromium.org setup_board: argument deprecations
2019-03-19 saklein@chromium.org setup_board: Update usages
2019-03-19 nednguyen@google.com cros_run_tests_unittest: temporarily disable DetermineBoardPackagesTest.testNonEmptyPackageSet test


Created with:
  gclient setdep -r src/third_party/chromite@6893e71405a3

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic37d558c01d6f4ec4bb03b733c92275ec832c4ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531270Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642259}

In most cases when the hook is installed we have the sampling running.
In rare case when the sampling was enabled and then disabled we still do
the check a bit later.

Change-Id: I499f9c8a73bfabe540051483a3b99b7a7b06ee46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529540Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642258}

Skip migration of Secondary Accounts to Chrome OS Account Manager if the
policy does not allow it.

Please check https://crbug.com/934492#c6 for a Design Document.

Bug: 934492
Change-Id: I239d5f711b2e41ac2ab92c46429d02249b469c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508459Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642257}

This is a run of
run-clang-tidy.py -checks="-*,modernize-use-using" -header-filter=ui/views/* \\src\\ui\\views\\

BUG=940732
TBR=sadrul@chromium.org

Change-Id: I1d92da938b69867a14b2dd5b7ef65c791eb25cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531420Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642256}

BUG=943829

TBR=gogerald@chromium.org

Change-Id: If8e9acca727c6c6951c5ab93da6910e56ef025f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531641Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Auto-Submit: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642255}

https://swiftshader.googlesource.com/SwiftShader.git/+log/0e712410582f..2dc0303903b1


git log 0e712410582f..2dc0303903b1 --date=short --no-merges --format='%ad %ae %s'
2019-03-19 capn@google.com Fix VulkanUnitTests on Visual Studio


Created with:
  gclient setdep -r src/third_party/swiftshader@2dc0303903b1

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: If222e9577e9e18b4753b2183d743d022609a62ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531267Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642254}

Bug: 784610
Change-Id: If1243b001f19a0af64f915ba272a6166167d0ee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529538
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642253}

A few RenderWidgetHostViewMac unit tests have expectations which only
work if the RenderWidgetHostViewCocoa is *not* in a window, which isn't
a state in which it would ever receive events. This change adjusts the
test to put the view in an NSWindow and changes expectations to match.

Bug: 868398
Change-Id: I8b4a1f12fd9e2d9418eb2291cfe279a22025dfbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529746Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642252}

https://pdfium.googlesource.com/pdfium.git/+log/3d3dcdff38a6..b488d9c8d805


git log 3d3dcdff38a6..b488d9c8d805 --date=short --no-merges --format='%ad %ae %s'
2019-03-19 thestig@chromium.org Roll v8/ 73d4f6ca5..93306f1d7 (989 commits)
2019-03-19 thestig@chromium.org Roll tools/clang/ 257c91cc4..207fd1e5d (7 commits)
2019-03-19 thestig@chromium.org Add CFXJSE_FormCalcContext::DotAccessorCommon().
2019-03-19 tsepez@chromium.org Fix self-intersecting copy in UTF16ToWchar()


Created with:
  gclient setdep -r src/third_party/pdfium@b488d9c8d805

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I447ae61e2c8163d94bb186a0cec2aecd67d72e0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531340Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#642251}

This works around a limitation in the test harness, that uses test names
to generate file names that are limited to 255 characters on Windows.

The resulting test names are cryptic (eg.
"CleanerFindsUwS/ChromeCleanerControllerTest.WithMockCleanerProcess/Proc2_CrPt0_UwS1_Ext0_Items0_Items0_Resp0")
but the enums can be matched to the right type by position so their
exact value doesn't matter.

R=csharp

Bug: 943231
Change-Id: Icf05ede9652004d6872d76499215aad3e935376b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531382Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#642250}

MojoRendererWrapper is a simple wrapper that forwards all
media::Renderer calls to the MojoRenderer it is given. This reduces
boilerplate code for other classes that use the MojoRenderer.

Change-Id: I66eb81b03892e5c5cc2925b71983b6b7113390d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524411
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642249}

As requested by A11y team.

TEST=manual

Bug: 887996
Change-Id: I902495fe52b450b67400779b05fcd2eda69eeaa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531222
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642248}

Add call to DidLoseContext() when InProcessCommandBuffer encounters a
parse error. This is the same logic found in CommandBufferStub.

Bug: 941806
Change-Id: I1f7480619914fa032215dab82420845cdb482398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531220Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642247}

DevTools: add Page.frameRequestedNavigation, deprecate Page.frameScheduledNavigation and frameClearedScheduledNavigation

- add FrameRequestedNavigation probe that gets dispatched whenever client-initiated navigation request is sent to browser and carries reason for navigation;
- expose the above as Page.frameRequestedNavigation
- deprecate Page.frameScheduledNavigation and Page.frameClearedScheduledNavigation;


Change-Id: Ia652b5381c22b68962a6f568e7cb18456dc0269a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524706
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642246}

The main change here is that icons are first centered on the whole
screen, then, when space becomes tighter, they are centered over the
available area on the shelf.

A few changes to make this work properly:

* Fix an issue in |GetDimensionOfCenteredShelfItems| which was taking
  into account all items, even the ones within overflow, making the
  calculations incorrect.
* Another issue was that the code calculating ideal bounds would
  assume control buttons (app list, back, overflow) were the same size
  as app buttons (56) while they're actually a little smaller (40).
  Giving control buttons their "real" size in the layout code allows
  for the removal of some overrides at each button class level.
* Split out a small chunk from |CalculateIdealBounds| which is getting
  too long. More of that to come in future changes.
* Make the special spacing between the app list button and the first
  app icon also there on the other side for more symmetry.

Also add some extensive test coverage.

Bug: 891080, 933291
Change-Id: If4bb69aa6e182cd29c02d467039b5d839d09f493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512299
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642245}

Change-Id: Icf63c40bfeb356bb219a9ba0f8fd215030bc45f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531229Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642244}

This is a run of
run-clang-tidy.py -checks="-*,modernize-use-equals-default" -header-filter=ui/views/* \\src\\ui\\views\\

BUG=940732
TBR=sky@chromium.org

Change-Id: Ia91bb23af5a5467ab4d5f1619d0ca0d2ea70925f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531179Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642243}

Specifically:
 * Change flag names in virtual test README files.
 * Rename high-contrast-mode directories for flag-specific web tests.

Bug: 938511
Change-Id: Ifdf4b3e8117c65987cafbc08566ec4e3602d34c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529669
Auto-Submit: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#642242}

Bug: 942322
Change-Id: Ic58f0237ab500399ad2cd5cb204cd0cd56d1e9a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529542
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642241}

s/printerAddedFailedmMessage/printerAddedFailedMessage

Bug: 943386
Change-Id: I5acbef41f793d51aafafb0c311dd68c165bf0d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529740Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642240}

It doesn't make sense to check all windows on all displays
while calculating the drag window magnetism. Only the display
on which the cursor is located makes sense.

This CL adds a test to verify that window drag magnetism works
when window is dragged to another display.

This CL is necessary to prevent a regression caused by my previous
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1526632
which is now reverted.

BUG=942728
TEST=ash_unittests

Change-Id: I1f354317d61ddf58d968262c39bfa26e9bf48aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530191
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642239}

This is a run of
run-clang-tidy.py -checks="-*,modernize-use-equals-default" -header-filter=ui/views/* \\src\\ui\\views\\

BUG=940732
TBR=sky@chromium.org

Change-Id: Ica5c14a7ff31d0fa47719d072dd58462db0b5b51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531232Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642238}

This flag will be used to stage the "Compositor threaded
scrollbar scrolling" feature. Gerrit CL 1512536 will
consume this flag.

Bug: 943221
Change-Id: I358721904b5bf4d8f24f645db0fcb195d215c8f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529206
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642237}

Change-Id: I85d20987913b576d26727b5837867a0c942fd911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525406Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642236}

There are a few visual regressions that need to fixed before
we can release rounded corners on dialogs.

Bug: 822075
Change-Id: I071d42f2ac3de6ef4700e0b9f0a0367ebc28f618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521984
Commit-Queue: Sajad Maysam <sajadm@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642235}

In the past we set button_cancel as the default button in meida picker.
According to the latest discussion, https://docs.google.com/presentation/d/1AgftDesmQ4BbsDDdC8Dahox472OMSkadwE51oYmlfeI/edit#slide=id.g5059ee7351_0_58,
reverse the primary/sencondary button now.

Bug: 941026
Change-Id: I82572814b5ae34be36ee6de721b126bafcb834c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529737Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642234}

These tests have been converted to use .any.js form.

Bug: 795636
Change-Id: I85f6e4db1626ab00f3efc80d275b2af636f70b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529744
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642233}

Bug: b/128442298
Test: Manual
Change-Id: I239598d77dc77ed7b3a1dffbf15ac238c4f71d7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531385Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642232}