GitLab

Currently the instantiation of ChildTraceMessageFilter in
child_thread_impl.cc is guarded by a check on
CommandLine.HasSwitch(kSingleProcess)
The rationale is that in single-process mode we don't want to have any
message filter as the browser-side tracing will cover all the threads.
However, the aforementioned check is not complete, as it does not
covers the case of tests using the InProcessUtilityThreadHelper [1].
In those tests, the kSingleProcess flag is not present, but the
renderer is in-process anyways.
Replacing the the HasSwitch check in with IsInBrowserProcess(),
which covers also the latter case.

[1] for instance extensions/browser/sandboxed_unpacker_unittest.cc

BUG=474973

Review URL: https://codereview.chromium.org/1069253003

Cr-Commit-Position: refs/heads/master@{#324276}

Right now, Gesture Navigation has two very distinct phases: the initial
one, where the web contents window receives events and is moved, and the
follow up navigation, where the page still hasn't loaded and the user
scrolls on the overlay. The meat of this patch is to unify as much of
the logic as possible without sacrificing features. A new class is
introduced, OverscrollWindowAnimation, and the responsibility of the
existing OverscrollNavigationOverlay is steered into performing the
actual navigation.

TEST=Overscroll*
BUG=467692,464532,420121

Review URL: https://codereview.chromium.org/895543005

Cr-Commit-Position: refs/heads/master@{#324275}

Fixes issues related to compiling chrome in component mode on Windows. This just does chrome, there are likely other issues for test targets. Getting Chrome to work will also require an ANGLE roll.

I converted two static_library -> source_set. These aren't necessary but I noticed the extra .libs were being created and these don't need real static libraries as far as I can tell.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1069533002

Cr-Commit-Position: refs/heads/master@{#324274}

Legacy Skia flag.

BUG=475022
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1071463004

Cr-Commit-Position: refs/heads/master@{#324273}

No intended behavior change.

BUG=none

Review URL: https://codereview.chromium.org/1071513003

Cr-Commit-Position: refs/heads/master@{#324272}

If a mouse event has been created from the same native event with the
same time stamp, it shouldn't be marked as repeated.

R=sadrul@chromium.org
BUG=474282
TEST=events_unittests --gtest_filter=EventTest.*

Review URL: https://codereview.chromium.org/1068463003

Cr-Commit-Position: refs/heads/master@{#324271}

Test the experiment Chrome-Proxy directive by verifying that
a specific test URL only triggers a bypass when the command
line flag "--data-reduction-proxy-experiment=test" is set.

BUG=452292

Review URL: https://codereview.chromium.org/1044573002

Cr-Commit-Position: refs/heads/master@{#324270}

per Hwi and Alex.

BUG=none

Review URL: https://codereview.chromium.org/1069583002

Cr-Commit-Position: refs/heads/master@{#324269}

BUG=475072
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/1066363003

Cr-Commit-Position: refs/heads/master@{#324268}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1055173003

Cr-Commit-Position: refs/heads/master@{#324267}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e0eac24..80027f9

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1075473002

Cr-Commit-Position: refs/heads/master@{#324266}

In ES6, these properties of the intrinsic %FunctionPrototype% are poisoned during
CreateIntrinsics() / AddRestrictedFunctionProperties(). It's unnecessary to poison them
again, and testing whether they are a function or not causes tests to fail.

BUG=v8:3982
R=arv@chromium.org

Review URL: https://codereview.chromium.org/1067223002

Cr-Commit-Position: refs/heads/master@{#324265}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/05e4aba..b7133be

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1069343004

Cr-Commit-Position: refs/heads/master@{#324264}

We broke repeating the same key twice in a row in r324081. Cancelling
repeat must update the repeated key, so that we can tell that we need
to start a new repeat for that key in UpdateKeyRepeat if it's pressed
again.

TEST=Repeat the same key twice in a row on link
BUG=473446

Review URL: https://codereview.chromium.org/1074503002

Cr-Commit-Position: refs/heads/master@{#324263}

When logging errors (Log.e), if the last argument is an exception,
its trace will be logged, like what happens with android.util.Log.

If the exception is used as argument for the format string, its
toString will be used in the message, then the trace will also be
printed, provided that it's the last argument.

BUG=474599

Review URL: https://codereview.chromium.org/1069373002

Cr-Commit-Position: refs/heads/master@{#324262}

CertNetFetcher is a class for issuing and cancelling network fetches, that will be used by CertVerifier. It fetches http:// AIA and CRL URLs.

This initial implementation has some remaining TODOs around:
  - Add POST parameters
  - Add cache bypass controls
  - Add maximum requests thresholds
  - Add more tests for cancellation/de-duplication

BUG=455366
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/908863004

Cr-Commit-Position: refs/heads/master@{#324261}

endRecording() is deprecated.

Review URL: https://codereview.chromium.org/1066273002

Cr-Commit-Position: refs/heads/master@{#324260}

Re-layout 30 times so that averages are more stable.

CL for perf tryjob: https://codereview.chromium.org/1064683002
https://codereview.chromium.org/1064723002

Review URL: https://codereview.chromium.org/1067623002

Cr-Commit-Position: refs/heads/master@{#324259}

Now places that just pass the PaintContext through to various *Recorder
objects don't need to include this or know what a PaintContext is
anymore.

TBR=sky
BUG=466426

Review URL: https://codereview.chromium.org/1063253003

Cr-Commit-Position: refs/heads/master@{#324258}

BUG=None

Review URL: https://codereview.chromium.org/1069073002

Cr-Commit-Position: refs/heads/master@{#324257}

Add documentation for the "LcpEchoDisabled" ONC property.

BUG=463602
TEST=None

Review URL: https://codereview.chromium.org/1060333003

Cr-Commit-Position: refs/heads/master@{#324256}

There's no need to go through gfx::Canvas to the SkCanvas underneath,
use the gfx::Canvas API instead.

R=sadrul
BUG=466426

Review URL: https://codereview.chromium.org/1064183002

Cr-Commit-Position: refs/heads/master@{#324255}

BUG=449203

Review URL: https://codereview.chromium.org/1066103002

Cr-Commit-Position: refs/heads/master@{#324254}

This CL includes the following changes:
1. The virtual keyboard container window is no longer automatically set to full screen size.
Instead, it will be set to the same size as the virtual keyboard window and will be positioned
where that window was positioned. This is to allow window.moveTo to move the VK window
correctly.
2. VK window and VK container is no longer always full width. In FLOATING mode,
window.resizeTo can resize the VK window to specified size.
3. Added one test for FLOATING mode and other tests fixes

BUG=466702

Review URL: https://codereview.chromium.org/1008453002

Cr-Commit-Position: refs/heads/master@{#324253}

Cr-Commit-Position: refs/heads/master@{#324252}

We are seeing null pointer dereferences inside UpdateWorkQueues called
from DoWork. My theory is this is caused by the RenderThreadImpl
getting deleted inside a task which causes the TQM to get deleted while
DoWork is executing.

This patch makes it safe to delete the TQM inside a task.

BUG=474461

Review URL: https://codereview.chromium.org/1072473002

Cr-Commit-Position: refs/heads/master@{#324251}

BUG=474873

Review URL: https://codereview.chromium.org/1075463002

Cr-Commit-Position: refs/heads/master@{#324250}

BUG=474398

Review URL: https://codereview.chromium.org/1069003002

Cr-Commit-Position: refs/heads/master@{#324249}

BUG=

Review URL: https://codereview.chromium.org/1070623002

Cr-Commit-Position: refs/heads/master@{#324248}

We DCHECK that the snap matrix is indentity or a 2D translation, but the
computation of this matrix is prone to floating point error, so an
approximate check makes more sense here.

BUG=None

Review URL: https://codereview.chromium.org/1067423002

Cr-Commit-Position: refs/heads/master@{#324247}

CoreAudio seems to be the source of a lot of hangs when under a
remote desktop session and we've had past success with moving
these users over to WaveOut, so do so for all remote sessions.

This first queries the SM_REMOTESESSION system metric and then
tries to get the friendly name of the default audio device; if
it can't do that and a remote session is present or it can and
friendly name is "Remote Audio", CoreAudio functions are
disabled.

This change also adds a check to WASAPIAudioOutputStream::Open
to fail when a remote audio stream is requested; which will
trigger fallback in the AudioOutputResampler (if the user
resumes their session locally later they'll get WASAPI again
once streams have been closed for a few seconds).

BUG=422522
TEST=remote desktop session w/ remote audio gets WaveOut; works
with xfreerdp and Microsoft Remote Desktop client for OS; local
session gets WASAPI, connecting and starting a stream remotely
gets WaveOut.

Review URL: https://codereview.chromium.org/1060673002

Cr-Commit-Position: refs/heads/master@{#324246}

Legacy Skia flag.

BUG=475017
TBR=reed@googl.ecom,mtklein@google.com

Review URL: https://codereview.chromium.org/1067403002

Cr-Commit-Position: refs/heads/master@{#324245}

BUG=356285

Review URL: https://codereview.chromium.org/964503002

Cr-Commit-Position: refs/heads/master@{#324244}

ContentViewCoreImpl holds a weak reference to the java peer. This means
reference returned by GetJavaObject may be null.

Go through all callers of this API and make sure they correctly handle
null reference.

BUG=469803

Review URL: https://codereview.chromium.org/1067023005

Cr-Commit-Position: refs/heads/master@{#324243}

Review URL: https://codereview.chromium.org/1069413002

Cr-Commit-Position: refs/heads/master@{#324242}

BUG=None
R=ellyjones@chromium.org

Review URL: https://codereview.chromium.org/1068493003

Cr-Commit-Position: refs/heads/master@{#324241}

R=phajdan.jr@chromium.org
BUG=412513

Review URL: https://codereview.chromium.org/1070613002

Cr-Commit-Position: refs/heads/master@{#324240}

BUG=474696

Review URL: https://codereview.chromium.org/1069223002

Cr-Commit-Position: refs/heads/master@{#324239}

This is in addition to the SafeSites histogram.

Also, cleanup some unused histograms in the URL filter.

Review URL: https://codereview.chromium.org/1043113002

Cr-Commit-Position: refs/heads/master@{#324238}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c654e90..05e4aba

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1070743002

Cr-Commit-Position: refs/heads/master@{#324237}