GitLab

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2

BUG=662005

Review-Url: https://codereview.chromium.org/2575893002
Cr-Commit-Position: refs/heads/master@{#438568}

BUG=674123
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2568133009
Cr-Commit-Position: refs/heads/master@{#438567}

This CL is a mechanical refactor to transition
OffscreenCanvasCompositorFrameSink to use CompositorFrameSinkSupport,
enabling it to share code today with Mus and Exo.

BUG=664547

Review-Url: https://codereview.chromium.org/2569923004
Cr-Commit-Position: refs/heads/master@{#438566}

https://chromium.googlesource.com/angle/angle.git/+log/c31b741..d967122

BUG=chromium:672380

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2577693002
Cr-Commit-Position: refs/heads/master@{#438565}

Test is flaking frequently because the period of the vsync is outside
the 10% tolerance expected.

BUG=674129

Review-Url: https://codereview.chromium.org/2573083003
Cr-Commit-Position: refs/heads/master@{#438564}

Currently, the use of chrome.tabs.update to navigate defaults to using
the selected tab. If another tab is selected before the navigation is
performed, this other tab will be navigated instead of the PDF viewer's
tab.

We pass the viewer's tabId to chrome.tabs.update to ensure the correct
tab is navigated.

BUG=672563
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568903002
Cr-Commit-Position: refs/heads/master@{#438563}

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2571893002
Cr-Commit-Position: refs/heads/master@{#438562}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c78686903901..4c2a679b9012

$ git log c78686903..4c2a679b9 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 eakuefner [Telemetry] Use better URLs for linking to HTML results

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2571243002
Cr-Commit-Position: refs/heads/master@{#438561}

BUG=674174
Test=Connect to a VPN network.
     Verify that connected network has "Connected" text indicator.

Review-Url: https://codereview.chromium.org/2571943002
Cr-Commit-Position: refs/heads/master@{#438560}

https://pdfium.googlesource.com/pdfium.git/+log/a9caab94c1f1..603f57b85c06

$ git log a9caab94c..603f57b85 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 dsinclair Update CFWL_ListBox to return instead of using out params.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2571863004
Cr-Commit-Position: refs/heads/master@{#438559}

Ran `tools/clang/scripts/upload_revision.py 289575`.

This is similar to https://codereview.chromium.org/2564983002/
but should have a fix for that arm64/iOS miscompile.

BUG=673495
TBR=hans

Review-Url: https://codereview.chromium.org/2577523002
Cr-Commit-Position: refs/heads/master@{#438558}

Required by the standard, and, apparently, MSVC2017.

Also remove redundant `inline`s (methods defined within a class body
are implicit inilne already), and use the iterator typedefs more.

BUG=none

Review-Url: https://codereview.chromium.org/2570343002
Cr-Commit-Position: refs/heads/master@{#438557}

We only use kIntersect in practice, no need to paramaterize.

R=reed@google.com,chrishtr@chromium.org
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2575583002
Cr-Commit-Position: refs/heads/master@{#438556}

Revert of Removing trace_data from our chrome telemetry build dependency list. (patchset #3 id:40001 of https://codereview.chromium.org/2556193002/ )

Reason for revert:
Was only for testing purposes

Original issue's description:
> Removing trace_data from our chrome telemetry build dependency list.
>
> BUG=chromium:670284
>
> Committed: https://crrev.com/7ff018563d1f7b78d5906e7478858f8931724693
> Cr-Commit-Position: refs/heads/master@{#437896}

TBR=eakuefner@chromium.org,nednguyen@google.com,sullivan@chromium.org,aiolos@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:670284

Review-Url: https://codereview.chromium.org/2569763005
Cr-Commit-Position: refs/heads/master@{#438555}

EVP_PKEY operations are Windows-style with an in/out length parameter.
It must be initialized to the size of the buffer.

BUG=674179

Review-Url: https://codereview.chromium.org/2575683003
Cr-Commit-Position: refs/heads/master@{#438554}

We are launching security chips/verbose security states to stable in
M55, and thus removing the Finch experiments and command-line flags.

The behavior we are launching is show-all and animate-nonsecure-only
(security verbose states are shown for all states but animated for
non-secure only).

BUG=647762

Review-Url: https://codereview.chromium.org/2560203003
Cr-Commit-Position: refs/heads/master@{#438553}

BUG=674161

Review-Url: https://codereview.chromium.org/2569233006
Cr-Commit-Position: refs/heads/master@{#438552}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/2410df4..fa849a2

$ git log 2410df4..fa849a2 --date=short --no-merges --format=%ad %ae %s
2016-12-14 hbos@webrtc.org Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.
2016-12-14 henrika@webrtc.org Adds basic Bluetooth support to AppRTCMobile
2016-12-14 johan@webrtc.org Run 'git cl format --full' on Base64.
2016-12-14 danilchap@webrtc.org Remove deprecated RTPSender::SendPadData
2016-12-14 johan@webrtc.org Remove static cast from H264SpropParameterSets.
2016-12-14 ivoc@webrtc.org Improvements to the reliability of the echo detector perf test.
2016-12-14 johan@webrtc.org Add vector<uint8_t> to Base64 decoded data types.
2016-12-14 aleloi@webrtc.org Delete webrtc/transport.h.
2016-12-14 peah@webrtc.org Corrected access of null pointer in audioproc_f: The previous CL that added the ability to add and artificial nearend signal had an issue with null pointer access.
2016-12-14 henrika@webrtc.org Removes verification of audio parameters on Android
2016-12-14 nisse@webrtc.org Revert of Delete VideoFrame default constructor, and IsZeroSize method. (patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ )

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2569393004
Cr-Commit-Position: refs/heads/master@{#438551}

BUG=672229

Review-Url: https://codereview.chromium.org/2571023003
Cr-Commit-Position: refs/heads/master@{#438550}

This change prevents reloads being shown an offline preview. This does
not prevent other previews from being shown. A reload on an offline
preview is still considered to be non-opt out for the blacklist unless the user hit "show original".

BUG=672237

Review-Url: https://codereview.chromium.org/2563493002
Cr-Commit-Position: refs/heads/master@{#438549}

Made the following arguments / attributes non-nullable to match the spec.

History#pushState argument title seemed to be never used by our code.
https://github.com/whatwg/html/issues/2174

BUG=662005

Review-Url: https://codereview.chromium.org/2569663005
Cr-Commit-Position: refs/heads/master@{#438548}

This is just a refactoring change, there should be no change in behavior yet.

Currently Chrome accessibility support is basically off of on. This change
adds some additional accessibility mode flags so we will be able to selectively
enable just part of accessibility support. See the linked bug for more details.

The idea of casting the accessibility mode bitmask to an enum of all possible
valid accessibility modes doesn't really make sense anymore as the number of
possible valid permutations is now large, so I'm eliminating
AccessibilityModeHelper and making AccessibilityMode into just an integer
type rather than an enum.

Following changes will implement support for these new modes and enable
tracking and manually toggling their usage.

BUG=672205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2558933002
Cr-Commit-Position: refs/heads/master@{#438547}

(Includes some unrelated minor cleanup)

BUG=671302

Review-Url: https://codereview.chromium.org/2572013003
Cr-Commit-Position: refs/heads/master@{#438546}

This extends MessageEvent to allow ServiceWorker as a type of source
attribute according to the changes in HTML and replaces the existing
ServiceWorkerMessageEvent code usage with this extended MessageEvent.

Related spec issue: https://github.com/w3c/ServiceWorker/issues/989
Related spec change:
 - HTML: https://github.com/whatwg/html/pull/1944
 - SW: https://github.com/w3c/ServiceWorker/commit/6c68bd87bdfd153186a5b9904e31676c56730e2f
Related WPT: https://github.com/w3c/web-platform-tests/pull/4186

Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Xp9hmKyuOrI

BUG=659074

Review-Url: https://codereview.chromium.org/2466513002
Cr-Commit-Position: refs/heads/master@{#438545}

We're deprecating DOMWindowProperty. So this CL replaces it with ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2571753002
Cr-Commit-Position: refs/heads/master@{#438544}

The parameter defines a fraction of page loads that should have extended
performance measurements enabled. ContentSubresourceFilterDriverFactory uses it
for each main-frame navigation as a probability for enabling
|measure_performance|, which then gets distributed to all
DocumentSubresourceFilter's corresponding to (sub-)frames of the page.

If the variation parameter is not present or malformed, the extended performance
measurement is switched off.

BUG=672519

Review-Url: https://codereview.chromium.org/2569693002
Cr-Commit-Position: refs/heads/master@{#438543}

with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2555213004
Cr-Commit-Position: refs/heads/master@{#438542}

TSAN.

BUG=582277

Review-Url: https://codereview.chromium.org/2566273002
Cr-Commit-Position: refs/heads/master@{#438541}

Makes simple improvements to RecentTabHelperTest:
- Use ASSERT calls in some cases where test code would crash later if
  the expectation was not met.
- Added missing check of model().is_loaded().
- Update and reenable the DownloadRequest test.

BUG=674184

Review-Url: https://codereview.chromium.org/2571633003
Cr-Commit-Position: refs/heads/master@{#438540}

This change enables refactoring of AudioInputRendererHost and
surrounding code.

In this CL:
* Cleaned up instances of handling DCHECK errors in AudioInputRendererHost, see style guide https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#CHECK_DCHECK_and-NOTREACHED
* Sanitize volume in AudioInputRendererHost::OnSetVolume.
* Generalized AudioInputController::Factory interface and made sure the factory is used for all the factory methods of AudioInputController.
* Removed skipping authorization check for fake devices in AudioInputRendendererHost
* Removed unused weak_factory member of AudioInputRendererHost.
* Added unit tests for AudioInputRendererHost.

BUG=653861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2531333005
Cr-Commit-Position: refs/heads/master@{#438539}

Revert of [DevTools] Migrate storage domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2572933002/ )

Reason for revert:
Manually confirmed that this patch breaks Lighthouse.

Original issue's description:
> [DevTools] Migrate storage domain to new generator.
>
> BUG=664683
> TBR=pfeldman
>
> Committed: https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee
> Cr-Commit-Position: refs/heads/master@{#438449}

TBR=caseq@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2576643003
Cr-Commit-Position: refs/heads/master@{#438538}

Revert of Set overflow: auto in StyleResolver::styleForDocument. (patchset #1 id:1 of https://codereview.chromium.org/2571893003/ )

Reason for revert:
This breaks compiles on Android Cast bot: https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/58645

Original issue's description:
> Set overflow: auto in StyleResolver::styleForDocument.
>
> Without this, the call to setStyle in Document::updateStyle would temporarily
> mark the LayoutView as overflow: visible.  With root layer scrolling this causes
> PaintLayerScrollableArea to remove the scrollbars.
>
> This change has no effect on the document's final overflow style, which comes
> from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).
>
> BUG=672335
>
> Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
> Cr-Commit-Position: refs/heads/master@{#438533}

TBR=bokan@chromium.org,szager@chromium.org,skobes@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672335

Review-Url: https://codereview.chromium.org/2570293003
Cr-Commit-Position: refs/heads/master@{#438537}

The introduction of an interface allows dependent classes
(MostVisitedSites) to inject doubles in tests.

BUG=619584

Review-Url: https://codereview.chromium.org/2570783003
Cr-Commit-Position: refs/heads/master@{#438536}

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG=663469

Review-Url: https://codereview.chromium.org/2574213002
Cr-Commit-Position: refs/heads/master@{#438535}

It is possible to have |GestureScrollUpdate| and |GesturePinchUpdate| in the same
|GestureScrollBegin/End| sequence. This CL coalesces multiple GSUs and GPUs into 1
GSU and 1 GPU using matrix transformation.

e.g.
|GSB| -> |GSU| -> |GSU| -> |GPU| -> |GSU| -> |GSE|
becomes
|GSB| -> |GSU|* -> |GPU|* -> |GSE|

* means coalesced events.

Note that we have to go through the matrix when there are 2 adjacent pinch events
with different pinch point as they would coalesce to 1 scroll event and 1 pinch event.

BUG=661601

Review-Url: https://codereview.chromium.org/2552853002
Cr-Commit-Position: refs/heads/master@{#438534}

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Review-Url: https://codereview.chromium.org/2571893003
Cr-Commit-Position: refs/heads/master@{#438533}

This LayoutObject type is only used for non-outermost SVGSVGElements, so
no need to do runtime checks of the type.

Review-Url: https://codereview.chromium.org/2570293002
Cr-Commit-Position: refs/heads/master@{#438532}

https://skia.googlesource.com/skia.git/+log/65115a1b1a5c..60c05f98aa22

$ git log 65115a1b1..60c05f98a --date=short --no-merges --format='%ad %ae %s'
2016-12-13 herb Mark the leaf classes of GrOp final.
2016-12-14 bsalomon Change ConstructorInitializerWidth in .clang-format from 4 to 8
2016-12-14 robertphillips Replace TextureType with SkBackingFit
2016-12-14 robertphillips Make filterMaskGPU use GrTextureProxy
2016-12-14 robertphillips Add asDeferredTexture & asDeferredRenderTarget helpers to GrSurfaceContext
2016-12-14 mtklein Revert "Revert "SkNx basically always is fast now.""
2016-12-14 mtklein Revert "Revert "clamp to premul when reading premul sRGB""

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2571923004
Cr-Commit-Position: refs/heads/master@{#438531}

We shouldn't ask people to pipe insecure URLs to python3.

(https://llvm.org is itself problematic since it has a SHA-1
certificate. That too should get fixed, but, in the meantime, curl still
accepts SHA-1 and probably isn't going to raise its bar anytime soon,
even though Chrome 56 will.)

BUG=none

Review-Url: https://codereview.chromium.org/2570333002
Cr-Commit-Position: refs/heads/master@{#438530}

There's a bunch of weird glitches right now that cause the text to flip to the left. AFAICT, these two changes fix all of them:
1) Set the alignment of the text field directly.
2) RFC 3987 requires us to set the writing direction of URLs to LTR so that we get שלום.com instead of moc.שלום. This appears to change the alignment of the string if it's not set explicitly. So: set it explicitly.

BUG=648554, 673362

Review-Url: https://codereview.chromium.org/2555783002
Cr-Commit-Position: refs/heads/master@{#438529}