GitLab

Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #1 id:1 of https://codereview.chromium.org/2615843002/ )

Reason for revert:
This patch was not the culprit for the layout test failures.

Original issue's description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
> Cr-Commit-Position: refs/heads/master@{#441599}

TBR=eae@chromium.org,szager@chromium.org,loyso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642454, 642450, 642460

Review-Url: https://codereview.chromium.org/2611233002
Cr-Commit-Position: refs/heads/master@{#441775}

Revert of Roll WebRTC 15911:15919 (5 commits) (patchset #1 id:1 of https://codereview.chromium.org/2617693003/ )

Reason for revert:
Revert in hopes of fixing linux x64. If doesn't fix it will revert revert http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/15545

Original issue's description:
> Roll WebRTC 15911:15919 (5 commits)
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/af5a0a0..5445b07
>
> $ git log af5a0a0..5445b07 --date=short --no-merges --format=%ad %ae %s
> 2017-01-05 ehmaldonado@webrtc.org Reland of actor webrtc_perf_tests into several source_sets. (patchset #1 id:1 of https://codereview.webrtc.org/2613913002/ )
> 2017-01-05 ehmaldonado@webrtc.org GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package boundaries.
> 2017-01-05 danilchap@webrtc.org Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ )
> 2017-01-05 mbonadei@webrtc.org Revert of Fixing package-boundary violation with srjar_deps (patchset #5 id:80001 of https://codereview.webrtc.org/2610823002/ )
> 2017-01-05 mbonadei@webrtc.org Fixing package-boundary violation with srjar_deps
>
> TBR=
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> BUG=
>
> Review-Url: https://codereview.chromium.org/2617693003
> Cr-Commit-Position: refs/heads/master@{#441751}
> Committed: https://chromium.googlesource.com/chromium/src/+/01b8456652e46cc732b7d9282f07fca6e4c99d00

TBR=perkj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2615103002
Cr-Commit-Position: refs/heads/master@{#441774}

Previously, layer titles found their way into the resource manager
as ANDROID_RESOURCE_TYPE_DYNAMIC_BITMAP and were left there forever.
Over time, these recources accumulated (easily reproducable by
entering and exiting the tab switcher) and is more than likely the
cause of memory related crashes when entering the tab switcher.
The title layer itself was removed from the LayerTitleCache but the
resources that constitute the title were never correctly managed.

This change adds a function to the ResourceManager that allows the
LayerTitleCache to remove associated resources. Specifically, only
dynamic bitmaps can be manually removed.

BUG=669348

Review-Url: https://codereview.chromium.org/2578233002
Cr-Commit-Position: refs/heads/master@{#441773}

BUG=648510

Review-Url: https://codereview.chromium.org/2610183002
Cr-Commit-Position: refs/heads/master@{#441772}

It's unused already.

BUG=625089

Review-Url: https://codereview.chromium.org/2610853009
Cr-Commit-Position: refs/heads/master@{#441771}

Unfortunately, due to the way this code relies on posting a delayed
tasks that gets run at a later time, writing a unit test is very
difficult.

BUG=678659

Review-Url: https://codereview.chromium.org/2618693003
Cr-Commit-Position: refs/heads/master@{#441770}

This API was only being used by tests and most call sites were using it
incorrectly. Calling RemoveAllDownloads() immediately after creating a
DownloadManager is guaranteed to do nothing. Any new or persisted
downloads are added by some other entity asynchronously long after the
the DownloadManager has been created. In Chrome a DownloadManager starts
out empty until the downloads history DB is succuessfully queried.

In addition, this API is quite likely to do the wrong thing. A real
browser would need to pick and choose which downloads it wants to remove
based on whether the downloads are currently in progress or not -- which
is why Chrome was not using this API.

As a side-effect of removing the API, we can also remove the
Download.ClearAllSize UMA metric.

BUG=none

Review-Url: https://codereview.chromium.org/2593183002
Cr-Commit-Position: refs/heads/master@{#441769}

Inform the scheduler on resuming activites, so fetching of new
snippets consider this event.

(There is a related CL that triggers a similar event for new tabs:
https://codereview.chromium.org/2592053004/)

BUG=676308

Review-Url: https://codereview.chromium.org/2599743002
Cr-Commit-Position: refs/heads/master@{#441768}

DevTools: do not subscribe to global object events from the widgets that are not necessarily disposed.

Review-Url: https://codereview.chromium.org/2615753003
Cr-Commit-Position: refs/heads/master@{#441767}

SpellCheckTest.SpellCheckSuggestions_EN_US times out flakily on
Windows Debug. Disable the test on those builds.

TBR=groby@chromium.org
BUG=678753

Review-Url: https://codereview.chromium.org/2610393002
Cr-Commit-Position: refs/heads/master@{#441766}

BUG=676391

Review-Url: https://codereview.chromium.org/2618503003
Cr-Commit-Position: refs/heads/master@{#441765}

Previously suggestions that are a subset of another suggestion are not
deduped.

With this patch, only the most complete version will be suggested to
the user.

A side-effect of this change is that ContactDetails are now sorted by
relevance in regards or the information required from the merchant
instead of completeness.

For example, considering a profile A with only email and a profile B
with email and phone, and a merchant requires email, phone and name.
Previously the order between A and B would have been decided by
frecency since both were incomplete. With this patch, B would be
suggested first since it has more information.

BUG=674647

Review-Url: https://codereview.chromium.org/2583593002
Cr-Commit-Position: refs/heads/master@{#441764}

Fixes a regression where --debug-devtools erroneously no longer used the debug version
of devtools (e.g. minified / unbundled).

Also added an npm command to debug test: "npm run debug-test inspector/test-name.html"

BUG=none

Review-Url: https://codereview.chromium.org/2611843003
Cr-Commit-Position: refs/heads/master@{#441763}

Gtk3.20 added CSS names and changed a bunch of widget's classes to be
names instead.  This CL adds a runtime check for Gtk3.20 and uses
names for newer versions, and classes otherwise.  Unfortunately we
must load the symbol for setting the object name dynamically since we
still need to support Gtk3.10 (on Trusty).

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2609943005
Cr-Commit-Position: refs/heads/master@{#441762}

If there are multiple surfaces from the same FrameSinkId that have
temporary references we might not remove one of the temporary
references.  We track the temporary references in DisplayConfigurator
and remove them when a real reference is added. An iterator is
incremented twice in some cases and we stop tracking one extra temporary
reference we never removed. DisplayCompositor no longer knows about the
temporary reference, so it never gets removed.

BUG=none

Review-Url: https://codereview.chromium.org/2612873003
Cr-Commit-Position: refs/heads/master@{#441761}

BUG=624175

Review-Url: https://codereview.chromium.org/2616963002
Cr-Commit-Position: refs/heads/master@{#441760}

Review-Url: https://codereview.chromium.org/2613103002
Cr-Commit-Position: refs/heads/master@{#441759}

if an initialization error occurs while creating an audio stream.

BUG=678697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2611063003
Cr-Commit-Position: refs/heads/master@{#441758}

https://pdfium.googlesource.com/pdfium.git/+log/e4d611c9c6d8..48f776f7e801

$ git log e4d611c9c..48f776f7e --date=short --no-merges --format='%ad %ae %s'
2017-01-05 npm Remove unused CPDF_ImageCacheEntry::GetCachedBitmap
2017-01-05 tsepez remove unused CFX_PtrToInt32 typedef

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2615923002
Cr-Commit-Position: refs/heads/master@{#441757}

Since both targets require ARC and //ios/chrome/browser/ui has a
public_deps on //ios/chrome/browser/ui:ui_arc, the separation is
no longer necessary.

BUG=624363

Review-Url: https://codereview.chromium.org/2617603003
Cr-Commit-Position: refs/heads/master@{#441756}

The code fixes the bug referenced by the bug field. If requested fps is 15 and
the camera supports fps ranges 0 - 30, 10 - 20, 14 - 16 and 15 - 15. Previously,
we would choose 15 - 15 fps. This is bad because it doesn't leave the camera
room to adjust based on the lighting conditions. Heuristic copied from WebRTC
chooses the 10 - 20 fps range instead.

BUG=630266

Review-Url: https://codereview.chromium.org/2354923002
Cr-Commit-Position: refs/heads/master@{#441755}

Review-Url: https://codereview.chromium.org/2614003002
Cr-Commit-Position: refs/heads/master@{#441754}

Reland of "Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content."

- Use SurfaceLayers in embedders and Window Manager to properly position
  the embedded content in the layer tree.

- WM no longer uses underlay surfaces for window decorations. Instead
  they are submitted to Mus as part of the WM's surface.

- FrameGenerator now only creates SurfaceDrawQuad for the top-level
  window rather than recursively creating SurfaceDrawQuad for all windows
  in the window tree, since all surfaces are now part of the tree rooted
  at the surface of the top-level window.

Previously landed in crrev.com/441492, but reverted in crrev.com/441522
since it broke some tests on Windows. This CL includes a fix for that
brokenness.

BUG=672943, 669964
TBR=jbauman@ for DEPS change (previously lgtm'ed in the original CL)

Review-Url: https://codereview.chromium.org/2613903003
Cr-Commit-Position: refs/heads/master@{#441753}

This CL adds test cases for methods in the blink::WebPresentationClient
interface implemented by PresentationDispatcher.

BUG=576808

Review-Url: https://codereview.chromium.org/2597853002
Cr-Commit-Position: refs/heads/master@{#441752}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/af5a0a0..5445b07

$ git log af5a0a0..5445b07 --date=short --no-merges --format=%ad %ae %s
2017-01-05 ehmaldonado@webrtc.org Reland of actor webrtc_perf_tests into several source_sets. (patchset #1 id:1 of https://codereview.webrtc.org/2613913002/ )
2017-01-05 ehmaldonado@webrtc.org GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package boundaries.
2017-01-05 danilchap@webrtc.org Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ )
2017-01-05 mbonadei@webrtc.org Revert of Fixing package-boundary violation with srjar_deps (patchset #5 id:80001 of https://codereview.webrtc.org/2610823002/ )
2017-01-05 mbonadei@webrtc.org Fixing package-boundary violation with srjar_deps

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2617693003
Cr-Commit-Position: refs/heads/master@{#441751}

We are no longer performing native drawing on these platforms, use the
Skia placeholder instead.

BUG=675977
R=reed@google.com
TBR=

Review-Url: https://codereview.chromium.org/2611153002
Cr-Commit-Position: refs/heads/master@{#441750}

This gets rid of the remaining call to SetSelectedTab(), which has no effect on any platforms anymore.

BUG=646465, 571533, 675239, 675238

Review-Url: https://codereview.chromium.org/2521173004
Cr-Commit-Position: refs/heads/master@{#441749}

Reason: Now, the HTML diff is always available.

BUG=672651

Review-Url: https://codereview.chromium.org/2607163002
Cr-Commit-Position: refs/heads/master@{#441748}

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets updated). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2571263002
Cr-Commit-Position: refs/heads/master@{#441747}

This change is needed to help the rename_to_chrome_style clang tool with
the Great Blink Rename.  Without this change, the tool would rename
blink::FloatRect::x accessor to X and consequently would rename all
references to this name (which before this CL would also include the
body of the EXPECT_FLOAT_RECT_EQ macro defined in
cc/test/geometry_test_utils.h).

BUG=678704
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617563003
Cr-Commit-Position: refs/heads/master@{#441746}

Using update-w3c-deps in Chromium 787a1e7a.

Includes a change to port/base.py (and unittest) since the manifest format has now changed (http://crbug.com/678077).

TBR=jsbell,tkent

BUG=678077

Review-Url: https://codereview.chromium.org/2610243002
Cr-Commit-Position: refs/heads/master@{#441745}

This should bring the Ozone/LinuxOS builds back building (not running).

Review-Url: https://codereview.chromium.org/2614713004
Cr-Commit-Position: refs/heads/master@{#441744}

Add more items to CCT/Herb menu including:
1. Bookmark action & Download action to the top bar
2. "Add to home screen" and "Request desktop site" to the menu
3. The return of "find in page"

Udpate text message in the snackbar for Bookmark action and Download
action to display which app the action is execucted. For example, if CCT
is opened in Chrome Dev, the text in the snackbar for Bookmark should be
"Bookmarked in Chrome Dev".

BUG=671797

Review-Url: https://codereview.chromium.org/2596973002
Cr-Commit-Position: refs/heads/master@{#441743}

This removes the virtual method GetName in favor of just storing the name directly on the BaseScreen instance and returning it via a new method screen_id. Previously, all of the GetName overrides just returned a value directly.

BUG=672142

Review-Url: https://codereview.chromium.org/2549373005
Cr-Commit-Position: refs/heads/master@{#441742}

BUG=676090

Review-Url: https://codereview.chromium.org/2618783002
Cr-Commit-Position: refs/heads/master@{#441741}

Basically it's doing a vector insert when it should be doing an element
assignment. See crbug.com/676445 for details

BUG=676445

Review-Url: https://codereview.chromium.org/2594123003
Cr-Commit-Position: refs/heads/master@{#441740}

Revert of Memoize LayoutTheemDefault::clampedMenuListArrowPaddingSize(). (patchset #1 id:1 of https://codereview.chromium.org/2600873002/ )

Reason for revert:
This appears to be causing the layout test failures in crbug.com/678684.  (Ran a local bisect to find the culprit.)

Original issue's description:
> Memoize LayoutTheemDefault::clampedMenuListArrowPaddingSize().
>
> This is the second try to fix a performance regression of menulist rendering.
> The first try [1] didn't have major improvement. This CL reverts it, and cache
> another value.
>
> [1] crrev.com/438496
>
> BUG=673754
>
> Committed: https://crrev.com/b1f1c5d7ee4bfe822c4c0a384a9ac2ddaa71554f
> Cr-Commit-Position: refs/heads/master@{#441569}

TBR=keishi@chromium.org,tkent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673754

Review-Url: https://codereview.chromium.org/2612113003
Cr-Commit-Position: refs/heads/master@{#441739}

We display various visual tab indicators but there is no corresponding indicator for accessible labels. The updated accessible label is in the format of:

Page title - Tab status

For tabs in incognito this is a format:
Page title - Tab status (incognito)

This fixes the crashes by adding a check for the active tab index.

BUG=635610

Review-Url: https://codereview.chromium.org/2581023002
Cr-Commit-Position: refs/heads/master@{#441738}

BUG=667641

Review-Url: https://codereview.chromium.org/2609463002
Cr-Commit-Position: refs/heads/master@{#441737}

BUG=677223

Review-Url: https://codereview.chromium.org/2612313002
Cr-Commit-Position: refs/heads/master@{#441736}