- 12 Mar, 2018 40 commits
-
-
Tsuyoshi Horo authored
To match spec text changes in https://github.com/WICG/webpackage/commit/3cae549. Bug: 803774 Change-Id: I31dc56506cdaf1d67b05eba15b77d3c7fef89b33 Reviewed-on: https://chromium-review.googlesource.com/958748 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#542450}
-
Christian Dullweber authored
The test is flaky on linux-chromeos-dbg. TBR=xiyuan@chromium.org Bug: 811379 Change-Id: If35f60f4f24df396e181628a276ad94fc6ccba94 Reviewed-on: https://chromium-review.googlesource.com/958467Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542449}
-
Takashi Toyoshima authored
Now, ResourceLoader calls WebURLLoader's interface in DidChangePriority if |loader_| instance is already created. But we do not want to call it if the instance is still in the ResourceLoadScheduler's queue. Bug: 819931 Change-Id: I93bd5abc3d32a2b9a822372700d864adb8bbdf93 Reviewed-on: https://chromium-review.googlesource.com/958648Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542448}
-
Mark Cogan authored
This is the animation when presenting a tab from the tab grid and the current selected tab isn't visible (so the full grid zoom can't easily be done). It would also be used when tapping 'done' while on the remote tabs page. This CL sets this to be the transition when presenting a tab in all cases. A future CL will use the more detailed transition when it's available. The animation code is straightforward: set a zero alpha and scale transform, then animate back to full alpha and the identity transform. Bug: 804540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I58f6ac505352f39ffc9f92e2dc3b85898944a2df Reviewed-on: https://chromium-review.googlesource.com/956147 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542447}
-
Adam Rice authored
The external/wpt/dom/interfaces.html test is painfully slow on MSAN bots due to parsing 3000 lines of IDL. It's also quite slow even on a regular bot. Add it to SlowTests. This is step 1 to try to remove the Timeout expectation from the test. If it reliably runs to completion on the MSAN bot when marked as slow then I will remove the timeout expectation in a followup change. Bug: 810963 Change-Id: I00ffa9675697fada0254c301224dbfce31978f0c Reviewed-on: https://chromium-review.googlesource.com/951164Reviewed-by:
-
Sasha Morrissey authored
Test: manually verified at chrome://histograms after opening a zip Bug: 820877 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie15460a6b8f25a2a08cb52a4360e334f7d7f03a4 Reviewed-on: https://chromium-review.googlesource.com/958822Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542445}
-
Tetsui Ohkubo authored
This CL implements a brightness slider to UnifiedSystemTray. This CL adds following classes: * UnifiedSliderView * Base view class of a slider row in UnifiedSystemTray. Volume slider will also be implemented on top of it. * UnifiedBrightnessView * View class of a brightness slider that inherits UnifiedSliderView. It observes current brightness state. * UnifiedBrightnessSliderController * Controller class of a brightness slider that changes the screen brightness according to the user action. This CL also adjusts paddings in feature pods to match the numbers in the latest UX spec. Screenshot: http://screen/DxrSR2UrS72 UnifiedSystemTray design doc: go/cros-qs-restyling TEST=manual BUG=819943 Change-Id: I802dcbb98c0b52ab6ec9b53a741bf558049e60ce Reviewed-on: https://chromium-review.googlesource.com/955162 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#542444}
-
Christopher Cameron authored
This isn't used. TBR=sky Bug: 818085 Change-Id: I2998682053bffc7a1b8b016d4eb8280dfcd20993 Reviewed-on: https://chromium-review.googlesource.com/958003Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#542443}
-
Takashi Toyoshima authored
To simplify how Blink handles origins, I will remove the fetcher security origin from the Resource. It was used for caching SW related meta data, but the new source origin would match the concept better. Bug: 803766, 811669 Change-Id: I872cbc33a640126bacfc79ff15f16b588d35fc02 Reviewed-on: https://chromium-review.googlesource.com/940286Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
qi1988.yang authored
As close as possible to the C++17 standard, use std::Optional. Bug: 805207 Signed-off-by:
qi1988.yang <qi1988.yang@samsung.com> Change-Id: I88560f320ad38b986eb84a73e488eb4968ea1660 Reviewed-on: https://chromium-review.googlesource.com/956652Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542441}
-
https://chromium.googlesource.com/catapult.git/+log/1537dcedd27d..6eaec901b986 $ git log 1537dcedd..6eaec901b --date=short --no-merges --format='%ad %ae %s' 2018-03-12 nednguyen Add more logging to debug flaky failure of ActualPageRunEndToEndTests.testTrafficSettings Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I06daa01c20e7fbcefb63523e39d1c26351acc31e Reviewed-on: https://chromium-review.googlesource.com/957840Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542440}
-
Yutaka Hirano authored
Some modules set values but it looks no one uses the value in a meaningful way. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I49517ad8bc6a4ac2229e3a380cbd8fb53be5b3f5 Reviewed-on: https://chromium-review.googlesource.com/954893Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#542439}
-
Tetsui Ohkubo authored
This CL adds UnifiedSystemInfoView, which implements system info row in UnifiedSystemTray. The system info row shows current date, battery status, and the enterprise management status of the device. In the existing SystemTray, these functionalities were implemented in SystemInfoDefaultView and TrayEnterprise. Screenshot: http://screen/PjHGknbGzBL Design doc: go/cros-qs-restyling TEST=UnifiedSystemInfoViewTest BUG=819944 Change-Id: I77faa513bfb32b74c4329642fbb2745dc3722a22 Reviewed-on: https://chromium-review.googlesource.com/956905 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Trent Apted authored
TBR=dgozman@chromium.org Bug: 819285 Change-Id: I632bb2bf537037e7f69a22013f67d89d6549ab9d Reviewed-on: https://chromium-review.googlesource.com/958645Reviewed-by:
-
Kunihiko Sakamoto authored
ICU needs to be initialized explicitly, because Signature header parsing involves URL parsing which relies on ICU for IDN handling. Bug: 819896 Change-Id: Ia2c63e34eed78a586c7b471eec9b78ac9fbcb953 Reviewed-on: https://chromium-review.googlesource.com/958782Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Trent Apted authored
TBR=tmartino@chromium.org Bug: 819976 Change-Id: I45d3f2f0286c6572ace56ab1ca73b1009c4737cc Reviewed-on: https://chromium-review.googlesource.com/958747Reviewed-by:
-
Han Leon authored
BUG= Change-Id: Iaf37fa21c8b7c05996db17f33778bc5a4b0271c0 Reviewed-on: https://chromium-review.googlesource.com/958233 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542434}
-
Patricia Lor authored
r534573 fixed a bug where hover highlights would disappear when a normally-ripple-enabled button was long-pressed by always showing the highlight during the ripple animation (which is invisible on MacViews). However, this fix also caused non-highlight enabled bubbles to start showing the default highlight implementation, which looks like a transparent reddish square. Fix this by allowing ink drop clients to set their AutoHighlightMode according to the platform. Bug: 809896, 795224 Change-Id: I4e1269900c38b75affb7606b6eab5f034cd609d4 Reviewed-on: https://chromium-review.googlesource.com/930522Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#542433}
-
Tetsui Ohkubo authored
This CL adds a feature pod button for network. By clicking on the button, it will show network detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling Screenshot: http://screen/rUc0p85Y7S3 TEST=manual BUG=813499 Change-Id: I5b563f1fa37a016cb5992bd7fbaaa02a8c1d51b4 Reviewed-on: https://chromium-review.googlesource.com/952114Reviewed-by:
-
Luciano Pacheco authored
Remove include of <vector> added by me on previous CLs. Even though these files use std::vector we don't want to promote the use of this thus we remove these includes. Bug: 820271 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I66a466a60d78ed66f8d93049ace52c673477d8bc Reviewed-on: https://chromium-review.googlesource.com/956824Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#542431}
-
Kunihiko Sakamoto authored
Bug: 819649 Change-Id: I44905d1b25690bdfa8f652e2e56b5ca868996df4 Reviewed-on: https://chromium-review.googlesource.com/958764Reviewed-by:
-
Christopher Lam authored
This CL enabled experimental app banners on CrOS in preparation of enabling DesktopPWAWindowing by default. Bug: 707014 Change-Id: Ia1c56612df17212e42130c639280a8c97de217be Reviewed-on: https://chromium-review.googlesource.com/956646Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#542429}
-
Kent Tamura authored
* generate_origin_trial_features.py: Now we use only lower-cased component string. So we restrict --target-component flags to lower-cased strings. This CL doesn't affect production. Bug: 770603 Change-Id: I5725c741c383e2edb095892faac55511d8899d43 Reviewed-on: https://chromium-review.googlesource.com/958781Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#542428}
-
Kent Tamura authored
Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I928bb5c36061934e272a15c4a436023534f6bbb5 Reviewed-on: https://chromium-review.googlesource.com/958641 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Ramin Halavati authored
ProxyConfigSource is removed and ProxyConfigWithAnnotation class is added to wrap a constant ProxyConfig and its NetworkTrafficAnnotation. To goal is to provide an annotation wherever a ProxyConfig is modified, so that the source of configs for proxies and their changes would be traceable and transparent. Bug: 656607 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I64f0eaad8f37682da4571b4a9aae69d974ce584d Reviewed-on: https://chromium-review.googlesource.com/934126 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542426}
-
Istiaque Ahmed authored
Bug: 818395 Change-Id: I794bd2ebabceab3724ca6e2ff6f9b93578f1cf84 Reviewed-on: https://chromium-review.googlesource.com/957976 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542425}
-
Kunihiko Sakamoto authored
After this patch: - SignedExchangeHeader parses the Signature: header - SignedExchangeSignatureVerifier takes a SignedExchangeHeader instead of custom input parameter struct - SignedExchangeHandler holds SignedExchangeHeader as a member Bug: 803774 Change-Id: I842f211360c93b11b52a495f6b0c6fa5b664c197 Reviewed-on: https://chromium-review.googlesource.com/954904 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
Bug: 819687 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I522757792789eb4e492ee34a6bf4f17d463018c3 Reviewed-on: https://chromium-review.googlesource.com/953162Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542423}
-
Sasha Morrissey authored
thumbnail should appear. Test: Open a .PDF or .HTML file in Drive in quick view in the Files App. A Bug: 625944 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I06b8d498b641b3a1c5823617fbe57fa298654bf2 Reviewed-on: https://chromium-review.googlesource.com/952425Reviewed-by:
Keigo Oka <oka@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#542422}
-
Trent Apted authored
This reverts commit af1c15b1. Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1) Unexpected Failures: * external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html * external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html * external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html * external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html * external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html since https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761 errors like 15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines): 15:59:42.311 5904 CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md 15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644]) Original change's description: > bluetooth: Use DeviceUUID in FakeBluetooth > > This change refactors the Web Bluetooth test API to use the > DeviceUUIDs helper class defined in BluetoothDevice. Additionally, > this change finishes the implementation of SimulateGATTServicesChanged, > and as a result, tests are updated to set the next discovery response > before calling this interface. > > BUG=719826 > > Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d > Reviewed-on: https://chromium-review.googlesource.com/939984 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541577} TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 719826 Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104 Reviewed-on: https://chromium-review.googlesource.com/958741Reviewed-by:
-
Luciano Pacheco authored
Change button height to "em" unit to match padding unit, to fix button text being chopped. Move background color to parent element to remove gray line between the two banners. See bug for screenshots. Bug: 722766 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d153e39fdfc0065918feaeb07672c58be37b662 Reviewed-on: https://chromium-review.googlesource.com/954803Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
-
Joel Hockey authored
Add scrolling to outer container and set inner container to use margin: auto inside flex box. Bug: 801311 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4fcedad71bdf65efde6353c95f1cae03dd11bf62 Reviewed-on: https://chromium-review.googlesource.com/954523Reviewed-by:
-
Luciano Pacheco authored
CL #3 out of 5. Convert the remaining directories of third_party/WebKit/Source/core/. When the class ctor is private use base::WrapUnique(), otherwise use std::make_unique(). Remove includes of wtf/PtrUtil.h, and add missing #includes detected by the 'git cl lint' command. Bug: 781645 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie8367d0c6913a8cfccb37b57335b5d9ae2c46f81 Reviewed-on: https://chromium-review.googlesource.com/950623Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#542418}
-
Kent Tamura authored
Bug: 770603 Change-Id: Iaa7d740585bd2635aefac260cc416b3002e2b667 Reviewed-on: https://chromium-review.googlesource.com/958701Reviewed-by:
-
Kunihiko Sakamoto authored
The new format tells how many bytes to read before starting the parser, and it can be parsed without buffering the entire signed exchange. So after this patch, SignedExchangeHandler no longer uses string accumulation. This patch also updates the test htxg files to the new format. Test: all existing tests should pass. Bug: 803774 Change-Id: Id463bd74330392619c2a7b334b0a359a6b742be0 Reviewed-on: https://chromium-review.googlesource.com/945092 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Dominick Ng authored
BUG=811578 Change-Id: I89e36faf196520ecc05dea024204792f54caea1b Reviewed-on: https://chromium-review.googlesource.com/939063Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#542415}
-
Trent Apted authored
This reverts commit b213e00a. Reason for revert: ProcessManagerBrowserTest.NestedURLDownloadsToExtensionAllowed fails on Win7 (32) since https://ci.chromium.org/buildbot/chromium.win/Win7%20%2832%29%20Tests/31089 errors like [2768:3776:0309/113129.955:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [2768:7568:0309/113130.435:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico Original change's description: > Break up NestedURLNavigationsToExtensionBlocked into two tests. > > The test recently starting timing out on the bots, most likely because > it was taking too long. It might've become too slow after r529904 added > more code to it (coverage for downloads). > > This CL breaks up the latter addition into its own test. > > Bug: 806684 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ie1d8fb7278387147e6f781c3163ea5fc89cbf183 > Reviewed-on: https://chromium-review.googlesource.com/944570 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542177} TBR=rdevlin.cronin@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806684 Change-Id: I75d971eb328af97f4f4aa98efb36628993ce9c96 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/958661Reviewed-by:
-
Trent Apted authored
This reverts commit 4233662f. Reason for revert: suspected for browser_tests memory leak reported for SiteDetailsBrowserTest.ManyIframes starting in link - https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/26536 example stack like Indirect leak of 16 byte(s) in 1 object(s) allocated from: #0 0x9c5602 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92:3 #1 0x12a5445c in make_unique<ukm::mojom::UkmRecorderInterfaceProxy, mojo::InterfaceEndpointClient *> buildtools/third_party/libc++/trunk/include/memory:3079:28 #2 0x12a5445c in mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigureProxyIfNecessary() mojo/public/cpp/bindings/lib/interface_ptr_state.h:214 #3 0x12a5375b in instance mojo/public/cpp/bindings/lib/interface_ptr_state.h:113:5 #4 0x12a5375b in get mojo/public/cpp/bindings/interface_ptr.h:97 #5 0x12a5375b in operator-> mojo/public/cpp/bindings/interface_ptr.h:100 #6 0x12a5375b in ukm::MojoUkmRecorder::UpdateSourceURL(long, GURL const&) services/metrics/public/cpp/mojo_ukm_recorder.cc:32 #7 0x1bd46a10 in blink::Document::UkmRecorder() third_party/WebKit/Source/core/dom/Document.cpp:5978:20 #8 0x1c741e81 in blink::LocalFrameView::EnsureUkmTimeAggregator() third_party/WebKit/Source/core/frame/LocalFrameView.cpp:5862:32 Original change's description: > [OOPIF] Move IsLocalRoot() helper from Frame to LocalFrame. > > This method doesn't really make sense on Frame, as it is a property of > a LocalFrame. Putting it on Frame implies that there are situations > where it would return true for RemoteFrame, but that acn never happen. > > There are a few places that walk all frames in the frame tree looking > for local roots and thus need to do an extra IsLocalFrame() check now: > - PropagateZoomFactorToLocalFrameRoots: visits all the local roots in a > frame tree to update the zoom factor. > - DidExitFullscreen: this one is slightly unusual in that it only > notifies the *topmost* local root. > - FocusedOrMainFrame: arguably wrong and should be removed. > > If there are a more instances in the future of needing to walk the frame > tree for all local roots, it might be worth adding a helper. > > Change-Id: Ib91a813c16d5a9b4393962f0053f14447989053f > Reviewed-on: https://chromium-review.googlesource.com/958232 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542403} TBR=dcheng@chromium.org,haraken@chromium.org Change-Id: I189d52af812f6e3d4cdaf8ab40bd22197f14fcc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/958622Reviewed-by:
-
Trent Apted authored
This reverts commit 29607010. Reason for revert: causes telemetry_perf_tests to fail on mac 10.12 since https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/10960 error like Failed to execute "/b/s/w/ir/.swarming_module_cache/vpython/aa03a4/bin/python /b/s/w/ir/components/crash/content/tools/generate_breakpad_symbols.py --binary=/b/s/w/ir/out/Release/Chromium.app/Contents/Versions/67.0.3365.0/Chromium Helper.app/Contents/MacOS/Chromium Helper --symbols-dir=/b/s/w/itcCWvow/tmpsqdLGL/symbols --build-dir=/b/s/w/ir/out/Release" causing Unexpected Failures: * core.stacktrace_unittest.TabStackTraceTest.testCrashMinimalSymbols * core.stacktrace_unittest.TabStackTraceTest.testCrashSymbols Original change's description: > generate_breakpad_symbols: ensure otool path exists on Mac > > BUG=813163 > TBR=jochen@chromium.org > > Change-Id: I1fb5565b978fb38b39fb2ddf9f726f9a3c5bd794 > Reviewed-on: https://chromium-review.googlesource.com/953591 > Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> > Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541636} TBR=sergeyberezin@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813163 Change-Id: If21d6769c514e5a037fb3e1d8ed2a20c43f01482 Reviewed-on: https://chromium-review.googlesource.com/958363Reviewed-by:
-
Dominick Ng authored
The result of creating a bookmark app is a pointer to an extension. When this pointer is null, either the extension failed to be created, or the user did not accept the installation prompt. This CL assumes that the user declined the prompt, which is the expected outcome of a nullptr. It means that the userChoice promise will be resolved with 'dismissed' when the ExperimentalAppBanners feature is active on desktop. BUG=805744 Change-Id: Ibafe6478e665169194da930ab4d210e62b07b759 Reviewed-on: https://chromium-review.googlesource.com/942582 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#542411}
-
