GitLab

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2700823002
Cr-Commit-Position: refs/heads/master@{#453237}

https://skia.googlesource.com/skia.git/+log/61b721c449d0..ab8e02a4dee7

$ git log 61b721c44..ab8e02a4d --date=short --no-merges --format='%ad %ae %s'
2017-02-27 halcanary SkGradientShader: Fix multi-byte-read-stack-use-after-scope
2017-02-27 mtklein Drop SkRasterPipelineBench N to 15.

Created with:
  roll-dep src/third_party/skia
BUG=694098

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2717363002
Cr-Commit-Position: refs/heads/master@{#453236}

This single callback replaces UrlHashChanged and HistoryStateChanged.

BUG=692331
TEST=page gets translated after same document navigations.

Review-Url: https://codereview.chromium.org/2711363003
Cr-Commit-Position: refs/heads/master@{#453235}

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2703803002
Cr-Commit-Position: refs/heads/master@{#453234}

Merge the addBeginTime and addEndTime methods into a single method
addInstanceTime (that takes a BeginOrEnd argument.) Migrate callers to
the new method, getting rid of SVGSMILElement::handleConditionEvent in
the process.
Also inline some trivial functions in SVGAnimationElement.

BUG=641437

Review-Url: https://codereview.chromium.org/2712343004
Cr-Commit-Position: refs/heads/master@{#453233}

Instead of left and right, callers now specify leading and trailing. For
LTR, leading = left, and trailing = right, and in RTL they are reversed.

BUG=678257

Review-Url: https://codereview.chromium.org/2717603003
Cr-Commit-Position: refs/heads/master@{#453232}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/1c1bd4d..b369f97

$ git log 1c1bd4d..b369f97 --date=short --no-merges --format=%ad %ae %s
2017-02-27 tommi@webrtc.org Remove extra call to TimeUntilNextProcess from within Process.
2017-02-27 kthelgason@webrtc.org iOS AppRTCMobile: Fix SocketRocket bug
2017-02-27 henrika@webrtc.org Simplifies FineAudioBuffer by using rtc::Buffer
2017-02-27 tommi@webrtc.org Revert of Use TaskQueue in IncomingVideoStream (patchset #10 id:320001 of https://codereview.webrtc.org/2716473002/ )
2017-02-27 tommi@webrtc.org Fix race in INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO
2017-02-27 tommi@webrtc.org Use TaskQueue in IncomingVideoStream instead of the PlatformThread + event timer approach.
2017-02-27 sprang@webrtc.org Fix race condition in VideoSendStreamTest.ChangingTransportOverhead

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2723503002
Cr-Commit-Position: refs/heads/master@{#453231}

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2714973002
Cr-Commit-Position: refs/heads/master@{#453230}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a75c463e8416..645770e4019b

$ git log a75c463e8..645770e40 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 achuith Disable testEnsurePCv1Cold and testEnsurePCv1WarmFromScratch

Created with:
  roll-dep src/third_party/catapult
BUG=694722

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2720693005
Cr-Commit-Position: refs/heads/master@{#453229}

https://pdfium.googlesource.com/pdfium.git/+log/eb38d63ba8a8..1d7018e92d31

$ git log eb38d63ba..1d7018e92 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 dsinclair Whitespace change

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2715263002
Cr-Commit-Position: refs/heads/master@{#453228}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/25400c4c..0dae245e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2717343002
Cr-Commit-Position: refs/heads/master@{#453227}

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds more information when dmabuf mmap fails in the crash report
that is uploaded.
It adds the values of the parameters passed to mmap, the validity of the fd
passed to mmap, the last errno set, and the logical size of the buffer.

Additionally, while we used to always report mmap failing as out of memory,
after this CL we'll differentiate based on the last system error set.

BUG=629521

Review-Url: https://codereview.chromium.org/2710183005
Cr-Commit-Position: refs/heads/master@{#453226}

https://skia.googlesource.com/skia.git/+log/9eac2ea77340..61b721c449d0

$ git log 9eac2ea77..61b721c44 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 borenet Roll Recipe DEPS

Created with:
  roll-dep src/third_party/skia

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2722573002
Cr-Commit-Position: refs/heads/master@{#453225}

Network traffic annotation is added to network request of
ntp_snippets/remote/json_request.

BUG=656607

Review-Url: https://codereview.chromium.org/2709483006
Cr-Commit-Position: refs/heads/master@{#453224}

It's no longer necessary now that we've removed the S5s from the perf
waterfall.

Review-Url: https://codereview.chromium.org/2709103006
Cr-Commit-Position: refs/heads/master@{#453223}

Dragging works correctly as well

BUG=648563

Review-Url: https://codereview.chromium.org/2718763002
Cr-Commit-Position: refs/heads/master@{#453222}

Opening links in the regular profile closes the bottom sheet,
so this makes the behaviour for incognito consistent with that
and fixes the issue of the sheet being open while the tab model
switches from regular to incognito.

BUG=690059

Review-Url: https://codereview.chromium.org/2710323003
Cr-Commit-Position: refs/heads/master@{#453221}

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash because there's no PopularSites object.

BUG=682622,696471,681774

Review-Url: https://codereview.chromium.org/2721603002
Cr-Commit-Position: refs/heads/master@{#453220}

BUG=661257

Review-Url: https://codereview.chromium.org/2712703004
Cr-Commit-Position: refs/heads/master@{#453219}

BrowserWindow::CreateBrowserWindow should not assume gfx::NativeWindow is
aura::Window*, so make the code that requires that conditional on USE_AURA.

BUG=None

Review-Url: https://codereview.chromium.org/2714063003
Cr-Commit-Position: refs/heads/master@{#453218}

This change adds docstrings to these scripts, and prints out
these docstrings as description messages when -h is passed.

BUG=692926

Review-Url: https://codereview.chromium.org/2719633002
Cr-Commit-Position: refs/heads/master@{#453217}

Move components/payments:payment_app from common deps to mojo_bindings
public deps since service_worker/service_worker_event_dispatcher.mojom depends on it.

Review-Url: https://codereview.chromium.org/2717933004
Cr-Commit-Position: refs/heads/master@{#453216}

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (also renamed to fillGlyphBufferForResult and updated to return the
    total accumulated advance instead of advance delta)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.

BUG=574136
R=drott@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2715773002
Cr-Commit-Position: refs/heads/master@{#453215}

https://pdfium.googlesource.com/pdfium.git/+log/f2225817ddbe..eb38d63ba8a8

$ git log f2225817d..eb38d63ba --date=short --no-merges --format='%ad %ae %s'
2017-02-27 dsinclair Whitespace change

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2718973003
Cr-Commit-Position: refs/heads/master@{#453214}

CL fixes a typo in ws::Display::num_window_manager_states
method declaration/usage.

TBR=sky@chromium.org

BUG=None

Review-Url: https://codereview.chromium.org/2717333002
Cr-Commit-Position: refs/heads/master@{#453213}

This is a followup change after similar changes already landed in WebRTC.

BUG=none

Review-Url: https://codereview.chromium.org/2722553002
Cr-Commit-Position: refs/heads/master@{#453212}

Update the local FreeType version that is statically linked for
layout tests to 2.7.1 plus patches, the same version that we use
on Android.

The FreeType 2.7.x series enable interpreter version 40 of the TrueType
hinting interpreter, which performs subpixel hinting and results in a
rendering result more similar to newer Windows versions. It does not
produce strict, bilevel-style hinting results as before. This leads to
slightly wider advance widths in many cases for our layout test
baselines.

This allows us to enable the
fast/text/variable-fonts/variable-box-font.html
http/tests/webfont/variable-box-font-arraybuffer.html tests for
OpenType Font Variations, since this FreeType version has
sufficient support for it. It will also help us with testing
color emoji fonts, as well as allowing us to fuse the two
checkouts for freetype-android and freetype2 in the near future.

BUG=274030

Change-Id: I2524902d8f48c9b0fdf2c5d86943c6f9615cccc2
Reviewed-on: https://chromium-review.googlesource.com/444189
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#453211}

The metadata should not be updated in this case.

BUG=696365

Review-Url: https://codereview.chromium.org/2719723002
Cr-Commit-Position: refs/heads/master@{#453210}

Also qualify a straggler include of theme_resource.h (but the .gn file can't
set use_qualified_include=true for this one yet until grit writes a qualified
include for the generated _map.cc file).

BUG=401588

Review-Url: https://codereview.chromium.org/2719823002
Cr-Commit-Position: refs/heads/master@{#453209}

Displays an error message if:
1. PaymentResponse.complete() gets called with 'fail'.
2. The promise returned by PaymentRequestUpdateEvent.updateWith()
doesn't get settled in a reasonable amount of time.

Payment Request will cancel once the user dismisses the error screen.

TBR=rouslan@,sdefresne@,

BUG=602666

Review-Url: https://codereview.chromium.org/2701923003
Cr-Commit-Position: refs/heads/master@{#453208}

When the device wakes up, check and reschedule, if the policy refresh should happen earlier based on system time.

BUG=665343
TEST=Manually tested on lulu device.

Review-Url: https://codereview.chromium.org/2638923002
Cr-Commit-Position: refs/heads/master@{#453207}

There's a issue which is caused by the asynchronousness of audio focus.
When tab B gains focus from tab A, we will first receive the event that
A becomes playing, and then B becomes paused. We should ignore the
notification updates when the tab id mismatches the current notification
and the tab is paused.

BUG=695967

Review-Url: https://codereview.chromium.org/2714993002
Cr-Commit-Position: refs/heads/master@{#453206}

If a task has already been posted to drain the incoming queue of messages,
don't post another.

R=haraken,dcheng
BUG=693595

Review-Url: https://codereview.chromium.org/2716163002
Cr-Commit-Position: refs/heads/master@{#453205}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a6a5b322..25400c4c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2716183004
Cr-Commit-Position: refs/heads/master@{#453204}

Protobuf dependency check is added to build tools and revision updated after that.

BUG=684383
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2716353002
Cr-Commit-Position: refs/heads/master@{#453203}

Following discussions in https://codereview.chromium.org/2711833003,
cookies and auth are disabled for network request of
template_url_fetcher.

BUG=

Review-Url: https://codereview.chromium.org/2717323002
Cr-Commit-Position: refs/heads/master@{#453202}

We used to try to prevent this, as an attempt to make sure that no
fragmentainer group would have overlapping flow thread portion rectangles with
other fragmentainer groups. But that was already easily achievable with e.g. an
empty block between two column spanners anyway.

There is a legitimate reason for the flow thread portion bottom to be above the
top: negative margins.

Introduce MultiColumnFragmentainerGroup::logicalHeightInFlowThreadAt().
Less duplicated code. Some extra care is now needed, to make sure that we don't
end up with negative logical heights.

BUG=688760,683090,683554

Review-Url: https://codereview.chromium.org/2709013007
Cr-Commit-Position: refs/heads/master@{#453201}

The WebContents created in CustomTabActivity.java will certainly
navigate to a page and need a renderer, so there's no reason to delay
renderer initialization. Instead of calling
WebContentsFactory.createWebContents, we call
WebContentsFactory.createWebContentsWithWarmRenderer, which initiates
render initialization immediately.

BUG=695807

Review-Url: https://codereview.chromium.org/2714073003
Cr-Commit-Position: refs/heads/master@{#453200}

It's possible to enable three-finger swipes in System Preferences,
and they result in immediate -swipeWithEvent: calls, unlike two-finger
swipes which should be tracked.

Added code to convert them to ET_GESTURE_SWIPE and to handle them
in BrowserView. Cocoa code handled these events in
BrowserWindowController in a similar fashion.

BUG=691558

Review-Url: https://codereview.chromium.org/2690573002
Cr-Commit-Position: refs/heads/master@{#453199}

Part 2 of adding support for record<K,V> WebIDL types to the bindings
generator.

This CL lands the uncontroversial bits that the idl_* side (as opposed to
the v8_* side) of the scripts will need:
- A new IdlRecordType type that wraps a record<K,V> and holds information
  about its key and value types.
- Code to parse Record nodes and convert them into IdlRecordTypes when
  parsing IDL files.

In practice, this is still a no-op, as we do not do anything with this new
IDL type just yet.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2719913002
Cr-Commit-Position: refs/heads/master@{#453198}