- 09 Sep, 2020 40 commits
-
-
Reilly Grant authored
Now that we are starting to use the Core Location API for geolocation the Chrome app should probably have the location entitlement. Bug: 1051591 Change-Id: I66ff154a77298179737f12d4c00d43153422e325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401269Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805487}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/21205c372020..eedd5bcc37d4 2020-09-09 hjd@google.com Merge "Replace size() == 0 with empty()" 2020-09-09 hjd@google.com Merge "trace_processor: DecompressTrace should fail on non-protos" 2020-09-09 fmayer@google.com Merge "Update docs to reflect heap_profile works on Windows." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3468d611801729a1d3bf91a947c1610cc358d055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805486}
-
David Van Cleve authored
This change expands the Trust Tokens browser tests to cover additional redemption-related cases: redemption to issuer with no tokens -> expect error redemption after successful issuance, to other issuer -> expect error redemption after successful issuance, against same issuer -> should handle server error, failing the operation successful issuance, redemption, another redemption -> should hit SRR cache successful issuance, redemption, issuer-prompted refresh -> should execute redemption despite SRR cache successful issuance, redemption, refresh prompted from non-issuer context -> should error issuance from origins A+B, cors mode redemption to origin A, redirect to origin B -> redemption succeeds, using origin B as issuer issuance from origin A yielding exactly 1 token, cors mode redemption to origin A, redirect to origin A -> redemption succeeds (same token is sent) issuance from origin A, no-cors mode redemption to origin A, redirect to origin B -> redemption succeeds, obtain origin A SRR A prior change (crrev.com/c/2308860) expanded coverage by adding more issuance-related tests; a subsequent change will add more signing tests. Bug: 1071293 Change-Id: Iaa654c99162dbaa735b3b9fe2e3aad359e9c27ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309007 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#805485}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /testing/libfuzzer to source.chromium.org equivalent. This CL was uploaded by git cl split. R=kcc@chromium.org Change-Id: I232ff49bcc35a9f8df60868b6f8bb6b7544b8eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392750 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#805484}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /docs to source.chromium.org equivalent. This CL was uploaded by git cl split. Change-Id: I8014645395846f3e57117b7faaae9dd8c0ef6e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392761Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#805483}
-
Miguel Casas authored
This CL extends the histogram Media.VAVDA.VaapiWrapperCreationSuccess to "2021-08-05", just like its sibling Media.VaapiVideoDecoder.VaapiWrapperCreationSuccess. I took the chance to clean up the owners/cc list. Bug: 1125689 Change-Id: I9a459ac4dcf5480aa60bc08cf0c25ce2b968a087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401511 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#805482}
-
Becca Hughes authored
Moves the promise into the private part of the module this is so we don't show the module until the data has been loaded from the server. Change-Id: Ia770729be44ce0f802d462162132ad09c16e6169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367876Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805481}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /native_client_sdk to source.chromium.org equivalent. This CL was uploaded by git cl split. R=bradnelson@chromium.org Change-Id: I82869389eff1a7fb5d2e04c9843f4a5f4dbc6d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392708 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805480}
-
Sylvain Defresne authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/6f13aaac..e002e68a e002e68a Add support for symbolset to bundle_data targets 32c8eaf9 Add netbsd as a platform c0669368 Allow ".c++" as a C++ source file extension 58d9b89d [format] Sort visibility like deps 484245b9 clang: Fixes to module support b722d8ba Identify current toolchain on error Bug: none Change-Id: I588cb58da4ef228abf1f3e7c75cf557d6ba020d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401160 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#805479}
-
Stephanie Kim authored
Bug: 1066875 Change-Id: I888a0271e4c6cf8e1c0fdfd6a77460e504319c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399559Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#805478}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0a1061da0c7f..97b880e6ff82 2020-09-09 aleksi@sapon.ca Add missing CMake spirv-cross dependency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0d31065838b15da83f79e1354463c9d598bf1c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805477}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ifb4f0aa2f2619a8fed01d5b5667b592e61c7afc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401844Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#805476}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b74c18d1728..4d42f9890bdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1109276 Tbr: davidvc@google.com,adithyas@google.com Change-Id: If9aeed590e88801bb54ebdb19f0c5240f22d11a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401874Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805475}
-
Kyle Milka authored
When content is shared in the Sharing Hub v1 include a preview showing the page favicon, title, and url. http://screen/704072c1-8ebf-4764-8660-0aa67c95dfa4.png Bug: 1120093 Change-Id: Iea5b67f063fcf663917badd84bdeacb5942959dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367442 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805474}
-
David Van Cleve authored
This reverts commit 4f07b55d. Reason for revert: * DevTools browser tests failing on Win7 Tests (dbg)(1) * Culprit range https://chromium.googlesource.com/chromium/src/+log/21a14c8bdf3e885c3131f7f8b94c16bed42df603%5E..3f69f1b139fce1d827865806b5c1432a477e34cd * This is the only DevTools-related change in that range Original change's description: > Roll DevTools Frontend from 88a5d76f5f62 to 214971471446 (2 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88a5d76f5f62..214971471446 > > 2020-09-09 jacktfranklin@chromium.org Expose the live directive from LitHtml > 2020-09-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Ie7af2d4c541d054337a72daa4e11c9530b120927 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401299 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#805365} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd4098ed2e359c4513a2479e3fdd02e1c9249499 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401908Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805473}
-
Noah Rose Ledesma authored
Add an off-by-default flag to enable the redesigned Global Media Controls UI. Bug: 1124401 Change-Id: I499eba511d873d1152bfd58b68948e311a50fc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398889 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805472}
-
Anne Lim authored
Please see bug for design doc. Bug: 1121806 Change-Id: I2b847d3720f4b4c5fc2c9d7db4195c1df5367c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390970Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#805471}
-
Vincent Boisselle authored
Bug: 1126510 Change-Id: I7ca19081e54aaee7d6c4116a0773fda2da14efe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401701 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#805470}
-
Alison Maher authored
As resolved by the CSSWG [1], we should respect system color rules set by the author/user in Forced Colors Mode. This CL adds the logic to accomplish this. [1] https://github.com/w3c/csswg-drafts/issues/4178 Bug: 970285 Change-Id: I9eb4a33f8767f48d0c0a6fd65faec15f11edc140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390865 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#805469}
-
Daniel Classon authored
The initializeKeyboardWatcher WebUI event was missing from the Device Page browser proxy. Add it in, and replace chrome.send in the Manage A11y subpage. Bug: None Change-Id: I5cc568e52ab6c602b1af49794e60368aa9d9f170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399602 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805468}
-
Sven Zheng authored
Adds CI bot for chromeos-amd64-generic-lacros-dbg. Also changes chromeos_amd64-generic_lacros, chromeos_amd64-generic_lacros_rel to use other pre-defined configs and it should have no differences. Bug: 1121667 Change-Id: I6405da5c9ec0464fed59effeadcb3758f18ce927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398976Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805467}
-
Aaron Colwell authored
This change converts the site_url param to a SiteInfo in preparation for making a similar change to DoesSiteURLRequireDedicatedProcess(). This is part of an ongoing process to replace site URL usage in method signatures with SiteInfo. This change also includes a few minor cleanups related to default SiteInstances. This change does not introduce any user visible behavior changes. - Changed CanBePlacedInDefaultSiteInstance() to take a SiteInfo instead of site URL. - Removed allow_default_site_url from GetSiteForURLInternal() and updated callers to handle default SiteInstance cases instead. - Added SiteInfo::CreateForDefaultSiteInstance() and updated code to use that instead of doing a complicated path through ComputeSiteInfo(). - Added SiteInstanceImpl::SetSiteInfoToDefault() to make the conversion to a default SiteInstance a little more explicit. Bug: 1085275 Change-Id: Ib65a41201902c48b13b82172304c8afe15b997fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399016 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805466}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change fixes a particular issue where the Javascript "onfocus()" event doesn't fire when accessibility API's call focus() on a specific node when the frame containing that node doesn't currently have focus. Blink's implementation of "onfocus()" in Document::SetFocusedElement has a condition under GetPage()->GetFocusController().IsFocused() to prevent focus from being fired if the page doesn't have focus. This is correct behavior from Javascript's perspective. From the accessibility side, behavior was already added to focus on the document before focusing on a specific node in https://chromium-review.googlesource.com/c/chromium/src/+/1809943 However, when that change calls into RenderFrameHostImpl::AccessibilityViewSetFocus, if the view is a RenderWidgetHostViewChildFrame, nothing will happen, as that method is empty. So this change completes that method with a simple focus implementation. A browser test was added to confirm that the Javascript onfocus event is properly fired. Bug: 1124067 Change-Id: I5a77fcdfba96da45fe548e93c2da8c9a69181066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389005 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805465}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5fc363ed10fc..149db0ded77e 2020-09-09 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewUnusedDeclarations.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2bf13cc93941fe419490405ab5363573dd7a5ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805464}
-
David Bertoni authored
The ExtensionBrowserTest::ContextType should be used instead of a custom enum. Bug: 1100412 Change-Id: I7871b377cfdb134285b1f2c98b87c268a8779bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390663Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805463}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599651808-76687bf9821b87304e86bb785c30a5b3566b2da2.profdata to chrome-mac-master-1599674142-9f13839562e8523855d1bff685bbea34c58e94a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I97bf632d5444f8b782789347e8c0aae5c1a4602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805462}
-
Adithya Srinivasan authored
Bug: 1122186 Change-Id: Ie474c061c3d115e9c9370485bf02ee3a1c4131c2 Tbr: ssid@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401514Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805461}
-
Sebastien Marchand authored
This only affects profiling builds (coverage or PGO) There's already some logic to wait for all the renderer processes to dump their profiling data on shutdown but this doesn't cover the utility processes and they end up corrupting some profile data files. This CL extends the logic that we already use for the renderer and GPU processes to the other childs. Bug: 1071664, 1124774 Change-Id: I64a1fa247226a3521efc6680bb103c15f7b37cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399819Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#805460}
-
Wenyu Fu authored
1. Move the baseline of the title at the center of the screen; 2. Increase the margin around bottom button group, and made adjust to small screen devices; 3. Center the ToS and UMA components between the title and accept button Bug: 1120842 Change-Id: Ie6ab2f4322d1ffd2e2614987424c636604797c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391268Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805459}
-
Noah Rose Ledesma authored
This change eliminates a possible reference invalidation. Previously, a pointer to an element in a vector was being dereferenced after erase was called. Bug: 1126351 Change-Id: Icfca65af49a1ddc716915dc16d5e4bb6ea45b149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401509Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#805458}
-
Scott Violet authored
The fixes were merged to earlier versions, so the min version requirement can be updated. BUG=none TEST=test only changes Change-Id: I8a0658d62a1fcfac3825f8c6b93d7ce9f714893e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398894Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805457}
-
Yann Dago authored
Use end date when deleting browsing data in storage partition Bug: 1103815 Change-Id: I29d3c7d0b55806579470a1fe96d98061a5b50f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372725Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#805456}
-
David Van Cleve authored
Looks like FindLongString is supposed to be disabled on Mac debug testers but the test name wasn't changed over to the MAYBE_ prefix. Recent flake: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8869619630837658832/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.13.6/0/logs/Deterministic_failure:_FindInPageControllerTest.FindLongString__status_FAILURE_TIMEOUT_/0 Bug: 1096911 Tbr: justincohen@chromium.org,skhapugin@chromium.org Change-Id: I213df7a630ffb9cdf025b3e80a32c389ba14db78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401868Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805455}
-
David Black authored
Bug: 1124581 Change-Id: I6dead04514935b1a6f5a9abc9f6e4398991776f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399455 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805454}
-
Rakib M. Hasan authored
Bug: 1126255 Bug: 1041619 Change-Id: I3699b90e207f560f58c98893665041dba63ea1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399748Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#805453}
-
danakj authored
We allow these directories to work together now and have decided to merge them to simplify understanding the code relationships. Add forwarding headers in content/browser/frame_host/ to make this transition easier. PRESUBMIT and tricum errors are not addressed in this CL as it is just moving code. TBR=avi@chromium.org Bug: 1091083 Change-Id: Id112b1eb4c8de0ac074a593f495dd79f4d02105d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401303 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805452}
-
David Tseng authored
See go /chromevox-touch-gestures Note that the previous mappings were to previous and next word which are now available via three finger left/right to word and then flick up or down. R=akihiroota@chromium.org Bug: 1124454 Test: browser_tests --gtest_filter=ChromeVox*.SwipeLeftRight2 Change-Id: I82e98a1b6da15dd82d0ff9c55ce98cdedb99aad1 AX-Relnotes: makes ChromeVox two finger swipe left and right perform escape and return respectively. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386009 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805451}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc952b0b. With Chromium commits locally applied on WPT: c07a387a "Make DefinitelyNewFormattingContext return true for SVG foreignObject" eadf7030 "Implement Animation::setTimeline" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Id849639ce9fa7f652eb9d8768b91f5d8e3b601c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401760Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805450}
-
Pavol Marko authored
Update the Cert Provisioning UI when the state of a certificate provisioning process changes. Rate limit updates to the UI to max 1 update per 2 seconds to avoid flickering / performance issues. Bug: 1081396 Test: unit_tests Change-Id: If539d19885e9e2804dfc9d3f662a58dff8f0be53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377729Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805449}
-
Donn Denman authored
Removes the special treatment of plain HTTP pages with respect to privacy. These pages were considered privacy-insensitive, but now we treat them the same way as secure HTTPS pages. BUG=1124397 Change-Id: Ic3f5640ffa020e7f4656a78965b6f87662c039a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393526 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#805448}
-