GitLab

Avoid the race by:
1. Calling InitApplicationContext() from CronetLibraryLoader.ensureInitialized()
2. Remove other calls to InitApplicationContext()
3. Make ChromiumUrlRequestContext() call CronetLibraryLoader.ensureInitialized()
Also:
4. Remove duplicate NetworkChangeNotifier initialization from ChromiumUrlRequestContext()
5. Remove now duplicate CronetLibraryLoader.ensureInitialized() call from ChromiumUrlRequestFactory()

BUG=465392

Review URL: https://codereview.chromium.org/991923002

Cr-Commit-Position: refs/heads/master@{#319729}

Revert of base: Fix/add header #ifndef guards. (patchset #2 id:20001 of https://codereview.chromium.org/985003004/)

Reason for revert:
This seems to be causing tree closing compile failure https://build.chromium.org/p/chromium/builders/Android/builds/36135/steps/compile/logs/stdio.

Original issue's description:
> base: Fix/add header #ifndef guards.
>
> Header guards should be defined based on the path and file name of the
> header file. Some headers have it wrong, some are missing the guards,
> and some just have the matching comment wrong.
>
> R=Nico
> BUG=464816
>
> Committed: https://crrev.com/301b392761fd8f66f3a701ab1dd011c6e7a55e19
> Cr-Commit-Position: refs/heads/master@{#319722}

TBR=thakis@chromium.org,danakj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464816

Review URL: https://codereview.chromium.org/989343002

Cr-Commit-Position: refs/heads/master@{#319728}

This patch enables javascript code injection like <webview>.executeScript({code: ...}), but does not include file injection like <webview>.executeScript({file: ...}). File injection will be in another patch.

BUG=434081

Review URL: https://codereview.chromium.org/942533003

Cr-Commit-Position: refs/heads/master@{#319727}

Simple move of small chucnk of code out of glue layer.

BUG=464491

Review URL: https://codereview.chromium.org/984273002

Cr-Commit-Position: refs/heads/master@{#319726}

This reverts commit eabf1f5b.

Removing the toggle in about:flags breaks a workaround for users who
have nonstandard nsswitch configurations for hosts.

Revert the removal until we properly check nsswitch.conf before
assuming a standard configuration.

BUG=117655

Review URL: https://codereview.chromium.org/987133003

Cr-Commit-Position: refs/heads/master@{#319725}

Test a log method that could be helpful for debugging.  Also inline SpdyPriorityIR constructors for code convergence.

This CL lands server change 87053738 by birenroy.

BUG=

Review URL: https://codereview.chromium.org/988733003

Cr-Commit-Position: refs/heads/master@{#319724}

BUG=455057

Review URL: https://codereview.chromium.org/980353002

Cr-Commit-Position: refs/heads/master@{#319723}

Header guards should be defined based on the path and file name of the
header file. Some headers have it wrong, some are missing the guards,
and some just have the matching comment wrong.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/985003004

Cr-Commit-Position: refs/heads/master@{#319722}

Have BluetoothAdapterProfileChromeOS objects managed through
BluetoothAdapterChromeOS, avoiding problems where references were being
left behind in BluetoothSocketChromeOS after deletion.

Adds some unit tests to confirm lifecycle works correctly even when
multiple profiles are requested simultaneously.

This is a resubmit of https://codereview.chromium.org/935383003/ after a revert
for LSan test failures https://codereview.chromium.org/975323002/, a patch with
just changes from the old CL can be found there.

BUG=457978
R=armansito, isherman@chromium.org, keybuk

Review URL: https://codereview.chromium.org/982593002

Cr-Commit-Position: refs/heads/master@{#319721}

Per the explanation in the bug, ui/ios should not have been created in
the first place; this code belongs in the ui/gfx subcomponent.

BUG=446643

Review URL: https://codereview.chromium.org/983413004

Cr-Commit-Position: refs/heads/master@{#319720}

Code in AnalysisCanvas::willSaveLayer was treating the case of layers
composited with kSrc_Mode as if they did not affect the destination,
when in fact it is kDst_Mode that does not affect the destination.
As a result of this error, the compositor was culling layers that
contained opaque canvas elements, which are composited with
'src' for performance.

BUG=464694
TEST=skia_unittest AnalysisCanvasTest.SaveLayerWithXfermode

Review URL: https://codereview.chromium.org/990983003

Cr-Commit-Position: refs/heads/master@{#319719}

Review URL: https://codereview.chromium.org/991953002

Cr-Commit-Position: refs/heads/master@{#319718}

Causing failures on perf waterfall.

NOTRY=true
BUG=465446

Review URL: https://codereview.chromium.org/989323002

Cr-Commit-Position: refs/heads/master@{#319717}

Make all the LOGs that follow DRM calls PLOGs since we're interested in
the error message.

Also add a few more LOGs during device probing just in case we end up in
odd states where the DRM device is controlled by another process and
we're trying to take ownership.

BUG=none

Review URL: https://codereview.chromium.org/991963002

Cr-Commit-Position: refs/heads/master@{#319716}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/86e31a1..d2737ad

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/995473002

Cr-Commit-Position: refs/heads/master@{#319715}

BUG=442033
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/990253003

Cr-Commit-Position: refs/heads/master@{#319714}

Revert of [Android] Fix a flicker in stopping Chrome (patchset #11 id:200001 of https://codereview.chromium.org/843883002/)

Reason for revert:
Caused regression with lockscreen battery consumption.

Original issue's description:
> [Android] Fix a flicker in stopping Chrome
>
> Currently, we draw a blank frame as we release resources in onStop().
> This can be prevented if we hide the tab when the window gets hidden instead of
> on activity stop.
>
> BUG=434401
>
> Committed: https://crrev.com/e4b1990c9d49fd9734940fa863513ad43b82c6e7
> Cr-Commit-Position: refs/heads/master@{#311809}

TBR=tedchoc@chromium.org,dtrainor@chromium.org,yusufo@chromium.org,aelias@chromium.org,sievers@chromium.org,changwan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=434401

Review URL: https://codereview.chromium.org/990183004

Cr-Commit-Position: refs/heads/master@{#319713}

Now XMPP is implemented directly in remoting/signaling instead of
relying on WebRTC. The new code is mostly just a translation of
the XMPP implementation we use in the webapp from JavaScript to
C++ and uses the same layout and class names, except that the main
class is called XmppSignalStrategy instead of XmppConnection.

BUG=459756, 443806, 417336

Review URL: https://codereview.chromium.org/958703003

Cr-Commit-Position: refs/heads/master@{#319712}

Review URL: https://codereview.chromium.org/989913002

Cr-Commit-Position: refs/heads/master@{#319711}

BUG=

Review URL: https://codereview.chromium.org/989673002

Cr-Commit-Position: refs/heads/master@{#319710}

The request and response headers can change between the original request
and the requets that receives 304. Make sure the state of the cached entry
reflects the latest headers.

BUG=453306
TEST=net_unittests

Review URL: https://codereview.chromium.org/976373005

Cr-Commit-Position: refs/heads/master@{#319709}

R=rch@chromium.org

Review URL: https://codereview.chromium.org/985383003

Cr-Commit-Position: refs/heads/master@{#319708}

Blink's CL exposes aria row and column headers.

BUG=451047

Review URL: https://codereview.chromium.org/955373002

Cr-Commit-Position: refs/heads/master@{#319707}

Upstreams miscellaneous helper classes and utility files that don't
have other dependencies, and can thus be built and tested as-is.

BUG=464810

Review URL: https://codereview.chromium.org/988383002

Cr-Commit-Position: refs/heads/master@{#319706}

This provides a central location for application-specific cleanup code and also
allows the "no error message on cancel" logic to be made application-agnostic.

Review URL: https://codereview.chromium.org/988963003

Cr-Commit-Position: refs/heads/master@{#319705}

The observer is running on another pipe which could cause race conditions and
make the implementation unnecessarily complex. This CL drops the observer and
merges the config update into the main mojo::DemuxerStream interface.

BUG=460154
TEST=No DCHECK fires and playback works. mojo:media_test passes.

Review URL: https://codereview.chromium.org/981423002

Cr-Commit-Position: refs/heads/master@{#319704}

Android lint complains when we use APIs added to Android after ICS
because these will causes crashes if used on ICS devices. In cases where
we only call the API on later versions of Android, we need to annotate
the method or class with @TargetApi to tell Android lint that each
particular use of the new API is safe. This adds a bunch of such
@TargetApi annotations.

BUG=266140

Review URL: https://codereview.chromium.org/969883002

Cr-Commit-Position: refs/heads/master@{#319703}

Review URL: https://codereview.chromium.org/991783005

Cr-Commit-Position: refs/heads/master@{#319702}

The chrome-specific web_view event code was not fully updated during the guest_view_events refactor, resulting in the one chrome-specific event, 'contextmenu', not working properly. This patch updates that code.

BUG=465194

Review URL: https://codereview.chromium.org/989173005

Cr-Commit-Position: refs/heads/master@{#319701}

Make it to use base::android::OnJNIOnLoad interface.

BUG=447393

Review URL: https://codereview.chromium.org/984163002

Cr-Commit-Position: refs/heads/master@{#319700}

Same as previous fix, but for mouse buttons.

The SYN_DROPPED part is N/A because that is handled by libevdev.

BUG=463002
TEST=Tested unplug by unplugging mouse with left button held.
  Left mouse button gets properly released rather than being stuck.
  (NB: Could not reproduce without adding a delay to expose the race).

Review URL: https://codereview.chromium.org/983213003

Cr-Commit-Position: refs/heads/master@{#319699}

Adds the ability to extract which applications can handle a particular
intent.

BUG=464934

Review URL: https://codereview.chromium.org/988963004

Cr-Commit-Position: refs/heads/master@{#319698}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/13e51f9..86e31a1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/994643002

Cr-Commit-Position: refs/heads/master@{#319697}

Revert of Re-enable the new SQLitePersistentCookieStore load strategy. (patchset #1 id:1 of https://codereview.chromium.org/953993002/)

Reason for revert:
This CL causes hangs during shutdown.

https://code.google.com/p/chromium/issues/detail?id=465271

Original issue's description:
> Re-enable the new SQLitePersistentCookieStore load strategy.
>
> When I first turned on the new load strategy, it caused deadlocks during
> shutdown. I found and fixed the bug in SequencedWorkerPool.
>
> BUG=448910
>
> Committed: https://crrev.com/043d6b497dda7a39138eca1fb9df89ee340e543b
> Cr-Commit-Position: refs/heads/master@{#318305}

TBR=erikwright@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448910

Review URL: https://codereview.chromium.org/992723002

Cr-Commit-Position: refs/heads/master@{#319696}

Chrome Apps (e.g. hangouts etc.) can set a custom shape for the windows. Make
sure the shape is translated correctly in hidpi environment.

BUG=461120
R=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/985993002

Cr-Commit-Position: refs/heads/master@{#319695}

BUG=463892

Review URL: https://codereview.chromium.org/988003002

Cr-Commit-Position: refs/heads/master@{#319694}

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/983223004

Cr-Commit-Position: refs/heads/master@{#319693}

autosize is no longer used in <extensionoptions> and it adds a lot of complexity.

I eventually want <extensionview> and <extensionoptions> to merge to reduce maintenance
overhead, especially on the <webview>/GuestView team. This dead code makes it harder to reach that objective.

BUG=442033

Review URL: https://codereview.chromium.org/990223002

Cr-Commit-Position: refs/heads/master@{#319692}

BUG=462246
TEST=Start Chrome with --enable-new-avatar-menu and a single, local profile.
Sign in. The avatar button should correctly update and display the synced name.

Review URL: https://codereview.chromium.org/974373002

Cr-Commit-Position: refs/heads/master@{#319691}

We were putting the wrong FrameTreeNode ID on the OpenURLParams
when a navigation was destined for a different WebContents.

BUG=464944
TEST=Shift click a link to https://chrome.google.com/webstore
     in --site-per-process mode.

Review URL: https://codereview.chromium.org/988953003

Cr-Commit-Position: refs/heads/master@{#319690}