- 03 Mar, 2020 40 commits
-
-
Kush Sinha authored
This reverts commit ea6fab21. Reason for revert: AccountReconcilor has a non-predictable end-state. It can end up in failure or success states depending on race conditions. See https://crbug.com/1053905 for details. Original change's description: > Remove OAuth2LoginVerifier > > Remove OAuth2LoginVerifier and make the OAuth2LoginManager observe > AccountReconcilor instead of doing /MergeSession. > > DD: http://doc/1fACI5GQgXvmlmEJj6aPedazXeDZAZPw9jH_E91WGe3w > > Bug: 977137 > Change-Id: Iaa21dd12f0ca6568d920f135bbfdddf3f9def088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674099 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738673} TBR=xiyuan@chromium.org,droger@chromium.org,holte@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Bug: 977137, 1053905 Change-Id: I5f7a92732c367f3fa07bc9ac0a688a5c4e3b4be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081430Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#746402}
-
Zhuoyu Qian authored
This CL update the functions GetOriginsForTypeOnFileTaskRunner and GetOriginsForHostOnFileTaskRunner of FileSystemQuotaUtil to use dedicated Origin type instead of GURL. Change PluginPrivateDataDeletionHelper::CheckOriginsOnFileTaskRunner also. Bug: 598424 Change-Id: Ica53219f4f7acbf457195a7cb964b404bf7af98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074842Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746401}
-
Manuel Rego Casasnovas authored
In r745093 we fixed an issue with sticky elements with strict containment. However that introduced a performance regression in the following test: perf_tests/paint/contain-update-layer-tree.html This change applies the fix only for sticky positioned elements so the performance tests comes back to previous numbers. Change-Id: I686e2cfee13a3e44f5f67d05ed7526b6f01d4e5f Bug: 1057255,1057257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083030Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746400}
-
Maksim Ivanov authored
Change the color of the "smart card" ("chip") icon displayed in Ash Login Screen to use the value recommended by the UX designers: #E8EAED. Implementation-wise, this desired color is denoted as "GoogleGrey200". Bug: 1024254 Test: log in via a smart card and log out, take screenshot, verify that the "smart card" icon displayed under the user pod has colors #E8EAED Change-Id: I15d53810434975b80d1ee5c0fccaba18a1b8c1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085071Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746399}
-
David Bokan authored
As a result of pre-commit input suppression (see https://crbug.com/958424 for details and CLs), old expectations in the compositor that if we receive a ScrollUpdate or ScrollEnd we must have seen a ScrollBegin are no longer true. A begin might have been suppressed. Most of input handling code already early-outs and handles this case gracefully so we just remove DCHECKs here that guard this behavior. ScrollEnd must also early-out. Bug: 1041666 Change-Id: Ie3f2b523100f40f59fee121c4be43f4a6870c8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083934Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746398}
-
Gauthier Ambard authored
Tests are passing locally. Fixed: 1054372 Change-Id: I6ad38e4ea1576eef974c542e7b03dd85637f883c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074257Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746397}
-
Tim van der Lippe authored
This was replaced by an e2etest in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2046553 TBR=aerotwist@chromium.org Bug: 1044632 Change-Id: Ib7b0b4ceede6a14688e3eaa8a7cd94d7dfa45d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084812Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#746396}
-
Dan Harrington authored
Task now exposes Execute(OnceClosure) instead of Run(), and can be called outside of a task queue, or from within another task. This change was made so that tasks to be composed of multiple smaller, nested tasks. We plan to use this feature in components/feed/v2. An 'upload' task can be run on its own, or as an intermediate step in a 'load' task. Change-Id: Icbe64021b8fecd8abbc09c64d2d15dfab2e2708c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078786 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#746395}
-
Yann Dago authored
Bug: 1033573 Change-Id: Ia481923c34fe9deb83f785582229eac8b8a7f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083601 Auto-Submit: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746394}
-
Yi Gu authored
The test fast/scroll-snap/snaps-after-keyboard-scrolling.html started to be flaky on fast path after being enabled on it in crbug.com/878878. Bug:878878, 1056957 Change-Id: I506f9a63ac10c059b7e9e30da29c36826a2d6bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084110Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746393}
-
Aaron Leventhal authored
For <table style="display:foo">, do not immediately assume it is for layout, just because there is no table layout interface. A follow-up CL will transform IsDataTable() to rely much more on DOM interfaces, rather than layout interfaces. Bug: 1011067 Change-Id: Iebb6224d311f09b1b3bf6e6aa08efbe7393b42d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079267 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#746392}
-
Nazerke authored
This CL modernizes the ContextMenuCoordinator to use |browser| in the initializer. HistoryTableViewController was also updated to use browser to get |browserState| value. Bug: 1029346, 1050693 Change-Id: I0763c2e5c2b7f34b4b2af3cf217f830018696981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083310 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746391}
-
Mugdha Lakhani authored
Bug: 1052375 Change-Id: Iead6adcf4d00aab75be10eb8c2ef3a73dfbb5492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083454Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#746390}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/189353b3..5f37cd3c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id011a3765fb2ef6c56189d447178f8459a00dd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084831Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746389}
-
Jérôme Lebel authored
SigninCoordinators should always be stopped and released at the end. This was not done when the add account coordinator is not successful. Bug introduced with: crrev.com/c/2064945 Bug: 971989 Change-Id: Idac9d4019d499eeeeab0e36a8f73828145916748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084851 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746388}
-
Yifan Luo authored
Delete both network::features::kFetchMetadata and network::features::kFetchMetadataDestination flags. Bug: 1054543 Change-Id: Iab8ecca52fe019c48dc27ced7fc832ca576fe22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084553Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#746387}
-
Fredrik Söderquist authored
It's always the ComputedStyle of the LayoutObject passed as the first argument. Bug: 1028063 Change-Id: I3f87f42ae51d5d6013b71989054e0594f55a283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083306Reviewed-by:
-
Maksim Ivanov authored
Introduce a separate variable that allows the user of the <pin-keyboard> Polymer element to control the "letter-spacing" attribute of the input field. This fixes the flaky issue introduced in https://crrev.com/c/2069324 that was sometimes causing the "letter-spacing" attribute to be not set on <pin-keyboard>'s input at all. (Presumably, the problem was due to self-referring to the variable from its var() expression.) Bug: 1051859 Test: start SAML login using a smart card, type 8 digits in the PIN dialog, verify that all 8 dots fit into the input field but the dots aren't touching each other Change-Id: I0deb28782ddcd320bc3b6f35ddf10c1da0491233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082378 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL refactors the tab restoration classes for multi-window, scoping some functions to a Browser, and removing use of TabModelList. Non-functional changes: * TabRestoreDelegateImplIOS (which is the iOS implementation of the sessions::LiveTabContext API, not "TabRestoreDelegate") was a keyed service. It's renamed to LiveTabContextBrowserAgent and (accordingly) scoped to a Browser (on desktop, Browser directly implements this API. * The associated factory class is removed. * TabRestoreServiceClient is updated to use Browser and BrowserList instead of TabModel and TabModelList. * The RestoreTab() helper function is updated to take a Browser param instead of a BrowserState. FUNCTIONAL CHANGE: Previous to this CL, IOSChromeTabRestoreServiceClient's implementation of CreateLiveTabContext() simply returned the (single) BrowserState- scoped sessions::LiveTabContext implementation. Looking at the desktop implementation of this function, it appears to create a new window: https://cs.chromium.org/chromium/src/chrome/browser/sessions/chrome_tab_restore_service_client.cc?type=cs&g=0&l=35 While that might be a desirable behavior when multi-window is supported, we don't yet have a set of hooks available to do that cleanly; nor do we want to instead return some arbitrary, already-opened window. It looks like the call sites for this (in TabRestoreServiceHelper) are: - When restoring a session by ID with the WINDOW type, and - When restoring a tab without a provided context or with the NEW_WINDOW disposition. ios/ doesn't currently have code paths that do either of these, and this CL adds a check in the RestoreTab helper to guard against them. Then, the implementation of CreateLiveTabContext() now is a NOTREACHED() no-op. crbug.com/1056596 tracks adding support for window restoration with multi-window. Bug: 1056208 Change-Id: Ib51ea7ea6efd3a51e6ec07d031e1a3ae1203579b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078915 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746384}
-
Xi Han authored
CachedFeatureFlag values are set by @Features.EnableFeatures and @Features.DisableFeatures after this CL. Bug: 1056327 Change-Id: Ie4bbc9f21908ef3f7e9336c7d558165a54837381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075972 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746383}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/56364b6b6026..bbbd9a2a1f41 git log 56364b6b6026..bbbd9a2a1f41 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 cepheus@frii.com Fix #1843: Handle built-in function output parameters to a swizzled arg Created with: gclient setdep -r src/third_party/glslang/src@bbbd9a2a1f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I79a75d05ef8e8faf7bae1a2584130517ddf9e3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746382}
-
Anna Malova authored
Bug: 1007815 Change-Id: I1cf38ed3882ae5c01690cd18e706deffef7e91c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083485Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746381}
-
Ian Clelland authored
This affects the parsing and serialization of tokens in structured headers draft 15 and above. When operating in Draft 9 mode for backwards compatibility, a character sequence beginning with an asterisk will be parsed as a byte sequence instead. Bug: 1048756 Change-Id: I5b1e2a57501a2e2dedb1183f495f71d75146c46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084711Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#746380}
-
Anna Malova authored
Bug: 1007815 Change-Id: I72241731610b566ca062ff95f8fd94289999b3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083327Reviewed-by:
-
Harald Alvestrand authored
This is a read-only attribute revealing a detail from the SDP offer/answer exchange. Spec: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-cantrickleicecandidates Bug: chromium:708484 Change-Id: I8fab2050bac0237cb513d70c8c257a54bdc0a4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082512Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#746378}
-
Anna Malova authored
Bug: 1007815 Change-Id: I55de9222c2fe53148a3e73524db8cc668a34b4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083324Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I225112c7fcd440a7f67980ccca934593d6110e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083182Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I7dae325790cbd7f9cca45659ee0f7ec9ec27f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083544Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I09fad24dfee175d0456e12333b063ac57b2c0193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083543Reviewed-by:
-
Jonathan Backer authored
This reverts commit d32b3d49. Bug: 1037939 Change-Id: I150adeacc788d6e06e7c41b7ce00b4edd8cddc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989034Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e36af5c1ab9b..db533a37a8ca Created with: gclient setdep -r src-internal@db533a37a8ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idecc3a5456dff651e768734dae29f4669929462b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083964Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746372}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/06b6db68ff7e..6e9087162a1c git log 06b6db68ff7e..6e9087162a1c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 dneto@google.com Get spirv.hpp from SPIRV-Headers, not Glslang (#992) Created with: gclient setdep -r src/third_party/shaderc/src@6e9087162a1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I3d264570307be0a48f0f533a645d85cb9f1c4816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083966Reviewed-by:
-
Yoichi Osato authored
That's because we won't send body with the request. This CL also refactors CopyHeadFrom function to take reference than pointer because all arguments must not be null. Bug: 787704 Change-Id: I426c0251772cede8d130a24c298f99d005ac345c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082853Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#746370}
-
Tim van der Lippe authored
This test was replaced by an e2etest in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2083316 TBR=aerotwist@chromium.org Bug: 1044632 Change-Id: Ie1fd5772d3139aa4b61a725cd271bd4bf6feec60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084853Reviewed-by:
-
shivanigithub authored
Change-Id: I0225bfb6a17f9a914eb317ee814d729778fc4e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079095Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#746368}
-
Ehimare Okoyomon authored
Changed edit_exception_dialog.js from site settings to follow the same exception pattern setting as add_site_dialog.js Bug: 1057091 Change-Id: I7d1337197df0fc7bc294df077eb433b90820c661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082379 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746367}
-
Bret Sepulveda authored
To ensure permission bubbles are consistent with other bubbles in width, this patch tweaks CalculatePreferredSize so that it is always DISTANCE_BUBBLE_PREFERRED_WIDTH dips wide instead of sometimes snapping to a larger size. Change-Id: Ifed85665168ffccf2d8fda1e34f489a51c11f085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082570Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#746366}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/853789cdfe3c..96c2eb6258ae git log 853789cdfe3c..96c2eb6258ae --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Move nanobench flags logic into gen_tasks_logic/nanobench_flags.go 2020-03-03 borenet@google.com [recipes] Compute nanobench flags in gen_tasks 2020-03-03 borenet@google.com [recipes] Move nanobench flags to a separate file Created with: gclient setdep -r src/third_party/skia@96c2eb6258ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I888c5a94b2babf88cdcce4b0cdd27c9e3c2d6078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083963Reviewed-by:
-
Stepan Khapugin authored
Groups all per-window shutdown code together and moves it before the other shutdown code to match expected behaviour of shutdown in multiwindow world. Bug: none Change-Id: I7abf63beecd3d2d6c0479da9c9a6f31477f3ae53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084595Reviewed-by:
-
Stepan Khapugin authored
Moves AppURLLoadingService to SceneController. Change-Id: Ifc8053cf455918fed6839646be65f22fd7d35a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081427Reviewed-by:
-
