- 05 Aug, 2019 40 commits
-
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=scottmg@chromium.org Change-Id: I6aaf63a8b1094b302aad010f3e48e009fe8a04fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733549 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#684010}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=thakis@chromium.org Change-Id: I55e7922bb8f294bd9286a0ea3dab4753815089ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733608 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Carlos Caballero authored
Remove references of MessageLoopForIO in /fuchsia/mojom/fidl_interface_request_mojom_traits_unittest.cc MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=dominickn@chromium.org Change-Id: I9d67cc20b478d774cd08d1b6101a4da882b7e71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733614 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#684008}
-
Takuto Ikuta authored
The entry is only for linux_layout_tests_root_layer_scrolls try builder. Bug: 846740 Change-Id: I4b9c7ea84e15d5dea02569d6785b46b7fe20e4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734834 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#684007}
-
Takuto Ikuta authored
I think it is sufficient to specify dimensions_sets only in builders config. No behavior change intended. Change-Id: I36c50d22f5d5b56f49d54c838848eb59565b7a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735451 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Currently default os dimension seems to be specified in chromium_swarming module. https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_swarming/api.py?l=460&rcl=4134bbc385e6082a8b1ad3ebaa0fb9872e1d4915 So this does not change os dimension of swarming tests triggered from bots. Bug: 954450 Change-Id: I67f184fb125a15a2b8c9396bfa7c1d98c3080617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574876 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
This changed ensures that 'hour' and 'minute' are always specified when using the 'Time' property. BUG=924762 TEST=Unit tests. Change-Id: I8c3ed78c4d8decbf1fb758d532af8014c5fd9cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732680Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#684004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00c9f0dc9225..96555343063b git log 00c9f0dc9225..96555343063b --date=short --no-merges --format='%ad %ae %s' 2019-08-05 egdaniel@google.com Put read and output swizzle back on gl format table. Created with: gclient setdep -r src/third_party/skia@96555343063b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I7ff010067c4b2df8829bde3b3e0f6ebf5728182d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684003}
-
Mitsuru Oshima authored
Bug: None Change-Id: Icc08efd9ec16d63e4ba841778a90ce10d662b6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733583 Auto-Submit: Mitsuru Oshima (OOO 8/5,6) <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684002}
-
Theresa authored
BUG= Change-Id: If1a47d7a8b4825afc6ba9b0e1f42832cb0f28281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733859 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684001}
-
Aaron Gable authored
This reverts commit 68c22826. Reason for revert: This breaks PRESUBMIT.py / the chromium-presubmit bot. Unclear why this was able to pass those checks while landing, but now new tryjobs on top of this are failing. Original change's description: > Add comment to bnc in net/OWNERS. > > See https://crrev.com/c/1704282 for context. > > Change-Id: Ifcfd3b7b9b7867176a90a092056f453fb74124c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736692 > Auto-Submit: Bence Béky <bnc@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683980} TBR=rch@chromium.org,bnc@chromium.org Change-Id: I7398c0c42f872f747e6be40fe7ed3bcf08ef028f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737007Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#684000}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a81193b1377..0453b000cc33 Created with: gclient setdep -r src-internal@0453b000cc33 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I1c2fa3cc128646669d5c97287c7bf63a3469f1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736614Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683999}
-
jongkwon.lee authored
Re-enable interactive uitests that were disabled for crbug/823543 and crbug/824418. These issues are because of crbug/641969 which is no longer reproduced on MacViews browser. BUG=823543, 824418, 641969 Change-Id: Id5de29e9d95962f98748d140469f4709fcbd4fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699665 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683998}
-
Chris Sharp authored
This test is often failing on Linux ChromiumOS MSan Tests. TBR=pmarko@chromium.com Bug: 990817 Change-Id: I3bffd39a40823d7ea2dbb80f4f03b2bbf434b891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736435Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683997}
-
Ivana Zuzic authored
A new signature for ChangeSavedPassword takes the index of a password entry, instead of its sort_key, because Android finds passwords by index, rather than by sort_key. Bug: 377410 Change-Id: I972091c7f59c6a0d3c9cc4cbbabea276fcba5c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731829Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#683996}
-
Matt Jones authored
The ModelListAdapter now uses data providers, this patch updates the tutorial to reflect that. Bug: 967054 Change-Id: I012e0451dc0d72102fdc8b07d05ecbb9d051fa37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680652Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683995}
-
Javier Ernesto Flores Robles authored
Bug: 976645 Change-Id: Id5de30ade3821d6ace315411a41932841b2370c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735583 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#683994}
-
Javier Ernesto Flores Robles authored
Also adds a dark color for iOS 12 compatibility. Bug: 976645 Change-Id: Ia5fca38c00fa9f5cbe7275093695ab4c979e4a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731846Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#683993}
-
chrome://omniboxmanuk authored
Change-Id: Idd54e0d77d3e7a5949db9c284acb319c208f33da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733092Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Chris Sharp authored
This reverts commit 0c4a415f. Reason for revert: reverting to see if this is causing consistent failures on Linux MSan Tests, browser_tests, DevToolsSanityTest.TestDeviceEmulation (timeout) Original change's description: > Paint non-fast scrollable regions for resize handles > > Non-fast scrollable regions are regions on a cc::Layer where the > compositor should not handle scroll events. These are primarily for non- > composited scrollers but are also used for resize handles and plugins. > This patch paints non-fast scrollable regions for resize handles. > > The interesting code change is in ScrollableAreaPainter::PaintResizer > where we now emit a ScrollHitTestDisplayItem for resizers. This fixes > a class of bugs such as non-fast regions being on the wrong cc::Layer > (https://crbug.com/968691) and having the wrong offset > (https://crbug.com/989038). > > Design doc: > https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj > > Bug: 864567, 968691, 989038 > Change-Id: I8193077279617418433306912d712c31d99149f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730521 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683670} TBR=pdr@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864567, 968691, 989038, 990692 Change-Id: I1986b58522d7658109155e811419a6d3ae1d2dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736702Reviewed-by:
-
Omer Katz authored
Replaced --enable-blink-features=HeapConcurrentMarking with --enable-features=BlinkHeapConcurrentMarking. Bug: 989278 Change-Id: Iab12b8784f413d6bb5e47b3c0a360d34dab9ddd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728585 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#683990}
-
Richard Knoll authored
When we receive a high priority push message, Android puts us in a temporary whitelist to launch background tasks. This is especially important if the device is in doze mode, as no other tasks (e.g. scheduled via JobScheduler) will run at that time. We try to start our service and fallback to the default BackgroundTaskScheduler if we were not whitelisted. This new behavior can be enabled on a per-subscription basis by passing a flag to the InstanceID::GetToken call. This CL includes a refactoring of that method to be able to pass multiple flags, instead of the |is_lazy| flag alone. TBR=khorimoto@chromium.org,carlosk@chromium.org,dcheng@chromium.org Bug: 987192 Change-Id: I534478dbe535162bdc59ee4b3eac2cd5f77e286f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710317 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#683989}
-
Chris Sharp authored
Test is often timing out on Linux ChromiumOS MSan Tests bot. TBR=alemate@chromium.org Bug: 990362 Change-Id: Id5cf58d7cbbf9045bad7d12f72812525371ba298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736432Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ad5c4accad00..3d351c688586 git log ad5c4accad00..3d351c688586 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 srte@webrtc.org Revert "Adds PeerConnection scenario test framework." Created with: gclient setdep -r src/third_party/webrtc@3d351c688586 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: If1b5572a10ef7457959f38ccb8700400b3a029c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736107Reviewed-by:
-
Friedrich Horschig authored
In another CL, I noticed that the CreditCardAccessoryMediator class is unused. Since there were no tests, nobody noticed that the metrics for it were never recorded. This CL unifies all three sheets to use the same mediator which records the same metrics (impressions for actions and the manage XX link). Tests are added for all metrics and the credit cards in general. Bug: None Change-Id: Iea80f67eca31ab1287d92ca0178789fe271aba47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736667 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#683986}
-
Caitlin Fischer authored
Change-Id: I51b476895be6d7b072e899e28f4d53f84b21f598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736705 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#683985}
-
Fan Yang authored
This reverts commit https://chromium.googlesource.com/chromium/src/+/9f9dd5090001e41fb0a33f08cc5bb1779ed28148. $ git log 7deaf37e9..c691071e9 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 dschinazi Add missing QUIC_EXPORT_PRIVATE to test client ALPN 2019-08-02 fayang Fix tests to make chromium compile. 2019-08-02 fayang Fix a chromium compile error where local variable shadows member variable. 2019-08-01 dschinazi Support 20byte connection IDs in QUIC v99 2019-08-01 dschinazi Add connection ID length checks 2019-08-01 dschinazi Make QUIC enforce ALPN when using TLS handshake 2019-07-31 bnc Add helper methods to QpackSpdyStreamTest instead of hard-coding QPACK-encoded headers. 2019-07-31 fayang gfe-relnote: Close QUIC connection is there are too many (> 1000) buffered control frames in control frame manager. Protected by gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames. 2019-07-31 renjietang Add version DCHECK for SPDY frames that are already replaced by HTTP/3 frames in v99. 2019-07-31 dschinazi Deprecate quic_do_not_override_connection_id 2019-07-31 dschinazi Fix a QUIC end_to_end test when some flags are enabled 2019-07-31 bnc Remove Http3FrameLengths. 2019-07-31 bnc Change HeaderBlocksForStream from QuicDeque to std::list. 2019-07-31 fayang gfe-relnote: Let GFE be able to use HTTP2(tree-style) priority write scheduler in QUIC and enable it via a connection option H2PR. Protected by gfe2_reloadable_flag_quic_use_http2_priority_write_scheduler. 2019-07-31 dschinazi Introduce IsConnectionIdLengthValidForVersion 2019-07-31 fayang gfe-relnote: Replace SpdyPriority priority with const spdy::SpdyStreamPrecedence& precedence in GfeQuicServerSession::CreateServerPushStream. No functional change expected. Not protected. 2019-07-31 fayang gfe-relnote: Add a FifoWriteScheduler where the stream with the smallest stream ID will have the highest priority. Not used in prod, not protected. 2019-07-31 fayang Add a const_cast to make chromium build. 2019-07-31 dschinazi Support LengthPrefixedConnectionIds in v99 2019-07-30 bnc Add QpackBlockingManager to track blocked streams and blocking entries. 2019-07-30 fayang Fix comparison of signed to unsigned in htt2_priority_write_scheduler_* and spdy_intrusive_list_test. 2019-07-30 renjietang Remove headers stream from IETF QUIC. 2019-07-30 bnc Refactor incoming SETTINGS logic to QuicSpdySession::OnSetting(). 2019-07-30 fkastenholz Wire in the ack exponent trransport config for IETF QUIC 2019-07-29 quiche-dev Create a QuartcMultiplexer which separates streams and datagrams into channels. 2019-07-29 bnc Add QpackHeaderTable::MaxInsertSizeWithoutEvictingGivenEntry(). 2019-07-29 renjietang Make OnPushPromiseFrameEnd() return the same value as OnHeadersFrameEnd(). 2019-07-29 bnc Clean up HTTP/3 and QPACK settings. 2019-07-29 bnc Internal QUICHE change 2019-07-29 fkastenholz Connect up IETF QUIC Max ACK Delay transport parameter 2019-07-29 fayang gfe-relnote: Fix Http2PriorityWriteScheduler::UpdateStreamParent. Not used in prod. Not protected. 2019-07-27 bnc Update QuicSpdySessionTestClient.Http3ServerPush* tests. 2019-07-26 renjietang Write push promise on request streams. 2019-07-26 fayang gfe-relnote: In QUIC, let write_blocked_list be able to use HTTP2 priorities. Not used yet. Not Protected. 2019-07-26 fayang gfe-relnote: Fix Http2PriorityWriteScheduler::ShouldYield. Not used in prod. Not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Please note quartc_multiplexer_test.cc is not added to BUILD.gn because it failed on Linux MSAN Tests: https://luci-milo.appspot.com/p/chromium/builders/ci/Linux%20MSan%20Tests/18389 Change-Id: I35bbd7a1920f2d075f3cc638d2dd1e6570505e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736463 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#683984}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/594583382d4e..00c9f0dc9225 git log 594583382d4e..00c9f0dc9225 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 robertphillips@google.com Increase specificity of GrColorType computed for YUV planes (take 2) Created with: gclient setdep -r src/third_party/skia@00c9f0dc9225 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I08045f42218539f288e110bea6fbfa45acc6dad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734764Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibf33ad4f45a420ddae482b945ae68a9825c8ec07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736108Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8c1079cc71d7..a5468613faff git log 8c1079cc71d7..a5468613faff --date=short --no-merges --format='%ad %ae %s' 2019-08-05 perezju@chromium.org [Telemetry] Write 'benchmark/story' test paths in LUCI format Created with: gclient setdep -r src/third_party/catapult@a5468613faff The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:966835,chromium:983993 Change-Id: I48166ba007ed9b5853e2a06e0206376d9bb6243e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734762Reviewed-by:
-
Bence Béky authored
See https://crrev.com/c/1704282 for context. Change-Id: Ifcfd3b7b9b7867176a90a092056f453fb74124c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736692 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 75b38795. Reason for revert: Adding expectation to address Linux Leak failure Original change's description: > Revert "Add web tests virtual suite for audio service - Take 2" > > This reverts commit 8d648953. > > Reason for revert: Causing failures on WebKit Linux Leak > > Failure output: > 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed: > 06:31:06.621 2998 worker/6 leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) > > Original change's description: > > Add web tests virtual suite for audio service - Take 2 > > > > Adds extra expectations with respect to reverted > > https://chromium-review.googlesource.com/c/chromium/src/+/1715811 > > > > Bug: 976696 > > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088 > > Reviewed-by: Armando Miraglia <armax@chromium.org> > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683565} > > TBR=guidou@chromium.org,armax@chromium.org > > Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 976696 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508 > Reviewed-by: Chris Sharp <csharp@chromium.org> > Commit-Queue: Chris Sharp <csharp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683600} TBR=csharp@chromium.org,guidou@chromium.org,armax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976696 Change-Id: I9172e204adef935eb4ae4a60045a54b6c9c157f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735378Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#683979}
-
Stephane Zermatten authored
With this change, tests that wait for onboarding systematically call AutofillAssistantUiTestUtil.waitUntilViewMatchesCondition, which waits longer than expresso normally does. Bug: 990118 Change-Id: Ie6ae12786eec2d4fab04b49aa13cdbfa6088e943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736706Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#683978}
-
Peter E Conn authored
Bug: 988068, 984945 Change-Id: Ia095904e4d07ded1814af0d35ed2cff3c50b6946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736669Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#683977}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=miu@chromium.org Change-Id: I692e8ce91f43e17c5d0ad58dc1b194145490a4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733613 Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683976}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/12af46b649fd..ad3443c93121 git log 12af46b649fd..ad3443c93121 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 wl@gnu.org Minor documentation improvement. Created with: gclient setdep -r src/third_party/freetype/src@ad3443c93121 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I93ee5bf566c0c5cc87149069120e121300592ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735999Reviewed-by:
-
Mark Cogan authored
WKWebView's -takeSnapshotWithConfiguration:completionHandler: may call its completion handler more than once under some circumstances. Since we typically embed a callback bound with BindOnce into this callback, repeated calls will CHECK() and crash. This CL changes the snapshot callback to be a repeating callback. The callback will remain owned by the block passed into WKWebView, and will be destroyed only when WKWebView discards the block. Bug: 981893 Change-Id: I9ae72fd8ca42ca4ac704b23df942931a3afd1310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728553 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#683974}
-
Hajime Hoshi authored
This CL implements page eviction. When JavaScript is executed on one document in the back/forward cache, the full page is evicted. This uses V8's SetAbortScriptExecution, which aborts execution and instead executes the registered hook. In the hook, eviction is triggered via mojo. In the current implementation, the page is evicted even when the frame is frozen not by bfcache, but this eviction works only when the feature flag is set. Detecting the reason why the frame is frozen is a remaining task. Design Doc: https://docs.google.com/document/d/1E6efB594SqODZX5_PRxmv8eZ9YsmheqhKFg3KoDh3vs/edit?usp=sharing This CL includes the change: * Browser-side implementation https://chromium-review.googlesource.com/c/chromium/src/+/1614163 Bug: 980111 Change-Id: I7d2779441aab118612a666304ff2366cffeffc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654739 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#683973}
-
Juan Antonio Navarro Perez authored
The CL introducing the results processor [1] broke reporting of Telemetry's return_code when called via run_benchmark. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1692986 This is a quick fix for that. Adding tests to make sure we don't break this again in the future as follow up CLs. TBR=crouleau@chromium.org Bug: 990472 Change-Id: I4139d4b7503bad6555b5ee8d919499dd32fbff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735581Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#683972}
-
Ross McIlroy authored
BUG=894773 Change-Id: I57c5c7cea3effd7a09bc72b3fe4893bb094eebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731908Reviewed-by:
-
