GitLab

Bug: 1002674
Change-Id: I01e0daa245231d101425d8ff5a82f7d197f390e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098350
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755506}

App was crashing when trying to navigate from an interstitial page
(forward, backward, back to safety). Remove WebStateObserver in
both the destructor and WebStateDestroyed so that both navigations
and closing the page are covered.

Bug: 1066445
Change-Id: Iace4d26edbaec1ccc26a9b6c410a4de827c5be7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130777
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755505}

Tests assume that NOTIFICATION_EXTENSION_HOST_CREATED fires at most once
(see BrowserActionInteractiveTest::TearDownOnMainThread which compares
the number of "created" vs "destroyed" notifications).  This assumption
has not been met by the product code, which would fire
NOTIFICATION_EXTENSION_HOST_CREATED for every RenderViewReady
notification which happens not only for the very first RenderViewHost,
but also for possible subsequent RenderViewHost swaps (e.g. when
navigating cross-site).

This CL fixes ExtensionHost::RenderViewReady, to ensure that the
NOTIFICATION_EXTENSION_HOST_CREATED fires at most once per ExtensionHost
object.

Note that NOTIFICATION_EXTENSION_HOST_CREATED is only listened to by
test code (browser_action_interactive_test.cc and
management_api_browsertest.cc).  This means that this CL should have no
effect on production code and product behavior.

Fixed: 1066287
Change-Id: I30b26294c9edb18420b7d3d4b8d560c360914a06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129230
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755504}

This is needed for Fullscreen to reset itself when a navigation occurs.

Bug: 790886
Change-Id: I8ac3cb22679e5f2dfc5f966797513d67e8b08da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132627Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755503}

The following legacy policies are read by the manager:
  DelayDeliveryUntilVerdict
  BlockLargeFileTransfer
  AllowPasswordProtectedFiles
  BlockUnsupportedFiletypes
  kURLs* policies

The manager is not called by chrome code yet since the CL is already
quite large and to avoid having this reverted if subsequent code breaks
something.

Bug: 1062348
Change-Id: I4708a9a8a3bab8e559536b426bc4759705f48395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124856Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755502}

These issues were open against a WPT test that was written but the patch
was reverted in blink, implementation is still pending.

BUG=922618

Change-Id: I33ade6c7805a7d3ec55fc3e6b1f1f3747b192657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132860Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755501}

https://chromium.googlesource.com/openscreen.git/+log/e5b4b11496a0..07dc402b0545

git log e5b4b11496a0..07dc402b0545 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 rwkeane@google.com Add Hashing functions to Util

Created with:
  gclient setdep -r src/third_party/openscreen/src@07dc402b0545

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Icee3acde6623b2fe0eca14b5ed4475f736e985fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132856Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755500}

Previously NativeKeycodeToDomCode() would treat codes with a NULL name
for the DomCode (i.e. DomCodes used internally by Chrome to represent
keys with no standardized DOM |code| value.) as unknown.

This has been work-around in the DomCode table by assigning non-NULL
names to non-standard DomCodes, leading to confusion over which are
standardized mappings, and which are Chrome-internal.

Allow native keycodes with no standardized DOM |code| name to be mapped
to their Chrome-internal DomCode value, so that non-standard keys may
be switched to NULL names.

Bug: 952051
Change-Id: I1a08928765e76816410c3b005383b43910be5b51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020928
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755499}

This reverts commit f4b86b70.

Reason for revert: This broke the build and the CQ.

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8884198304462181456/+/steps/generate_build_files/0/stdout

Original change's description:
> [chromecast] Add process/thread id to the logs.
> 
> Also remove the timestamp since logd adds the timestamp. This
> makes the logs similar to cast.
> 
> Bug: internal b/152558058
> Change-Id: Ifda50ed1115e2192aaa7887440aba7a02341ef09
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123507
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Commit-Queue: Mohit Hotwani <hmohit@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755445}

TBR=halliwell@chromium.org,jlevasseur@google.com,kmackay@chromium.org,kmackay@google.com,hmohit@chromium.org

Change-Id: I537c73a4453f1d31e54c75ab2f8a23757b6be2a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: internal b/152558058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132831Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755498}

Change-Id: Ifbc6768dd3e0bbf8b64e2a1a6bd93322c6916ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132826
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755497}

Before this CL some os and browser routes had the same name. This was
a bit confusing. If a some c++ code called '/reset', it is not clear if
this url is a chrome or browser subpage. A distinction needed to be made.
This CL renames OS specific route RESET, which is shared with browser
routes to a more distinguishable name OS_RESET. Allowing this bug(990169)
to be unblocked.

Bug: 990169
Change-Id: Ia805b6889bf3b6afe0c22dfc1b11b3ea93fdb2a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108873Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#755496}

Bug: 1066832
Change-Id: Ib53fc0452e7d4157cfe8adb64acee2d2e8c81e5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132147Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755495}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85b8bc1b0e14..56891834a29d


Created with:
  gclient setdep -r src-internal@56891834a29d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I7a422407aa0112092ffff7a61e5fca53ff4d2228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132851Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755494}

Also keeping it for another 4 months and changing ownership to policy
infrastructure team.

Bug: 1053252
Change-Id: Ic3d59b06d03b6ed11b6e701afcb9db32c172470a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130252Reviewed-by: Igor <igorcov@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755493}

Roll src/third_party/shaderc/src/ 1db568ebb..486655782 (1 commit)

https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/1db568ebb1f0..486655782f8b

$ git log 1db568ebb..486655782 --date=short --no-merges --format='%ad %ae %s'
2020-03-31 rharrison Add knob to control force_zero_initialized_variables (#1028)

Roll src/third_party/spirv-cross/spirv-cross/ 172e39f03..e58e8d5db (40 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/172e39f0398b..e58e8d5dbe03

$ git log 172e39f03..e58e8d5db --date=short --no-merges --format='%ad %ae %s'
2020-03-31 post MSL: Fix access chain for deep struct hierarchy on array of buffers.
2020-03-30 dsinclair Roll GLSLang, SPIRV-Tools and SPIRV-Headers
2020-03-26 post Add support for forcefully zero-initialized variables.
2020-03-19 post GLSL: Implement GL_EXT_shader_framebuffer_fetch.
2020-03-19 post Run format_all.sh.
2020-03-19 post GLSL/HLSL: Fix nonuniform qualifier for SSBO atomics.
2020-03-19 post GLSL/HLSL: Implement nonuniform qualifier for image atomics.
2020-03-10 post include/spirv_cross: Fix typo.
2020-03-05 post HLSL: Do not emit globallycoherent for SRV ByteAddressBuffer.
2020-03-04 post Add test for disable-storage-image-qualifier-deduction.
2020-03-04 post HLSL: Add option to always treat SSBO as UAV, even with readonly.
2020-03-04 post Add option to disable storage image qualifier deduction.
2020-03-04 post Remove old hack which forces NonWritable/NonReadable.
2020-03-02 post Add -V alias for --vulkan-semantics.
2020-02-24 post MSL: Add C API for force native arrays.
2020-02-24 post MSL: Add native array test for composite array initialization.
2020-02-24 post MSL: Reintroduce workaround for constant arrays being passed by value.
2020-02-24 post MSL: Reinstate workaround for returning arrays.
2020-02-24 post MSL: Add a workaround path to force native arrays for everything.
2020-02-19 dsinclair Roll GLSLang, SPIRV-Tools and SPIRV-Headers
2020-02-14 post Reject SPIR-V modules with garbage ID bound.
2020-02-08 post HLSL: Declare undef variables as static.
2020-02-06 post Remove old memory_scope flag from iOS barriers.
2020-02-03 post Use GNUInstallDirs for include path as well.
2020-02-01 orbea cmake: Don't hardcode the pkg-config file.
2020-02-01 orbea cmake: Use GNUInstallDirs.
2020-02-01 post CMake: Avoid warning when parent project uses VERSION in project().
2020-01-27 post Compile fix on older compilers.
2020-01-27 post GLSL: Support GL_ARB_enchanced_layouts for XFB.
2020-01-25 cdavis MSL: Move inline uniform blocks to the end of the argument buffer.
2019-12-16 cdavis MSL: Support inline uniform blocks in argument buffers.
2020-01-23 post Make SmallVector noexcept.
2020-01-22 42098783+barath121 Typo at line 324
2020-01-16 post Update license headers to 2020.
2020-01-16 post Run format_all.sh.
2020-01-16 post MSL: Add support for force-activating IAB resources.
2020-01-16 post Deal with illegal names in types as well.
2020-01-15 post Reflection: Add array stride/matrix stride reflection.
2020-01-15 post Reflection: Emit reflection information for array size literalness.
2020-01-15 post GLSL: Implement geometry shader passthrough extension.

Created with:
  roll-dep src/third_party/shaderc/src src/third_party/spirv-cross/spirv-cross

Change-Id: I77642e3f04f1fd9ddd52962b324876f352680f4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132850
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755492}

This CL deletes recording of
NewTabPage.RecentTabsPage.TimeVisibleAndroid UMA metric.

BUG=1053084

Change-Id: I2c7fa9c9c70993bec7d2a5b97bb32495a2b924a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130889Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755491}

This reverts commit 6c92556c.

Reason for revert: Visual Studio 16.5.2 released, which fixes the issue,
and the workaround is (ironically) incompatible with 16.5.2.

Original change's description:
> build: workaround for VC v14.25 / MSVC 19.25
>
> Adds a temporary fix to vs_toolchain.py to use the previous version of
> MSVC's header files and documents how to install the previous version
> alongside 19.25.
>
> Bug: 1058860
> Change-Id: I6e96af3c71b23e5c5430237d00125a5830c37855
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117732
> Commit-Queue: Richard Townsend <richard.townsend@arm.com>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753998}

TBR=sky@chromium.org,thakis@chromium.org,richard.townsend@arm.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1058860,1066935
Change-Id: I343aac7a0af7d89bf5497bf0d063e03731599f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132379Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Cr-Commit-Position: refs/heads/master@{#755490}

These __impl targets contain everything except the analysis steps (e.g.
errorprone, lint) so that other targets can depend on __impl rather than
the analysis steps finishing. The full target will depend on other full
targets to ensure that all analysis steps are run.

Improves base java signature change by 6.3s (171.9s -> 165.6s)

Bug: 906803
Change-Id: Ife1463b85be453a5f33aba97eaf3af7224e458ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132629
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755489}

This CL adds preliminary unit tests for org.chromium.base.FileUtils.
Currently we only test FileUtils.recursivelyDeleteFile() because a bug
(Issue 1066733) was found while developing the test, and it's desirable
to make the test available ASAP. Remaining tests will be added after.

Bug: 1066730, 1066733
Change-Id: I9356c4443e36108cd74e37dd1a1cb0e032ae5515
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132642
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755488}

This change applies the BindOnceRewriter in //base.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=brucedawson@chromium.org

Bug: 714018
Change-Id: I9b35e5f70260a892ed38255edd632699c293235b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132388Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755487}

Currently DidNotProduceFrame terminates the reporter in any stage,
which might not be correct in all situations.
For example if the reporter is in BeginMainFrame stage and it's taking
a long time and can not be submitted in the correct interval, it will
receive DidNotProduceFrame but might be submitted next frame.

To prevent termination of such reporters, this change flags the reporter
which receives DidNotProduceFrame in order to appropriately terminate
it when replaced by a new reporter.

Bug: none
Change-Id: I9adb148ef18ff750d3cc7c0f00e1108bc68e3e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131008
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755486}

Previously the ClearSyncedData sign-out feature in iOS mimicked the
current design in Android by adding a third option to signout for
clearing Chrome data. This caused a lot of confusion to the dialog
and was not iOS idiomatic.

The new design adds two signout options to the accounts table screen
when signed into a non-managed account and only the signout and
clear all data option when using a managed account.

Bug: 1043949
Change-Id: Idee2869fe4687da57d6388bf65f122d5b570b7ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124454
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755485}

This change allows for the user to enter localhost URLs when adding a
site to the site access for an extension through the settings page.

Bug: 1064613
Change-Id: Ibebdb5afb5b5f99743630adc6a268541e7bf4dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131346Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755484}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/05530618..e4572046

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3dfde80fb246e82a2f74775d4edea73417d97777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132217Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755483}

Roll ChromeOS orderfile from 83-4085.6-1584956258-benchmark-83.0.4091.0-r2 to 83-4085.6-1584956258-benchmark-83.0.4097.3-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I9ad429ce6254593de0a5a60fcb60a5b79b48d1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132948Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755482}

Adds a --bypass-skia-gold-functionality flag to the gtest implementation
of the Skia Gold pixel tests which causes all tests that use Skia Gold
to skip any actual interactions with Gold.

This is meant to be used in the unlikely event that there's a Gold
outage that can't be fixed quickly so that the outage does not block
CLs, etc.

Bug: 1057848
Change-Id: I9aebe7bb4dc460383096306d7ad1b9858eddd433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123509Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755481}

Change-Id: Ia775e491a920617164c61350ce73b351e2aafbb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132387Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#755480}

Bug: 923481
Change-Id: I60cb8729b9d423858afe6c15b47da67b98b58e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131043
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755479}

Previously kBackgroundPaintInScrollingContents from
LayoutBoxModelObject::GetBackgroundPaintLocation() meant we should paint
background in the scrolling contents layer only if the scroller was
composited. It would be changed to kBackgroundPaintInGraphicsLayer if
we found the scroller was not composited at multiple places. However,
that didn't work for CompositeAfterPaint.

Now save the the real BackgroundPaintLocation in LayoutObject
bitfields (in place of previous PreviousBackgroundPaintLocation), and
invalidate background when it changes.

This fixes CompositeAfterPaint issue that background was painted in
scrolling contents when the scroller was not composited.

This also improves raster invalidation in some cases.

Change-Id: Ide87d31f63eb14de909edd65aff1e88f1b44d984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127991Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755478}

In MakeCredential, if the authenticator has user verification "supported
and configured" and the request is not u2f only, user verification
requirement is forced to be "required". This change exempts platform
authenticators from this enforcement.

Change-Id: I7120e1a5c2ffd6064d29d47da64142918767a60d
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124236Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#755477}

The test changed with --enable-gpu-rasterization instead of
--force-gpu-rasterization but the trybots didn't pick up the right
expectations somehow on Mac 10.14?

R=vmpstr@chromium.org

Bug: 1066392, 866140, 1065893
Change-Id: I861106133411158802e10cc13fea3ddf609572da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129783
Auto-Submit: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755476}

Change-Id: I4419da39a18a97bf764852ce87d7003f3813217b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131167Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#755475}

It is deadcode.

Change-Id: Ia7db200d18526b457751148b0163025ce66f85f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132639
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755474}

This reverts commit e315c666.

Reason for revert: This allegedly increased the binary size on mac perf builder by 940 KiB (http://crbug.com/1066342)

Original change's description:
> Add quick check parameter to ConfiguredProxyResolutionService ctor
> 
> Doing this cleans up an undesirable ConfiguredProxyResolutionService
> usage pattern where code that primarily works with a
> ProxyResolutionService must currently cast to the specialized class
> before setting the right PAC quick check value.
> 
> Bug: 1032820
> Change-Id: I777eb1c6097a604bf522e7d87f8806f4df0324b2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113802
> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753426}

TBR=eroman@chromium.org,jam@chromium.org,mmenke@chromium.org,niarci@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1032820
Change-Id: I1ad89c7ee4da76f34d8bf363cc824a2d5aea655a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132628Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755473}

Add usage of MaxSimultaneousLoad threshold in BackgroundTabLoadingPolicy's
loading logic.

Bug: 1059341
Change-Id: I20f167142a32df59fbd2126c22a15936a5b744da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122479
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755472}

In this CL next bugs are fixed:
- Passwords and username not aligned,
- Missing divider after header section in password check,
- Layout issues with RTL languages.

Fixed: 1066779, 1066782, 1066788
Change-Id: I17eaacd576b22816390d4d2852fd783c9c9f0853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130853
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755471}

The tests in ukm_egtest.mm should be kept in sync with those in
//chrome/browser/metrics/ukm_browsertest.cc. The test in
ukm_browsertest.cc for which EG are being added is
AddSyncedUserBirthYearAndGenderToProtoData.

(A second CL will be sent for tests corresponding to those in
metrics_service_user_demographics_browsertest.cc.)

Bug: 1065870
Change-Id: I5ad386a0b96cbb1feea51676a908374d13863819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127247
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755470}

Bug: 1006823, 656015
Change-Id: I47875b25a542ba6040eda7147449c7fb61d89024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132218
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755469}

This CL adds support for performance.eventCounts, gated behind the
EventTiming flag. EventCounts is maplike and enables computing the
number of input events that have occurred for any of the supported event
types. It is populated on WindowPerformance::RegisterEventTiming so that
it matches when timing with when the PerformanceEventTiming entry is
created for slow events. The spec for this is here:
https://wicg.github.io/event-timing/#sec-event-counts

Bug: 543598

Change-Id: I95bd8b977556557811a1eff8d9fc5d106af0d2b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125019
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755468}

Bug: 1059767
Change-Id: I69880f5bb32cb6400138f1af0b2cf9da56a08c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129013Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755467}