- 21 Jul, 2020 40 commits
-
-
Becca Hughes authored
Mark a Media Feed and its contents as being displayed when it is shown in the UI. This will shuffle the feeds to show new content. BUG=1053599 Change-Id: Ibf48d01e10a010e07177a54ea2f0b3400b68867f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309800Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790460}
-
Andrew Grieve authored
This reverts commit 561b40b5. Reason for reland: Other culprit CL reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2310131 Original change's description: > Revert #2 of "Android: Updates to warnings-as-errors when building" > > This reverts commit 3a98cccc. > > Reason for revert: The reland also broke the tree. > > Original change's description: > > Reland "Android: Updates to warnings-as-errors when building" > > > > This reverts commit 57deecbb. > > > > Reason for reland: Suppressed cast lint warning > > > > Reverted in: 339e6581. > > > > > Original change's description: > > > > Android: Updates to warnings-as-errors when building > > > > > > > > * Delete java_warnings_as_errors > > > > * Use treat_warnings_as_errors for android rules > > > > * warnings-as-errors is now default true for debug builds > > > > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py > > > > so that these warnings can all be turned off locally. > > > > * Made build_utils.CheckOutput fail by default when stderr or stdout is > > > > printed. This should prevent build logs from creaping in. > > > > * Added "you should use treat_warnings_as_errors=false" into error > > > > message when builds fail due to warnings. > > > > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org > > > > Bug: 1029357 > > Change-Id: I56c1349c6e823737aa8a59a8e961e5a518667ba0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308868 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790410} > > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org > > Change-Id: I4721f016821d3675e389740d7d2d59e787ff9304 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1029357 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310392 > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790453} TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,tmartino@chromium.org,andruud@chromium.org Change-Id: Ib19547f2099ec59b9b00b43a9f9ae5d9ea23e28e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309813Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790459}
-
Sven Zheng authored
Bug: 1104291 Change-Id: I741cc87519f105aafad4671ab837acaaa652f1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308130 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#790458}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/62ab4833a6a1..84d986f9a16a 2020-07-21 jacktfranklin@chromium.org Rename `NewElementsBreadcrumbs` => `ElementsBreadcrumbs` 2020-07-21 aerotwist@chromium.org Changes ninja hardlink copy for file copy 2020-07-21 aerotwist@chromium.org [TypeScript] disallow explicit any If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I61b5347a2b239a87b18d1f556893df45ab051f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790457}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b0b5891ddfac..921d95386ccd 2020-07-21 miu@chromium.org Fix scaling default recommendation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106140 Tbr: jophba@chromium.org Change-Id: I92fb5fdb167e9f82828b674e8d14e7cb43adbccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790456}
-
Livvie Lin authored
Before: https://drive.google.com/file/d/1D9OunuuOxV5O9FWTnU0MKMpn6hkeop8_/view?usp=sharing After: https://drive.google.com/file/d/1R-O4UNXMCG-e_wHnN4sH3M92QhvLhpKj/view?usp=sharing Change-Id: Ia2a96b5eeb977ef58479ac6ebfc9106d7dd62304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304093Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790455}
-
Hidehiko Abe authored
On chromeos-chrome on Linux for development purpose, if XDG_RUNTIME_DIR is set, but it is missing, create it. Bug: 1107789 Test: Ran locally. Change-Id: I42086e71fed05976f40508c86f2c5644dd565a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310030 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#790454}
-
Tommy Martino authored
This reverts commit 3a98cccc. Reason for revert: The reland also broke the tree. Original change's description: > Reland "Android: Updates to warnings-as-errors when building" > > This reverts commit 57deecbb. > > Reason for reland: Suppressed cast lint warning > > Reverted in: 339e6581. > > > Original change's description: > > > Android: Updates to warnings-as-errors when building > > > > > > * Delete java_warnings_as_errors > > > * Use treat_warnings_as_errors for android rules > > > * warnings-as-errors is now default true for debug builds > > > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py > > > so that these warnings can all be turned off locally. > > > * Made build_utils.CheckOutput fail by default when stderr or stdout is > > > printed. This should prevent build logs from creaping in. > > > * Added "you should use treat_warnings_as_errors=false" into error > > > message when builds fail due to warnings. > > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org > > Bug: 1029357 > Change-Id: I56c1349c6e823737aa8a59a8e961e5a518667ba0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308868 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790410} TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org Change-Id: I4721f016821d3675e389740d7d2d59e787ff9304 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310392Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790453}
-
Stephanie Kim authored
Setting this to 6 concurrent links because linux64-beta/stable/trunk uses 6. Bug: 1072012, 1103490 Change-Id: I20a32e90e43719823f903d498b10895d0cf17a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298288Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#790452}
-
Bence Béky authored
Log a newly added HTTP2_SESSION_SEND_GREASED_FRAME event every time an HTTP/2 frame of reserved type (as defined in [1]) is sent. This happens after sending a SETTINGS frame, and also before each DATA frame. The ones sent before DATA frames are generated in SpdyStream::QueueNextDataFrame(). The DATA frame is generated earlier by SpdySession::CreateDataBuffer() but only enqueued later. In order for the greased frame to be logged before the DATA frame (corresponding to the order in which they are sent), DATA frame logging is moved from SpdySession::CreateDataBuffer() to SpdyStream::QueueNextDataFrame(). [1] https://mikebishop.github.io/http-misc-extensions/draft-bishop-httpbis-grease.html Bug: 1106652 Change-Id: Icaa8e874e48a85d93d5920d75d9e0bb0caa43949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309350Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790451}
-
Rakib M. Hasan authored
Updates wpt_update_expectations.py so that it can mark tests as flaky by adding pass expectations for tests with unexpected passes. Bug: 1050754 Change-Id: I071c21d574763b9fa5d7d3f1637ad2236933941f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303869 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#790450}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1eb58de32c0..09357ccfa85a 2020-07-21 herb@google.com split out GrDirectMaskSubRun from GrMaskSubRun 2020-07-21 kjlubick@google.com [skottiekit] Initial npm files 2020-07-21 bsalomon@google.com Rename GrMipMapped GrMipmapped 2020-07-21 fmalita@chromium.org [skottie] More masking fixes 2020-07-21 fmalita@chromium.org [skottie] Add RenderFlag::kDisableTopLevelClipping If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I4b59f82c225ad5aba57e87abc77477d9fc68235f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790449}
-
Ali Juma authored
This disables SafeBrowsingTestCase/testRestoreToWarningPagePreservesHistory since it is flaky. Bug: 1106498 Change-Id: I0953c8c0f2c36ea01a7e1f0ff738db6c842df94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308867 Auto-Submit: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#790448}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c5d08140dbeb..7d529ff6e1c2 2020-07-21 amaiorano@google.com Fix ENABLE_RR_DEBUG_INFO on LLVM 10 2020-07-21 amaiorano@google.com Remove support for LLVM < 10 2020-07-21 amaiorano@google.com Delete LLVM 7 Kokoro configs 2020-07-21 amaiorano@google.com Fix LLVM-10 CMake build 2020-07-21 swiftshader.regress@gmail.com Regres: Update test lists @ 97f99232 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I003ff3b00f25b4ff184f40943ab77fb29fe1b848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790447}
-
Bruce Dawson authored
vs_toolchain.py gets a directory listing for win_sdk_dir\bin and then sorts it by converting the 10.x.x.x directory names to tuples of integers. This fails on Python 3 because int and str types are not comparable so directories with non-integral (non-version) names caused comparison failures when compared against integral (version) names. This change filters out the unwanted names before sorting instead of after sorting, which lets this work on Python 3 (tested by running manually). A misleading variable name was also changed. This was reported by a pdfium user. Change-Id: Ifb0accd831945c6d0eb44e838071b8ddd609ddb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309454 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#790446}
-
David Bokan authored
Split out from https://crrev.com/c/2284613. This CL adds knowledge of a main frame RenderWidget's state as a nested widget. We also do some related cleanups and simplifications. GuestViews and Portals create a RenderView and associated RenderWidget with a RenderWidgetDelegate. However, such RenderWidgets aren't the top level widgets in the frame tree. There are cases where we want to treat these widgets as subframes, rather than a top-level frame, such as the CL mentioned above. In this CL we plumb through the view type when creating a RenderView. This information is used by RenderWidget to determine if it's nested. Additionally, we add code to keep this bit up-to-date in the case where a portal is activated/deactivated, changing this status. As a small, unrelated change, we also fold setting the RenderWidgetDelegate into RenderWidget::InitForMainFrame to make it clear that main-frame widgets, and only main-frame widgets, have a non-null delegate_. This change should be a no-op. Bug: 932669 Change-Id: I685e1d13970e9c88a19c66972bd3ce3bf4749c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302813Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790445}
-
Jan Wilken Dörrie authored
This is a reland of ee99ff7f Original change's description: > [base] Prepare //net for base::string16 switch > > This change prepares //net for the switch of base::string16 to > std::u16string on all platforms. This was achieved by making > net_unittests compile on Windows after the switch was made. > > Furthermore, it fixes small issues in //base and //sql. > > Bug: 911896 > Change-Id: I11fd80998e9f5e954a87870533685a3f77fa42d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303431 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790126} TBR=wfh Bug: 911896 Change-Id: Ibbd6cb6695b40149971186f05ffb6b859acd68f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309689 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790444}
-
chrome://settings/content/cookieschrome://settings/cookiessauski authored
Recently the chrome://settings/content/cookies URL has been deprecated in favor of the chrome://settings/cookies URL. This CL adds a redirection mechanism to ensure existing direct links continue to function. Bug: 1103539 Change-Id: I5fcb354106b50848fa9a0d84fc0403568b42bab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289773 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#790443}
-
Justin Cohen authored
Speculative fix for some full screen PDF tests. Change-Id: I5a96eb529e457c61701b6cfe08fc65888438b58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310191 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790442}
-
Brandon Walderman authored
This change implements the Set Storage Access command for TestDriver in Blink and content_shell: https://privacycg.github.io/storage-access/#automation This is needed to support more in-depth WPT tests for the Storage Access API. The current WPT tests for this feature cover basic IDL behavior, but are not able to verify that the requestStorageAccess API itself is functional because the browser must first be put into a state where third-party cookies are blocked. A new set_storage_access method has been added to testdriver.js. It functions similarly to the existing set_permission method. This calls a Blink-internal method that forwards the passed in arguments to the content shell via Mojo. A new WebTestStorageAccessManager class in the content shell converts the arguments into ContentSettingsPatterns and passes these settings to the CookieManager. The WebTestStorageAccessManager also enables third-party cookie blocking so that these rules will take effect. Bug: 1096803 Change-Id: I635687e7d00cf95fa2cf54fb86e1f65a0fe85f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253280Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Cr-Commit-Position: refs/heads/master@{#790441}
-
Katie Dektar authored
This reverts commit eb6596e7. Reason for revert: Suspected to have broken compile on Android: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/13404? Original change's description: > Refactor DisplayCutoutController to prepare for componentization. > > DisplayCutoutController is split into DisplayCutoutController > (destined for //components) and DisplayCutoutTabHelper (which stays > in //chrome). Relocation/reuse will occur in a follow up CL. > > TBR=dtrainor@chromium.org > Bug: 1095714 > > Change-Id: Ie119069ae4756baf73acc23d655665fce1d4c035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296888 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790402} TBR=dtrainor@chromium.org,estade@chromium.org,beccahughes@chromium.org Change-Id: I9821d88e9e06163aae93800ae84ed21fb32ac180 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1095714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310131Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790440}
-
David Grogan authored
Flex uses image preferred widths as flex-basis. When an image has max-height:blah%, that can affect its preferred width. FlexNG wasn't passing the percent resolution height to legacy for this calculation, and the % max-height was being treated as auto. ComputeMinAndMaxContentContribution was already doing this for replaced elements, so piggy-back on that code. Bug: 1107604 Change-Id: Icecb312ce8aee22cad6e4b1925aab77ecbd3c2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309048Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790439}
-
Rijubrata Bhaumik authored
We added support for multiple scan invocations on the same Reader in this CL https://chromium-review.googlesource.com/c/chromium/src/+/2145263 Since Origin Trials feedback was to remove Filtering, spec : https://github.com/w3c/web-nfc/pull/565 WIP CL : https://chromium-review.googlesource.com/c/chromium/src/+/2225770/ we tried to reason if in a world without filtering, multiple scans on the same Reader is needed at all. The present thinking is to simply reject scan promise when there's already an ongoing scan. Spec discussions: https://github.com/w3c/web-nfc/issues/592 Bug: 520391 Change-Id: Ic50873ddc30351cec6656ac7b030394dc9fa18ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297559 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#790438}
-
Ben Wagner authored
These should be added to a 'public' variable, but Skia does not yet export enough '*_public' variables to make a complete 'public' list. These files should in the meantime be added to 'sources' so that the build and 'analyze' steps are aware of them. Change-Id: Ia3a8920d803c2e27593af99932b1350d31cea886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300272Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Auto-Submit: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790437}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of ed8ef709 Original change's description: > Amend dom-distiller script for bug ID handling > > "None" would be ignored, and add space after ",". > > Bug: None > Change-Id: I85167f2e9ba0cea7affd754825fd34e817568bd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304337 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789569} Bug: None Change-Id: I2d77fa208af77bf18e2e0626d69f420e620a9995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305055Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790436}
-
Lei Zhang authored
It is easier to understand vs. base::DeleteFile(path, true). Bug: 1009837 Change-Id: I97c80413b319b070d1e95a96a6acbae0bd086d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285916Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790435}
-
Edward Lesmes authored
Bug: 1107663 Change-Id: Iddb187ca9ecf5d390189142669c03ad5568e81fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309134Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#790434}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of 033b5754 Original change's description: > Use code review in DOM distiller dist repo > > Before this CL, this script builds DOM distiller, pushes the compiled > artifacts to the dom-distiller/dist repo, and generates a local commit > for rolling. The local commit needs to be uploaded as a CL. > > In order to avoid pushing without reviewing, we want to generate a CL > in the dom-distiller/dist repo instead of directly pushing to it. > > When reviewing the CL in the dom-distiller/dist repo, the reviewer > needs to run update_domdistiller_js.sh in validation mode to make sure > the artifacts in the CL are identical to local output. > > Bug: None > Change-Id: Ia29c1686106c3516f341e4d826aca69842ac5668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304338 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789575} Bug: None Change-Id: I361ece06de4fc744b06a46f6924abaec20bf81de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304995Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790433}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7bd9cbfeffa..8fbd57f0d966 2020-07-21 vapier@chromium.org licensing: add analogix-anx3429-firmware to Google-TOS list 2020-07-21 jiancai@google.com toolchain: create unique names for clang crash diagnoses 2020-07-21 khwon@chromium.org build-ap: switch to coreboot from coreboot-zork 2020-07-21 vapier@chromium.org locking: move chatty lines to debug 2020-07-21 tcwang@google.com toolchain: Use temp bucket for unvetted artifacts on branches 2020-07-20 briannorris@chromium.org vm: drop deprecated -usbdevice If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2c0c808e4000d508929e643358445a4cf717416f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790432}
-
Peter Marshall authored
Change-Id: Ia29fc63cbae53d5f4cdcbb9d644682a138431c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309693 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#790431}
-
Clemens Arbesser authored
This bridges the gap between legacy UserData and the new UserModel. For now, only additional values can be requested, but this can be easily extended to apply to the selected card/profile etc. as well. All values requested in this manner will be client-side only and never leave the device. Bug: b/145043394 Change-Id: Iaf3fe8af7a24418eabe36393b5428752a1d20aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308417Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790430}
-
Sammie Quon authored
It used to start a new animation if the power button was pressed in the middle of a power menu animation. It's really hard to see without slow animations, but some users have noticed. Fixes this by using IMMEDIATE_ANIMATE_TO_TARGET to animate from the current opacity to the target. Also avoids recreating the contents of the widget on each press. Test: manual Change-Id: I2361e431cae9bb74a37b29354b6b0825e81ca4ac Fixed: 832975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297746Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790429}
-
Mohamed Heikal authored
A collection of bugfixes for creating R.java in java_library_impl targets: - test libraries support. - apk under test R.java shadowing bugfix. - always generate onResourcesLoaded like package resources did. - Fix issue where R.java is not generated for the apk package name. - Change webAPK manifest package name (remove .new because it is a java keyword). Reason for reland: Fixed build issue with webAPKs. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2302919 This reverts commit 1895ffb4 Bug: 1073476 Change-Id: Ic095091eb64db32d1653e219f507463de59cacf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307809 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790428}
-
Andre Le authored
BUG=1105851 Change-Id: Id07b79538a69b9bbdd5b0033e1d60c5e94d20b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303052Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#790427}
-
Devlin Cronin authored
Move //c/c/extensions/manifest_handlers/extension_action_handler.[h|cc] to //extensions/common/manifest_handlers/, since it has no //chrome dependencies. This is a pure move; there are no functional changes. Bug: 1073590 Change-Id: I329a7a7901a90ad972173ed999de250fbdb4fcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259517Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790426}
-
Benoit Lize authored
Modulo operations are very slow, replace it with a subtraction and a bitmask operation. Bug: 998048 Change-Id: Iff08febd395c7735c416ced4914e32fcf4d9f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309696 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#790425}
-
Scott Violet authored
This makes it so that ShouldUpdateHistory() returns false for same document navigations to the same url without a user gesture. A common use of this history.replaceState(), which we don't really want logged to history as it's not really what the user thinks of as a navigation. BUG=1103495 TEST=HistoryBrowserTest.ReplaceStateSamePageIsNotRecorded Change-Id: Iafc0c7b93298940eb76cd1ca93ba7ffe3b2d32df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305236 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790424}
-
Michael Crouse authored
This change creates the mojom interface and a LiteVideoHint struct to pass the information from the browser render frame host to the render frame agent to be used for throttling media request. These messages are sent once per frame and only from the browser to the renderer. This change also makes the MaxThrottlingDelay finch controllable and passed via LiteVideoHint from the browser. This will make switching to controlling per origin via Cacao easier in the future. A future change will enable a message to be returned with the result of throttling requests for metrics and updating the user blocklist. Bug: 1082553, 1106013 Change-Id: I7019dbf6e9cb934b3c9276073d1de2662709c20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300931Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#790423}
-
Scott Violet authored
Prior to this patch targeting would potentially consider the parent. This is problematic as if there is a suitable child, then preferring the parent likely means targeting a container view, which generally doesn't do anything with events. Considering the parent for distance to center is also problematic in so far it means touches on the center of a parent are preferred over a touch on a child, even though the center is slightly off. TEST=none BUG=1085694 Change-Id: I8e65bddf2a48bef514094fb29c8aed2dbbc46176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295439Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#790422}
-
Olivier Robin authored
As AddCount is not exposed in macros, use directly histograms functions. As only one report is received every 24 hours, not caching the histogram should not be an issue. This is still behind a flag and only enabled on canary. Bug: 1017434 Change-Id: I47680e10ec5030b1d6e68c845a5cbb1ae91f92f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283742Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790421}
-