- 16 Nov, 2017 40 commits
-
-
Yuke Liao authored
This reverts commit cef83520. Reason for revert: DownloadTaskImplTest.* tests fail on iOS 11 devices, both iPhone and iPad. Original change's description: > DownloadTaskImpl implementation for //ios/web Download API. > > This CL implements DownloadTask public interface. > > DownloadControllerImpl CL: crrev.com/c/758525 > Design doc: http://go/ios-web-download-api > > Bug: 780646 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I2c508e77f3e529223499d6f2791b28011589fe90 > Reviewed-on: https://chromium-review.googlesource.com/758506 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517176} TBR=sdefresne@chromium.org,eugenebut@chromium.org,gchatz@chromium.org Change-Id: I14f0c37aa92330b0a665bf59bb665f010ee1209d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/776067Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517225}
-
Vlad Tsyrklevich authored
This reverts commit d2cc1555. Reason for revert: speculative revert, this might cause hangs on Linux component builds due to linker symbol resolution issues. Original change's description: > [cfi-icall] Use ProtectedMemory for GetProcAddress > > Control Flow Integrity [1] indirect call (cfi-icall) checking can not > verify that dynamically resolved function pointers call their intended > function. Instead we place the pointer for GLGetProcAddress in > ProtectedMemory, a wrapper for keeping variables in read-only memory > except for when they are initialized. After setting the pointer in > protected memory we can use the UnsanitizedCfiCall wrapper to disable > cfi-icall checking when calling it since we know it can not be tampered > with. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 771365 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ia79c1cfab8e00f88bcc437c34cbb3012537c015a > Reviewed-on: https://chromium-review.googlesource.com/769654 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517208} TBR=kbr@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org Change-Id: Ia474d99619795f9b2c40422858caf2a02461e462 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771365 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/775596Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517224}
-
Vlad Tsyrklevich authored
This reverts commit d0de1771. Reason for revert: speculative revert, this might cause hangs on Linux component builds due to linker symbol resolution issues. Original change's description: > [CFI] Use ProtectedMemory in CertVerifyProcNSS > > Because CertVerifyProcNSS dynamically resolves a pointer to the function > CERT_CacheOCSPResponseFromSideChannel(), Control Flow Integrity [1] > indirect call (cfi-icall) checking can not verify that it is the > intended target for that function pointer call site. > > Since we can not use cfi-icall to check the function pointer, instead we > place the pointer in ProtectedMemory, a wrapper for keeping variables in > read-only memory except for when they are initialized. After setting the > pointer in protected memory we can use the UnsanitizedCfiCall wrapper to > disable cfi-icall checking when calling it since we know it can not be > tampered with. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 771365 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5d65b3591681f3daa917b6516eec1e5e47513d12 > Reviewed-on: https://chromium-review.googlesource.com/765098 > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517169} TBR=eroman@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org Change-Id: I2d9a65fd6284c2cf954b46588d70fd1fa6292014 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771365 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/775595Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517223}
-
Tom Anderson authored
Linking on arm64 can fail when dependent libraries are missing. That is, when linking against liba which depends on libb, linking will fail when only libb is missing. This CL adds a check to prevent these types of missing libraries. BUG=webrtc:8535 R=thestig@chromium.org Change-Id: I14e15ce534bd8ac5602f84dedcaab2db041656fb Reviewed-on: https://chromium-review.googlesource.com/773200Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#517222}
-
Joel Einbinder authored
Brings the inspected page to front and focuses it Change-Id: I0e6b18b079091fe2b0dfccbc69829470dcfaeeec Reviewed-on: https://chromium-review.googlesource.com/761057Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#517221}
-
Ian Kilpatrick authored
We previously didn't correctly handle block-end borders. This fixes a couple of subtle bugs: - We don't grow the block-size of a fragment if it doesn't have any content. - We expand to encapsulate floats first, then grow to encapsulate the border. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7770a1d23a9c25fcab51e2e681e00e4b4d3e9d08 Reviewed-on: https://chromium-review.googlesource.com/770645 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#517220}
-
dpapad authored
The lower part of the sidebar was incorrectly sized, causing the scrollbar to appear after part of the content was already hidden. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I50458546e67af9dfcd5416bdc81f6dfa7ca6e5b6 Reviewed-on: https://chromium-review.googlesource.com/775554Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#517219}
-
Vlad Tsyrklevich authored
This reverts commit e77256b1. Reason for revert: Reverting while I investigate failures causing recursive calls to hang. Original change's description: > [cfi-icall] Use ProtectedMemory for localtime ptrs > > Control Flow Integrity [1] indirect call (cfi-icall) checking can not > verify that dynamically resolved function pointers call their intended > function. Instead we place the LibcFunctions pointers in > ProtectedMemory, a wrapper for keeping variables in read-only memory > except for when they are initialized. After setting the pointers in > protected memory we can use the UnsanitizedCfiCall wrapper to disable > cfi-icall checking when calling them since we know they can not be > tampered with. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 771365 > Change-Id: Ib74faff066e1107293b67d11f2a1a054bbff08b5 > Reviewed-on: https://chromium-review.googlesource.com/769853 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517152} TBR=jorgelo@chromium.org,palmer@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org Change-Id: I77e142638d73bd53de4b6fc1b9db2ffc819f6459 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771365 Reviewed-on: https://chromium-review.googlesource.com/775594Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517218}
-
Emircan Uysaler authored
This is a reland of cff667d9 Original change's description: > Use async GPU readbacks in canvas.captureStream() > > This CL replaces the existing blocking call to SkImage::readPixels() with > GLHelper::ReadbackTextureAsync() and GLHelper::CreateReadbackPipelineYUV() > callbacks for texture backed images. > In order to use for these calls, a GLHelper instance is lazily created and > owned by blink::WebGraphicsContext3DProvider. > > Bug: 727385 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Iad8561183afddff0794038213ee22cec3e04ed76 > Reviewed-on: https://chromium-review.googlesource.com/756474 > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516979} TBR=danakj@chromium.org,miu@chromium.org,kbr@chromium.org,haraken@chromium.org,junov@chromium.org Bug: 727385 Change-Id: Ic939674cf678a239a9a68bfb6211198fa33441c9 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/775593Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517217}
-
Scott Violet authored
We're not using it anymore. BUG=none TEST=none Change-Id: I029f967a98acc26ada4fbeebae4739acc9695d2f Reviewed-on: https://chromium-review.googlesource.com/775178Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#517216}
-
Andrew Grieve authored
Robolectric assumes that all R.java files that define a resource define it with the same ID. This is true for android_apk() targets because they run a final process_resources() step. However, junit_binary() targets currently just pull in the intermediary R.java files, which define different values for same resources. This change makes junit_binary act more like android_apk, in that it adds a dedicated call to process_resources() in order to generate consistent R.java files. Bug: 785618 Change-Id: I62f8c3d30a626ec63ad22f9759adb9ad66f94b88 Reviewed-on: https://chromium-review.googlesource.com/773978Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#517215}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2db9c912..06577269 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibcb3154e662ea26c346a8d67e8711f6ade564e36 Reviewed-on: https://chromium-review.googlesource.com/774758Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517214}
-
Trent Apted authored
Also make the focus ring rounded corners properly rounded. Currently the focus ring is drawn with a rounded-rectangle _stroke_. That gives the "middle" of the stroke the correct correct corner radius, but it's the outside edge of the stroke that matters. To make nice rounded rectangles, it's necessary to draw a fill rather than a stroke. Currently the focus ring on non-retina appears to take a "shortcut" around the corners. Fix the border stroke as well as the focus ring so that everything is symmetric and aligns nicely. The shrinking is a problem for aligning bubbles. Fix it by, uh, not shrinking when the omnibox has focus. Animated before/after screenshots: non-retina - https://bugs.chromium.org/p/chromium/issues/attachment?aid=312541&inline=1 retina - https://bugs.chromium.org/p/chromium/issues/attachment?aid=312539&inline=1 Bug: 761701 Change-Id: I4d3e4dd15175c6d9454b633fa693cadeba39588f Reviewed-on: https://chromium-review.googlesource.com/773718Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#517213}
-
liberato@chromium.org authored
This CL incorporates SurfaceChooserHelper to handle promotion hints from CodecImage. It also requests promotion hints in VideoFrameFactoryImpl. This adds support for both player-fs and div-fullscreen cases for overlays to MCVD. Bug: 781875 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8063a562676af9a0a5532b8434f9fe7fee20b005 Reviewed-on: https://chromium-review.googlesource.com/762061 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#517212}
-
Lucas Garron authored
Bug: Change-Id: I1f9c87102672de1c60c6e505ba183220e7b7689f Reviewed-on: https://chromium-review.googlesource.com/774121 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#517211}
-
Yuzhu Shen authored
Bug: None Change-Id: I476e1ba191391085cc6719b07c90fa0a6f2e42db Reviewed-on: https://chromium-review.googlesource.com/775676Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#517210}
-
Nektarios Paisios authored
The IAccessible2 APIs allow an AT to retrieve the caret offset in any object via |get_caretOffset| and ask for the ia2hypertext using |get_text(start-offset, end_offset)|. None of these APIs return or accept an affinity. This makes it impossible for us to determine which piece of text should be returned when anonymous inline blocks are not used to separate lines. Anonymous inline block ++Static text "Line 1" Inline block ++Static text "line 2" If the anonymous block is ignored in the accessibility tree we get: Static text "Line 1<embedded object character>" The text offset for the embedded object character could either refer to the end of line 1 or the beginning of line 2. R=dmazzoni@chromium.org, aleventhal@chromium.org Tested: With Jaws by creating a content editable and typing a few lines Change-Id: Iafcca4ff41796a045b598b95a62e92efdd99f4aa Reviewed-on: https://chromium-review.googlesource.com/773111 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517209}
-
Vlad Tsyrklevich authored
Control Flow Integrity [1] indirect call (cfi-icall) checking can not verify that dynamically resolved function pointers call their intended function. Instead we place the pointer for GLGetProcAddress in ProtectedMemory, a wrapper for keeping variables in read-only memory except for when they are initialized. After setting the pointer in protected memory we can use the UnsanitizedCfiCall wrapper to disable cfi-icall checking when calling it since we know it can not be tampered with. [1] https://www.chromium.org/developers/testing/control-flow-integrity Bug: 771365 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia79c1cfab8e00f88bcc437c34cbb3012537c015a Reviewed-on: https://chromium-review.googlesource.com/769654 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517208}
-
Andrew Grieve authored
Bug: 664306 Change-Id: Ie2c460e9c6af89833ecb3e67100f969233729e39 Reviewed-on: https://chromium-review.googlesource.com/774939Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#517207}
-
Eric Karl authored
We aren't benefitting from the complexity added by the DeferredTextureImageData APIs, and this API blocks us from using PaintImage::Decode's decode-to-scale functionality. This change removes our usage of DeferredTextureImageData APIs, instead using SkImage::makeTextureImage to handle upload. Additionally, we now use the PaintImage::Decode API, adding decode-to-scale support. Bug: 773799 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia5f480213c3a5c8225ccd289aa2c081056840f94 Reviewed-on: https://chromium-review.googlesource.com/713593Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#517206}
-
Albert J. Wong authored
Previously, the background trigger logic attempted to hop between the IO and UI threads. This caused problems with task invalidation. In the new logic, the background trigger logic only runs on the UI thread which allows cancellation using WeakPtrFactory. Bug: 751321 Change-Id: Ibccf6f5f898ce53ffa2d52f11ebba00118d025f2 Reviewed-on: https://chromium-review.googlesource.com/773113 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517205}
-
Robert Sesek authored
6dd2be7c44a9 Stop providing unimplemented stubs for util/mach/exc_server_variants.cc f09257b17c36 Remove more unneeded MIG server stubs a7453394d6ed Provide a StringPiece getter and setter for StringAnnotation Bug: 598854 Change-Id: I402e191195c90891c0f44e73334cfceed2f61568 Reviewed-on: https://chromium-review.googlesource.com/774912Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517204}
-
David Tseng authored
This reverts commit 9cb0482f. Reason for revert: <INSERT REASONING HERE> A subsequent change stops the failing test from being run on asan but went through after this revert. Seee bug 776308 Original change's description: > Revert "Reland2: Fire focus if needed in automation api" > > This reverts commit 66698953. > > Reason for revert: So sorry to do this! But that same test is failing consistently post this reland: > https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24261 > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F24261%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FTestAsNormalAndGuestUser__x2f_SpokenFeedbackTest.NavigateSystemTray__x2f_0%2F0 > > Original change's description: > > Reland2: Fire focus if needed in automation api > > > > TBR=dtseng@chromium.org > > Bug: 773866 > > > > Original change > > > > Reviewed-on: https://chromium-review.googlesource.com/723606 > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#509911} > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > > Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077 > > Reviewed-on: https://chromium-review.googlesource.com/728302 > > Reviewed-by: David Tseng <dtseng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#510131} > > TBR=dmazzoni@chromium.org,dtseng@chromium.org > > Change-Id: Id0bc77906aee42b7449e72c71bc2c533ed7ddcb9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 773866 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/729720 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510305} TBR=dmazzoni@chromium.org,dtseng@chromium.org,aboxhall@chromium.org Bug: 776308, 773866 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia67d7681b56c6475f4824c82f434f0c1f0a820f8 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/775618Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#517203}
-
Shenghua Zhang authored
Bug: 778442 Change-Id: Ic4d924ff0a36b47d78b7af16bebbe010ce7094c2 Reviewed-on: https://chromium-review.googlesource.com/770612 Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517202}
-
Jiaquan He authored
This commit: - removes all app_list_constants.* and app_list_features.* references from app list model classes; - removes some unused model file includes. Bug: 733662 Change-Id: If7887a4c4cb4fa479fd72a0d5dee895cb4449568 Reviewed-on: https://chromium-review.googlesource.com/775515 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517201}
-
Ryan Hamilton authored
BUG=784147 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2831e2f7191e089cbb3011ca6907283b427cb3a6 Reviewed-on: https://chromium-review.googlesource.com/767329Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#517200}
-
Yuri Wiitala authored
Introduces the capture pipeline implementation. This is the glue between all of the various components and actors in the system. In an upcoming change, mojo IDL will be introduced to allow VIZ clients to create and control FrameSinkVideoCapturers and receive a stream of video frames. Bug: 754872 Change-Id: I6074f2556f49d18ed4f031f7d3a5d667d13ce49a Reviewed-on: https://chromium-review.googlesource.com/765689 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#517199}
-
Joshua Pawlicki authored
Bug: 785936 Change-Id: I08bf3e8a66291df8fffa256bad765c6e0743d29b Reviewed-on: https://chromium-review.googlesource.com/775555Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#517198}
-
Danyao Wang authored
WKBasedNavigationManager::AddPendingItem returns an existing nav item for back/forward navigation. So we can't assume RENDERER_INITIATED just because AddPendingItem() is called. This fixes breakage in NavigationCallbacksTest.ForwardPostNavigation. Bug: 776077 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7b9aa10654e6073647390a021e77eefb8005794b Reviewed-on: https://chromium-review.googlesource.com/769862Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#517197}
-
Robert Flack authored
This is a followup to https://crrev.com/c/770451 which added MAYBE_TimeT but didn't use it to disable the test. TBR=mark@chromium.org Bug: 782033 Change-Id: Ic6b4d319fcc572c78b01a8642ea415e77dc1a2eb Reviewed-on: https://chromium-review.googlesource.com/774993Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517196}
-
Zhenyao Mo authored
BUG=783069 TEST=GPU bots R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If14091cbaa75d941a88c28f7a3aa7baed3d7e0e9 Reviewed-on: https://chromium-review.googlesource.com/767115 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517195}
-
Abhishek Arya authored
R=rnk@chromium.org,etienneb@chromium.org Bug: 783296 Change-Id: I9b7e4dc365781881cf12f97ac2e612b5f23daba3 Reviewed-on: https://chromium-review.googlesource.com/769302 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#517194}
-
Steven Bennetts authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ef632e4a473b..aed007c17605 $ git log ef632e4a4..aed007c17 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 cywang auto_updater: Apply cold reboot for AU 2017-11-15 dgarrett cros tryjob: Fix submission of unknown build configs. 2017-11-15 dgarrett cros_tryjob: Add go link to -tryjob error messages. 2017-11-16 phobbs Revert "gob_util: Support Appengine Gerrit credentials." 2017-11-14 dgarrett branch-util: Fix branch-util-tryjob for testing. 2017-11-15 shapiroc Fix issue with model specific au fanout 2017-11-07 aelder deploy_chrome: Add --private_key option 2017-11-09 phobbs locking: Fix errno.EDEADLK reference. 2017-11-15 cmtice Revert "generic_stages: temporarily ignore all target prebuilts." 2017-11-15 chrome-bot Update config settings by config-updater. 2017-11-15 hiroh TestSimpleChromeWorkflowStage: Pass --nogn-gen to cros chrome-sdk 2017-11-09 phobbs gob_util: Support Appengine Gerrit credentials. 2017-11-08 achuith [cros_vm]: Use virtio instead of cirrus. 2017-11-14 cmtice generic_stages: temporarily ignore all target prebuilts. 2017-11-13 shapiroc Configure coral for chrome/android pfq and paladin 2017-09-13 vapier cros tryjob: restore metavar 2017-11-14 stevenjb TestSimpleChromeWorkflowStage: Pass --nogngen to cros chrome-sdk 2017-11-14 chrome-bot Update config settings by config-updater. 2017-11-13 xixuan cros-update: use curl instead of wget to check devserver health. 2017-11-13 chrome-bot Update config settings by config-updater. 2017-09-29 stevenjb cros_chrome_sdk: Automatically generate args.gn files 2017-11-11 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts." 2016-07-20 sjg commands: Use cros_config_host instead of fdtget 2017-11-08 dgarrett cbuildbot: Enforce tryjob safe configs. 2017-11-01 dgarrett cros tryjob: Enforce tryjob safe configs. 2017-11-07 manojgupta generic_stages: temporarily ignore all target prebuilts. 2017-11-09 akeshet summarize_build_stats: link to new cq-weekly dashboard 2017-11-09 akeshet summarize_build_stats: drop the "Top reasons" table 2017-11-09 akeshet summarize_build_stats: add a category picker to the top X lists 2017-11-10 chrome-bot Update config settings by config-updater. 2017-11-09 dgarrett chromeos_config: Remove tryjob config overrides. 2017-11-01 dgarrett cros tryjob: Update --list for production vs tryjob. 2017-11-07 vapier image_test: move security_CroshModules autotest here 2017-11-08 derat chromite: Make TastVMTestStage unforgiving. 2017-11-06 nxia Get current builders_array from metadata. 2017-11-09 stevenjb chrome_chromeos_lkgm: Add --email to 'git cl upload' 2017-11-08 derat chromite: Run ARC Tast VM tests on betty-release. 2017-11-08 ayatane Fix typo 2017-11-06 ayatane Exclude provision suite from subsystems 2017-08-21 smbarber chromeos_config: Add tatl-full builder on external waterfall 2017-11-08 lhchavez Remove support for aosp_bertha* Android targets 2017-11-08 stevenjb chrome_chromeos_lkgm: Remove any existing chrome checkout 2017-11-08 chrome-bot Update config settings by config-updater. 2017-09-28 nxia chromite changes for Cros_CL_Status_Viewer 2017-11-06 phobbs cidb: Changes for cl_exonerator 2017-11-07 dgarrett chromeos_config: Update generated files together. 2017-11-07 achuith [cros_vm]: Better error messages for qemu. 2017-11-03 pprabhu cidb_integration_test: Wait longer for mysqld to initialize. 2017-11-08 chrome-bot Update config settings by config-updater. 2017-10-20 dgarrett chromeos_config: Create mirrored tryjob build configs. 2017-11-07 stevenjb cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) 2017-11-06 akeshet pre-cq: mark failed-to-apply changes as pre-cq-failed so they don't loop 2017-10-27 davidriley Reland "cbuildbot: Emit partition files for provisioning purposes." 2017-11-06 derat chromite: Ensure TastVMTest runs after VMTest failure. 2017-11-06 pprabhu cq_stats: deploy the correct cidb credentials. 2017-11-06 pprabhu Update cidb settings for gen2 SQL instances. 2017-11-06 pprabhu Hack fake_modules some more to allow chromite import. 2017-10-31 dgarrett cros_uprevchrome: Tweak tempdir creation. 2017-11-06 dgarrett cros_tryjob: Add --chrome_version passthrough option. 2017-11-03 llozano chromite: cleanup board lists for llvm-toolchain configs. Created with: roll-dep src/third_party/chromite Bug: 762650 Change-Id: Ib17a3570e32c98bae423d88c6320a5be95a26fef Reviewed-on: https://chromium-review.googlesource.com/775023Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517193}
-
Xianzhu Wang authored
The test seems still flaky, but the incorrect text expectation shadowed the image flakiness. Rebaseline the text expectations to expose the real image flakiness. Bug: 777259 Change-Id: I176c37017288122becd018aa154f44465b5e574c Reviewed-on: https://chromium-review.googlesource.com/774501 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517192}
-
Alexandr Ilin authored
This reverts commit e378a8f4. Reason for revert: Several performance regressions was found. The feature will be re-enabled after all issues are fixed. Original change's description: > Enable SpeculativePreconnect Field Trial Testing > > The predictors::kSpeculativePreconnectFeature is explicitly disabled in > net::Predictor browser tests because the LoadingPredictor if enabled > intercepts all prefetch and preconnect coming from a renderer. > > WarmupManagerTest.testPreconnect() was expecting two connections to be > opened but it's not the case for the LoadingPredictor, it opens only > one connection. > > Bug: 699080 > Change-Id: I73537c3a59818793e41c5741762fe675a4efa97f > Reviewed-on: https://chromium-review.googlesource.com/754837 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Alexandr Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515502} TBR=jwd@chromium.org,tedchoc@chromium.org,xunjieli@chromium.org,alexilin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 699080, 784206 Change-Id: I315b11b955b4aee52b6644835d649414507265f4 Reviewed-on: https://chromium-review.googlesource.com/774779Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517191}
-
Henrique Nakashima authored
Bug: 665554 Change-Id: I96b716d38a51c13a5d94595c2b568f06471a33aa Reviewed-on: https://chromium-review.googlesource.com/774980Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#517190}
-
Kyle Horimoto authored
When GATT services are unavailable, BluetoothLowEnergyWeaveClientConnection bubbles an event up to SecureChannel, which subsequently bubbles an event up to BleConnectionManager. This CL will be used in a follow-up CL to work around the GATT services issue. Bug: 784968, 672263 Change-Id: I63de1eb025fcef9bec32bd10f3f3956d53c14cca Reviewed-on: https://chromium-review.googlesource.com/773586Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517189}
-
Kevin Bailey authored
Moved resolution of template URL service earlier, as well as DCHECKs. Removed subsequent unnecessary null tests. Bug: 766382 Change-Id: I7ee5460e8a02bf28dc5984d5424f5ab7c826896f Reviewed-on: https://chromium-review.googlesource.com/772071 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#517188}
-
Greg Thompson authored
The test harness is less flaky now, so perhaps this can run reliably. BUG=665296 R=sky@chromium.org Change-Id: Iae61f9aa6cce8eaa4d99ed2cf7d8794e9dec1094 Reviewed-on: https://chromium-review.googlesource.com/774599Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#517187}
-
Daniel Park authored
Bug: 783991 Change-Id: I3ba066c89f8733e2b20acc71e2103f467749cae4 Reviewed-on: https://chromium-review.googlesource.com/772800Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#517186}
-