- 23 Oct, 2019 40 commits
-
-
Stephen McGruer authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: Ia6d3f44d2b9fbe139192e8057167063aefcee7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875386Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708713}
-
Sean Topping authored
Adds MediaControlUi, which can be used to enable a simple touch UI for media apps without a touch-supported UI. Some other changes are included in this CL to simplify internal code as a result of this change: * Remove CastWindowManager from CastContentWindow public API. * Rename CastWindowManager::SetWindowId() to SetZOrder(). * Move CastContentWindow from "shell" namespace to "chromecast". Merge-With: eureka-internal/316519 Bug: internal b/137663169 Test: CQ Change-Id: I2d78e73162bb30a652f591b5def651468e44eaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817146Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#708712}
-
Anastasiia Nikolaienko authored
Change route for Sync subpage in focus configuration map for people page. onIronSelect_ in settings_animated_pages.js throws an assertion error for '#sync-status .subpage-arrow'. It looks like .subpage-arrow element was removed in https://crrev.com/c/1742350. Bug: 1014317 Change-Id: I7ca645cfae432305616fcf7e2415cebddd4c103b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875101Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#708711}
-
Rayan Kanso authored
Pipes whether addresses are required to mojo, and handles the expected address return values. TBR=mkwst@chromium.org Bug: 1016870 Change-Id: I4d77de31736195c01754369e71f78d6825a1f811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874206 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708710}
-
Stephen McGruer authored
TBR=eyaich@chromium.org Bug: 1017290 Change-Id: Ifc2e4fcbdc9a184d71ad8749c0a0f40ff95b241b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876733Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708709}
-
Darin Fisher authored
This renamed ContentSettingsRenderer to ContentSettingsAgent and the corresponding class ContentSettingsObserver to ContentSettingsAgentImpl. This class represents the agent of the content settings system that runs in the renderer process. It is responsible for answering some of the blink::WebContentSettingsClient methods directly and for others it needs to delegate to the browser process. It does so through a new interface named ContentSettingsManager. This provides async and sync methods to check for permission to access different storage types. A big change here is that instead of answering these questions about storage access on the IO thread, now the code is answering those on the UI thread. The old code was constrained by the NPAPI plug-in system that forced synchronous IPCs from the renderer process to be handled not on the UI thread. Now we no longer have that constraint, and it is far simpler to just handle the IPCs directly on the UI thread. There is potential for some added delay to storage access if the browser's UI thread happens to be busy, but this should be a minor issue compared to the overall cost of accessing the storage systems. Change-Id: I97513988c900efe63f4feb02894d7a14e6fec8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864823 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#708708}
-
Johannes Henkel authored
This makes the code shorter, there is less shuffling things into and out of fields. Add comment about why we don't queue serialized messages. Change-Id: Icbb2e6cd3eb63290d845a817f06bc4bd6a5a59a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873203 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708707}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/21bfa401ddea..6adb0a26846c git log 21bfa401ddea..6adb0a26846c --date=short --no-merges --format='%ad %ae %s' 2019-10-23 mbonadei@webrtc.org Do not compile webrtc_lib_link_test if is_asan=true. Created with: gclient setdep -r src/third_party/webrtc@6adb0a26846c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5ce2f02f580dae2e6d642508b942d8b703ad1d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708706}
-
Kelvin Jiang authored
This CL adds a MatchedRule (which consists of a rule ID and a source type) to RequestAction, which is needed to support the getRulesMatched and onRuleMatchedDebug functions for the DNR feedback API. Bug: 967942 Change-Id: Ie10bc5b0a84963a909bb72f3bd51b355fd9d530c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869989 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708705}
-
Wei-Yin Chen (陳威尹) authored
TabAttributeCache stores URL, title, and root ID for tabs so that they are available before native initialization. Bug: 1016952 Change-Id: I45365dff66c89d859562c116e61a0a9ea75f2bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874707Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708704}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/b5a8b9ebfa6e..4cc508c720ac $ git log b5a8b9ebf..4cc508c72 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 fayang Fix build error in chromium by adding QUIC_EXPORT. 2019-10-22 renjietang Clean up code on SETTINGS. 2019-10-22 vasilvv Split QuicEndpoint into QuicEndpoint and QuicEndpointBase. 2019-10-22 renjietang Consider pending streams in ShouldKeepConnectionAlive. 2019-10-22 wub Internal QUICHE change 2019-10-22 renjietang Do not accept fin that would decrease the stream's final offset. 2019-10-22 zhongyi Add get method for initial_retransmittable_on_wire_timeout, which is used by chromium only and accidentally removed in cl/275943283. 2019-10-22 fayang gfe-relnote: Remove save_retransmittable_frames from QuicPacketCreator::AddFrame. No functional change expected, not protected. 2019-10-22 renjietang Clean up QuicPacketCreatorTest. 2019-10-22 fayang gfe-relnote: In QUIC, clean up !session_decides_what_to_write code path. 2019-10-21 quiche-dev Internal QUICHE change 2019-10-21 renjietang Fix buffer overflow issue by changing how test string is created. 2019-10-21 zhongyi When there is no retransmittable packet on the wire and there are open streams, the connection may send retransmittable PINGs to detect path degrading with aggressive timeout. 2019-10-21 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_rst_if_stream_frame_beyond_close_offset. 2019-10-21 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_aggressive_connection_aliveness 2019-10-21 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_do_not_send_settings. 2019-10-21 fayang gfe-relnote: In QUIC, populate the actual length of full padding frame in nonretransmittable_frames (of SerializedPacket). Protected by existing gfe2_reloadable_flag_quic_populate_nonretransmittable_frames. 2019-10-21 wub Internal QUICHE change 2019-10-21 fayang gfe-relnote: In QUIC, add a utility function CopySerializedPacket. Not used yet, not protected. 2019-10-21 fayang gfe-relnote: In QUIC, populate nonretransmittable_frames in SerializedPacket. Protected by gfe2_reloadable_flag_quic_populate_nonretransmittable_frames. 2019-10-18 vasilvv Implement QuicTransportStream, a stream that can be only accessed after client indication is received. 2019-10-18 wub gfe-relnote: (n/a) In quic_framer_process_data_packet_fuzzer, set framer's decrypter for INITIAL encryption level. Test only. 2019-10-18 renjietang Remove redundant calls to QuicSession::NeuterUnencryptedData(). 2019-10-18 dschinazi Refactor quic_client_interop to avoid dropping letters 2019-10-18 renjietang Coalesce adjacent stream frames. 2019-10-18 quiche-dev Add a new Tunnel Health Checker. The health checker is configured to run about every 5th ICMP probe and checks the packet exchanger's counters in both directions. If *no* packets have passed in one direction, this will tear down the tunnel, leaving it to be restarted on the next epoll cycle. 2019-10-18 zhongyi gfe-relnote: n/a, test change only. 2019-10-18 fayang Add two copy utility function CopyQuicFrame and CopyQuicFrames. 2019-10-18 fayang gfe-relnote: Add a bool to QuicSentPacketManager, indicating whether a forward secure packet gets acked. No functional change expected. Not protected. 2019-10-18 wub gfe-relnote: (n/a) Fix quic_framer_process_data_packet_fuzzer to not to use version 0. Test only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ie3d7ff02abbfda44dcb0611afe967f1c43422026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872655 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708703}
-
Huanzhong Huang authored
To address https://bugs.chromium.org/p/chromium/issues/detail?id=1005788#c41; allow screen reader to read out a text associated to cookie controls toggle. Bug: 1017143 Change-Id: I9031d3f82bcda44b0e8b6fd59c8e9b6a43dfc930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876387Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#708702}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32803ff74448..e9462dd2dac4 git log 32803ff74448..e9462dd2dac4 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 robertphillips@google.com Rename *worstCase* to backingStore* in GrSurfaceProxy 2019-10-23 fmalita@chromium.org GPU support for SkColorFilters::HSLAMatrix Created with: gclient setdep -r src/third_party/skia@e9462dd2dac4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I689f298d6568ef4ecb3d6d39f7f5dbfc46ba9365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708701}
-
Dale Curtis authored
These are no longer needed and some of them have expired. BUG=1000058 R=tguilbert Change-Id: Icb64d7c76610d888c4083c72a6c0633a057d0fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874709Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708700}
-
Elly Fong-Jones authored
Migrate to the new DialogDelegate::set_button_label() pattern. Also, since the string is static, use it directly from the view. Bug: 1011446 Change-Id: I067d07b75d7d02c628f009328e36afdfd1d1f7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876467Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708699}
-
Lily Chen authored
Bug: None Change-Id: I62d87f2fcb30322e0f311de7dfdf1d0992d044e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876793 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#708698}
-
Shivani Sharma authored
Populate NetworkIsolationKey in MockHttpRequest so that the tests are equipped to support partitioned Http cache. Also passes the generated cache key in various test utility functions instead of simply the URL. Bug: 1009621 Change-Id: I5c9577a8bffc9438902bd9c079a703a2dcf6e191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830094 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708697}
-
Javier Ernesto Flores Robles authored
This adds a common method to our testing class that can be used in EG1 and EG2. |EarlGrey| has 2 methods to rotate the device, once for EG1 and another for EG2. Which makes this check pretty common in the EG2 migration. Adding it to the base test class instead of to |EarlGrey| to avoid creating a 3rd method signature for it. Once EG1 support is removed a simple search and replace can be used to clean this. Bug: 1016368 Change-Id: I24b2c4ae56266111e6069990252164090df80bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871874 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#708696}
-
Xiyuan Xia authored
This reverts commit 099f851f. Reason for revert: Breaks popup widget on Windows: https://crbug.com/1016672 https://crbug.com/1016980 Original change's description: > cros: Fix capturing orientation > > Instead of setting the rotation as part of the transform on > ash root window, call viz SetDisplayTransformHint so that > capturing code as a consumer of viz could get the correct > orientation. > > Bug: 847693 > Change-Id: Id70f91dc84fc9274145d5a160a51b8c7fa50deed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825892 > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707004} TBR=xiyuan@chromium.org,sky@chromium.org,oshima@chromium.org,dcastagna@chromium.org,khushalsagar@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847693, 1016672, 1016980 Change-Id: Ic437d89b1cd43b3c9280dadeb45be93f5a21b753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876689Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708695}
-
Tomasz Wiszkowski authored
This change ensures that the Suggestion icon's drawable area remains square. We cannot depend on vertical dimension of the embedded drawable because ColorDrawables, that (along with BitmapDrawables) are entirely handled by RoundedCornerImageView, do not have a fixed vertical size. Bug: 982818 Change-Id: Ib6966eaaaa21d85e61220c9631ae19cd269a2779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866921 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#708694}
-
Stephen McGruer authored
Bug: 788440 Change-Id: I0a208b7c363e912ed76f270dbcc1af3e16a44100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829355Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708693}
-
Alex Cooper authored
Removes the "test" qualifier for WebVr, thus ensuring that all existing and any future WPTs or web_tests for WebVr will not work. Stops import of WebVr specific WPTs. As part of prepping to remove the runtime flag, also removes the feature policy mapping for WebVr and the corresponding webexposed feature policy Future changes will remove the browser tests and then the corresponding runtime flag and all remaining blink code. Bug: 960132 Change-Id: I884718d8644d5b95eded93c781cce2c410adb0bc No-Export: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865531Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#708692}
-
chrome://device-emulatordpapad authored
Fixed: 1015241 Test: Page still loads, no more HTML Imports warnings in DevTools. Change-Id: Id253682734ef7d456b5dd244657011f5de03d73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874814Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708691}
-
Fritz Koenig authored
CMAA was put in place to improve performance on Intel GPUs. Performance has improved on Gen9 GPUs to the point that MSAA 4x is faster than CMAA. On older GPUs run with MSAA 2x, which is comparable to CMAA in speed. Bug: 1003860 Test: chrome://gpu shows MSAA Test: https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html?webglVersion=2 Change-Id: I3500881cbd74fa430eb0b209880b8b242fc708eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815768Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#708690}
-
Jonah Ryan-Davis authored
Tests became very flaky, suppressing to get the trybots green. TBR=ynovikov@chromium.org Bug: 1017162 Change-Id: Idac22c98879e4d4b44c24287e4a03ce87fb7452b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875275 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#708689}
-
Chris Mumford authored
TtsApiTest.PlatformSpeakError used testing::CreateFunctor which was unnecessary because gmock's testing::InvokeWithoutArgs currently supports invoking a method of an object. Making this change simplifies the test as well as an upcoming change to gmock_mutant.h. Bug: 1007833, 806952 Change-Id: Id8dbd560ba1233ba2288e8179b0aced29d02a110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874052Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708688}
-
Klaus Weidner authored
ARCore's checkAvailability reads shared preferences via ArCoreContentProvider, need to turn off strict mode to avoid failing tests that run with enforcement enabled by default. Bug: 1015597 Change-Id: I55023029673498455fd673185ed9153be0af5148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874826Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#708687}
-
Lei Zhang authored
Build a binary for the PDFium fuzzer added in https://pdfium-review.googlesource.com/61470 . Change-Id: Ibec0fb7289691e446d62af5557385aef1253d30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873397Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#708686}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f4478ca7839..370eefceab98 git log 1f4478ca7839..370eefceab98 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 saklein@chromium.org call_templates: Fix artifacts examples and standardize to betty Created with: gclient setdep -r src/third_party/chromite@370eefceab98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I60f81f9bece0c000a02cfde4b1fb8d0f32bfa4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708685}
-
Yusuke Sato authored
With this change, the order of private functions in the class roughly match the order they are called. This is just to make the code slightly easier to read. BUG=None TEST=try, no real code change Change-Id: I02a5d090fb29b70e70b50802eda6b141774efc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876727 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#708684}
-
Xinghui Lu authored
Password Reuse Detection is not fully functional on Android because it doesn't capture SetComposingText events and FinishComposingText events. In this CL, add SetComposingText and FinishComposingText events to ime_input_event_observers_. Changes on password manager which uses new APIs is in crrev.com/c/1873144. Bug: 1006430 Change-Id: Icb0e378d71bc0d1a2b42e70972ee4fd7cd97035c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824360 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#708683}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0cdd39db4443..1342a6ae6285 git log 0cdd39db4443..1342a6ae6285 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 treehugger-gerrit@google.com Merge "processor: Expose a C++ API for ExportJson to chrome" Created with: gclient setdep -r src/third_party/perfetto@1342a6ae6285 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I989a1ed0b1e0a6d65766ca1f525f60637841a387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875341Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708682}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a3f0da56e4c9..341701573a5d git log a3f0da56e4c9..341701573a5d --date=short --no-merges --format='%ad %ae %s' 2019-10-23 johnkslang@users.noreply.github.com Merge pull request #1946 from KhronosGroup/extend-web Created with: gclient setdep -r src/third_party/glslang/src@341701573a5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: Idde37ce3c894487c03465f24cab419403c668704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875344Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708681}
-
Michael Spang authored
This fixes the following error in components builds on chromecast: ld.lld: error: undefined symbol: media::mojom::kMediaRendererServiceName >>> referenced by shell_content_browser_client.cc:301 (../../content/shell/browser/shell_content_browser_client.cc:301) >>> content_shell_lib/shell_content_browser_client.o:(content::ShellContentBrowserClient::RunServiceInstance(service_manager::Identity const&, mojo::PendingReceiver<service_manager::mojom::Service>*)) in archive obj/content/shell/libcontent_shell_lib.a clang: error: linker command failed with exit code 1 (use -v to see invocation) Change-Id: I4fa28fead6e003b1bfc9fe0448c53acf56864b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874331Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708680}
-
Xing Liu authored
Starts from Android O MR1, Android code may resize the large icon. We don't need to check equality on the large icon bitmap. Bug: 999357 Change-Id: I65f38a0fb120608ea9d23611f6e93db5ec674bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864385Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708679}
-
Ken Rockot authored
Ports ash usage of the Data Decoder service to use the service interface directly rather than going through a Service Manager Connector. Bug: 977637 Change-Id: I3cf24b34ab0eeff6665055b5add7fb1d90c591bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872918Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#708678}
-
Josh Nohle authored
This is an implementation of CryptAuthV2DeviceManager used for tests. It queues DeviceSync requests made via ForceDeviceSyncNow(). These requests are sequentially processed by calls to FinishNextForcedDeviceSync(), which also updates parameters such as the last DeviceSync time. Bug: 951969 Change-Id: I964425fcab12a25d58082f882d344146f324bacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874196Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#708677}
-
Mohamed Amir Yosef authored
With the new parser in place, FormData should be used to check empty fields instead of PasswordForm Change-Id: I8242cc82524d14de4a82c2ffde6d8c059c7d3ee2 Bug: 949519,1017129, 1008798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849894 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#708676}
-
Xianzhu Wang authored
The tests were flaky because of inconsistent forcus status. Change-Id: Idb494efcc489a441446c4a9b12968cde86faf8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872991Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708675}
-
Lily Chen authored
This change adds different types with which CookieAccessDelegateImpl can be constructed. One type, USE_CONTENT_SETTINGS is the default behavior of checking the CookieSettings to determine whether a given cookie is Legacy or Nonlegacy. The other type, ALWAYS_LEGACY, always returns Legacy access semantics for every cookie. The ALWAYS_LEGACY type of CookieAccessDelegate is used for Android WebView, for compatibility reasons. (The SameSite cookie changes would break too much stuff, so we treat every cookie as Legacy to maintain compatibility.) Bug: 986319 Change-Id: I68384da121b025525da5fd2ef6f9dff25a8a2ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872782Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#708674}
-