GitLab

Now that Promises have arrived in stable, we can start using them.
This change converts onStateChange to use promises and adds rudimentary
unit test support to handle this new feature.

V8's Promises are not used because the Javascript test harness expects
tests to complete synchronously. Promises, which run asynchronously, may
still be pending at the completion of a test, causing the test case to fail.

BUG=164227

Review URL: https://codereview.chromium.org/158003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250992 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=gcasto@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/153243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250990 0039d316-1c4b-4281-b951-d872f2087c98

r1852: (sdefresne) Fix generation for ninja of multiarch executable targets
r1851: (sdefresne) Use "formats" parameter to TestGyp to filter the format
r1850: (sdefresne) Improve ninja's Xcode emulation
r1849: (sdefresne) Extract XcodeVersion to be a standalone module function
r1848: (sdefresne) Fix comparison of Xcode version
r1847: (scottmg) Ninja generator: check if meminfo exists before reading it.

BUG=314720
R=blundell

Review URL: https://codereview.chromium.org/148903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342585
TEST=Remove the OFFICIAL_BUILD ifdefs and:
1) Confirm that running with --force-fieldtrials with an unforceable experiment and a forceable one only forces the forceable one.
2) Confirm that the value which couldn't be forced in the browser also makes it unforced in the renderer.

Put the OFFICIAL_BUILD ifdefs back and confirm that unforceable experiments are still forceable in non-official builds.

Review URL: https://codereview.chromium.org/153913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250988 0039d316-1c4b-4281-b951-d872f2087c98

    
    The program reads an H.264 bitstream file and writes a file containing
    the decoded frames in I420 format. Alternatively it verifies MD5 sum
    of the decoded frames. It can be used for development verification and
    regression testing.
    
    BUG=none
    TEST=run through H.264.1 Base/Ext/Main profile test streams on link.

Review URL: https://codereview.chromium.org/27498002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250987 0039d316-1c4b-4281-b951-d872f2087c98

The plan to use <dialog> in WebUI didn't work out. It was risky to use
an experimental feature in Settings, especially as Chrome for iOS won't
be able to use it.

BUG=276825

Review URL: https://codereview.chromium.org/156853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250986 0039d316-1c4b-4281-b951-d872f2087c98

We should update the manifest file as well as the contents of the extension in
the chromeos image.

BUG=342308
TEST=none

Review URL: https://codereview.chromium.org/162593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250985 0039d316-1c4b-4281-b951-d872f2087c98

For example, it supports running two GPU threads.

This simplifies the scheduling/queuing logic in InProcessCommandBuffer
a bit and moves the non-thread/queue implementation out to WebView by
allowing for passing in a InProcessCommandBuffer::Service instance
when creating a context.

BUG=332146

Review URL: https://codereview.chromium.org/143023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250984 0039d316-1c4b-4281-b951-d872f2087c98

- Variable renaming: they should be prefixed with received_ so that
  reviewer can understand that they store values received from the
  server
- HandleFrame() is just a part of ProcessFrame(). I want them to have
  names from which we can see that
- Factor out the switch-clause in HandleFrame building a frame type
  string as the method is very long

BUG=none

Review URL: https://codereview.chromium.org/131333010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250983 0039d316-1c4b-4281-b951-d872f2087c98

A UserStyleLevel parameter is no longer used in insertUserStyleSheet()
and insertUserStyleSheet() calls just insertStyleSheet() again.

blink side: https://codereview.chromium.org/143203006

Review URL: https://codereview.chromium.org/154113008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250982 0039d316-1c4b-4281-b951-d872f2087c98

Like linux, on android we can get the thread names to show up in the
debugger by setting the process name for the LWP.

This change sets the name of the calling thread using prctl.

BUG=332881

R=jam@chromium.org
R=torne@chromium.org

Review URL: https://codereview.chromium.org/144943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332032
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/132803012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250980 0039d316-1c4b-4281-b951-d872f2087c98

Update deps whitelist to match current downstream merge list.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/163323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250979 0039d316-1c4b-4281-b951-d872f2087c98

> suppress data race on media::CoreAudioUtil
> BUG=314654
> TBR=ygorshenin@chromium.org
> TEST=waterfall
> 
> Review URL: https://codereview.chromium.org/57643003

TBR=zhaoqin@google.com
BUG=314654

Review URL: https://codereview.chromium.org/163253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250977 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService (https://codereview.chromium.org/137753012/)

Reason for revert:
Possible build bustage on Win64.

Original issue's description:
> [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService
> 
> BUG=80194
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250814

TBR=bauerb@chromium.org,rogerta@chromium.org,pavely@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=80194

Review URL: https://codereview.chromium.org/162943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250967 0039d316-1c4b-4281-b951-d872f2087c98

If a channel closes right before a send call, listeners might not be notified of
the problem, which can cause hangs. This CL fixes that and adds a test that makes
sure that this does not happen in the future.

This is cl/30133002 + a memory leak fix.

BUG=338709

Review URL: https://codereview.chromium.org/150893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250964 0039d316-1c4b-4281-b951-d872f2087c98

Add GCM check in status code metric collection. We also decided to collect registration success signal now.

BUG=284553

Review URL: https://codereview.chromium.org/158023007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250963 0039d316-1c4b-4281-b951-d872f2087c98

We should use LF-only unless it is really necessary (e.g. .BAT files).
Probably this was introduced by crrev.com/250068.

BUG=none
TBR=mnaganov@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/162763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250962 0039d316-1c4b-4281-b951-d872f2087c98

Move the sources! section out of link_settings, where it was
being ignored.

BUG=330074

Review URL: https://codereview.chromium.org/150973007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250961 0039d316-1c4b-4281-b951-d872f2087c98

When a profile is being signed out, we need to:
1) Close all the requests and connections.
2) Delete the GCM store.
3) Delete the persisted registration info (sender IDs and
   registration ID) from the app's state store.
4) Delete the persisted data from prefs store

To support 3, we need to remember the IDs of all registered
apps. As the result, I added the code to write the IDs of
all registered apps to the prefs store.

Also due to this change, we do not need to listen to 
NOTIFICATION_EXTENSION_LOADED and load the registration info
when the app is loaded because we will restore all the app
IDs and then read all the registration info when GCMProfileService
starts. This also makes us support other types of apps.

BUG=284553
TEST=new tests added

Review URL: https://codereview.chromium.org/162233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250958 0039d316-1c4b-4281-b951-d872f2087c98

The idea came first while I found this code was using google_breakpad's
scoped_ptr version rather than base's version.

Then I saw in win8/ that this function could return a scoped_ptr to make
it clear the ownership to caller, i.e., this function passes the
ownership of ExceptionHandler to the caller, so it should own the
pointer to release it when it is done.

BUG=None
TEST=None
R=grt@chromium.org

Review URL: https://codereview.chromium.org/160283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250957 0039d316-1c4b-4281-b951-d872f2087c98

In some cases we have multiple libraries with the same package name
(particularly test+non-test). If one of these depends on the other and
refers to package-private stuff in the second, then it should be rebuilt
if the signature of package-private stuff is changed. To ensure that
happens, the TOC file must include the signatures of package-private
members.

Review URL: https://codereview.chromium.org/161773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250956 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for moving webpagereplay.py into Telemetry.

BUG=

Review URL: https://codereview.chromium.org/160443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250953 0039d316-1c4b-4281-b951-d872f2087c98

main changes:
- Updating synthetic video test sequence to be more uniform.
- Fixing added delay to render/playout times introduced in the rtp-stats API update.
- Sending audio packets to pacer in a timed manner.
 

BUG=329563

Review URL: https://codereview.chromium.org/147993010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250947 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/161873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95758

Review URL: https://codereview.chromium.org/139443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250944 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for integrating the error console work with the Apps Developer Tool.  On the chrome side, this means:
- Adding new DeveloperPrivateAPI functions to open developer tools and read file source.
- Making DeveloperPrivateAPI listen for extension errors.
- Refactor ExtensionErrorHandler WebUI to allow for shared code with DeveloperPrivateAPI (error_handler_ui_util).
- Refactor extension_error[_overlay].js to use either chrome.send or chrome.developerPrivate functions.
- Refactor so that all knowledge of whether the overlay can be displayed is in extension_error_overlay.js

Images: http://imgur.com/a/IAGMU#0
BUG=335313

Review URL: https://codereview.chromium.org/150663013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330735
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/161803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333900

Review URL: https://codereview.chromium.org/149843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250941 0039d316-1c4b-4281-b951-d872f2087c98

We want to track effectiveness of the app launcher install education
pages in enabling users to find, and start using, the app launcher when
it is auto-enabled upon installing the first v2 packaged app. The
launcher is not auto-shown for the "first" install, to encourage users
to learn where it is.

This CL marks "how" the app launcher is enabled (e.g. command line flag,
webstore, etc.), and when the enable occurs. Then, when the user shows
the app list, the enable method and time taken to show it is recorded.

We also need to record users that "never" show the app list, or who see
the app list show automatically upon installing a _second_ app. One hour
is chosen as a timeout: if no value is recorded after one hour, a value
is recorded in the "last" bucket for the time taken.

BUG=314235
TBR=xiyuan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250348

Review URL: https://codereview.chromium.org/143683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285976
TEST=content_browsertests:ServiceWorkerVersionBrowserTest.Install*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250804

Review URL: https://codereview.chromium.org/153553008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250936 0039d316-1c4b-4281-b951-d872f2087c98

(It uses --single-process, which is disabled on branded builders.)

BUG=342418

Review URL: https://codereview.chromium.org/161093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250934 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338

Review URL: https://codereview.chromium.org/160023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250930 0039d316-1c4b-4281-b951-d872f2087c98

Adding Ozone CursorLoader and necessary API functions to allow setting the cursor in SoftwareFactoryOzone

BUG=

Review URL: https://codereview.chromium.org/158023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250929 0039d316-1c4b-4281-b951-d872f2087c98

Also constantifying trial/group names for that trial to avoid duplicating hard-coded strings.

Review URL: https://codereview.chromium.org/147053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330931
R=eroman@chromium.org

Review URL: https://codereview.chromium.org/159913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250927 0039d316-1c4b-4281-b951-d872f2087c98

the Storage API docs are now hosted at extensions/storage not
extensions/storage.html. Paths which include .html are redirected to remove the
.html.

BUG=294008
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/148293018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250926 0039d316-1c4b-4281-b951-d872f2087c98

Tests have changed significantly since the flake. Hopefully all the
base::RunLoop work has fixed it now. The stray content::RunMessageLoop is gone.

BUG=171546

Review URL: https://codereview.chromium.org/161133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250925 0039d316-1c4b-4281-b951-d872f2087c98