GitLab

- roll clang 142072:142664

BUG=none
TEST=none
TBR=hans

Review URL: http://codereview.chromium.org/8370009

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8382027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107056 0039d316-1c4b-4281-b951-d872f2087c98

In this mode, we issue queries as the user types, but don't show the preview.
The name HIDDEN seems more appropriate here, so I've usurped that name for this
trial, renaming the earlier one to SILENT (since it doesn't speak the queries
over the wire).

BUG=none
TEST=interactive_ui_tests InstantFieldTrial*

Review URL: http://codereview.chromium.org/8370020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107053 0039d316-1c4b-4281-b951-d872f2087c98

This happens when a handler is registered, where there is already a handler
with the same origin and scheme already registered. These calls should go
through the the registry and update the registered handler, and now do.

This was broken recently however the unit tests did not catch the problem,
because the key logic was in browser.cc. That logic has been moved into the
registry and a test added.

BUG=99926
TEST=Unit test added.


Review URL: http://codereview.chromium.org/8371023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107052 0039d316-1c4b-4281-b951-d872f2087c98

I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8351025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100898
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/8359029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107050 0039d316-1c4b-4281-b951-d872f2087c98

gypi magic needs right incantation

BUG=none
TEST= waterfall green, specially safe_browsing_tests and sync_unittests
Review URL: http://codereview.chromium.org/8351017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78283
TEST=


Review URL: http://codereview.chromium.org/8124024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8387012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107043 0039d316-1c4b-4281-b951-d872f2087c98

I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98

It would happen if CreateClientCertificateChain() returns NULL.
Found by the clang static analyzer. Probably doesn't happen in
practice.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8308009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107041 0039d316-1c4b-4281-b951-d872f2087c98

Activate IRT building on ARM for NaCl.

In order for this to be on for real, the PNaCl toolchain still needs to
available

Since NaCl is still turned off by default on ARM, this code should be a no-op
for all other cases.

This also moves the compilation a step forward for ARM. 

There is a bootstrap dependency on memset on ARM - so SYSROOT on the
ChromiumOS chroot is required to gain access to libc.

R=bradnelson,robertm
BUG=http://code.google.com/p/chromium/issues/detail?id=61695
BUG=http://code.google.com/p/chromium/issues/detail?id=38909
BUG=http://code.google.com/p/nativeclient/issues/detail?id=135


Review URL: http://codereview.chromium.org/8375035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107040 0039d316-1c4b-4281-b951-d872f2087c98

Make the bookmark manager consistently reset the hash when starting to edit (so that when editing is complete, a new edit operation can still be invoked on the same element).

Disable the console diagnostics on navigateTo (to be consistent with the other disabled diagnostics in this file).

Make WebUI bookmark editing work on Mac (Mac was invoking the native UI directly instead of going through the BookmarkEditor class which decides which UI to show).

Make 'Add page' pre-populate the bookmark entry with the title/url of the current page (as for the non-webui behavior).  Note that based on UX feedback, we probably don't want to use the bookmark manager in this case at all, so we'll probably add a new dialog for this.  But I already had this ready and it's a step closer (removes a= from bookmark manager, etc.) so I'm still committing it for now. 

Make the certificate viewer non-modal to match the native version.

BUG=99205
TEST=Manual


Review URL: http://codereview.chromium.org/8314017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107039 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8373006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107034 0039d316-1c4b-4281-b951-d872f2087c98

 - Fixed a bug that prevented searching from the last page of the settings window.
 - Fixed appearance of the extensions page title.
 - Stop the extensions page from listening to NAV_ENTRY_COMMITTED, this event is no longer needed
   since the migration and was generating extension loads for every settings page change.
 - Prevent redundant searches from occurring when the user first starts typing into the search field.
 - Use custom 'searchChanged' events rather than key/mouse events for customizing extensions list
   appearance during a search.

BUG=99047
TEST=See reproduction steps in bug.

Review URL: http://codereview.chromium.org/8353022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107033 0039d316-1c4b-4281-b951-d872f2087c98

a PING and perform CheckPingStatus immediately with hung
interval of 0ms. The unit test verfies the SPDY session
is closed and there are no streams.

BUG=101234
R=willchan
TEST=spdy network unittests

Review URL: http://codereview.chromium.org/8369023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107032 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Unittests

Review URL: http://codereview.chromium.org/8374014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107031 0039d316-1c4b-4281-b951-d872f2087c98

This is a build fix for Mac GCC caused by r106669 <http://crrev.com/106669>.

BUG=none
TEST=fix builds on the "Webkit Mac (valgrind)" bot.
Review URL: http://codereview.chromium.org/8370034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107029 0039d316-1c4b-4281-b951-d872f2087c98

 implemented basic feature such as
   creating/deleting workspace,
   adding/removing windows to/from workspace
   calculate bounds for workspaces.

This is not hooked up with UI yet.

BUG=none
TEST=workspace_manager_unittests added

Review URL: http://codereview.chromium.org/8361025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107028 0039d316-1c4b-4281-b951-d872f2087c98

These methods are currently just used by metrics.  I moved
them from base into the browser a while back, but I think it
makes the most sense for them to live in gfx::Screen.  I'm
also relocating the tests to ui_unittest and making them work
on Aura.

BUG=99711,100341
TEST=ran ui_unittest

Review URL: http://codereview.chromium.org/8382019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=check_perms is green

Review URL: http://codereview.chromium.org/8382025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107024 0039d316-1c4b-4281-b951-d872f2087c98

Fixes bug http://code.google.com/p/chromium-os/issues/detail?id=22018

BUG=chromium-os:22018
Review URL: http://codereview.chromium.org/8382024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107023 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8380022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107020 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8198024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107019 0039d316-1c4b-4281-b951-d872f2087c98

Browse to the page and test that the url is correct for the page.

R=jhawkins@chromium.org
BUG=90420
TEST=browser_tests --gtest_filter=*OptionsWebUITest.*


Review URL: http://codereview.chromium.org/7501004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8351011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org


Review URL: http://codereview.chromium.org/8370026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107015 0039d316-1c4b-4281-b951-d872f2087c98

on all OS_POSIX systems where it's available by checking
the return value.


BUG=
TEST=base_unittests SysInfoTest.MaxSharedMemorySize

Review URL: http://codereview.chromium.org/8381022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101225
TEST=AMD/ATI new drivers are enabled.

Review URL: http://codereview.chromium.org/8379004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107013 0039d316-1c4b-4281-b951-d872f2087c98

Previously the user agent was set when we set the content client,
which was set in the zygote, which didn't have a command line.

Now, we still set the user agent in the zygote, but if the
--user-agent command line switch is passed, we will reset the
user agent in ZygoteMain.

R=jam@chromium.org
BUG=99418
TEST=run chrome with --user-agent=foo on linux, visit
whatsmyuseragent.com, ensure 'foo' is displayed.

Review URL: http://codereview.chromium.org/8296011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/8356032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107011 0039d316-1c4b-4281-b951-d872f2087c98

This flag allows us to avoid compiling and executing JavaBridge code when the
feature is not required. The flag defaults to off, but is enabled on Android.

BUG=96703

Review URL: http://codereview.chromium.org/8383001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20875
TEST=none
TBR=xiyuan
Review URL: http://codereview.chromium.org/8383021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100887
TEST=Check that the initial 'home screen' has text.

Review URL: http://codereview.chromium.org/8382020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98919
Review URL: http://codereview.chromium.org/8354028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107003 0039d316-1c4b-4281-b951-d872f2087c98

Before we were leaving dangling streams un-Stop()'d, causing delayed messages to
eventually crash the browser when their source_callback_ was followed but
already invalid.

BUG=101228
TEST=trybots, manual testing.

Review URL: http://codereview.chromium.org/8385001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107000 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100411
TEST=no

Review URL: http://codereview.chromium.org/8382018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8359021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106998 0039d316-1c4b-4281-b951-d872f2087c98

1) Added missing headers causing compilation errors
2) Added an #ifdef to prevent the case of a dangling else{} without a preceeding if(){}.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8387005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106997 0039d316-1c4b-4281-b951-d872f2087c98

Removed legacy encoding mechanism that was temporarely used at one point while WebUI was still being developed.

BUG=chromium-os:20875
TEST=none

Review URL: http://codereview.chromium.org/8332013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101401
TEST=less flaky waterfall
TBR=noelallen


Review URL: http://codereview.chromium.org/8332011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106995 0039d316-1c4b-4281-b951-d872f2087c98