GitLab

I misinterpreted the docs as meaning that read() and write() should
always return the number of bytes requested.

What it actually says is that the functions should always return the
number of bytes requested _unless_ the EOF is reached or there is an
error.

BUG=411557
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/549353003

Cr-Commit-Position: refs/heads/master@{#294018}

Old processing order for each command:
  scheduler.PutChanged() -> parser::ParseCommand() -> decoder::DoCommand()

This patch runs commands in batches (default of 20):
  scheduler.PutChanged() -> CmdParser::ParseCommands(20) -> dec::DoCommands(..)

Performance improvement is an average 0.2ms/frame on N5 on GPU rasterized pages.

BUG=394570

Review URL: https://codereview.chromium.org/558513003

Cr-Commit-Position: refs/heads/master@{#294017}

Add 3px of internal padding for textfield/combobox content.
Remove corresponding unused padding from FocusableBorder.
This better accommodates excessively tall fallback font text.
Update Omnibox, Find Bar, App List, and CookieInfoView.

See before/after pics at http://crbug.com/404999#c51

BUG=404999
TEST=Bookmark bubble/dialog, find bar, etc. don't clip most tall fallback text.
R=sky@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/516943003

Cr-Commit-Position: refs/heads/master@{#294016}

https://chromium.googlesource.com/angle/angle/+log/ab56c6aeff8ea52a8927a947ec20d19eb4564fc9..eeb7b0e9038b0fc57ead6a491541548159855dc2?pretty=full

BUG=
TEST=tree
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/554763004

Cr-Commit-Position: refs/heads/master@{#294015}

Reland 189a2ed4d209231d517b0e64a722722dead3f17a Fixes HasEventListener check in ExtensionKeybindingR

TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/554073002

Cr-Commit-Position: refs/heads/master@{#294014}

The APIs that need forward declarations were actually introduced in
OS X 10.7 SDK instead of 10.9 SDK, forward declare them in the wrong
place will cause build issue when using older SDKs like 10.7 or 10.8.

BUG=390212

Review URL: https://codereview.chromium.org/555163002

Cr-Commit-Position: refs/heads/master@{#294013}

When use the Pepper MapTexSubImage2DCHROMIUM() and the Compositor API together, it may cause memory leak, and then run out of memory. The problem is because the Compositor API uses sync point to sync texture producer and the Chrome compositor, it does not need any IPC, so the PpapiCommandBufferProxy::last_state_[1] will not get updated, so the client does not known when the GPU process finishes accessing the memory, and then the memory can not be reused forever. This change add a shared state in PpapiCommandBufferProxy. It allows PpapiCommandBufferProxy updating state from a shared memory without an IPC. It fix this issue.

BUG=411004

Review URL: https://codereview.chromium.org/547733002

Cr-Commit-Position: refs/heads/master@{#294012}

The AppModelBuilder does not rely on content so much, rather
it's highly related to the extension system. Therefore, it's
better to be in athena/extensions, and its name should be
ExtensionAppModelBuilder instead.

This will simplifies DEPS rules of athena/content.

BUG=None
R=oshima@chromium.org
TBR=yoz@chromium.org, xiyuan@chromium.org, tony@chromium.org
TEST=build

Review URL: https://codereview.chromium.org/543263002

Cr-Commit-Position: refs/heads/master@{#294011}

event.

Occasionally we synthesize scroll or tap cancel events when a touch
sequence has been canceled or terminated, we want to make sure that
ET_GESTURE_END always happens after them.

BUG=379772

Review URL: https://codereview.chromium.org/549333002

Cr-Commit-Position: refs/heads/master@{#294010}

Implement postMessageEvent(), which is nearly identical to
RenderFrameImpl::willCheckAndDispatchMessageEvent(). The most notable difference
is the void return value, as remote frames know that the MessageEvent must
be delievered cross-process.

This is step 2 of 3 in getting WebRemoteFrameClient up and running.

BUG=411066

Review URL: https://codereview.chromium.org/545653002

Cr-Commit-Position: refs/heads/master@{#294009}

This has debugging statements in case it turns out not to be. Fingers crossed, though.

BUG=407376
TEST=no crashing, we hope

Review URL: https://codereview.chromium.org/549243002

Cr-Commit-Position: refs/heads/master@{#294008}

This uses the code from GYP to compute the maximum number of concurrent links
to use in the link pool, and sets this value in the toolchains.

Review URL: https://codereview.chromium.org/548633004

Cr-Commit-Position: refs/heads/master@{#294007}

https://skia.googlesource.com/skia/+log/32673b99a4fb5d798206eb7665b730ed0b4597a0..f5b6bf775c331784964bfcc9b9ac707dc6a7c62b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/555973003

Cr-Commit-Position: refs/heads/master@{#294006}

BUG=None
R=mmenke@chromium.org

Review URL: https://codereview.chromium.org/537403003

Cr-Commit-Position: refs/heads/master@{#294005}

This fixes a mistake in an earlier CL.

BUG=412393

Review URL: https://codereview.chromium.org/557833002

Cr-Commit-Position: refs/heads/master@{#294004}

Added all the plumbing to make Blink aware of the top controls position
and how its viewport has been resized as a result. This CL adds all the
machinery and plumbing but does not yet connect main-thread scrolls to
the top controls. This is needed to support scrolling the top controls
during slow-scrolls as well as correct viewport behavior in the virtual
viewport pinch-to-zoom.

The machinery for top controls now includes two values:

top_controls_layout_height: The amount that the viewport was shrunk to
accommodate the top controls. This is updated only during a layout that
causes a viewport resize (i.e. RenderWidget::OnResize). The compositor
needs this to know how much the viewport layer has already been resized
by Blink.

top_controls_content_offset: The amount that the top controls are showing.
This will be the same as top_controls_layout_height right after a viewport
resize, but will diverge since the top controls will move without
immediately causing a RenderWidget resize.

Blink now keeps track of the top controls "content offset", which is the
distance the content is offset from the top of the screen due to top
controls. It receives updates to this value from the Impl thread during
a commit and echos them back to the compositor.

On the compositor side, the top controls layout height is moved into the
LayerTreeImpl. This is necessary since a commit will change the viewport
layer's size on the pending tree. Keeping it in LayerTreeHostImpl meant
that, until the pending tree was activated, the top controls layout height
corresponded to the viewport bounds in the pending tree. This was causing
flickering as the viewport container was the incorrect size for a short
time. The compositor also keeps track of the top controls content offset
value. The top controls offset uses the same model as page scale, keeping
an offset (the value as known by the main thread), a delta from the main
thread's value, and a sent_delta to keep track of what has been sent to
the main thread.

See https://codereview.chromium.org/513053003 for Blink-side patch.

BUG=333143

Review URL: https://codereview.chromium.org/511253003

Cr-Commit-Position: refs/heads/master@{#294003}

Also shifts mechanism for minimizing interference with top-level traffic
from delaying dispatch to using the IDLE request priority.

BUG=387890
BUG=383404
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/495523003

Cr-Commit-Position: refs/heads/master@{#294002}

Revert of Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL." (patchset #1 id:1 of https://codereview.chromium.org/547843002/)

Reason for revert:
Doesn't look like this helped with the perf regression, so undoing the original revert.

Original issue's description:
> Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL."
>
> This reverts commit e06bd133.
>
> This is a preemptive revert to see whether a pagecycler regression can
> be attributed to this change. (Even if it can, we still probably want to
> make the change, but it's good to know.)
>
> BUG=409214
> TBR=davidben@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5fee53e7fe9a5a0f6aeb568446d8cdee5e3a96b7

TBR=davidben@chromium.org,agl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409214

Review URL: https://codereview.chromium.org/559663003

Cr-Commit-Position: refs/heads/master@{#294001}

The root of all filesystems should be a directory node
except in the special case of blob URL where we maintain
the legacy behavior of having the mount point be a file
containing the blob content.

Also, fix the Access() call for http filesystem so that
it honors the access bits of the node itself.

This fixes an issue in naclports where a mount() of
an http filsystem followed by a chdir(http_root) would
always fail with ENOTDIR.

TEST=nacl_io_test

Review URL: https://codereview.chromium.org/547713002

Cr-Commit-Position: refs/heads/master@{#294000}

Fixes NULL pointer dereference when the RenderThreadImpl is
destructed but outstanding HTMLMediaElement objects have not
yet been garbage collected.

Reordering will keep audio streams alive slightly longer, but
that should be of no consequence since they would still respond
to graceful shutdown attempts by any living AudioRendererImpls.

BUG=408345
TEST=none

Review URL: https://codereview.chromium.org/517793003

Cr-Commit-Position: refs/heads/master@{#293999}

BUG=411430

Review URL: https://codereview.chromium.org/545973002

Cr-Commit-Position: refs/heads/master@{#293998}

https://chromium.googlesource.com/chromium/blink/+log/8c33177074ab109238d17fd4559691dcabe2a46d..f03316e4e9a81f26dcfe261fb27f54a71b00310c
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/556953002

Cr-Commit-Position: refs/heads/master@{#293997}

These were removed from the code in 2011 as seen in https://crrev.com/70740

Review URL: https://codereview.chromium.org/553083002

Cr-Commit-Position: refs/heads/master@{#293996}

The root cause is a combination of BufferedDataSource::Stop()
requiring a lock and BlockingURLProtocol::Read() returning
control to FFmpeg which may destory resources in use by an
ongoing BufferedDataSource::ReadCallback() call.

The lock in BDS::Stop() shared by BDS::ReadCallback() prevents
the stop signal from taking affect until after the read finishes,
however calling BUP::Abort() will immediately returns control to
FFmpeg which may destroy the resources in use by BDS::ReadCallback().

Sadly, given the racy nature and multi-class dependencies I've been
unable to craft a unit test for this, but I've manually verified this
fix works by arbitrarily delaying BDS::Stop() under an ASAN build.

BUG=411318
TEST=none

Review URL: https://codereview.chromium.org/544843005

Cr-Commit-Position: refs/heads/master@{#293995}

Merge of internal change 74954339

BUG=412306

Review URL: https://codereview.chromium.org/555143002

Cr-Commit-Position: refs/heads/master@{#293994}

BUG=412471
TBR=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/558733002

Cr-Commit-Position: refs/heads/master@{#293993}

This is code placed into separate file that was removed in https://codereview.chromium.org/478183005

Code is still used by CEF.

BUG=374321
NOTRY=true

Review URL: https://codereview.chromium.org/557663002

Cr-Commit-Position: refs/heads/master@{#293992}

BUG=120488

Review URL: https://codereview.chromium.org/546193002

Cr-Commit-Position: refs/heads/master@{#293991}

Currently, the findbugs_diff.py and friends ignore the
CHROMIUM_OUT_DIR environment variable, and hardcodes the out folder
to just be 'out'. This is problematic for developers who use a
different out folder.

This CL makes the generic findbugs util library read the environment
variable, and then default to 'out' if it is not set.

BUG=None

Review URL: https://codereview.chromium.org/553783007

Cr-Commit-Position: refs/heads/master@{#293990}

Fixes link error on building chrome for bundled harfbuzz on Ubuntu 14.04

BUG=None

Review URL: https://codereview.chromium.org/547283004

Cr-Commit-Position: refs/heads/master@{#293989}

This change adds ipc_mojo_perftests that runs the same benchmark
as of ipc_perftests. Now head-to-head comparison becomes possible.

For this change, whole ipc_perftests logic is extracted to
ipc_perftest_support.cc to make it reusable by ipc_mojo_perftests.

TEST=none
BUG=none
R=jam@chromium.org, darin@chromium.org, yuzhu@chromium.org

Review URL: https://codereview.chromium.org/536213002

Cr-Commit-Position: refs/heads/master@{#293988}

This change is a prerequisite for transitioning the "max outstanding
frames" decision logic over to a time-based heuristic.  It adds tracking
of the number of audio samples enqueued in the encoder, from which the
needed backlog stats can be determined.

Also, this introduces an abstract method in FrameSender,
GetNumberOfFramesInEncoder(), since this is computed differently for
audio versus video.

BUG=404813

Review URL: https://codereview.chromium.org/545593002

Cr-Commit-Position: refs/heads/master@{#293987}

This call was only useful if we cared to have Windows attempt to find the target should the path have moved. Since moving Chrome installs (or installing them on anything but a local C: drive) is unsupported there is no need to do this. This code only cares about the target path currently stored in the shortcut (regardless of its existence) -- for which GetPath() is sufficient.

This call could otherwise take up to 3 seconds per unresolvable shortcut which can drastically impact uninstall times when setup.exe attempts to delete all shortcuts pointing to its chrome.exe in common shortcut paths.

This should also get rid of LOG(ERROR)s in test_installer about unresolveable shortcuts as we will now only inspect the path stored in the shortcut without trying to actually resolve it.

BUG=412380
R=cpu@chromium.org, grt@chromium.org

Review URL: https://codereview.chromium.org/553783005

Cr-Commit-Position: refs/heads/master@{#293986}

Before, the WebContents was closed directly from OnDontProceed. This breaks if the caller expects the WebContents to survive (happened e.g. when a new interstitial was being initialized).
This CL instead posts a task to the message loop.
Also, the tab won't be closed anymore if it's the last one in the window, as that would lead to closing the window.

BUG=411841

Review URL: https://codereview.chromium.org/550973002

Cr-Commit-Position: refs/heads/master@{#293985}

Makes possible to print from windows with printing_enabled=2.

BUG=374321

Review URL: https://codereview.chromium.org/549423002

Cr-Commit-Position: refs/heads/master@{#293984}

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333

Committed: https://chromium.googlesource.com/chromium/src/+/5c361bce306a985bcb65cd9db6060ccbe139f66d

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293983}

R=phajdan.jr@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/543323002

Cr-Commit-Position: refs/heads/master@{#293982}

BUG=402081
R=gab@chromium.org

Review URL: https://codereview.chromium.org/553053002

Cr-Commit-Position: refs/heads/master@{#293981}

Slice up the tiled image just like CursorLoaderX11 does and pass it on
to CursorFactory as a vector, hotspot, and frame delay.

Also add stub implementation for BitmapCursorFactoryOzone that just
creates a static cursor with the initial frame.

R=sky
BUG=343245
TEST=viewed css "wait" cursor on cros link_freon

Review URL: https://codereview.chromium.org/543823002

Cr-Commit-Position: refs/heads/master@{#293980}

GetAllFoldersWithDepth is used to get all folders under which users are able to move their own bookmarks. Mobile, other, root node and managed folder are not included in the returned result.

BUG=386785

Review URL: https://codereview.chromium.org/506353003

Cr-Commit-Position: refs/heads/master@{#293979}