GitLab

This experimental CL allows cfprefs and gamecontrollerd to observe how
the perf bots respond. This will likely be reverted once the results
show up.

Bug: 689306
Change-Id: I8e0ab2919e4cf7e65217be1169b63a7bde806df4
Reviewed-on: https://chromium-review.googlesource.com/764394Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515997}

With this SDK roll, Fuchsia now sets PATH. Switch environment variable
tests back to checking for its existence to remove #if.

Bug: 707030
Change-Id: Ifc0f1fea3388c6ad98f98864bb9bf7c4f8c87035
Reviewed-on: https://chromium-review.googlesource.com/766470Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515996}

This fixes 16 of the 21 compositing/ layout tests listed on crbug.com/778469.
The remaining 5 are affected by crbug.com/784053.

This patch includes new baselines for the tests that are fixed (diff against
generic baselines in patchset 1).  These reflect the presence of scrolling
layers in the layer tree dump, and "flattenInheritedTransform": false due to
crbug.com/778060.

Bug: 778469
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1cffa503561942aef7c932f6d52ae541dc88e8a2
Reviewed-on: https://chromium-review.googlesource.com/764952Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515995}

Previously WebKeyboardEvents were built for Windows by ignoring the
ui::KeyEvent field values, and populating the WebKeyboardEvent directly
from the NativeEvent fields, if available.

We now derive the WebKeyboardEvent fields from the supplied ui::Event,
and update some fields from the NativeEvent, if available. To reduce
the amount of patch-up code, handling of Windows' native auto-repeat
flag will be used, for ui::KeyEvents generated from a NativeEvent,
instead of being synthesized by ui::KeyEvent::IsRepeated.

Bug: 25503
Change-Id: I9d5b1468852d85392ae3a5f57d9457726612ddf1
Reviewed-on: https://chromium-review.googlesource.com/754130Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515994}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8b43ab72..c4f852d8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia6ff2b1e6aecf8f0b0aaac300a6efc2df4509df8
Reviewed-on: https://chromium-review.googlesource.com/766607Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515993}

Tbr: dpranke@chromium.org
Bug: 484160
Change-Id: I8b63ce9b3ca95b37cd36f40ee1af619ce0a0409b
Reviewed-on: https://chromium-review.googlesource.com/763913Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515992}

Close the connection when a QUIC RST_STREAM is received which contains an invalid final byte offset.

BUG=782737

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I740f9320b8d97e8fe0ca4a4ba7af62579988fb7e
Reviewed-on: https://chromium-review.googlesource.com/764492Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515991}

CL makes use of the existing BitmapCursorFactoryOzone implementation
to add pointer/mouse cursor support to Ozone/Wayland.

Implementation of wayland_cursor.cc|h is originally based on [1].

[1] https://github.com/01org/ozone-wayland/

TEST=chrome --mash/mus --ozone-platform=wayland

BUG=578890

Change-Id: Iccd0a23dd1329bfe32ac78af9379ba3fd739d63f
Reviewed-on: https://chromium-review.googlesource.com/644946
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515990}

This CL cleans up and simplifies SegmentedString, leading
to an improvement in parsing performance.

This CL also adds a cache for the current_char_ in SegmentedSubstring,
so it can avoid a branch when calling GetCurrentChar().

Profiling shows a 1.5% improvement in the jQuery benchmark in
Speedometer 2.0 and around 1% across the various VanillaJS benchmarks
in Speedometer 2.0.

Change-Id: Idc1ae1e277aaec1c9f581075eab563fcd2a72688
Reviewed-on: https://chromium-review.googlesource.com/762016
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515989}

Bug: 783811
Change-Id: Ic2f9e7fcfb05e4d87f79c8ec53d370edc8b53d27
Reviewed-on: https://chromium-review.googlesource.com/763917Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515988}

The old-school layout logic in BVC was also re-inserting views on each
update, which is unnecessary, and in some cases causes views to show up
in the wrong z-order.  Insert only needs to happen on initial layout,
so gating this in a flag should fix the issues.

Bug: 782373
Change-Id: I326f3b9199717c0ad014267fa0239581574a826d
Reviewed-on: https://chromium-review.googlesource.com/763711Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515987}

Fix possible null dereference in SafeBrowsingNavigationObserverManager::IdentifyReferrerChainByWebContents.

Change-Id: Idfb13c91de87685598d447ddab8c755693955ea1
Reviewed-on: https://chromium-review.googlesource.com/765214
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515986}

This is a reland of 31974d24
Original change's description:
> Initial implementation of cc::ScrollTimeline
> 
> This creates a compositor side concept of a ScrollTimeline, and adds
> plumbing so that blink WorkletAnimations created with ScrollTimelines
> will create a cc::ScrollTimeline on the compositor side. This means
> that scroll-driven AnimationWorklets are now possible.
> 
> There are a number of caveats to this initial implementation:
>  * We never update the cc::ScrollTimeline, so if the scroller
>    changes on the blink side we won't know.
>  * We assume that the scroller is composited. If it isn't composited
>    during animation play() we will log a warning and fail to start,
>    but if it is composited at that time and later becomes non-composited
>    we will likely crash.
> 
> Bug: 776952
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id0342c62209b387130a69edca4ff3682748bd8a3
> Reviewed-on: https://chromium-review.googlesource.com/738437
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: dstockwell <dstockwell@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515645}

Bug: 776952
Change-Id: I372d8fd48c62a63b5c6b10688d3829e4ac2c3be1
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/764578Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515985}

As Xcode 9.0+ is required to build Chrome on iOS, remove
supports for older versions.

Bug: none
Change-Id: Idf2e9516cb8f508109e22f3afaef8cd56ad94eb5
Reviewed-on: https://chromium-review.googlesource.com/763409Reviewed-by: Elodie Banel <lod@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515984}

Currently there is an inconsistency between CreateNavigationItem and
GetLastCommittedNonAppSpecificItem. The former sets user agent type of
an item to NONE if URL is app-specific. The latter looks for an item
with user agent type that is not NONE, and uses VirtualURL to find
these. Historically this has not been a problem because app-specific
URLs always had identical VirtualURL.

Offline Reading List navigation items break this assumption. They have
app-specific URLs (e.g. chrome://offline/<blob>) and regular-looking
VirtualURLs.

Bug: 781284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I45d9afdb854b1d5340f6d4d2bb7ac306f0897662
Reviewed-on: https://chromium-review.googlesource.com/764540
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515983}

Change table headers' height and color, since the they look like buttons.

Change the "Notes" header back to "Description" since it makes much more sense.

Screenshot: https://drive.google.com/a/chromium.org/file/d/188W0j_izuPSxVt6SwskLEOdqUI8vcoCU

Bug: 764419
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If743172020754c50b6c234e3bb23f7f2d178cb36
Reviewed-on: https://chromium-review.googlesource.com/763669Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515982}

Convert TranslateController to directly track registration with
the observed WebState instead of relying on the deprecated code
in WebStateObserver.

Bug: 775684
Change-Id: I62146d7085ab3e230c71cab0510a1ed86aa6a162
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/757109
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515981}

R=skau@chromium.org

Bug: 779256
Change-Id: I5772282ee310a594b5e31d5931fa38a6fa67cde8
Reviewed-on: https://chromium-review.googlesource.com/755417Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515980}

TBR: wez@chromium.org
Bug: 784448, 784449
Change-Id: I06d0473968ae2dbdb9c480cf58b25ba1fbc2a764
Reviewed-on: https://chromium-review.googlesource.com/766152Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515979}

After 24423de1dc711cebf73d097943d2090ce4d8aed7 [0] gn boostrap fails
with

  undefined reference to `base::internal::ObserverListThreadSafeBase::tls_current_notification_'

Add observer_list_threadsafe.cc that contains that static var to
bootstrap.py to make it work again.

[0] https://chromium-review.googlesource.com/740989

Bug: 783188
Change-Id: Iac583c52b8aed452b3bdd5b33a60857e2e8285b9
Reviewed-on: https://chromium-review.googlesource.com/758584
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515978}

Current phone number rationalization does not distinguish between
focusable and non-focusable fields. If a form has a hidden number field
then a visible number field, the first one will be considered as the
first complete number field, and the second field is not filled
automatically as a result.

We should skip the non-focusable fields in the rationalization process.

Bug: 782240
Change-Id: I71eeb613d3127770b2bf0a0bb120c7cca3282728
Reviewed-on: https://chromium-review.googlesource.com/757217
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515977}

The QuicStreamFactory::OnJobComplete crash is gone in M63. This CL removes
the added CHECKs.

Bug: 750271
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iee46a69d151be4c5e8ceb91c33ec63e445ede2fd
Reviewed-on: https://chromium-review.googlesource.com/766487Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515976}

Again.

Change-Id: I82deeea0c31ac8f609a6a5d98113c65de1fd30b0
Reviewed-on: https://chromium-review.googlesource.com/762873Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515975}

In jumbo builds (use_jumbo_build=true) the two different
LevelDBStatusToStatus could end up in the same translation unit which
would then cause compilation errors since they only differed by return
value.

This CL gives them unique names, ToServiceWorkerStatus() and
ToNotificationDatabaseStatus().

Bug: 746953
Change-Id: Iceaf6facc3142990d62769f693eb57bfc5c5f143
Reviewed-on: https://chromium-review.googlesource.com/760358Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#515974}

Mac now has a default shortcut for "Command+Shift+Y", so update
the commands sample extension to use "MacCtrl+Shift+Y" to avoid
conflict.

Bug: None
Change-Id: Iced6c9bc9dc43f99461cc0c3bd93eaa19da1d6a1
Reviewed-on: https://chromium-review.googlesource.com/748025Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515973}

BR tags and tabulation characters produce NGPhysicalTextFragment
without ShapeResult. This patch skips computing intercepts in such
cases. Whether they should or should not is still subject to
discuss though.

This fix alone doesn't fix any tests because then crashing tests
will crash in other DCHECK. fast/inline/br-text-decoration.html
should pass when combined with other fixes.

Bug: 636993, 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I74687c7b2acc34c4889d2efac8c42b91b79cd3a3
Reviewed-on: https://chromium-review.googlesource.com/765622Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515972}

After commit a565e32a ("WPT import: Stop appending @chromium.org to TBR
emails altogether"), whenever _fetch_ecosystem_infra_sheriff_username()
returned an empty string we'd pass it on instead of falling back to
'qyearsley' like we did before.

Fix it by making sure we always return the fallback string both if there's
an exception as well as if there is nobody currently on rotation.

Bug: 755753, 784262
Change-Id: I31b298bd3ffe53fc10fec42f8096f04d9fdb08dd
Reviewed-on: https://chromium-review.googlesource.com/765492Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#515971}

The list used to be sorted and was ot anymore. Resorted by increasing
alphabetical order, case ignored (sort -f) as it seemed to be originally
(i.e. AllowBluetooth comes before Allowed because b < e).

Bug: None
Test: unit_tests pass
Change-Id: I7d38b6d6e813fbe16516280884ad5344a0d60f3e
Reviewed-on: https://chromium-review.googlesource.com/763990Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515970}

This patch factors ViewPaintInvalidator into BoxPaintInvalidator
which reuses BoxPaintInvalidator's logic for invalidating the
scrolling contents layer. This fixes one root layer scrolling test.

Bug: 781419

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I62a84be195920a63e2db1207d4e329450eebeabf
Reviewed-on: https://chromium-review.googlesource.com/759738
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515969}

Zucchini Trunk didn't support kExeTypeElfX64, and we'd like to add
support. To keep enums ExecutableType consecutive, we need to shift
other enums, but this affects patch format. So we isolate the
renumbering to a small CL. Also fix test.

Bug: 778316
Change-Id: I31d693f325240164e0d66227fbb1254f09aa1548
Reviewed-on: https://chromium-review.googlesource.com/765258Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515968}

On Android, wheel events are sent with the pixels per tick and number
of ticks. Currently, the synthetic_smooth_move_gesture puts the
desired delta into the wheel event which assumes each wheel tick scrolls
1 pixel. On Android, the default today is each tick is 64px. This means
the scroll distance and speed end up being 64X the requested amount!

This patch fixes the Android gesture target to set the event values
correctly by setting the correct number of ticks given the desired
delta (and truncating any remainder).

However, since we try to send an event every 16ms, this means any
gesture that scrolls slower than a wheel tick every 16ms wont scroll
at all since we truncate the delta to the wheel tick size. So this
patch also changes the dispatch logic to avoid accumulating and sending
an event that doesn't have any ticks. This means for slower scrolls, we
may go multiple frames without sending a scroll.

I've also added tests in telemetry for this change:
https://chromium-review.googlesource.com/c/catapult/+/751684
This patch adds methods setPageScaleFactor and setBrowserControlsShown
that are used from those tests.

Bug: 778587
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib40aee2b3f9f38f68482b30e27b95f7fe84e1ef9
Reviewed-on: https://chromium-review.googlesource.com/749980Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515967}

Define the layout_height and layout_width for ToolbarButton elements
in-line rather than in styles.xml. This is a speculative fix for crash
reports we've received indicating these attributes are missing.

BUG=779271

Change-Id: I732ee9b39262aa8bfbc74dea57ea72469cd9e647
Reviewed-on: https://chromium-review.googlesource.com/764378
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515966}

This CL makes ChromeSigninClient use content::NetworkConnectionTracker
instead of net::NetworkChangeNotifier.

This CL additionally modifies NetworkConnectionTracker's
constructor so we can mock it in TestingBrowserProcess and tests.

Bug: 754709
Change-Id: Ic05662830839403d5b327793f8faf7284a0da0bd
Reviewed-on: https://chromium-review.googlesource.com/757583Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515965}

Bug: 703565
Change-Id: Ic71b59bcff1c14e3e5a221951b58ba12893b1004
Reviewed-on: https://chromium-review.googlesource.com/765658Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515964}

We will shortly be converting sync WebUI to obtain information about the
signed-in user via the Identity Service rather than the SigninManager.
To prepare for doing that conversion incrementally, this CL adds a
variant of sync_ui_util::ConstructAboutInfo() that takes in the
AccountInfo of the primary account directly.

In upcoming CLs, we will port over callers to obtain this AccountInfo
asynchronously via the Identity Service and pass it in to
ConstructAboutInfo() once obtained. All callers are already part of
an asynchronous flow, so these conversions will not be difficult.

TBR=rkc@chromium.org

Bug: 783144
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icf30d739a01106feb454a67eb2b83a79dd2fc5bd
Reviewed-on: https://chromium-review.googlesource.com/758771Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515963}

Convert LanguageDetectionController to directly track registration
with the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Bug: 775684
Change-Id: Ib3331edef26d31e0ccb48e65eed9fc4b5de84fa3
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/757106
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515962}

RenderingTest::SetUp has been using RuntimeEnabledFeatures::SetOverlayScrollbarsEnabled
for testing. This CL remove the use, instead make it to use ScopedOverlayScrollbarsForTest.

Bug: 769541
Change-Id: I7fa923adc379ad219065bdc57c54878dea637acd
Reviewed-on: https://chromium-review.googlesource.com/762968
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515961}

And use it from //PRESUBMIT.py instead of passing --file <file> for each
file that needs to be processed.

The idea is to read the list of files we want to process from a text file
instead of reading everything from the command-line.

web-platform-test imports were hitting an "argument list too long" error
because there's a particularly huge import with several directories being
renamed; at one point, we ended up with a command-line with ~260k
characters.

Bug: 780055, 780629
Change-Id: Ib1c8b902c42ade77ccbd2662905301d7f766f9d9
Reviewed-on: https://chromium-review.googlesource.com/751504Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#515960}

Bug: 780546
Change-Id: Ib2f73178d7a4373d0bcfe772eea3a5c885d564b6
Reviewed-on: https://chromium-review.googlesource.com/749581Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515959}

Introduce a class that supports hanging on to temporary
files long enough for the OS to pick them up (and clean
them up after restart of Chrome if it fails the first
time around). Necessary because Windows doesn't
guarantee temp file deletion on shutdown/restart.

Bug: 734095
Change-Id: I2926dc33b489f150a75f97792266e1a31a4ea5a2
Reviewed-on: https://chromium-review.googlesource.com/708742
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515958}