- 06 Sep, 2018 40 commits
-
-
Matthew Jones authored
This patch adds an API util method that simply does not run the setAccessibilityTraversalBefore method on devices that are running Android versions < L. Bug: 881400 Change-Id: Ie29a7f8f96e87661d0543fe99ca9e5f1a18f468f Reviewed-on: https://chromium-review.googlesource.com/1211103Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#589288}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ad370480282d..59d21660a3d9 git log ad370480282d..59d21660a3d9 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 hnakashima@chromium.org Fix integer overflow in LoadCryptInfo. Created with: gclient setdep -r src/third_party/pdfium@59d21660a3d9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:847283 TBR=dsinclair@chromium.org Change-Id: I29b63f62d289f5c1647d782933bec6ee1b8186ef Reviewed-on: https://chromium-review.googlesource.com/1211043Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589287}
-
Emircan Uysaler authored
Bug: 879020 Change-Id: I8112074b24ed28fa7fd39ea1cbd0f8fc0b24b043 Reviewed-on: https://chromium-review.googlesource.com/1208933Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589286}
-
Jialiu Lin authored
This Cl fixes two problems of ChromePasswordProtectionService:: IsPingingEnabled(). 1. We should specifically check if user signed in for sync password reuse case before sending out the ping. 2. For saved password reuse pings, we don't need to check for sync status. Bug: 876788 Change-Id: Iec7ffdc1d1b1af5ae73c9c4b6e8a78930c75aad6 Reviewed-on: https://chromium-review.googlesource.com/1194827 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#589285}
-
Ehsan Karamad authored
This CL implements the renderer side of MimeHandlerView based on cross-process frames (behind a flag). The new subclass of MimeHandlerViewContainerBase will use a content frame inside a plugin element for loading the MimeHandlerViewGuest's extension. The current implementation is not complete and the missing features such as postMessage support will be added in the follow-up CLs. This CL also introduces a new class of parametric browser tests (MimeHandlerViewCrossProcessTest) which will be the destination of the current MimeHandlerViewTests as more features are integrated into the frame-based version. The new test class runs the test on both BrowserPlugin-based and cross-process-frame-based versions. Document: https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.qw81a2bk3v6w Bug: 659750 TBR=thestig@chromium.org Change-Id: Ia69aeed47f4fa1c7f5b81cdde71a8d8b5ff59165 Reviewed-on: https://chromium-review.googlesource.com/1187231 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#589284}
-
Kevin Marshall authored
The Fuchsia component manifest now allows us to specify arbitrary binaries in a package as an entry point. Before, the entry point executable had to reside at the special path /pkg/bin/app. Keeping the executable name intact will facilitate stack trace symbolization on multiple packages. Bug: 798851 Change-Id: Ib116602e2e0e430478d24829112df63c27f3d025 Reviewed-on: https://chromium-review.googlesource.com/1208716 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589283}
-
Guido Urdaneta authored
Bug: 860311 Change-Id: Id41234cfd6337fd2dcdd319fc514f9ae7663c6a4 Reviewed-on: https://chromium-review.googlesource.com/1211724Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#589282}
-
Robert Flack authored
Animations updates with BlinkGenPropertyTrees require paint in order to have animations updated. This modifies the animate_only property to not skip paint but only skip commit. BlinkGenPropertyTrees changes the blink lifecycle such that painting produces the property trees which are then directly passed to the compositor. As a result, the animations update can only happen after we know the painted artifacts which means that animation updates are now dependent on running paint. Bug: 872773 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d2424b3b658a0908a08adfce20940610cdd9b09 Reviewed-on: https://chromium-review.googlesource.com/1199603Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589281}
-
sczs authored
Patchset 1 is the original CL. https://crrev.com/c/1205806 The only change on this CL is to disable dynamic height on non-UI Refresh since the legacy cells don't support it. ======= Original Description ======= This CL changes BookmarksTableVC so it uses dynamic row height. It also updates some EG tests that started to fail once this change was made. I suspect this has to do with internal TableView management of cells when using dynamic height. The BottomCell test cell was moved to the penultimate position since we now snap at the top of the top cells instead of using the offset value of the TableView. This meant that the top cell was completely visible when re-creating the cache and the "Bottom Cell" was partially hidden. Bug: 869671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic1844c60f88357acabc008acbb6be6b38f9e99b1 Reviewed-on: https://chromium-review.googlesource.com/1210548 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#589280}
-
sebsg authored
Some of the ids comming from payments needed to be converted before they could be displayed. This should only affect the sync internals page, no feature code. Bug: 879556 Change-Id: I423580564574ea5f883044d4a4e08bf0e8c9b1e7 Reviewed-on: https://chromium-review.googlesource.com/1205192 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#589279}
-
Chris Palmer authored
This reverts commit 5f80b9a8. Reason for revert: Revert was wrong; it was OK the first time. Original change's description: > Revert "Add `CheckedRandomAccess[Const]Iterator`." > > This reverts commit 383049f2. > > Reason for revert: Landed wrong patchset! > > Original change's description: > > Add `CheckedRandomAccess[Const]Iterator`. > > > > And add a first call site. > > > > Bug: 817982 > > Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo > > Change-Id: I2db298494e4f562ffac1f68b87c7a617e592f196 > > Reviewed-on: https://chromium-review.googlesource.com/963726 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589244} > > TBR=ajwong@chromium.org,palmer@chromium.org,dcheng@chromium.org,jyasskin@chromium.org,mmenke@chromium.org,tsepez@chromium.org,nharper@chromium.org > > Change-Id: Icf99f8409054d853a15b8d27cdb232ff727f8a42 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 817982 > Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1211743 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Commit-Queue: Chris Palmer <palmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589245} TBR=ajwong@chromium.org,palmer@chromium.org,dcheng@chromium.org,jyasskin@chromium.org,mmenke@chromium.org,tsepez@chromium.org,nharper@chromium.org Change-Id: Ieba0af822a2287583cf37a109538f6ceeb8e4f98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817982 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1211902Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589278}
-
Paul Meyer authored
Change-Id: I617662f80f0bcdc723607337d8a2e153f537469b Bug: 879692 TBR: jbroman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1200149 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#589277}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b63139d..41db1841 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d84c6755b8854b08b4ed33e325aadc3f98f7382 Reviewed-on: https://chromium-review.googlesource.com/1209544Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589276}
-
Xianzhu Wang authored
See core/layout/README.md for the definitions of scroll position and scroll offset. Previously ScrollTranslation used -LayoutBox::ScrolledContentOffset() which corresponds scroll offset. This caused trouble in PropertyTreeManager for blink-gen-property-trees which expects ScrollTranslation to translate by scroll position (the scroll offset seen by cc which knows nothing about scroll origin). Now let ScrollTranslation translate by scroll position (scroll offset + scroll origin), so it translates the container's content box space to the scrolling contents space, and both spaces are originated from the top-left corner. At places where the code expect the coordinate space relative to scroll origin, we need to add scroll origin to the offset to convert to the new space of ScrollTranslation. Bug: 853945 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9c7d5925a25d42365c8a6fe6951383af8eab127e Reviewed-on: https://chromium-review.googlesource.com/1181644 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589275}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7359954301e1..4d42ef39658b git log 7359954301e1..4d42ef39658b --date=short --no-merges --format='%ad %ae %s' 2018-09-06 ianelliott@google.com Add A4A opt-in/out logic 2018-09-06 jmadill@chromium.org Fix JSON cpp DEPS. 2018-09-06 oetuaho@nvidia.com Support multisample arrays in shader programs 2018-09-05 jiajia.qin@intel.com Fix that same resource is bound on SRV and UAV simultaneously Created with: gclient setdep -r src/third_party/angle@4d42ef39658b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I2d3494e590e5597ca0792ce6f9a894fca8c67688 Reviewed-on: https://chromium-review.googlesource.com/1211046Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589274}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a63f1d10. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24195 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: If5164fcab6535f2897adeeb84ee4767ff7c037f5 Reviewed-on: https://chromium-review.googlesource.com/1211025 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589273}
-
Ross McIlroy authored
This reverts commit 04bab180. Reason for revert: Failing DCHECKs by blocking on non-blocking task. BUG:878750 Original change's description: > [v8] Re-post non-blocking ScriptStreamer tasks (reland) > > Posted blocking ScriptStreamer tasks can end up in a queue, and have > their Resource complete loading before the task even starts. When this > happens, these tasks will no longer block on network input, but they > will still be posted to the blocking task runner, which does not spin up > new threads if the running task is not blocked. When there are a lot of > small functions posted for streaming, this results in a slightly > paradoxical starvation, where the blocking task runner is processing > lots of no-longer-blocking tasks all in one thread, as it has no reason > to spin up new threads. > > To avoid this, if a streaming task isn't started before the resource > finishes loading, we can cancel this posted task, and instead post a new > non-blocking task to the non-blocking thread pool. This frees up the > blocking task runner to process only blocking tasks (and thus allows it > to spin up new threads for them). > > TBR=kouhei@chromium.org > > Bug: chromium:865098 > Bug: chromium:866868 > Change-Id: I930b10d23fd538b3529ab3a31f6caba13a8661fb > Reviewed-on: https://chromium-review.googlesource.com/1179744 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584032} TBR=rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:865098, chromium:866868 Change-Id: I8c26832b131cf8997c304422eb0324bb0770b947 Reviewed-on: https://chromium-review.googlesource.com/1211582Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589272}
-
Ryan Harrison authored
When getting text from PDFium, the library does not filter ZWW (0x200B), since it is a valid non-control character. It is ignorable though, so the embedder aka Chrome, has the option of whether or not to display this character. Given that it shouldn't have any visual display, including it in the displayed text can lead to weird UI situations. Like the length of text being longer then number of characters displayed or navigating the cursor requires multiple key presses to get over the ZWW. BUG=chromium:743522 Change-Id: I5312a3aad4a752659fb4455853cd1030f0660bd9 Reviewed-on: https://chromium-review.googlesource.com/1210966Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589271}
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1iYtj0IQfLB6KLZmguxpStD_LgYIFCwF9/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1fJUyPl6Vs0eiOx9eNJubf-OxEfi0nk3M/view?usp=sharing Bug: 872647 Change-Id: I681f16b95f56840e16fc49004828c2014a205ef4 Reviewed-on: https://chromium-review.googlesource.com/1210642Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#589270}
-
Steve Kobes authored
This ensures that JankTracker cannot be trivially circumvented by forcing layer promotion of janking content. Also add a REF check that was missing from crrev.com/587033. Bug: 581518 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3da0c1986f3b1b033af5f8126459966d1884ef2f Reviewed-on: https://chromium-review.googlesource.com/1208453 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#589269}
-
Vladimir Levin authored
This patch adds the ability to create parent alias clips, with the code to skip those when generating display item lists. Also adds tests. R=trchen@chromium.org, chrishtr@chromium.org Bug: 870521 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia60e89a7c74bcda785c8b8cce971eda48d2e0fd6 Reviewed-on: https://chromium-review.googlesource.com/1208717 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589268}
-
Nicolas Ouellet-Payeur authored
|AlternativeBrowserLauncher| uses prefs to decide which browser to launch, and then uses an |AlternativeBrowserDriver| to do I/O operations that launch the browser. Bug: 876804 Change-Id: I8461d72e8fb711a50148c3d7f27a2b286493df9f Reviewed-on: https://chromium-review.googlesource.com/1197185 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#589267}
-
Chris Lu authored
Bug: 874471 Change-Id: Ied43248aefe91db97b00090a4fde284b326a82ba Reviewed-on: https://chromium-review.googlesource.com/1205103 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#589266}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d289218f53f..30d7c2688aa9 git log 1d289218f53f..30d7c2688aa9 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 hjd@google.com Merge "Add atrace_categories to atrace.cfg" Created with: gclient setdep -r src/third_party/perfetto@30d7c2688aa9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6a8d8109a818698a96f7401ab5d10082ef0b818e Reviewed-on: https://chromium-review.googlesource.com/1208905Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589265}
-
Peter Wen authored
Bug: 877957 Change-Id: I49d47adfc4bec9e6f7b580e76b0204541a338d9c Reviewed-on: https://chromium-review.googlesource.com/1211523Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589264}
-
Jeremy Klein authored
This reverts commit 54d36f8e. Reason for revert: The original change was in fact not the cause of the builder breakage. Confirmed by jdonnelley. Original change's description: > Revert "Add the ability for AndroidSmsAppHelperDelegate to launch the PWA." > > This reverts commit 6d6b6173. > > Reason for revert: Suspected of breaking the Mac builder: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20Builder/89748 > > This code doesn't seem obviously related to the webui failure there, but there are no other webui CLs in the blame list. > > Original change's description: > > Add the ability for AndroidSmsAppHelperDelegate to launch the PWA. > > > > Also actually use this ability when the "Set Up" button in multidevice > > settings is clicked. > > > > R=khorimoto@chromium.org > > > > Bug: 870093 > > Change-Id: I3dd5bcd9c8e3946e1ae42a5db69f2bb7ed3ea586 > > Reviewed-on: https://chromium-review.googlesource.com/1185498 > > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589196} > > TBR=khorimoto@chromium.org,tommycli@chromium.org,jlklein@chromium.org > > Change-Id: I855abd7c530600362082c83ee155aaa3d713415f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 870093 > Reviewed-on: https://chromium-review.googlesource.com/1211382 > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589218} TBR=khorimoto@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org,jlklein@chromium.org Change-Id: I906bbc0862ca17834fd7e009fdd23af4735d4d49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870093 Reviewed-on: https://chromium-review.googlesource.com/1211430Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#589263}
-
Hector Carmona authored
Bug: 832933 Change-Id: Id3c08467445cd359c24b6a1cad1e1132d61d87a2 Reviewed-on: https://chromium-review.googlesource.com/1204716Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#589262}
-
Aleks Totic authored
ComputedStyle::HasOutline does not work when outline is set by focus. Focus outline status is determined by LayoutTheme::ShouldDrawDefaultFocusRing Created a utility function for this. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Bug: 835484 Change-Id: If717533f72374ea493368ac6db07037961e312ef Reviewed-on: https://chromium-review.googlesource.com/1210944Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#589261}
-
Christopher Cameron authored
Move TooltipManager from BridgedNativeWidget (in the app shim side) to BridgedNativeWidgetHost (in the browser side). Change the one method in TooltipManagerMac that interacted with Cocoa to go through mojo instead. This is necessary to ensure that NativeWidgetMac::GetTooltipManager works when NativeWidgetMac (in the browser) does not have direct access to BridgedNativeWidgetImpl (in the app shim). Bug: 859152 Change-Id: I46ceeeed8e18f3fab35ace5664bb17ceff5da40c Reviewed-on: https://chromium-review.googlesource.com/1205496Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#589260}
-
Kevin McNee authored
Currently, the definition of public custom elements for guest view containers is not clearly separated from the private implementation. We now have the custom element (e.g. WebViewElement) as a distinct entity which is backed by the private implementation (e.g. WebViewImpl). Bug: 793935, 867831 Change-Id: Iaee57a53ff727f27a7fab5601b54face9335faca Reviewed-on: https://chromium-review.googlesource.com/1187072Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#589259}
-
Esmael El-Moslimany authored
Bug: 875461 Change-Id: I9acdff2f8b1afd4075057add7b1799f7e6a11141 Reviewed-on: https://chromium-review.googlesource.com/1211102Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#589258}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Id2f5fa0725648e59b9e55d64af4172cf7fac9d1e Reviewed-on: https://chromium-review.googlesource.com/1210964 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589257}
-
John Abd-El-Malek authored
This only runs on the main waterfall, as the CQ is on 10.13. This is fine for now, given that network service is on the CQ for Windows and Linux, and there's no Mac specific networking code that this impacts. Bug: 877996 Change-Id: I955c397920f307869c2b1c5b84a62ae620b6be9d Reviewed-on: https://chromium-review.googlesource.com/1200308 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#589256}
-
Mitsuru Oshima authored
kWindowIconKey is used to pass the icon from views to aura/ash. For BrowserView, it is created here: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/browser_view.cc?rcl=d567caa14b94d1bac1d72e9c4dac9b7458786629&l=1918 A browser based custom app should use kOverrideWindowIconresourceIdKey to override the default behavior in BrowesrView (which uses the favicon). Bug: 881030 Test: manual Change-Id: I7d536b1bd641e69642ceadbd33a4ad871483812e Reviewed-on: https://chromium-review.googlesource.com/1210742Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#589255}
-
Manuel Rego Casasnovas authored
Firefox tests for css-contain spec are under css/vendor-imports/mozilla/mozilla-central-reftests/contain/ in WPT. This patch removes this folder as skipped from W3CImportExpectations and does the first import of these tests. BUG=881057 No-Export: true Change-Id: Iabd132cdeea92d0fa6abdb233756952946803100 Reviewed-on: https://chromium-review.googlesource.com/1208051 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589254}
-
Vladislav Kaznacheev authored
Bug: 881157 Test: manual Change-Id: I809b94d822a40432e108519d07c27787a71f86be Reviewed-on: https://chromium-review.googlesource.com/1211111Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589253}
-
Xiangjun Zhang authored
VideoCaptureClient was recently changed to only support the new base::ReadOnlySharedMemoryRegion being passed to the client. However, for desktop capturing, the read-write shared buffer handles are still passed by media::VideoCaptureDeviceClient. This CL temporally added the support of shared buffer handles back before the media::VideoCaptureDeviceClient is migrated to the new read-only API. Bug: 734672,843117 Change-Id: Ib3f6d58aa2541abfb29f1df014f1a01cfef50ef0 Reviewed-on: https://chromium-review.googlesource.com/1204721Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589252}
-
Shahbaz Youssefi authored
extensions no longer dependens on chrome:resources, so this dependency can be removed. Bug: 881353 Change-Id: I520ebbdff9aab4d0f2c073bd8530c84c4e0eb9ba Reviewed-on: https://chromium-review.googlesource.com/1210543Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589251}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c3dc59fc1c6..e8161dd154d7 git log 0c3dc59fc1c6..e8161dd154d7 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 caryclark@skia.org bookmaker self documentation 2018-09-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 155bfd11e9f0..dff32a0da1de (1 commits) 2018-09-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-06 halcanary@google.com Move some functions to MathPriv.h 2018-09-06 mtklein@google.com stop clamping in parametric stage 2018-09-06 rmistry@google.com Android compile bot target has changed. Update the bot name. 2018-09-06 mtklein@google.com remove SkRandom::next64() 2018-09-06 caryclark@skia.org Revert "SkStream: remove some WStream functions from public api" 2018-09-06 kjlubick@google.com [PathKit] Fix document.write warning in docs. 2018-09-06 halcanary@google.com SkStream: remove some WStream functions from public api 2018-09-06 mtklein@google.com Revert "update to new MakeFromStream signature" 2018-09-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 750e508722a9..155bfd11e9f0 (4 commits) 2018-09-06 reed@google.com update to new MakeFromStream signature 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@e8161dd154d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ieed8023dfe3f15924b91b15083c4ae75e8b2eef2 Reviewed-on: https://chromium-review.googlesource.com/1211044Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589250}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09307abef3dd..77e18bee2225 Created with: gclient setdep -r src-internal@77e18bee2225 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib76920828a3a701c8be18a667958b85950ff6eb3 Reviewed-on: https://chromium-review.googlesource.com/1208972Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589249}
-