- 29 Nov, 2018 40 commits
-
-
Alex Clarke authored
A reland of https://crrev.com/c/1324391 This is necessary because we want content::TestBrowserThreadBundle to own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment and you can't have two SequenceManagers on the same thread. This patch allows ScopedTaskEnvironment to optionally work with an externally owned SequenceManager solving the problem. This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, We now have the ability to mock time on the UI thread. TBR=asvitkine@chromium.org,miu@chromium.org,gab@chromium.org,fdoray@chromium.org Bug: 863341, 891670, 708584 Change-Id: Ia4409b885deb9935e6e5b6d99f4598f164d350db Reviewed-on: https://chromium-review.googlesource.com/c/1354919Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612122}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0113b4085f5a..275e8750e3d2 git log 0113b4085f5a..275e8750e3d2 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@275e8750e3d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ib9c02daa95f01c1aada3aa0ce2ac0b22b2c99294 Reviewed-on: https://chromium-review.googlesource.com/c/1354634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612121}
-
Colin Blundell authored
When SyncAuthManager receives an OnRefreshTokenUpdatedForAccount() observer callback from IdentityManager, it queries the value of the |is_valid| parameter. However, we are going to be removing that parameter altogether as it is confusing for the common case where consumers *shouldn't* check it. This CL changes SyncAuthManager to compute the validity internally by querying the error state of the refresh token via IdentityManager. There should be no functional change. The logic of the computation of whether the refresh token is valid is taken from the internal computation of the |is_valid| parameter that IdentityManager does. As a followup, we can consider re-hiding that logic inside IdentityManager via a helper method to reduce fragility. Bug: 908412 Change-Id: I4842652dc63bea7169e4e915b5f4382e9291a0ea Reviewed-on: https://chromium-review.googlesource.com/c/1350888 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#612120}
-
Mathias Carlen authored
Sub-scripts part of larger scripts are not explicitly known to the client, hence status match preconditions could not be applied in that case. Before this patch, this kind of script filtering was not possible. This patch introduces a way of updating the list of available scripts mid script execution by reporting an updated list as part of the get actions response. The updated list will be used when the script execution finishes and another round of precondition checks is triggered. After this patch, the backend will be able to fine script eligibility while still being backwards compatible with script status match preconditions. Note: This is an intermediate step towards removing the status match preconditions from the client and handle that entirely in the backend. R=szermatt@chromium.org Bug: 806868 Change-Id: Ia29bd0a7bc5a3f00b4b0f736dd28a93f6b422d92 Reviewed-on: https://chromium-review.googlesource.com/c/1352763 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612119}
-
Dean Liao authored
Log unsupported BufferFormat and VideoPixelFormat to facilitate debugging. BUG=None TEST=Noe Change-Id: I3b38a5c5a3cff91464d30ada4c6a09485f576006 Reviewed-on: https://chromium-review.googlesource.com/c/1354739 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612118}
-
Ken Rockot authored
Migrates video_capture away from the deprecated ServiceTest framework to use regular unit tests and new test helpers provided by the Service Manager client library. Bug: 906239 Change-Id: I56f9a1ce396b601f4e6a5e9078c506398cf50dbc Reviewed-on: https://chromium-review.googlesource.com/c/1352750 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612117}
-
Gauthier Ambard authored
This CL updates the EncryptionCollectionVC to use a UITableVC instead of the MDCCollectionVC. Bug: 894791 Change-Id: I875bc29cb3a7b27242897e7301a0e7fe761d1fcd Reviewed-on: https://chromium-review.googlesource.com/c/1350832 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#612116}
-
Raphael Kubo da Costa authored
This fixes the libstdc++ build after 86293fce ("IndexedDB: Move content/renderer/indexed_db/ to Blink, take 2"): In file included from /usr/include/c++/8/memory:80, from ../../mojo/public/cpp/system/buffer.h:17, from ../../mojo/public/cpp/system/core.h:8, from ../../mojo/public/cpp/bindings/lib/bindings_internal.h:16, from ../../mojo/public/cpp/bindings/lib/array_internal.h:18, from ../../mojo/public/cpp/bindings/array_data_view.h:10, from gen/third_party/blink/public/mojom/indexeddb/indexeddb.mojom-shared.h:17, from ../../third_party/blink/public/common/indexeddb/web_idb_types.h:29, from ../../third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h:12, from ../../third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc:5: /usr/include/c++/8/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = blink::IDBValue]’: /usr/include/c++/8/bits/unique_ptr.h:274:17: required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = blink::IDBValue; _Dp = std::default_delete<blink::IDBValue>]’ ../../third_party/blink/public/platform/modules/indexeddb/web_idb_value.h:49:30: required from here /usr/include/c++/8/bits/unique_ptr.h:79:16: error: invalid application of ‘sizeof’ to incomplete type ‘blink::IDBValue’ static_assert(sizeof(_Tp)>0, ^~~~~~~~~~~ libstdc++'s std::unique_ptr implementation has a few static_asserts in the destructor, one of which requires that the type passed to unique_ptr is fully declared at the time. indexed_db_dispatcher.cc is now in Blink, and it ends up indirectly including web_idb_value.h, and now WebIDBValue::ReleaseIdbValue()'s call to std::move() triggers that assert. Since we cannot include idb_value.h in web_idb_value.h without triggering checkdeps, move the implementation to web_idb_value.cc instead. Bug: 819294 Change-Id: I5fdcfab3fa83729863b5f825568780a0ccb0d96f Reviewed-on: https://chromium-review.googlesource.com/c/1352251Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#612115}
-
Friedrich Horschig authored
This CL allows icons from the same host as credential icons used in the keyboard accessory. Additionally, the icon isn't restricted to favicons anymore: touch icons or manifest icons are considered when looking for the best-fitting icon. It does consider subdomains. Example: - rsolomakhin.github.com/autofill uses icon from rsolomakhin.github.com - rsolomakhin.github.com does not reuse the icon from github.com The new icon sources besides favicons [1] are: - Touch icons (often used to display sites as apps on mobile platforms [2]) - Web App Manifest icons (defined for PWA-ready sites [3]) [1] often taken from /favicon.ico or <link rel="icon"> tags [2] https://mathiasbynens.be/notes/touch-icons [3] https://developer.mozilla.org/en-US/docs/Web/Manifest Change-Id: I3941f86f6a0a6f6518e405dcc4da390cc0dc0c84 Reviewed-on: https://chromium-review.googlesource.com/c/1353891Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#612114}
-
Sam McNally authored
Bug: 909056 Change-Id: I6ed0a7d0d48b3b21eaae60ffd5b28d7a1c134024 Reviewed-on: https://chromium-review.googlesource.com/c/1354732 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612113}
-
Grachev Aleksey authored
DocumentToFrame does not return the expected values if the WebPluginContainer is inside the iframe. After that CL DocumentToFrame() will be called from root_view. Bug: 907026 Change-Id: I87cbd03eb3d077d2e16a1e4c2997bbae78163daa Reviewed-on: https://chromium-review.googlesource.com/c/1349219Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612112}
-
Olivier Robin authored
This CL adds a watchdog to check the main thread responsiveness by posting regular tasks to the main thread and check their execution. If the main thread is not responsive for too long, a "crash" report will be generated and sent on next startup. A NSUserDefault will also be set to allow reporting the freeze on next startup. Bug: 910024 Change-Id: I541b27c993b90e0982227cbe4238a338938d760f Reviewed-on: https://chromium-review.googlesource.com/c/1350958 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612111}
-
Sam McNally authored
Bug: 909056 Change-Id: I526a3f743c2c458caad3f3dbaf899d9ef6e64518 Reviewed-on: https://chromium-review.googlesource.com/c/1354748 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Sam McNally authored
Convert: - crostini.js - install_linux_package_dialog.js - launcher_search.js - open_video_files.js - traverse.js Bug: 909056 Change-Id: Ia5aab9381820524216473db8313da0bb55f2612b Reviewed-on: https://chromium-review.googlesource.com/c/1353045 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Koji Ishii authored
The "empty" line box is what CSS defines as "certain zero- height line box", that suffices certain conditions as defined in the spec and is ignored for margin collapsing. It has some special behaviors, such as to ignore strut, that LayoutNG suppressed to generate their child fragments. However, we need them under certain conditions such as when they have out-of-flow container as descendants. This change breaks some normal flow, out-of-flow, and outline tests. Normal flow failures were fixed by adding an explicit |IsEmptyLineBox()| function. Out-of-flow failures are fixed as a separate CL in r610994 (CL:1351189). Outline failures are fixed in this CL and in r611954 (CL:13543199) thanks to atotic@. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4d393af016439cdbe085d91fdd1e8550d320d1f1 Bug: 636993, 903578 Reviewed-on: https://chromium-review.googlesource.com/c/1251142 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612108}
-
Dean Liao authored
WrapVideoFrame() currenlty copy data() regardless if source frame is mappable or not. This is incorrect, it should copy data() when source frame is mappable. BUG=None TEST=None Change-Id: I2f6005114bbaef78c6facc20d431940a77780e81 Reviewed-on: https://chromium-review.googlesource.com/c/1352126Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#612107}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6732bb38dc8..7fda03cb0aab Created with: gclient setdep -r src-internal@7fda03cb0aab The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I852e486a5a376fb13dcafddd4f12814b9dda8435 Reviewed-on: https://chromium-review.googlesource.com/c/1354633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612106}
-
Sam McNally authored
Bug: 909056 Change-Id: Ifd3eeffdc9bca6befdb21c7db84514717516cd21 Reviewed-on: https://chromium-review.googlesource.com/c/1354744Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3bad6b7e2cb925f559f10fc9d7510763e98e3b19 Reviewed-on: https://chromium-review.googlesource.com/c/1354635Reviewed-by:
-
Keishi Hattori authored
Convert P*, R* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I9df78f5d474752188412e07c880074b7f722207e Reviewed-on: https://chromium-review.googlesource.com/c/1350428 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
This CL rewrites #include lines of web_task_runner.h, which is now deprecated. Instead of web_task_runner.h, new include lines of post_cancellable_task.h and/or post_cross_thread_task.h are inserted, depending on what's used in each file. This CL only touches #include lines and nothing else. Bug: 826203 Change-Id: I3b4ae2d9e62966acac0400bd0c802fef3b3aecf9 Reviewed-on: https://chromium-review.googlesource.com/c/1351206 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
CreateContext() doesn't acquire lock if it is called by VaapiWrapper's caller. Lock should be acquired always in CreateContext(). This change also removes DestroySurfaces_Locked() and instead DestroySurfaces() is called everywhere. CreateSurfaces() and DestroySurfaces() are renamed to CreateContextAndSurfaces() and DestroyContextAndSurfaces() to specify what they are doing. Bug: 909547, 909561 Test: VDA, VEA, JDA, JEA unittest on eve Change-Id: Ib04386307c2e83d83e0afe079a1868ac02eff086 Reviewed-on: https://chromium-review.googlesource.com/c/1353056 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#612101}
-
Kent Tamura authored
For "Web Test". This CL has no behavior changes. Bug: 843412 Change-Id: Ic3cf211efc420f07528df5fcfd9193f08f99dcf0 Reviewed-on: https://chromium-review.googlesource.com/c/1353068Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Iaf5d3909b8a63f4beca7feda97e20695e5537a2b Reviewed-on: https://chromium-review.googlesource.com/c/1354747 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Hayato Ito authored
This CL is separated out from the wip CL, https://crrev.com/c/1350441, where recursive recalc slot assignment causes the tricky bug which is hard to debug. It would be better to detect recursive recalc slot assignment, which shouldn't happen. Change-Id: I07d2d22ea8e083ef1de5134d6879cb1a141ce183 BUG=906494 Change-Id: I07d2d22ea8e083ef1de5134d6879cb1a141ce183 Reviewed-on: https://chromium-review.googlesource.com/c/1354727Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#612098}
-
Xiaohui Chen authored
Fix shutdown crash in default_url_request_context_getter. Base class url_request_context_getter::OnDestruct() already posted the destruction to network_task_runner. This makes the thread join in default_url_request_context_getter crash because it is joining on the same thread. This cl removes the posting and joining logic in default_url_reqeust_context_getter since it is duplicate with the base class. We cannot create and hold the thread object either because that will implicitly join when destrcted, causing the same error. We use the global IO task runner instead. Bug: b:120096335 Test: locally build and run. Does not crash during shutdown. Change-Id: I80672c99eeab52198158bbb0e6471ccca1dcc21f Reviewed-on: https://chromium-review.googlesource.com/c/1354034Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612097}
-
Dan Beam authored
TBR=scottchen@chromium.org Bug: None Change-Id: I122dacc4367c85074cc21c8f9882df973fd010be Reviewed-on: https://chromium-review.googlesource.com/c/1354330 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#612096}
-
Amos Lim authored
According to the spec, the createImageBitmap should be moved to WindowOrWorkerGlobalScope mix-in. They were moved from the ImageBitmapFactories mix-in to the WindowOrWorkerGlobalScope mix-in[1]. [1]: https://github.com/whatwg/html/commit/cdd48e1f570c817402bf62108847c4a9f4b00b1e [2]: https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope-mixin This CL has no behavior changes. Bug: 701457 Change-Id: Idbf0cf3e22019cc24384ab3c409e202343eb1d5a Reviewed-on: https://chromium-review.googlesource.com/c/1349160 Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612095}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22619c2e1a6d..0113b4085f5a git log 22619c2e1a6d..0113b4085f5a --date=short --no-merges --format='%ad %ae %s' 2018-11-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 79d0e565b001..a972758d6e10 (1 commits) 2018-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c4e0a1e511fc..2c0d6a9404cd (4 commits) Created with: gclient setdep -r src/third_party/skia@0113b4085f5a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I536845019d34306d4d95f85ee095e6b89aa905c6 Reviewed-on: https://chromium-review.googlesource.com/c/1354632Reviewed-by:
-
Maksim Sisov authored
This patch makes it possible to compile ozone/wayland on systems without gbm available. on a system without gbm available. TEST: compile ozone/wayland with use_wayland_gbm = false Change-Id: Ibda6632dcafe5ba0a46a819045b7f366d5c76a46 Reviewed-on: https://chromium-review.googlesource.com/c/1350983 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612093}
-
Guido Urdaneta authored
This metric find cases of Web sites that use complex SDP. Complex SDP can lead to errors if the application assumes the wrong default SDP format. Tracking this is important during the transition of the default SDP format from Plan B to Unified Plan. Review: https://docs.google.com/document/d/1kiUze0n2yJGK2_TVhyKoGbER-xFlwZZaLLrjy0w4dek/edit Bug: 900951 Change-Id: Ic0eb065e73f2e7578f883b75477193e0019fcc62 Reviewed-on: https://chromium-review.googlesource.com/c/1347364 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#612092}
-
Marc Treib authored
It has been replaced by SyncUserSettings::IsFirstSetupComplete. Note that *Profile*SyncService::IsFirstSetupComplete still exists for now (it's used by SyncUserSettings). This will be changed in a later CL. There were 3 remaining places that still used the SyncService version of IsFirstSetupComplete; those are trivially migrated to SyncUserSettings. Bug: 884159 Change-Id: I90b29436986a7220803c61e2f2767c620e291e71 Reviewed-on: https://chromium-review.googlesource.com/c/1352785Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#612091}
-
Ken Rockot authored
Migrates prefs service away from the deprecated ServiceContext API to ServiceBinding, and migrates its tests from the deprecated ServiceTest framework to regular unit tests. Bug: 891780,906239 Change-Id: Id5d73b2aa6c87d40d3e9814946c91494a18afd66 Reviewed-on: https://chromium-review.googlesource.com/c/1351875 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612090}
-
Sam McNally authored
Bug: 909056 Change-Id: I59ba6c3b5bbaa22551a3b31229f394ce24ed0470 Reviewed-on: https://chromium-review.googlesource.com/c/1354750Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Ifd26dc5037d52bf98973b9e500695cbc27ecc6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1354735Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2c0d6a9404cd..7310da33bc7a git log 2c0d6a9404cd..7310da33bc7a --date=short --no-merges --format='%ad %ae %s' 2018-11-29 yizhou.jiang@intel.com Implement GetMultismaplefvANGLE and SampleMaskiANGLE of texture multisample extension Created with: gclient setdep -r src/third_party/angle@7310da33bc7a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I42909a3dddf5f6cf337c65db1c954954f7cf73cd Reviewed-on: https://chromium-review.googlesource.com/c/1354630Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Idafd58064585c900805629044cd192b2cfe2461a Reviewed-on: https://chromium-review.googlesource.com/c/1354731Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Ic5a91cccb89c55d65217e6e55444878e4ab623cd Reviewed-on: https://chromium-review.googlesource.com/c/1354733Reviewed-by:
-
Hirokazu Honda authored
Formerly, V4L2JEA calls S_FMT one time for YUV420M and checks if the pixel format filled by driver is either YUV420 or YUV420M. Then, a driver can fill NV12 even if it supports YUV420. V4L2JEA would rather execute S_FMT for YUV420M and YUV420 separately and check if the returned format is exactly same as the specified one. Bug: 908357 Test: VEA unittest on kevin Change-Id: I15b5bae4f8d1c728f0db0bb961a1f5d39fed3c53 Reviewed-on: https://chromium-review.googlesource.com/c/1352074 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612084}
-
David Staessens authored
This change moves all test-related setup and teardown to a separate test environment. It also fixes a small bug that causes a crash when destroying the video player without playing a video. TEST=ran new VD tests on nocturne BUG=879065 Change-Id: I0f746ff3aff1598130d563aa8241e87f3d739c8a Reviewed-on: https://chromium-review.googlesource.com/c/1350413Reviewed-by:
-
