GitLab

Removes last use of view_to_field_ directly, which permits rewriting it
as field_to_view_ and removing the FieldToView method.

Bug: 1106422
Change-Id: Ia827aba9e48487dad30b0f24a66d39ab0ab349bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416724Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809025}

Updates the host:port parsing logic in chromedriver so that the
debuggerAddress option can accept ipv6 addresses. This change does not
support ipv6 addresses containing a zone id as the underlying url
libraries will not parse them.

Bug: 1112509
Change-Id: I2adb13b5788fc88a5ce4c415f680e2e3f93d6c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412811Reviewed-by: Shengfa Lin <shengfa@google.com>
Commit-Queue: Satsuki Ueno <satsukiu@google.com>
Cr-Commit-Position: refs/heads/master@{#809024}

Design Doc: go/cros-camera:dd:cca-default-saved-folder

Bug: 1127587
Test: Take a photo and Camera folder is created and the photo is saved
there.

Change-Id: I2701ee5ed82df3df3a0ff2e65ad33f6e6145c3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407732
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Inker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809023}

Holding space items should open on double click and single tap.

Bug: 1129694
Change-Id: I844d1e5e5635ad3c7d1daf60126211b07c373e67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416766
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809022}

This CL adds a Android bookmark type for reading list, so we can
distinguish reading list bookmarks in UI and fork calls into reading
list backend.

Bug: 1128074
Change-Id: I8ceb198bcca68c794d7a044210a73b97679fce07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415589Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809021}

We've theorized that the App menu could be shown before the
PWA check finishes and this is an effort to track if that
happens in the real world.

Although the end result (of such a race) is pretty benign
(you get the behavior Stable is exhibiting today: the string
'Add to homescreen' would be shown instead of 'Install app'),
we'd still like to know how common this is in the real
world to see if we should address it.

Bug: 1128364
Change-Id: Ifa5c670811a2d4dd823757a94cd9eb8486e47ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406166
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809020}

Bug: 1107164, b/161612881
Change-Id: Idf86fa429de43b5da554d57bd1e8d1cbd186835b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378772
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809019}

This CL adds four miscellaneous tips to commit_checklist.md. Firstly,
use CL hashtags to group related CLs together. Secondly, don't use
chrome/OWNERS as a blanket stamp to land your CL if your CL makes
significant changes to subsystems. Thirdly, this CL adds a link to
instructions for building various targets. Fourthly, this CL adds a
tip about auto-submit.

Bug: None
Change-Id: Iaa3c51b8e2b4a49947061762f3a080a858f41fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369619
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809018}

This delegate provides access to the NearbySharingService from //ash.
It will be used to implement a pod button in the system tray that
toggles high visibility mode.

Bug: 154866703
Test: unit_tests
Change-Id: Icc6b84b6af0ba350d01a0a92e844f4dd2249600f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405439
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#809017}

The new trailing space logic refactoring, landed in r806928 and relanded
again in 807457, assigned the current offset as the non-hangable-run-end
when this is not applicable.

The root cause of this issue is that this offset must not exceed the
item s range-end, so that we clamp it to this range-end value. However,
since in some cases we use the original offset as the the
non-hangable-run-end, we may lead to a situation where the offset used
exceed the item's range end. This is precisely the DCHECK violation
described in the issue 1130288.

Since r808007 we have decided to use optional values for the
non-hangable-run-end, but we didn't update the implementation of the
PreviousBreakOpportunities and NextBreakOpportunities functions
accordingly.

Bug: 1130288
Change-Id: If5e5fb380320ca54f7a6d17d1c2bd020a643e12e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421728Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#809016}

Updating expiration date for:
 + Signin.AccountReconcilorState.OnGaiaResponse
 + MobileSignInPromo.SettingsManager.ImpressionsTilSigninButtons
 + MobileSignInPromo.SettingsManager.ImpressionsTilXButton
 + MobileSignInPromo.SettingsManager.ImpressionsTilDismiss
 + MobileSignInPromo.BookmarkManager.ImpressionsTilXButton
 + MobileSignInPromo.BookmarkManager.ImpressionsTilDismiss
 + MobileSignInPromo.BookmarkManager.ImpressionsTilSigninButtons
 + FirstRun.Sentinel.CreatedFileError
 + FirstRun.Sentinel.Created

Choosing the same expiration date than other sign-in metrics.

Fixed: 1125775, 1125709, 1125708, 1125673
Change-Id: Ibdcd6023e3de10efc4f060d02cd07842699a2eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421652
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809015}

ANGLE increases the OTA size on devices with constrainted space. Since
Chromecast hasn't transitioned to passthrough command decoder yet, don't
depend on ANGLE for now.

Bug: 1097320
Bug: b/159166071
Test: Compiled
Change-Id: I86a966af39e652564754d0680a9366c159b63b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422180Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809014}

TBR=govind@chromium.org

Change-Id: I18dc846e68a95e397446a17d5aa303286372923f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421763Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809013}

We need to invalidate the layout, in case the Header view is changed
after the bubble has been created.

This is also aligned with SetFootnoteView().

Bug: 1115936
Change-Id: I66896d7beeda5e2996ee9c72fad0bdbf99a268a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421517
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809012}

Fix or update several DCHECKs and crashes that occur with
GpuMemoryBuffer backed capture frames.

Most substantially, when hardware acceleration is disabled (and
so VideoCaptureImpl::gpu_factories_ or media_task_runner_ are absent,
allow the GpuMemoryBuffer to be reinterpreted as external system
memory, by using media::VideoFrame::WrapIOSurface. Move around some
of the CHECKs for gpu_factories_ or media_task_runner_ to only trigger
when we are heading into hardware accelerated paths.

Move a DCHECK in BindBufferToTextureOnMediaThread that would trigger
when the Gpu process crashes during capture (the frame will report
that it is of UNKNOWN format, and it will be DCHECKed that it is NV12).

Update the destructor ~BufferContext to only destroy the
GpuMemoryBuffer-backed SharedImage if the SharedImage has been
created (not if the BufferContext is of type GpuMemoryBuffer).

Weaken a DCHECK in OnAllClientsFinishedConsumingFrame that is invalid
for all GpuMemoryBuffer-backed frames on all platforms (it only
happens to not be hit most of the time due to a race condition
described in the referenced TODO).

Bug: 1128853, 1125879
Change-Id: I2bc26b1c4bbb63c1fdc2696f8e565ec418c3c501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419510Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809011}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/71b08cd277f4..9c946ee14364

2020-09-21 tvanderlippe@chromium.org Remove is_web_worker from formatter_worker implementation
2020-09-21 liaoyuke@chromium.org Make devtools work for non-default toolchains
2020-09-21 andoli@chromium.org [ts] Typecheck components/JSPresentationUtils.js with TypeScript
2020-09-21 tvanderlippe@chromium.org Move message handling of worker into formatter_worker.ts
2020-09-21 andoli@chromium.org [ts] Typecheck components/Reload.js with TypeScript
2020-09-21 tvanderlippe@chromium.org Remove autocompletion for box-shadow
2020-09-21 mmocny@chromium.org Extract Layout Shifts from all Renderer processes & its subframes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1129223,chromium:1130583
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I205841e6df9e5dd8369c1ed0327dba99cd83df03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422304Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809010}

Borders are monolithic, but this test expected them to be fragmented
(which is what the legacy engine does).

Bug: 829028
Change-Id: Ief578602b0dc763060a5cfdea5f13dd0fe96e7e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421595
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#809009}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ef916081..d56d50c3

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibfb481c3f298339e0122357e2615b5bcd92117cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421831Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809008}

Now that we have deprecated the Universal throughput tracker,
the aggregated throughput is no longer useful and this CL
removes related code.

Bug: 1128993
Change-Id: I96f95a9cba1f99d8e42ccdbc1c266c41b721d08d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421760Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809007}

Before this change, Nearby advertising, even in "low power" mode, was
always advertising over Bluetooth Classic -- poor for battery
performance, and dangerous for users' privacy.

Bug: 1128179
Change-Id: Idfeab6e02c442183ec03acb9b00cc048750611e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413175
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809006}

Renaming lab_color_space* files to dark_mode_lab_color_space* will
help identify dark mode module files easily and also help in running
the all related tests using --gtest_filter=*Dark* filter.

Bug: None
Change-Id: I56408d6bc3c9973b03407e4265614bd1549e97bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421978Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Cr-Commit-Position: refs/heads/master@{#809005}

This spacing was provided by the designer and matches the realbox.

Bug: 1128160
Change-Id: Ia5b4af4cbab04cf1b3a07eb2fa49e40a579d82be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422478
Auto-Submit: Tommy Li <tommycli@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809004}

This change adds a test for each type of nudge given by the tutorial.
Currently there are two types, general and practice_area, so there are
two tests in this patch. These tests confirm that nudges given in the
general tutorial context differ from those given in the practice area.

Bug: 1127045
Change-Id: I3019917f7ae5d618e976422b0fc25f54e74ef45d
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410675
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809003}

In other parts of the WebGPU API, we flush lazily at the end of the
task because the page needs to yield back to the browser for pending
callbacks to resolve anyway. Queue submissions however may be holding
lots of data which the GPU process can begin working on promptly.
Frequent queue submissions will have poor command throughput if we don't
flush eagerly.

In the future, the WebGPU command buffer should have a better
way for the Renderer process to ask the GPU process to begin processing
work, and update the GPU process (in a non-blocking way) of the latest
command it has finished writing. This would yield better throughput
without requiring frequent flushes.

Bug: 1128293
Change-Id: I19903dffc946865b11512d100b711409857b025f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417639Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809002}

Bug: 1128763, 1107058
Change-Id: Iba395be1240214924279dc3c928991b6a513d09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419918Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809001}

This change affects the password check row, the Safe Browsing row, and
the extension row. When the state is SAFE, make the entire row clickable
and display a clickable icon in the row. When the row is clicked, direct
the user to its corresponding settings page.

before: http://screen/ArPirizGoZhfiYz
after: http://screen/76CN4UQ4a4rbk4p
screen record: http://dr/file/d/1E6tBzL62Yfci7M4QqcWQm25cRX8O_7xl/view

Bug: 1103015
Change-Id: I545207019b52962e0b53dd1455b2e1108c4e2b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401812Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809000}

Requires an update to the Fuchsia test runner to support
isolated script args. Also tweaks the arguments to the
standalone tests on non-Fuchsia platforms so we can directly
invoke the Fuchsia test runner.

Bug: angleproject:3162
Change-Id: I8617cbcd903f0a172d5f796eb381663f2b7d5be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418972Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808999}

Roll Chrome Linux PGO profile from chrome-linux-master-1600689096-42a268e21a38ce243e34c88881f4529ac993701d.profdata to chrome-linux-master-1600711078-15e6465f6b9c8d99add6c7e09aa1cb16b33babfa.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: Idd60db73692a5606b158e9ea2beefa6f97103063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808998}

https://crrev.com/c/2327149 added a histogram to track the time taken
to perform the user encrypted directory mounts. Track this on the
Chromium side to see them in UMA.

BUG=1074735
TEST=validate_format, pretty_print.

Change-Id: Ic7f52f37f659c00818cd1eff0c00a84e894382ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381591Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Betul Soysal <betuls@google.com>
Cr-Commit-Position: refs/heads/master@{#808997}

Certain builds of Fuchsia set low-end device flag, which forces
SysInfo::AmountOfPhysicalMemory to return 512 MB.

This corrects an ordering issue introduced in crrev.com/c/2419555

Bug: 1126490, 1130036
Change-Id: I8d0520cc0393864265b2ad8c4646b146b7bcf547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421300Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808996}

Bug: 1095784
Change-Id: Ia03bd437d2339933dfa7b87ed52be79d10c58a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386555Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808995}

This CL creates a new canvas frame tracker to track canvas
invalidations in the current frame.

Bug: 1111392
Change-Id: I7707720d4749ea4ceb8928a624ec86ef831610bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417249Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808994}

The PluginContainer loses focus when the tab is changed which makes
this variable redundant. As it would assume that has_content_area_focus_
could be false while has_webkit_focus_ could be true, but that is
impossible.

Removing this concept simplifies the code and removes another widget
callback.

BUG=1097816

Change-Id: I3f1557be666b07a05b71d2be2ad756af91ccc2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419113
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808993}

Roll ChromeOS Airmont AFDO profile from 87-4247.0-1600077656-benchmark-87.0.4265.0-r1 to 87-4262.0-1600690455-benchmark-87.0.4265.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I11bfd67898e3b42aedb682a8bc47c09c99ac11b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422307Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808992}

Extend the expiry milestone of Quick Answers related feature flag.

Bug: None
Test: Locally build and test
Change-Id: I2df16ed1037d5f333cf864c1d697b0ec8c636587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419752
Auto-Submit: Yue Li <updowndota@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808991}

NOTRY=true
TBR=tkent@chromium.org

Change-Id: I5dfae4f34113699296028eb0566b3b479ad16959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422443Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808990}

Looks like AddressAccessoryController::GetIfNeeded is not currently
being called.

Bug: None
Change-Id: I4e717c1b481958b79a77bee4615b2d25c9663ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416808Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Auto-Submit: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808989}

Bug: 1114381
Change-Id: Ia5b0ae4e408ae770cbed0086dc6ff269793ea876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343955Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#808988}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05f0bbb70bde..37f4b38fcbc4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC hesen@google.com,etiennep@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: hesen@google.com,etiennep@google.com
Change-Id: I299cec8fba8c4a215e9802438372d136829fc825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422216Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808987}

Since SceneOverlays are no longer a per-layout construct, it is
possible for the layer tree to become stale. Overlays may continue
holding a layout's SceneLayer post being hidden. This patch adds
the ability of a SceneLayer to remove itself from its parent. This
happens after the layout has been hidden.

Bug: 1128279
Change-Id: Iab8f1f36487bf021868591d9013c4852141ae690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414614Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808986}