GitLab

end_date is a replacement for expiry_date, which is deprecated by this change. The difference is that end_date is acts as a normal filter, and causes study to not be created when the date is past. expiry_date caused the study to be created, and forced to the default group.

This change introduces a generic default group name, which is used for the field trial API when a study doesn't specify one.

BUG=677976

Review-Url: https://codereview.chromium.org/2614443002
Cr-Commit-Position: refs/heads/master@{#441487}

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2594983002
Cr-Commit-Position: refs/heads/master@{#441486}

This CL instruments SdchManager using MemoryDumpProvider.
Even though SDCH might be unshipped (see blink-dev),
it is useful to get an idea of how much memory dictionaries
cost.

BUG=669108

Review-Url: https://codereview.chromium.org/2541073003
Cr-Commit-Position: refs/heads/master@{#441485}

[CrOS Tether] Create BleScanner, a class which scan BLE advertisements and identifies nearby devices.

This class provides an API for registering or unregistering RemoteDevices. As long as at least one RemoteDevice is registered, a discovery session is active. If an advertisement from a registered RemoteDevice is scanned, observers are notified.

BUG=672263

Review-Url: https://codereview.chromium.org/2604063003
Cr-Commit-Position: refs/heads/master@{#441484}

Adds HistoryAdapterTest and HistoryManagerTest with tests for
removing history items and basic tests for initializing the
adapter.

Also fixes two bugs related to removing items:
 - Remove header if only 1 item is remaining so empty view is shown
 - Set item positions after removing an item

BUG=654071

Review-Url: https://codereview.chromium.org/2603403003
Cr-Commit-Position: refs/heads/master@{#441483}

Previously, our generated Xcode project has the issue that Xcode couldn't find
our xctests. And to fix it, one must first find the list of xctest files
under each of the application targets and then associate them with the
corresponding xctest target.

This CL enables identifying application targets and also find the list of xctest
files (xctests.mm and egtest.mm) under them recursively.

BUG=614818

Review-Url: https://codereview.chromium.org/2574643002
Cr-Commit-Position: refs/heads/master@{#441482}

SHA-1 is being phased out, and beginning with M57, SHA-1 certificates
signed by locally installed trust anchors is being disabled by default.
To re-enable, Enterprises should set an EnableSha1ForLocalAnchors policy
to allow it.

However, for platforms without enterprise policies, or for embedders,
this raises a question about what the default state should be - enabled
or disabled. As Chrome itself expects there to be non-trivial impact
(thus, the policy, supported until 1 Jan 2019), it is safer to leave
the current behaviour, enabling SHA-1 for these certs, on by default,
and leave it to embedders to disable (via the
SSLConfig/SSLConfigService).

If embedders support preferences, that's seen as sufficient support to
enable some degree of run-time control/flexibility, thus the default
is moved from //net to //components/ssl_config. Embedders using
//net will continue to support SHA-1 anchors by default, while embedders
that include //components/ssl_config (and use it) will disable it by
default.

BUG=673036

Review-Url: https://codereview.chromium.org/2613533004
Cr-Commit-Position: refs/heads/master@{#441481}

BUG=661357

Review-Url: https://codereview.chromium.org/2592733002
Cr-Commit-Position: refs/heads/master@{#441480}

Review-Url: https://codereview.chromium.org/2608733005
Cr-Commit-Position: refs/heads/master@{#441479}

We want to align all touchmoves regardless of whether they cause
a regression in scroll start. The expected regression would on average
half a frame.

BUG=642368

Review-Url: https://codereview.chromium.org/2612823002
Cr-Commit-Position: refs/heads/master@{#441478}

Manually convert audiobuffer.html to use testharness

BUG=676355
TEST=audiobuffer.html

Review-Url: https://codereview.chromium.org/2595073002
Cr-Commit-Position: refs/heads/master@{#441477}

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-one-sample-loop.html

Review-Url: https://codereview.chromium.org/2591383002
Cr-Commit-Position: refs/heads/master@{#441476}

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-grain.html

Review-Url: https://codereview.chromium.org/2595153002
Cr-Commit-Position: refs/heads/master@{#441475}

It overlaps with properties, and properties add type safety.

BUG=none
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2610203002
Cr-Commit-Position: refs/heads/master@{#441474}

There are no flags to be updated.

Migrate StringPiece::AppendToString to StrAppend
Merge internal change: 143299373
https://codereview.chromium.org/2617523002/

Add tests for QuicTextUtils::HexEncode and HexDecode which use non-ASCII printable data.
Merge internal change: 143126254
https://codereview.chromium.org/2616493003/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2618433002
Cr-Commit-Position: refs/heads/master@{#441473}

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2608163007
Cr-Commit-Position: refs/heads/master@{#441472}

BUG=677863

Review-Url: https://codereview.chromium.org/2611933003
Cr-Commit-Position: refs/heads/master@{#441471}

https://pdfium.googlesource.com/pdfium.git/+log/6745f96fab41..dc39e377e1a3

$ git log 6745f96fa..dc39e377e --date=short --no-merges --format='%ad %ae %s'
2017-01-04 tsepez Add missing operator<() to CFX_RetainPtr.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2614793002
Cr-Commit-Position: refs/heads/master@{#441470}

Previously, we implement scrollIntoView by scrolling the intersection of the
viewport and the content. However, when the content is not visible in the
viewport, e.g. outside boundary and the viewport's overflow attribute is
hidden, the intersection would be empty and the browser would stop the
scrolling logic. In this case, we presume the webpage wants to scroll the
position of the content but for some reason doesn't want to show it. In this
patch, we scroll the content's position for this special case.

BUG=673396
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2576963002
Cr-Commit-Position: refs/heads/master@{#441469}

BUG=656193

Review-Url: https://codereview.chromium.org/2614783002
Cr-Commit-Position: refs/heads/master@{#441468}

TBR=wjmaclean,rdevlin.cronin
BUG=678267

Review-Url: https://codereview.chromium.org/2616693002
Cr-Commit-Position: refs/heads/master@{#441467}

so AddOwnershipEdge can attribute memory correctly between
URLRequestContexts. See the following doc for more details on why it
is needed.

https://docs.google.com/document/d/1-dmr_dVgO090Y5_3K9itjsE0MsBTmbqwovu6lup1i14/edit

BUG=669108

Review-Url: https://codereview.chromium.org/2560593002
Cr-Commit-Position: refs/heads/master@{#441466}

Revert of Make run_webkit_tests random order by default for all platforms (patchset #2 id:20001 of https://codereview.chromium.org/2591933002/ )

Reason for revert:
fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots.

Original issue's description:
> Make run_webkit_tests random order by default for all platforms.
>
> BUG=671805
> R=dpranke@chromium.org,qyearsley@chromium.org
>
> Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95
> Cr-Commit-Position: refs/heads/master@{#441424}

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671805

Review-Url: https://codereview.chromium.org/2617563002
Cr-Commit-Position: refs/heads/master@{#441465}

Now that Mojo can generate the min_version information automatically,
migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to
GET_INTERFACE_FOR_METHOD(), which does not require the explicit version
number to be passed.

BUG=649782
TEST=git try

Review-Url: https://codereview.chromium.org/2599673005
Cr-Commit-Position: refs/heads/master@{#441464}

BUG=677311
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2612673002
Cr-Commit-Position: refs/heads/master@{#441463}

[Presentation API] Resolve PresentationRequest::reconnect() with existing presentation connection if such connection exists

Check if any presentation connection with specific presentationUrl and presentationId exists in current browsing context. If so, resolve reconnect() with existing connection instead of creating a new connection.

BUG=677540

Review-Url: https://codereview.chromium.org/2602523002
Cr-Commit-Position: refs/heads/master@{#441462}

This CL rolls the sysroots after 3b607160.  In addition, it also fixes
a bug in build-and-upload.py which would cause the script to fail if
not run in build/linux/sysroot-scripts.

BUG=668205
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2599763004
Cr-Commit-Position: refs/heads/master@{#441461}

Fix MissingFormatArgumentException in Evaluation test for latest logging
changes.

BUG=678279

Review-Url: https://codereview.chromium.org/2610883003
Cr-Commit-Position: refs/heads/master@{#441460}

chrome.storage, for instance, has events but no functions directly on the
API object. See extensions/common/api/storage.json.

BUG=653596

Review-Url: https://codereview.chromium.org/2610743002
Cr-Commit-Position: refs/heads/master@{#441459}

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146

Review-Url: https://codereview.chromium.org/2610983002
Cr-Commit-Position: refs/heads/master@{#441458}

Media renderer might get destroyed (due to pipeline being stopped or
suspended) while a video track restart is pending. When that happens
the VideoRendererImpl has a pending flush_cb_ that will get called from
video renderer destructor invoking RendererImpl::RestartVideoRenderer,
so RestartVideoRenderer needs to actually try restarting the video
renderer only if we are still in the playing state.

BUG=668963

Review-Url: https://codereview.chromium.org/2570773002
Cr-Commit-Position: refs/heads/master@{#441457}

bluetooth: bluez: Implement BluetoothRemoteGattCharacteristicBluez::SubscribeToNotifications and UnsubscribeFromNotifications.

BUG=636275

Review-Url: https://codereview.chromium.org/2613473002
Cr-Commit-Position: refs/heads/master@{#441456}

Enforce that the Cronet API classes and methods are never modified or
removed, only added.  Modifying or removing an API class or method
breaks backwards compatibility.  This is enforced by:
1. Keep an updated dump of the Cronet API in components/cronet/android/api.txt
2. When building check that the Cronet API matches that in api.txt
3. Provide a script for updating api.txt; this script also enforces that
   only additions are made to the API.
This change also maintains a version number for the Cronet API.  Cronet
can use this to enforce, for example that the Cronet implementation is at
least as new as the Cronet API being used.

BUG=629299
R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2544043002
Cr-Commit-Position: refs/heads/master@{#441455}

available (e.g. empty), we should use main frame url to search for
previous navigation.

This will help us correctly identify referrer of downloads that
happen in sub-frame.
For example, page A has a link to page B, and page B has a
subframe C, and subframe C links to download D.

A --->  B
        \iframe C -----> D
If we only look at the frame D's in, we can only reach C in
attribution. But in fact it should be D-C-B-A.

BUG=639467

Review-Url: https://codereview.chromium.org/2612663002
Cr-Commit-Position: refs/heads/master@{#441454}

Though clusterfuzz uses ubsan now, which should catch bad casts, using
these macros is still the typical convention for Blink code that needs
to downcast.

BUG=none

Review-Url: https://codereview.chromium.org/2617433002
Cr-Commit-Position: refs/heads/master@{#441453}

This adds the flash plugin path to the chrome://version page, which
allows users to see which flash plugin is loaded. This also allows
chrome://plugins to be removed.

BUG=667826

Review-Url: https://codereview.chromium.org/2607953002
Cr-Commit-Position: refs/heads/master@{#441452}

TBR=mfomitchev@chromium.org
NOTRY=true
BUG=678346

Review-Url: https://codereview.chromium.org/2615713002
Cr-Commit-Position: refs/heads/master@{#441451}

Tweak CryptauthDeviceManager to store fetched BeaconSeed data in Base64URL encoding, and retrieve it as raw data. This is necessary because CryptauthDeviceManager assumed that BeacondSeed data from the server was Base64 encoded, when in reality it was raw.

BUG=678145

Review-Url: https://codereview.chromium.org/2611913002
Cr-Commit-Position: refs/heads/master@{#441450}

Zoom should be preserved on reload. However, this behavior is not currently
reliably covered by tests (there is a layout test that attempts to cover this
behavior, but it is broken and will shortly be removed, as per comment 28 on
crbug.com/673065). This CL adds a proper test of this behavior.

BUG=673065

Review-Url: https://codereview.chromium.org/2608213003
Cr-Commit-Position: refs/heads/master@{#441449}

Download the poster image when it is available and draw remoting
interstial on it. Changes in this CL:
1. Refactored ImageDownloaderImpl and abstracted the core parts that
does the image downloading to ImageDownloaderBase. There should be no
behaviour change for ImageDownloaderImpl.
2. Added SingleImageDownloader which is a one time image downloader
working in Renderer to return a single image, and can be
self-destructed when downloading finishes.
3. RemotingRendererController will initiate the downloading when the
interstitial needs to be shown if poster image URL changes.

BUG=643964

Review-Url: https://codereview.chromium.org/2538853002
Cr-Commit-Position: refs/heads/master@{#441448}