- 27 Jul, 2018 40 commits
-
-
Peter Kvitek authored
Change-Id: I1e772fc31ede9a85d6cea1726c3c7fa9d3cd34ca Reviewed-on: https://chromium-review.googlesource.com/1147741Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578737}
-
jln@chromium.org authored
Make sure that the magic value can be cast to a char properly. BUG=724399,b:70905156 Review URL: https://chromiumcodereview.appspot.com/10541122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141814 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit b9ccf65a) Signed-off-by:
Gabriel Marin <gmx@chromium.org> Change-Id: I31162aefe53624f4bc61a6b2bc6fe83f9df5ff68 Reviewed-on: https://chromium-review.googlesource.com/1130779Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#578736}
-
Amy Qiu authored
Since zdnet_patholocial is failing on Nexus6 Webview and it has recently been refreshed, remove it. The rest of the old pages in pathological_mobile_sites will be removed next week (following protocol of removing old pages a week after new ones are added). Bug:868295 Change-Id: I875e54a498ff23a29569ec878a74f63a0ed44f75 NOTRY=true # CQ flake Change-Id: I875e54a498ff23a29569ec878a74f63a0ed44f75 Reviewed-on: https://chromium-review.googlesource.com/1153087 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#578735}
-
danakj authored
R=dcheng@chromium.org TBR=jochen@chromium.org Currently layout test code is split over: - content/shell/test_runner/ (separate component) Has renderer-side code, is allowed to use content/renderer/, does not use content/shell/renderer/. - content/shell/renderer/layout_test/ (part of content_shell_lib) Has renderer-side code, makes light use of content/shell/renderer/, but is not able to use content/renderer/. - content/shell/browser/layout_test/ (part of content_shell_lib) Has browser-side code, makes heavy use of content/shell/browser/, but is not able to use content/browser/. - content/public/test/layouttest_support.h Header for access to content/renderer/ things and content/browser/ things. Used by content/shell/renderer/layout_test/ and content/shell/browser/layout_test/. - content/test/layouttest_support.cc Impls for access to content/renderer/ and content/browser/ things. This patch aims to 1. Combine the test_runner/ and shell/renderer/layout_test/ pieces of code so they don't need to use indirections to interact. Their separation is a legacy of test_runner/ being implemented inside blink (WebKit) in the past. 2. Move layouttest_support.h out of content/public/ and the .cc out of content/test/ to a layout_test-specific code location. To do (1), test_runner/* moves to shell/renderer/layout_test/*. This is fairly straight forward. We remove the TEST_RUNNER_EXPORT macro as they are now part of a static library. They are left in the test_runner namespace at the moment. To do (2), we move layouttest_support.(cc|h) to shell/renderer/layout_test/. There are 3 methods in the file that are called from shell/browser/layout_test/ and use content/browser so we split those out to shell/browser/layout_test/. However this causes a problem that content_shell_lib will depend on content/{browser,child,renderer}/ via the layouttest_support.cc file. To avoid this, we - Move content/shell/renderer/layout_test/* into a separate build target called //content/shell:layout_test_renderer_lib and we give it visibility to content/renderer/ and content/child/. - Move content/shell/browser/layout_test/layouttest_support.* into a separate build target called //content/shell:browser_layout_test_support_lib. We don't move all of content/shell/browser/layout_test/* because of heavy interaction between it and its parent directory at this time. - For a few files used by the shell/renderer/ (and shell/) and shell/renderer/layout_test/ directories, we move them out to a shared library as well, called //content/shell:content_shell_renderer_common_lib. - And for the common/layout_test/layout_test_switches.cc files, which are used in both, but we'd like to not leak out of content_shell_lib since they are part of .../layout_test/, we make a non-public dep on //content/shell:content_shell_common_test_lib Ideally, I think we have a separate library for //content/shell/browser/layout_test //content/shell/common/layout_test //content/shell/renderer/layout_test But we need better indirection between the content_shell_lib and the .../layout_test/ code in order to do that. Once it was so, we would be closer to making it possible to have a content_shell build target that does not include any test code (and thus truly only uses the public APIs), and a separate content_shell-like build target that includes the layout test code. Bug: 866140 Change-Id: Ia39f7385711bdb610948a07fd473ad9b346b82ae Reviewed-on: https://chromium-review.googlesource.com/1145644Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578734}
-
Matt Menke authored
The tests check that cookies are persisted (Or not) for each of the NetworkContexts in Chrome. Also, fix comments in NetworkContextConfigurationBrowserTests. In particular, the System and SafeBrowsing NetworkContexts do support cookies, they just don't support some configuration options being tested. Bug: 868414 Change-Id: I8542a1ff7685efcf6588b29dcb5058dd06f1ceeb Reviewed-on: https://chromium-review.googlesource.com/1153141Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#578733}
-
Bailey Berro authored
This change makes the share entry field in the Add SmbShare dialog a cr-searchable-drop-down that is populated with shares discovered on the network as they are found. Test=verified locally Bug: chromium:757625 Change-Id: I6fdd74bc2c6f1efaea190bfc3d93eef046de7334 Reviewed-on: https://chromium-review.googlesource.com/1152211 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578732}
-
Devlin Cronin authored
Improve the semantic intersection logic in URLPatternSet to utilize URLPattern::CreateIntersection(). This allows callers to create an intersection between two sets that will include patterns that were not explicitly in either set, such as constructing the pattern `http://chromium.org/*` from `http://*/*` and `*://chromium.org/*`. Since not all callers may want this behavior, and in order to introduce three separately named Create*Intersection methods in URLPatternSet, add an enum, IntersectionBehavior, for callers to specify the type of intersection behavior to use. This includes string comparison (STL-set-style intersection), patterns explicitly contained by both sets (the old semantic intersection), and detailed (the new and improved semantic intersection). Add unit tests for the same. Bug: 867549 Change-Id: Ic80bec8c8c8bbac188efcf2862d92582379c5a7c Reviewed-on: https://chromium-review.googlesource.com/1150919 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578731}
-
Khushal authored
The GrShaderCache currently assumes that it can't be populated with an entry having the same key twice. This is incorrect in 2 scenarios. 1) If skia fails to link the cached binary, it will re-generate and store a new copy. 2) If skia uses a shader before it is loaded off the disk cache, we will find an existing entry in the memory cache when the disk cache entry is being populated. The above scenarios can result in errors in the internal accounting for memory used. Fix them. R=ericrk@chromium.org Bug: 868121 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifd4c1e872379b54d7c659d62ff6af09eeaad2b46 Reviewed-on: https://chromium-review.googlesource.com/1152552 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#578730}
-
Xing Liu authored
This CL adds some includes in download_db.h. TBR=drtrainor@chromium.org,qinmin@chromium.org Bug: 842245 Change-Id: I34fcfcf24e933d0be14f76705a65108c975e47e0 Reviewed-on: https://chromium-review.googlesource.com/1153402Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578729}
-
karandeepb authored
This CL introduces the onActionIgnored event on the web request API which is fired when an extension's proposed modification to a network request is ignored. This happens in case of conflicts with other extensions. This should allow the extensions to address conflicts as they like. Also, we no longer notify the user in case of conflicts between extensions. BUG=111700 Change-Id: I3e96740aee6b79b0823545bf17b4a50bbc8758aa Reviewed-on: https://chromium-review.googlesource.com/1150009 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578728}
-
Patrick Monette authored
The crash keys are named "unsigned-modules-*" where * is a number from 0 to 9. This will allow us to assess which accessibility software doesn't sign all of their modules. Bug: 846953 Change-Id: Iea0aabc1694972120c7ef48327c0b982092ed179 Reviewed-on: https://chromium-review.googlesource.com/1148990 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#578727}
-
Charlie Ma authored
- Show navigation history popup (align bottom and center) when long pressing Android system back button. - Add *Show full history* item, allow users go to history page. - Add flag: LongPressBackForHistory for this feature, default disabled. Bug: 800033 Change-Id: Ie3d755a7c9795235b40cf3c0ed6ffaf460dc3f21 Reviewed-on: https://chromium-review.googlesource.com/1144641 Commit-Queue: Charlie Ma <charliema@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#578726}
-
Scott Violet authored
This code is dead after removing window manager interfaces. BUG=none TEST=none Change-Id: If80370ec29fa97315b54b5404ee1287df36b82ab Reviewed-on: https://chromium-review.googlesource.com/1153403Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578725}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 048472b7. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." 408f60ca "Remove Shared Worker WPT for WebUSB" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21783 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio TBR=robertma No-Export: true Change-Id: Ifc124c69a2d49dc6272f6e45771989357063f543 Reviewed-on: https://chromium-review.googlesource.com/1152313 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#578724}
-
Jonathan Ross authored
RenderWidgetHostInputEventRouterTest has some heavy overrides of the classic hit testing path, to force what target is used when. With these the test never actually set sizes, or correct FrameSinkIds, on the views in use. However in Viz RenderWidgetHostInputEventRouter::FindViewAtLocation uses a completely different method for determining targets while in Viz Hit Testing Mode. This change updates the test to als provide mock hit testing data. A test wrapper HostFrameSinkManagerTestApi was added to allow for the setting of hit testing data while in unittests. Or in testing where Viz is not actually initialized. TEST=RenderWidgetHostInputEventRouterTest Bug: 796605 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I66c4322f70fdd8c5be07c3560110519153370cff Reviewed-on: https://chromium-review.googlesource.com/1145773 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578723}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9acfc6cac2c6..227424b57d28 git log 9acfc6cac2c6..227424b57d28 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 herb@google.com Remove SkTextBlobRunIterator.h from gni 2018-07-27 ziadb@google.com SkAR Java: minor refactoring to TapHelper (now GestureHelper) 2018-07-27 ziadb@google.com SkAR Java: refactoring main app class & finger painting class 2018-07-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 18f7e5033040..21e9baf71e6e (2 commits) 2018-07-27 mtklein@google.com add imgcvt 2018-07-27 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 4642d9fe69e1..23e7777f421d (1 commits) 2018-07-27 fmalita@chromium.org Hide SkTextBlob::GlyphPositioning from public API 2018-07-27 bsalomon@google.com Reland "Go back to cleaning up MIP levels on texture export rather than assuming dirty on texture import." 2018-07-27 robertphillips@google.com Add more optional debugging printouts for resource allocation 2018-07-27 robertphillips@google.com Fix explicit resource allocator bug Created with: gclient setdep -r src/third_party/skia@227424b57d28 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I47102c0f415005eba5c57e5e2af9696b813e7012 Reviewed-on: https://chromium-review.googlesource.com/1153287Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578722}
-
Takumi Fujimoto authored
Add a boolean metric MediaRouter.Sink.SearchOutcome, which records whether or not a sink was found for the ID that the user entered and attempted to cast to. Bug: 867086 Change-Id: Ie1bf8072b7700298b8a783480b05a2e845666946 Reviewed-on: https://chromium-review.googlesource.com/1148956Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#578721}
-
Erik Jensen authored
For me2me operations that return an AsyncResult, use RESULT_CANCELLED when the user cancels the UAC prompt on Windows. Operations that return true/false still return false, and it2me still returns ELEVATION_ERROR. Change-Id: Ia4bff10d80c0c3bb570497ab80ed83799e32f5b1 Reviewed-on: https://chromium-review.googlesource.com/1148881 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#578720}
-
Tiger Oakes authored
Fixes two CSS issues: * The options sidebar has no bottom padding * The infocard table sometimes expands past the screen width Bug: 847599 Change-Id: Ic39b594c777194e24fa8233094c41106166703cb Reviewed-on: https://chromium-review.googlesource.com/1152902 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#578719}
-
Steven Bennetts authored
Additional base::Value cleanup in preparation for some NetworkState cleanup. This causes ProxyConfigDictionary to conform to the new base::Value patterns. Specifically ProxyConfigDictionary now uses base::Value instead of std::unique_ptr<base::DictionaryValue> and pass by value semantics. This CL changes ProxyConfigDictionary::GetPacMandatory to return false if kProxyPacMandatory is not present, making the method consistent with other similar methods and consistent with the usage in the one call site that checks the result (proxy_api_helpers::CreatePacScriptDict). If that logic is incorrect and not covered by any tests (unlikely, test coverage for this code is quite thorough), then we will see the following error: "Invalid proxy configuration. Missing PAC mandatory field." For trivial changes to c/b/extensions and c/b/net: TBR=mattm@chromium.org, benwells@chromium.org Bug: 651157 Change-Id: I6fa01f2be11c8484d8783c3bf94445c3c4addbc7 Reviewed-on: https://chromium-review.googlesource.com/1150846 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#578718}
-
Zach Helfinstein authored
Bug: None Change-Id: Ie69dc81ced929895ff2241b8c862656f86f921c7 Reviewed-on: https://chromium-review.googlesource.com/1153434Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578717}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If99a958b253265e638565e24a31ec5c0fb30d6b3 Reviewed-on: https://chromium-review.googlesource.com/1153478Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#578716}
-
Daniel Bratell authored
In Win32 some headers defines "interface" to mean struct which makes it unsuitable to cross platform code. This instance was hit in a jumbo experimental build where apparently enough win32 headers were included in the translation unit. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e906a46620378be2ded6a4a4868e2034cc1868b Reviewed-on: https://chromium-review.googlesource.com/1152735Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#578715}
-
Xiaoyong Zhou authored
During OOBE, salt value is empty and boot.art relocation fails. This is a normal case. Should be reported separately. Bug: b:72291323 Change-Id: I0bec29d767fb131c0551bf0853b4dc4a62d97d59 Reviewed-on: https://chromium-review.googlesource.com/1152114 Commit-Queue: Xiaoyong Zhou <xzhou@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#578714}
-
James Wallace-Lee authored
Screen readers should read the title ("Add <extension>?") of extension install dialogs. Bug: 849910 Change-Id: I9d37b3810c046419f4c5a3b4428a57cb0a5f3289 Reviewed-on: https://chromium-review.googlesource.com/1135595 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578713}
-
James Hawkins authored
R=achuith@chromium.org Bug: none Test: none Change-Id: I4aae47d7919c36474eba760387c1017332da4b1d Reviewed-on: https://chromium-review.googlesource.com/1151898 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#578712}
-
Koji Ishii authored
This patch stops batching SkPaint::getTextWidth() on Mac. Batching SkPaint::getTextWidth() http://crrev.com/c/1150010 has no benefits on Mac because Mac uses getTextPath() instead of getTextWidth() due to https://bugs.chromium.org/p/skia/issues/detail?id=5328 The cost to prepare batching is usually much lower than the benefit of batching, the total speed is more than 10x faster, but since Mac does not get the benefit at all, the cost of the preparation turned out to be not ignorable. http://crrev.com/c/1150010: https://pinpoint-dot-chromeperf.appspot.com/job/14d1dc0fa40000 This CL: https://pinpoint-dot-chromeperf.appspot.com/job/11a873fda40000 Bug: 868148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifbb0f6576cd58f36cd17463a550a15924f5b2209 Reviewed-on: https://chromium-review.googlesource.com/1153007 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578711}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a67dd77dfc3..d8072e683a00 git log 6a67dd77dfc3..d8072e683a00 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 changwan@google.com Fix lint errors for systrace Created with: gclient setdep -r src/third_party/catapult@d8072e683a00 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:814330 TBR=sullivan@chromium.org Change-Id: Id0a010a7b20a5bc2549f796ee26367898b1bb3cc Reviewed-on: https://chromium-review.googlesource.com/1153327Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578710}
-
chrome://accessibilityJames Wallace-Lee authored
Show the native UI's accessibility tree for all open chrome windows in chrome://accessibility Change-Id: I119ac76f406010b9b2711de845aa3ace7ef69f5f Bug: 785493 Reviewed-on: https://chromium-review.googlesource.com/1147511 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578709}
-
Katie D authored
When the system voice is selected, chrome.tts.speak is not passed any voiceName parameter, allowing the system to pick a voice. Change-Id: I5abeccc6712d09e64e54c52cf3d4579b8ed60336 Reviewed-on: https://chromium-review.googlesource.com/1152215 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578708}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/21e9baf71e6e..021bad40ff8b git log 21e9baf71e6e..021bad40ff8b --date=short --no-merges --format='%ad %ae %s' 2018-07-27 jmadill@chromium.org D3D: Add streaming buffer initialize. Created with: gclient setdep -r src/third_party/angle@021bad40ff8b The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I0ee27b59b3be6c4369cec8a5ba375e01bd78c7bc Reviewed-on: https://chromium-review.googlesource.com/1153328Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578707}
-
Wenzhao Zang authored
Bug: NONE Change-Id: Ic15fc24e7bf75d259084566cefdefe7b3102a20f Reviewed-on: https://chromium-review.googlesource.com/1152694Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578706}
-
Reza.Zakerinasab authored
NOTRY=true TBR=fserb@chromium.org Bug: 866850 Change-Id: I7fdda7adc5c777e2da3cd0ce5cec43016a740a78 Reviewed-on: https://chromium-review.googlesource.com/1153439Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578705}
-
Chris Harrelson authored
This saves almost 4% of hit test time on some examples, and improves performance of occlusion hit testing for IOv2 accordingly. Bug: 831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I045e0414c84208b60796fe44ea023ebbb3fbe40a Reviewed-on: https://chromium-review.googlesource.com/1152296 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578704}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c84d971..0147f5d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id598b8841c5c43ea9532b2babb4bae053b83190b Reviewed-on: https://chromium-review.googlesource.com/1152324Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578703}
-
David Tseng authored
In most instances, ChromeVox wants to respect and process document selections for editable nodes triggered from its own action. This includes braille routing and any number of other commands that may programmatically set selection. This change undoes more specific logic to ignore actions, and only ignores selection actions for the ChromeVox toggle selection command. In toggle selection, we preemptively update ChromeVox's selection before actually getting the selection change. We likely still want this because we only want to report the incremental change in the selection and not the entire (possibly larger) selection. Change-Id: I4082f3cace42cccc369b2148791cbe0ae8db76c0 Reviewed-on: https://chromium-review.googlesource.com/1150291Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578702}
-
Gabriel Charette authored
This is: s/TaskPriority::BACKGROUND/TaskPriority::BEST_EFFORT/g git cl format applied to //src/base. TBR=robliao@chromium.org Bug: 863341 Change-Id: I5273c666b41a192e436a0629d385bc5877b40343 Reviewed-on: https://chromium-review.googlesource.com/1152160Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578701}
-
Peter Beverloo authored
There's a race condition where acknowledgement of having marked a request as completed comes in after the Background Fetch has been aborted, due to the way the BackgroundFetchDataManager executes its tasks. We need to handle that appropriately in the scheduler. Change-Id: Idb4483433aae4abb57e56be68362c4e0333402a7 Reviewed-on: https://chromium-review.googlesource.com/1152969 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#578700}
-
Koji Ishii authored
This patch changes to compute grapheme list for mid-ligature support only when needed. This patch is part of the LayoutNG performance efforts. As we measure LayoutNG performance, computing grapheme list for every ShapeResult turned out to be not cheap. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I58880530e56e0b1b965bd1a246bb8c3415b968a6 Reviewed-on: https://chromium-review.googlesource.com/1152640 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578699}
-
Artur Khachatryan authored
Releasing ChromeDriver version 2.41 Change-Id: If3355dc85425fbe799f0c8d3f9b999d1aedc1565 Reviewed-on: https://chromium-review.googlesource.com/1152563Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578698}
-