- 26 Aug, 2016 40 commits
-
-
felt authored
BUG=615123 TBR=jialiul@chromium.org TEST= 1. Go to the following URLs in different tabs: http://ianfette.org http://parkerly.com/sb-tests/bad-subresources.html https://parkerly.com/sb-tests/bad-subresources.html 2. Verify that the omnibox security indicator shows a red triangle for all three warnings Review-Url: https://codereview.chromium.org/2275123004 Cr-Commit-Position: refs/heads/master@{#414700}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fca74cffde72..393e77578d5b $ git log fca74cffd..393e77578 --date=short --no-merges --format='%ad %ae %s' 2016-08-26 petrcermak [tracing] Use tr.b.requestAnimationFrame in tr.ui.analysis.RebuildableBehavior TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2284643002 Cr-Commit-Position: refs/heads/master@{#414699}
-
finnur authored
This is accomplished by using the embedderOrigin more consistently throughout. BUG=639208 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2269963003 Cr-Commit-Position: refs/heads/master@{#414698}
-
johnme authored
Based on the flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=BackgroundTracingManagerBrowserTest - All tests BackgroundTracingManagerBrowserTest tests are flaky on Android - BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter is flaky on Android & Linux - BackgroundTracingManagerBrowserTest.NoWhitelistedArgsStripped and BackgroundTracingManagerBrowserTest.TraceMetadataInTrace are flaky on Android & Chrome OS NOTREECHECKS=true NOTRY=true BUG=639706 TBR=simonhatch@chromium.org Review-Url: https://codereview.chromium.org/2280073002 Cr-Commit-Position: refs/heads/master@{#414697}
-
dgn authored
When a new NTP is created, it queries the list of registered categories with the backend. The returned category order will be kept for the visible categories. Suggestions received from categories that are after that point will be ignored. BUG=640568 Review-Url: https://codereview.chromium.org/2274293002 Cr-Commit-Position: refs/heads/master@{#414696}
-
alemate authored
This CL fixes styles of Welcome screen. BUG=604119 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2267533002 Cr-Commit-Position: refs/heads/master@{#414695}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/7b10c1874469fdf3f8d621bd83c3093de7c46531 Add OWNERS file for goma team in recipe_modules/goma (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2281883002 Cr-Commit-Position: refs/heads/master@{#414694}
-
cylee authored
Setting OOM scores generally requires root permission. In the past it's done 1. For Chrome processes: via a SUID binary chrome-sandbox. 2. For Andorid processes: Send scores to Android via IPC. Android handles the rest. Now a new method is added to debugd dbus interface on ChromeOS to handle OOM score settings. https://chromium-review.googlesource.com/#/c/366154/ So we can set OOM score settings in the unified way on ChromeOS. BUG=b:30193036 TEST=minnie Review-Url: https://codereview.chromium.org/2247433002 Cr-Commit-Position: refs/heads/master@{#414693}
-
lizeb authored
BUG=641309 TBR=thakis,primiano,mattcary patch from issue 2283753002 at patchset 20001 (http://crrev.com/2283753002#ps20001) Review-Url: https://codereview.chromium.org/2280953002 Cr-Commit-Position: refs/heads/master@{#414692}
-
flackr authored
BUG=640344 TEST=Manual steps in bug. Review-Url: https://codereview.chromium.org/2278723002 Cr-Commit-Position: refs/heads/master@{#414691}
-
ricea authored
net::ParsedCookie::SetValue() applies a strict check to the passed-in value, but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It would nice if this was consistent. Add a histogram to determine the degree of compatibility problems with making it consistent. BUG=638117 Review-Url: https://codereview.chromium.org/2273633004 Cr-Commit-Position: refs/heads/master@{#414690}
-
johnme authored
Failed DCHECK on builds 7067 7054 7051 7024 7022 7021 7000 6988 of https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29 BUG=638693 NOTRY=true NOTREECHECKS=true TBR=alancutter@chromium.org Review-Url: https://codereview.chromium.org/2283773002 Cr-Commit-Position: refs/heads/master@{#414689}
-
haraken authored
I'm making toV8() never return an empty handle. This CL replaces the return value of toV8(ScriptValue) with v8::Undefined, but it won't change any web-exposed behavior because V8 interprets a returned empty handle as v8::Undefined(). BUG=625512 Review-Url: https://codereview.chromium.org/2280893002 Cr-Commit-Position: refs/heads/master@{#414688}
-
xidachen authored
At this moment, creating an ImageBitmap has several options such as flipY and premultiplyAlpha = false. So in some cases, we would have to convert the premultiplied input to unpremul format, and that involves allocating new memory. To prevent any potential integer overflow or OOM situation, this CL checks the size of the cropRect and the resizeWidth(resizeHeight), if the width * height * bytesPerPixel is larger than size_t range, we reject the promise. By doing the check at the beginning of each ImageBitmap constructor, we can guarantee that the subsequent multiplication of width * height * bytesPerPixel will not overflow. This CL also correct other places where there could be potential integer overflow. In particular, since we have checked at the beginning of each ImageBitmap constructor, it should be safe to use size_t for any computation of width * height in the code. TBR=kbr@chromium.org, haraken@chromium.org BUG=638615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2249853008 Cr-Commit-Position: refs/heads/master@{#414687}
-
johnme authored
Revert of Support server categories in NTPSnippetsService. (patchset #3 id:40001 of https://codereview.chromium.org/2279863002/ ) Reason for revert: I'm afraid this failed again on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/27385/steps/components_unittests%20on%20Mac-10.9 Original issue's description: > Support server categories in NTPSnippetsService. > > Reland of: > https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f > > Not clear why tests failed; they passed for me and in the CQ. > Removed one synchronization bit that wasn't really part of the change. > > BUG=633613 > > Committed: https://crrev.com/880bb766ee4985a8dd36be10098c5196c41f7509 > Cr-Commit-Position: refs/heads/master@{#414681} TBR=treib@chromium.org,sfiera@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633613 Review-Url: https://codereview.chromium.org/2283743002 Cr-Commit-Position: refs/heads/master@{#414686}
-
jwalczak authored
FFmpeg's AVCodecContext->channels contains "raw number of channels" (e.g. "2" for 2 channels, "8" for 8 channels). The change ensures that: - the value of "8" is correctly mapped to 0b111 ADTS channel config (aka MPEG-4 Channel Configuration), - the value of "7" becomes unsupported. BUG=640610 Review-Url: https://codereview.chromium.org/2273203003 Cr-Commit-Position: refs/heads/master@{#414685}
-
mmoroz authored
RELEASE_ASSERT prints the same message as SECURITY_CHECK, because RELEASE_ASSERT is deprecated and being actively replaced by SECURITY_CHECK. BUG=620960 Review-Url: https://codereview.chromium.org/2240233002 Cr-Commit-Position: refs/heads/master@{#414684}
-
mvanouwerkerk authored
Review-Url: https://codereview.chromium.org/2274663003 Cr-Commit-Position: refs/heads/master@{#414683}
-
rune authored
For no apparent reason we were always doing a full document recalc when finishing loading a non-blocking stylesheet. From webkit: https://bugs.webkit.org/show_bug.cgi?id=119236 BUG=284142 Review-Url: https://codereview.chromium.org/2278803002 Cr-Commit-Position: refs/heads/master@{#414682}
-
sfiera authored
Reland of: https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f Not clear why tests failed; they passed for me and in the CQ. Removed one synchronization bit that wasn't really part of the change. BUG=633613 Review-Url: https://codereview.chromium.org/2279863002 Cr-Commit-Position: refs/heads/master@{#414681}
-
tkent authored
In editing/selection/select-across-readonly-input-{1,4}.html, the end position is anchor=innerEditor type=AfterAnchor. indexFromPosition() didn't work well with such position. Review-Url: https://codereview.chromium.org/2278373002 Cr-Commit-Position: refs/heads/master@{#414680}
-
msramek authored
BrowsingDataHandler observes local history deletions, but not synced history deletions. In cases where there are no local history entries to delete, it can happen that the history page does not reload and it looks as if the deletion failed. See https://docs.google.com/document/d/1Fd6CdBf6UMbYbkwSjEKyFOxew0Xid5IaT-QwnFchjig/ for background. This CL 1. Adds an Observer subclass to the WebHistoryService. 2. Registers BrowsingHistoryHandler as a WebHistoryService::Observer; and since WebHistoryService's existence is based on whether history sync is enabled, we also register as a SyncServiceObserver. 3. Adds a test to browsing_history_handler_unittest.cc. Also tested manually on Android - seems to solve the problem described in the above mentioned document. BUG=604114,630164 Review-Url: https://codereview.chromium.org/2263613002 Cr-Commit-Position: refs/heads/master@{#414679}
-
tkent authored
selectionDirection incorrectly returned "none" in such case even on non-Mac platforms. BUG=640861 Review-Url: https://codereview.chromium.org/2285613002 Cr-Commit-Position: refs/heads/master@{#414678}
-
drott authored
Since we dropped support for rendering Type 1 fonts in Chrome, we should filter the list of fonts that can be configured as defaults to only display fonts that have the right font format, i.e. TrueType or CFF. A a side effect, this allows us to build the font list enumeration for ozone as well, as it is only dependent on Fontconfig after this CL, not dependent on Pango anymore. For backwards compability with the old implementation, we're adding three Fontconfig alias families Sans, Serif and Monospace to the list, since our default settings on Linux included the "Monospace" family for the fixed width font. BUG=630508,457307 Review-Url: https://codereview.chromium.org/2278143002 Cr-Commit-Position: refs/heads/master@{#414677}
-
alemate authored
BUG=604119 TEST=none Review-Url: https://codereview.chromium.org/2281813002 Cr-Commit-Position: refs/heads/master@{#414676}
-
xiaochengh authored
Revert "Stop SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar from using TextCheckingParagrah" This is a manual revert of commit 41165826, due to causing performance regression. Original issue's description: > Stop SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar from using TextCheckingParagrah > > SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar() does not really need > a TextCheckingParagraph as its parameter; an EphemeralRange of text to check is > sufficient. > > Hence, this patch changes its parameter from a TextCheckingParagraph to an > EphemeralRange, simplifying code and improving performance by eliminating the > overhead for finding the paragraph containing the text to be checked. > > BUG=n/a > TEST=n/a; no visible change > > Committed: https://crrev.com/41165826c11cc0b7f1457b4c455d7e2eb2de0819 > Cr-Commit-Position: refs/heads/master@{#414328} BUG=641083 TBR=yosin@chromium.org Review-Url: https://codereview.chromium.org/2286573002 Cr-Commit-Position: refs/heads/master@{#414675}
-
melandory authored
Safe browsing subresource filter should be able to make activation descision based on the type of the list and metadata for the list. BUG=609747, 641037 Review-Url: https://codereview.chromium.org/2272323002 Cr-Commit-Position: refs/heads/master@{#414674}
-
calamity authored
This CL disables the toolbar shadow test because it's flaky. This will be reenabled after investigation. BUG=640862 Review-Url: https://codereview.chromium.org/2271583009 Cr-Commit-Position: refs/heads/master@{#414673}
-
vitaliii authored
There are two types of requests: interactive (e.g. a fetch when NTP is opened) and noninteractive (e.g. a background prefetch). The noninteractive requests are less important and thus they can be dropped first if needed. This CL adds request type to the request. BUG=638224 Review-Url: https://codereview.chromium.org/2271283002 Cr-Commit-Position: refs/heads/master@{#414672}
-
finkm authored
BUG=627073 Review-Url: https://codereview.chromium.org/2273323002 Cr-Commit-Position: refs/heads/master@{#414671}
-
glider authored
This should probably fix the compile step on the Dr. Memory builder. BUG=640185 TBR=dpranke@chromium.org,cpu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2286623002 Cr-Commit-Position: refs/heads/master@{#414670}
-
meade authored
Review-Url: https://codereview.chromium.org/2280833002 Cr-Commit-Position: refs/heads/master@{#414669}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/30b05c202793..fca74cffde72 $ git log 30b05c202..fca74cffd --date=short --no-merges --format='%ad %ae %s' 2016-08-25 benjhayden Change blinkGcMetric to use NumericBuilder instead of ScalarNumeric. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2279993002 Cr-Commit-Position: refs/heads/master@{#414668}
-
achuith authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/762cbcd93409..19800a2aaeab $ git log 762cbcd93..19800a2aa --date=short --no-merges --format='%ad %ae %s' 2016-08-17 rahulchaudhry chromeos_config: add split toolchain builder configs. 2016-08-09 dgarrett ReportStage: Adjust where artifacts are linked. 2016-05-03 achuith VM tests in simple chrome. 2016-08-22 briannorris cros_sdk: improve curl output parsing 2016-08-19 phobbs metrics: Make SSLErrors when flushing warnings 2016-08-23 akeshet report_stages: do not abort hwtest suites from wrong branch 2016-08-23 bhthompson gs: downgrade to gsutil 4.19 2016-08-17 dtor remote-access: only offer our key when initiating connection 2016-08-22 dgarrett DebugSymbols: Increase logging of tar command. 2016-08-19 vapier gs: update to 4.21 2016-08-17 rahulchaudhry chromeos_config: cleanup gcc/llvm toolchain builder templates. 2016-08-17 rahulchaudhry chromeos_config: cleanup toolchain master config. 2016-08-17 rahulchaudhry chromeos_config: remove _toolchain settings already implied by 'full' build. 2016-08-17 rahulchaudhry chromeos_config: skip hwqual tarball upload in _toolchain builders. 2016-08-17 rahulchaudhry chromeos_config: remove _toolchain configs from 'cbuildbot --list'. 2016-08-19 laszio AFDO: Increase the expiration days of old AFDO data. 2016-08-19 dgarrett cros clean: Add --board argument. 2016-08-18 dgarrett DebugSymbolStage: Remove parallelism. 2016-08-18 dgarrett cros_build_lib: Strip CreateTarball debugging. 2016-08-18 davidriley report_stages: Add important as build metric field. 2016-08-18 akeshet metrics: forgive ts_mon AttributeError 2016-08-18 dgarrett UnittestStress: Include unittest run number in stage name. 2016-08-18 vapier config_stages_unittest: mark network tests 2016-08-18 vapier config_stages_unittest: fix style 2016-08-17 vapier gs: update to gsutil 4.20 2016-08-03 xixuan chromite: Add an builder_path to /etc/lsb-release file of the DUT. 2016-08-17 rahulchaudhry chromeos_config: mark all _toolchain configs with 'no_vmtest_builder'. 2016-08-17 rahulchaudhry chromeos_config: use official_chrome to get the USE flag for _toolchain. 2016-08-17 rahulchaudhry chromeos_config: remove chromeos_official setting from _toolchain. 2016-08-17 rahulchaudhry chromeos_config: remove default_hw_tests_override from _toolchain. 2016-08-04 stevenjb Include the number of chrome uprevs in 'cros stats --report success' 2016-08-12 dgarrett chromeos_config: Create new build config to stress unittests. 2016-08-08 nxia Cancel old pre-cq runs. 2016-08-16 akeshet cidb: spelling fix for file name 2016-08-12 rahulchaudhry chromeos_config: fix useflags specification for llvm-next builder. 2016-08-04 philipchen123 Elm: mark elm-paladin as important 2016-08-11 nxia Use git-cache for GCE builders. 2016-08-10 xixuan chromite: fetch 'stateful_update' script from devserver 2016-08-12 nxia Add trybot_cancelled action to clActionTable. 2016-08-09 dgarrett report_stages: Move archive_urls linking from results_lib. 2016-08-09 dgarrett commands: Simplify GenerateHtmlIndex signature. 2016-08-11 phobbs report_stages.py: Fix sorting of timelines 2016-08-10 aaboagye cros_stats: Add per-stage stability report. 2016-08-10 sjg crosfw: Build u-boot.rom on x86 2016-08-05 phobbs ts_mon_config: Don't pickle metrics objects 2016-08-10 vapier cbuildbot: enable e-mails for weave waterfall 2016-08-05 phobbs commands.py: GenerateHtmlTimeline sorted by end 2016-08-04 sjg crosfw: Add arm64 support 2016-08-01 dgarrett Revert "report_stage: No longer generate HTML index." 2016-08-03 nxia Add GetBuild, CancelBuild and CancelBatchBuilds requests. 2016-05-31 xixuan autoupdater: Add cros_host auto-update functions into auto-update lib. 2016-08-04 sjg crosfw: Use a default of 'all' for the 'target' command line option 2016-08-04 bhthompson Migrate veyron_minnie-chromium-pfq to veyron_jerry-chromium-pfq 2016-08-03 dgarrett chromeos_config: Disable veyron_rialto payload testing. 2016-07-14 rdob Enable SimpleTestUpdateAndVerify test in lakitu VM tests stage 2016-07-26 phobbs lib/metrics.py: Added Queue indirection 2016-08-02 bhthompson Migrate samus-cheets, cyan-cheets, and veyron_minnie-cheets builders 2016-07-20 sjg crosfw: Use a verbose build with -v3 or greater BUG= Review-Url: https://codereview.chromium.org/2286453002 Cr-Commit-Position: refs/heads/master@{#414667}
-
suzyh authored
Review-Url: https://codereview.chromium.org/2283593002 Cr-Commit-Position: refs/heads/master@{#414666}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/973bb63aa294b6e2f87027c8738ddcad1c339df2 Remove blink_downstream (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=584079 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2283633002 Cr-Commit-Position: refs/heads/master@{#414665}
-
falken authored
As per comments on the bug, this may be fixed now. Speculatively reenabling. BUG=461489 Review-Url: https://codereview.chromium.org/2278403002 Cr-Commit-Position: refs/heads/master@{#414664}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#414663}
-
yzshen authored
Previously the code couldn't correctly validate inlined nullable unions. BUG=None. Review-Url: https://codereview.chromium.org/2286513002 Cr-Commit-Position: refs/heads/master@{#414662}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/23c1b4a4e779..30b05c202793 $ git log 23c1b4a4e..30b05c202 --date=short --no-merges --format='%ad %ae %s' 2016-08-25 benjhayden Modernize RelatedValueSet, RelatedValueMap, Composition to use ES6 classes. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2283603002 Cr-Commit-Position: refs/heads/master@{#414661}
-