GitLab

Disable IPPET power monitor added in https://codereview.chromium.org/394923003/. The win8 perf bot (http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29)
became pretty flaky right after this power monitoring patch landed. Some of the failures are clearly
IPPET-related, but others are silent timeouts which also appeared around the same time.

Sample failures:

- AssertionError: Called StartMonitoringPower() twice.
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2561/steps/page_cycler.dhtml/logs/stdio

- IppetError: Timed out waiting for IPPET to close.
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2540/steps/page_cycler.dhtml/logs/stdio

- TimeoutException: Timed out while waiting 5s for IppetServerIsUp.
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2551/steps/page_cycler.dhtml/logs/stdio

- Generic timeout
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2558/steps/page_cycler.intl_ar_fa_he/logs/stdio

Original issue's description:
> [telemetry] Add IPPET power monitor.
>
> This power monitor lets our automated testers track power usage on Windows on Intel Sandy Bridge or later.
>
>
> BUG=336558, 153139
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286541

R=rmcilroy@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/443973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287779 0039d316-1c4b-4281-b951-d872f2087c98

Android JellyBean MR2 (API 18) introduced an Intent extra which tells the
file picker that it can select multiple files. Each of the files will be
returned as a ClipData entry on the completed Intent.

BUG=348912

Review URL: https://codereview.chromium.org/443683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287777 0039d316-1c4b-4281-b951-d872f2087c98

The timer is set when the inactive bubble shows up or when the user moves the mouse out of it. The active bubble doesn't have the timer.

BUG=394287

Review URL: https://codereview.chromium.org/441953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399653

Review URL: https://codereview.chromium.org/447543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401028
TBR=tmdiep
NOTRY=true

Review URL: https://codereview.chromium.org/440413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287774 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368750
R=sadrul
TEST=on device and desktop

Review URL: https://codereview.chromium.org/404423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384453

Review URL: https://codereview.chromium.org/433483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401002

Review URL: https://codereview.chromium.org/443873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287769 0039d316-1c4b-4281-b951-d872f2087c98

Password "key" icon in the omnibox should be focusable. If the bubble is open then it automatically passes its focus to the bubble.

BUG=392835

Review URL: https://codereview.chromium.org/440903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287768 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces the |SessionLocales| policy that can be used to
recommend one or more UI locales for a public session. If the policy is
set, the first recommended locale is pre-selected when starting a public
session. If more than one locale is recommended, the public session pod
is shown in its advanced form, highlighting the availability of language
and keyboard layout pickers.

The keyboard layout is automatically set to the most popular layout
matching the UI locale.

This CL also fixes the flaky DeviceLocalAccountTest.* and
TermsOfServiceDownloadTest.Ü.

BUG=214904, 241790, 401010
TEST=Extensive browser test coverage, including picker UI

Review URL: https://codereview.chromium.org/426063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287767 0039d316-1c4b-4281-b951-d872f2087c98

This is a speculative revert to see if issues on Mac bots get resolved.

BrowserTest.WindowOpenClose is e.g. failing on this assert:
ASSERTION FAILED: !active || m_layerTreeView

> Make SingleThreadProxy a SchedulerClient
> 
> This makes ui::Compositor no longer in charge of
> scheduling commits and draws, deferring it to cc::Scheduler.
> 
> Other compositors that use SingleThreadProxy are left calling composite
> synchronously and now pass a flag to indicate that this is their
> intention.  This patch doesn't remove synchronous composite, but now
> makes it mutually exclusive with scheduling.
> 
> BUG=329552, 287250
> 
> Review URL: https://codereview.chromium.org/134623005

TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/441343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400755

Review URL: https://codereview.chromium.org/440143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287764 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Uninitialized global message center instance leads to trouble when
modifying gyps.

Review URL: https://codereview.chromium.org/444463007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287763 0039d316-1c4b-4281-b951-d872f2087c98

The wm::WMState object takes care of setting up some window-manager related
functionality (e.g. window-stacking client, transient-window client). So
create WMState from the WindowManager implementation in athena.

BUG=400961, 386350
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/442193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287762 0039d316-1c4b-4281-b951-d872f2087c98

* AboutResource is updated as soon as the remote update is notified.

* The condition to trigger the fast-fetch mode is changed.
Previously we've skipped it if the directory changestamp is
close to the server changestamp, expecting the normal fetch
will finish very soon in that case. To correctly grasp the
expectation, however, we need to compare by using the changestamp
of the whole metadata in the DB, not the directory's.

BUG=329732

Review URL: https://codereview.chromium.org/444463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400095

Review URL: https://codereview.chromium.org/437203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287760 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399271

Review URL: https://codereview.chromium.org/442773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287759 0039d316-1c4b-4281-b951-d872f2087c98

Removed the 'using namespace std' directive from the header with using qualified
name for string as std::string.

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/441083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287758 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400734

Review URL: https://codereview.chromium.org/440323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287756 0039d316-1c4b-4281-b951-d872f2087c98

Remove the gin/v8 based bindings, in favour of bindings provided by mojo. Use
the same mechanism as chrome://omnibox to provide the bindings for the virtual
keyboard when the VK extension API is not available.

BUG=380215, 387276
R=sky@chromium.org

Review URL: https://codereview.chromium.org/328303008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287755 0039d316-1c4b-4281-b951-d872f2087c98

CL 393863002 switched Blink over to the new permission path for Web
Notifications, eliminating a synchronous IPC message and allowing the
rest of Web Notifications to be separated from WebFrame. Remove the
now unused code.

BUG=392187, 398045

Review URL: https://codereview.chromium.org/433433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287753 0039d316-1c4b-4281-b951-d872f2087c98

These tests started consistently failing: ConnectBasicNetwork, ConnectInvalidServiceNetwork.
(e.g http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12739)

> mojo: terminate apps if the shell goes away
> 
> Each application <> shell connection is represented by a ShellImpl instance
> on the shell side. This CL makes the Application watch its ShellPtr for pipe
> errors so it can Quit() itself if the shell goes away (shell loop destroyed).
> 
> mojo_shell_tests starts using a new method to terminate all shell connections
> in this CL, and waits afterward until KeepAlive quits the loop signifying that
> all apps are gone. This is done prior to destroying the shell MessageLoop so
> that the test ensures apps have all died before the next test. In the future
> it would be a test failure if this wasn't a no-op, but we have things in the
> shell that don't quit themselves right now.
> 
> The shell itself won't wait around for apps to die (as of this CL), but
> ~MessageLoop will still send the message to Application sides that will quit.
> 
> ** NOTE ** This does not require an app build target to explicitly add magic
> *.cc files to their sources.  It requires selecting an appropriate
> mojo_application_{chromium, standalone} library akin to mojo_environment_*.
> We can possibly combine these two in the future.
> 
> BUG=394477
> 
> Review URL: https://codereview.chromium.org/394903005

TBR=tim@chromium.org

Review URL: https://codereview.chromium.org/443063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287752 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Two Android build bots (downstream) are failing as a result of this CL.

Reverting as Android Build Sheriff.

BUG=401020
TBR=cjhopman
NOTRY=true


Original issue's description:
> Enable Android lint by default
> 
> BUG=393235
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287676

Review URL: https://codereview.chromium.org/446833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287749 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/448583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287748 0039d316-1c4b-4281-b951-d872f2087c98

This makes ui::Compositor no longer in charge of
scheduling commits and draws, deferring it to cc::Scheduler.

Other compositors that use SingleThreadProxy are left calling composite
synchronously and now pass a flag to indicate that this is their
intention.  This patch doesn't remove synchronous composite, but now
makes it mutually exclusive with scheduling.

BUG=329552, 287250

Review URL: https://codereview.chromium.org/134623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287747 0039d316-1c4b-4281-b951-d872f2087c98

The AutoSize test was failing on Mac:
WebViewTest.AutoSize (run #1):
[ RUN      ] WebViewTest.AutoSize
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors
[9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors
[9340:71171:0806/013455:INFO:CONSOLE(14)] "guest.loadstop", source: chrome-extension://blepeeghknicglkaidbjijdlejjompdl/main.js (14)
ASSERTION FAILED: !enable || !minSize.isEmpty()

(log: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/26134/steps/browser_tests/logs/AutoSize)

> <webview>: Move autosize from content to chrome.
> 
> BUG=330264
> TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json
> 
> Review URL: https://codereview.chromium.org/427883002

TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/446823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287746 0039d316-1c4b-4281-b951-d872f2087c98

These can now be intercepted within glibc so there
is no need to implement them directly.  mkdir/mkdir
were also be intercepted at this level under newlib
unnecessarily.

It seems that truncate.c is still needed but I've
got a fix for that in glibc:
https://codereview.chromium.org/439003002/

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3709
R=binji@chromium.org

Review URL: https://codereview.chromium.org/433193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287745 0039d316-1c4b-4281-b951-d872f2087c98

TrackerIDSet class is expanded on disk DB, and needs a good simulation
to work similarly with it.

This CL fixes handling of active tracker ID which was not correct.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOn*"

Review URL: https://codereview.chromium.org/441873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287744 0039d316-1c4b-4281-b951-d872f2087c98

Playing a WebM File with opus audio via MediaSource currently uses
kSampleFormatS16. In a video src it uses kSampleFormatF32.
S16 does not work (just plays noise).

BUG=400247
R=vigneshv@chromium.org

Review URL: https://codereview.chromium.org/437813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287743 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254066
TEST=NONE

Review URL: https://codereview.chromium.org/423173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401010
TBR=bartfab

Review URL: https://codereview.chromium.org/442233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287741 0039d316-1c4b-4281-b951-d872f2087c98

The problem is that we were generating zero hashes when there
were no input bytes, when we should have generated one.

To make this fix a little easier to test, I moved the code for
generating hashes of content into a utility funciton in
computed_hashes.{h,cc}. Also, in order to fix things for any
profiles that might have incorrect computed_hashes.json files, I
changed the format of it to add the notion of a version. When the
format or version isn't recognized, the code will return an error
from the Init function, and then the code that uses it elsewhere
in the content verification code will automatically try to
recreate it.

BUG=399251

Review URL: https://codereview.chromium.org/436563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287740 0039d316-1c4b-4281-b951-d872f2087c98

Previously, platform backends were singletons [per platform] but the platform
object itself was created and destroyed by the browser. Moreover, the current OS backend was publicly accessible.

This patch tightens up the lifecycle of platforms, making the host platform
an explicit singleton, and target platforms singletons owned by their finder.

And, the platform backend is no longer exposed. Sadly, three corner cases exist:
a memory test case and the actual desktop-based browser finders.

R=tonyg
BUG=356763

Review URL: https://codereview.chromium.org/436873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287739 0039d316-1c4b-4281-b951-d872f2087c98

This was re-enabled recently but was still flaky. This CL removes
another possible cause of flakiness and re-enables the test again.

BUG=171450

Review URL: https://codereview.chromium.org/448473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/434043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287737 0039d316-1c4b-4281-b951-d872f2087c98

corrected to "Microphone currently unavailable"


BUG=396971

Review URL: https://codereview.chromium.org/434373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287735 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346956

Review URL: https://codereview.chromium.org/436453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287734 0039d316-1c4b-4281-b951-d872f2087c98

Print more information in cast_simulator:
1. Total video frames.
2. Dropped video frames.
3. Late video frames.
4. Avg. target bitrate.
5. Avg. encoded bitrate.

Review URL: https://codereview.chromium.org/433363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287733 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330264
TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json

Review URL: https://codereview.chromium.org/427883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287732 0039d316-1c4b-4281-b951-d872f2087c98