- 12 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/21bb102317d6..17844a0135bf git log 21bb102317d6..17844a0135bf --date=short --no-merges --format='%ad %ae %s' 2019-10-12 vapier@chromium.org cros lint: upgrade to pylint-1.7 Created with: gclient setdep -r src/third_party/chromite@17844a0135bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4a6fe616a9f98f55b1d6251e6f2e20e4cb72e045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705390}
-
Ken Rockot authored
This changes BrowserTestBase::SetUp to disallow FeatureList overrides for the remaining duration of the test. Catches incorrect usage of ScopedFeatureList which can cause data races. Bug: 846380 Change-Id: Ie76d59e191edc3ac05c96131e83e5aa0b73dfda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842111 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#705389}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b6287e93..36ab07aa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie25c8bf1fcba97a7003c8b55d7f9744861235f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857380Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705388}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/483426c9f91a..21bb102317d6 git log 483426c9f91a..21bb102317d6 --date=short --no-merges --format='%ad %ae %s' 2019-10-12 vapier@chromium.org paygen_payload_lib: use binary mode in more places Created with: gclient setdep -r src/third_party/chromite@21bb102317d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia425bd459981c70789dac058ee5d64366b569bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857660Reviewed-by:
-
Xianzhu Wang authored
This is a reduced version of crrev.com/c/1835272. This CL keeps fast/scrolling/scrollbars still using mock themes, which will be addressed as part of crbug.com/953847. The mock theme was for 1. platforms that have multiple native themes / toolkits because we don't support multiple baselines for them 2. to reduce platform dependent baselines 3. to test some features (e.g. hover effect of scrollbar track) that are not available on some native themes However, the mock theme prevented us from testing the real native theme and may hide some bugs, and is a maintenance burden. Each of the above reasons can be counter justified: 1. If a platform does have multiple native themes / toolkits, we can force the test environment to test only one of them, or extent the testing infrastructure to support multiple native themes / toolkits. 2. We have good rebaseline tools to support platform dependent baselines. Also we prefer ref/testharness tests to pixel tests. 3. We only need to support a feature that is used by a native theme, thus it will be tested with that native theme. If a feature is not used by any native theme, then we don't need to test and support it. For discussions see: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADBxrieDnCJOwDide2ZbyGvQRKRJzia9Pxbc-fnXJNAShL5q%2Bw%40mail.gmail.com?utm_medium=email&utm_source=footer About TBR: The reviewers already LGTM'ed crrev.com/c/1835272. TBR=tkent@chromium.org,mkwst@chromium.org Bug: 1013637, 953847 Change-Id: Ifea3c76ed01efd694ad64eb21bc329e8e1c7c1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856359Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705386}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f90eb5d3..b6287e93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9092716bc56d167a6638bccf4cafd0c0144a4c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857244Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8be669fd96e4..8bbf9e2c6e40 git log 8be669fd96e4..8bbf9e2c6e40 --date=short --no-merges --format='%ad %ae %s' 2019-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 002d8b5c..c1f96a7b (705236:705365) Created with: gclient setdep -r src/third_party/webrtc@8bbf9e2c6e40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia8acd18a1f60abc302fab3c89bbecbd4f3e39965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857492Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cbae8a8b9f6..88d7869db091 git log 2cbae8a8b9f6..88d7869db091 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 ehmaldonado@chromium.org Reland "depot_tools: Add httplib2 to .vpython" Created with: gclient setdep -r src/third_party/depot_tools@88d7869db091 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I78ad64b527de6f93252dc272e4dd708ca83abd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857192Reviewed-by:
-
Sammie Quon authored
remove a performance related change which throttles some update events, UX did not like the look. Also stop drags if display changes, to avoid some weird looking states. Test: manual Bug: 1011449 Change-Id: I4bcb75e0b57975a511f75a65871bcff3b1e24719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856923Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#705382}
-
Achuith Bhandarkar authored
BUG=None TEST=None Change-Id: I09696c7c4b0d7f0b76c2fef4de7cee7e7e4c21e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853850Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#705381}
-
jonross authored
We are landing a patch to fix the running of skia_renderer_gl_blink_web_tests on Windows: https://chromium-review.googlesource.com/c/chromium/src/+/1856260 However some tests were failing. This change skips them until we've had the chance to properly triage. TBR=kylechar@chromium.org TEST=skia_renderer_gl_blink_web_tests Bug: 1011512 Change-Id: I6fa8b4542cb4c060edf40f11070252a9ab01daa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857480Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#705380}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1fce7657a2fd..483426c9f91a git log 1fce7657a2fd..483426c9f91a --date=short --no-merges --format='%ad %ae %s' 2019-10-12 coconutruben@chromium.org fwgdb: update to new servod rc logic 2019-10-12 coconutruben@chromium.org fwgdb: conform to new servo_parsing interface Created with: gclient setdep -r src/third_party/chromite@483426c9f91a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2fb9c308ca3b7b72a9065526cfc3da70e38e6cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857762Reviewed-by:
-
Lei Zhang authored
Change-Id: Idf93bd5e2e14196d82e44223d9213fa0ee4aecd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560442 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#705378}
-
Leon Han authored
Note: not support sub-records yet. The corresponding spec changes: https://github.com/w3c/web-nfc/pull/278 https://github.com/w3c/web-nfc/pull/326 and the relevant issue: https://github.com/w3c/web-nfc/issues/331 BUG=520391,995234 Change-Id: I5b99543bddf505975567ecad22c0d5390842337f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791533Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#705377}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d192e933eb69..1948af385c1b git log d192e933eb69..1948af385c1b --date=short --no-merges --format='%ad %ae %s' 2019-10-12 jmadill@chromium.org Add a roll_deps script based on WebRTC. 2019-10-12 jdarpinian@chromium.org Extend ANGLE_request_extension with DisableExtension 2019-10-11 lehoangq@gmail.com Metal implementation pt 1: autogen resources Created with: gclient setdep -r src/third_party/angle@1948af385c1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Icb8d31e177783f71057b5df2328da7f36539fccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857759Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I7cacd34d0bbfc41d56ab68f2b5407afc81971edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857024Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705375}
-
Miyoung Shin authored
This CL converts XRServiceTestHookPtr that is left only in MockXRDeviceHookBase class in chrome to the new Mojo type. Bug: 955171 Change-Id: Ie202d44cf61e1e3ddc89b19345619d4f40708384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847593Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#705374}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/373b149d8cf2..8be669fd96e4 git log 373b149d8cf2..8be669fd96e4 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 peah@webrtc.org AEC3: Add support for multiple channels to the reverb modelling Created with: gclient setdep -r src/third_party/webrtc@8be669fd96e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I7bdde6e38eccf1a596d72c3c1ec1c1610c769604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857196Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fafa247..f90eb5d3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id18b4bd98a5cd49a81d26ef0d73f0fe648ce5ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857242Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a82bb0b1ae2e..8352ab39aafc Created with: gclient setdep -r src-internal@8352ab39aafc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib06e238ed6be21611a61543d364c9c46f0610ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857193Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705371}
-
François Doray authored
PerformanceManagerLockObserver must stay alive until after base::ThreadPool shutdown because it can be accessed by IndexedDB which runs on a base::ThreadPool sequence. Bug: 980533 Change-Id: I6d454cffa68cb776b9c4abf3180506096c4e91c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856891 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#705370}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I93763520df60d63218c6664ce3fd0720fb642f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857194Reviewed-by:
-
Miyoung Shin authored
ManifestManager could be unreachable before ContextDestroyed() gets called and destructed before the receiver set is cleared. Then, it could lead to UAP bug, so this CL clears ReceiverSet<T> in Prefinalize instead of ContextDestroyed. Bug: 1012055 Change-Id: I3b1a569c8b4e26fde0c8ae3ac3cab27f5efc7c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855323Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#705368}
-
Lei Zhang authored
Similar to copyBetweenWindowsDriveToUsb, copyBetweenWindowsLocalToUsb and other related tests are also flaky. Disable them all. TBR=austinct@chromium.org Bug: 1008909 Change-Id: Ib87e1403a653fa599111faa38b30947ca0fbf216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857650Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705367}
-
Lei Zhang authored
Disable it on Android and Linux because it is very flaky. TBR=tbansal@chromium.org Bug: 1002223 Change-Id: Iec11ef5f5b093febac4cba3241073308bbb77f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857190Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 875ee43f. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I672a06d761ff891fac325eabfe852230a2604d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857379Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705365}
-
nancy authored
This is the follow up for crrev.com/c/1816495. InternalAppName has been moved to BuiltInAppName in AppService, so replace InternalAppName with BuiltInAppName, otherwise we have duplicate enum, which could cause confusing for the future change. Although the app_list/internal_app will be replaced by AppService for the long term goal, in short term(one or two months), they are still there, so as the temporary solution, update it to use the AppService's enum BuiltInAppName. BUG=1005640 Change-Id: I0992d549c25a40087212baba0b8d8305b1136d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852526 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705364}
-
Yoichi Osato authored
This patch changes network service to restrict sending the headers to the renderer not to leak info if handshake was failed. This also changes WebRequest API and devtools event listening as failed when handshake was failed. Change-Id: I03160b06546711365273180a8020239e09528a47 Bug: 944619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847592 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#705363}
-
Lukasz Anforowicz authored
After https://crrev.com/c/1842112 ContentRendererClient::ShouldFork is only used for prerender. Since prerender has been unsupported in production for a while (see https://crbug.com/755921 opened in August 2017) we can remove ContentRendererClient::ShouldFork entirely. This CL also removes AlwaysForkingRenderViewTest-based tests. These tests were testing ShouldFork-specific implementation details and are not applicable after removal of ShouldFork. Bug: 1003957, 883549 Change-Id: Ifd88909be59896b35c61f286f5225e1ab08b8d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812128 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705362}
-
Xida Chen authored
Right now the FrameSequenceTracker::ThreadType has 3 values: kMain kCompositor kSlowerThread The kSlowerThread should just be kSlower, to be consistent with the other two. Bug: None Change-Id: Ib4aa32b1313bdf72b1317f37f29193beab28622c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856728Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#705361}
-
Ken MacKay authored
Avoid clamping the sample range for each filter group. We still clamp in StreamMixer::WriteMixedPcm() before sending to output. Bug: internal b/142504553 Change-Id: I5a7376c229e9146ea25ebed40f8da1a46cc40c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856462Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#705360}
-
Lei Zhang authored
ArcAppModelBuilderRecreate.AppModelRestart and ArcAppModelBuilderRecreate.AppsNotReportedNextSessionDisabled are flaky. TBR=khmel@chromium.org Bug: 1013813 Change-Id: I511392b15a1ebd70687fa2bcb3c105db045fe34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857188Reviewed-by:
-
Prabir Pradhan authored
As per the wayland-protocol spec for locked pointer, the locked pointer object is no longer valid if the surface to which it is constrained is destroyed. This CL makes sure to break the constraint and send an unlock event when the surface associated with a locked pointer is destroyed. Bug: None Change-Id: I368af9a725da3c3b871c7574b2c76fe5fc113fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854879Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6787f232aedd..373b149d8cf2 git log 6787f232aedd..373b149d8cf2 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision da0e48ef..002d8b5c (705127:705236) Created with: gclient setdep -r src/third_party/webrtc@373b149d8cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I7b7152c5a0461d42834e8d0386563b10b842bd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856873Reviewed-by:
-
Lukasz Anforowicz authored
This CL coverts two places that used to manually populate NavigateParams from OpenURLParams, to instead rely on FillNavigateParamsFromOpenURLParams (which correctly propagates all relevant pieces of data from OpenURLParams, unlike the old, manual propagation which would only copy a handful of properties). This CL also augments FillNavigateParamsFromOpenURLParams to cover 2 additional fields of NavigateParams: initiating_profile and source_contents. Bug: 1007041 Change-Id: I4b30d18699ce41bc188801ea80aeff549b26f573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854209 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
David Benjamin authored
This makes it more obvious that state is only relevant for the CrOS-specific stuff, which should make it easier to split out. Bug: 125848 Change-Id: I45da1f43a2584271d9ec5aad07460200f9e948cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857040 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#705355}
-
Hector Carmona authored
Bug: 1012370 Change-Id: Ibd7304cc2a9c8fe81b60e26da5bbffeaa0eee324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857541Reviewed-by:
-
Sam Maier authored
Change-Id: I4a431f966ab297e7c81b7abe8e29ed302b984586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849181 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#705353}
-
Peter Kasting authored
This also uses auto more and a few other cleanups, mostly to limit the number of "cmds::" to be inserted. Bug: 82078 Change-Id: I62d7adda3f2a0eb4dfb264c3ac386e89e1979aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855582 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#705352}
-
Tsuyoshi Horo authored
When "Files by Google" opens a file "a.a.wbn" in USB storage, the URI is like content://com.google.android.apps.nbu.files.provider/3/content%3A%2F%2Fcom. android.externalstorage.documents%2Ftree%2FC93A-14FA%253A%2Fdocument%2FC93A- 14FA%253Aa.a.wbn There are five dots in the file name, and the URI doesn't match the current pathPattern due to the strange behavior of intent filter's pathPattern. https://stackoverflow.com/questions/51912180/strange-intent-filter-pathpattern-behaviour So "Files by Google" can't opens the file with Chrome. To fix this problem, this CL adds more android:pathPattern. Bug: 995177 Change-Id: I3c4652d6aff8508fa00ead0e3da2855706756725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852327Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705351}
-
