- 18 Apr, 2020 15 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1705a0f..f25b9eba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie23f47902533355fa9ee545030bd267f170d161f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760275}
-
chrome://os-settingsdpapad authored
Bug: None Change-Id: I403ae122bf417f3474f15157f23a67a96c3919a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155280 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#760274}
-
Ben Pastene authored
The bot https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome runs on 104 GB mem machines, but only has a single linker running at any time. This bumps it up to 2 (and unpins the value of max_jobs_per_link) to see what effect it has on build times. Change-Id: Ifbd14cc05e2bfa60156969a6a8da8ed05f6afa93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149388 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Bob Haarman <inglorion@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#760273}
-
Daniel Playfair Cal authored
This is needed for the use of std::find. Change-Id: I2dc43b3887c467986c5346be5a9e27a987e1e5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152333Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#760272}
-
Nate Chapin authored
Bug: 1068008 Test: fast/workers/sandbox-origin-setup-crash.html Change-Id: I7f87ce0c2a9119f3e78455e15463c5a4e1be9039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140951 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#760271}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/13e4cdb26a25..2d5da0298b9b git log 13e4cdb26a25..2d5da0298b9b --date=short --first-parent --format='%ad %ae %s' 2020-04-17 jmadill@chromium.org Minor angle_end2end_tests cleanups. 2020-04-17 lehoangq@gmail.com Separate GLES1's state enum switch code from GLES2+ 2020-04-17 cclao@google.com Vulkan: store ImageLayout in PackedAttachmentOpsDesc 2020-04-17 geofflang@google.com Remove more bad files before rolling into AOSP. Created with: gclient setdep -r src/third_party/angle@2d5da0298b9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I5af8473c3572faa10054cc514f97c382e7a3e3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760270}
-
Jae Hoon Kim authored
Previously if the signals from dlcservice for installation completion is posted prior to the installation dbus method callback being posted, the DCHECK would assert and this change removes the DCHECK. BUG=b:153527570 TEST=unit_test --gtest_filter=Dlcservice* Change-Id: I619d2f1b29cf262b76d4c1389a92970b99d47431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144399 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#760269}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a5ce9072b623..34b3e095fffc git log a5ce9072b623..34b3e095fffc --date=short --first-parent --format='%ad %ae %s' 2020-04-17 oysteine@google.com Merge "Pass process_priority from the StreamingProfile packets through to the JSON output" Created with: gclient setdep -r src/third_party/perfetto@34b3e095fffc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5140fb3f0a9d85ef5f757a091116b42be918c8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155193Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/377573cc1038..068611f07d28 git log 377573cc1038..068611f07d28 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 capn@google.com Fix JIT on separate thread Created with: gclient setdep -r src/third_party/swiftshader@068611f07d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9f2d11415267e99b1f7148e0baba7b2baa2f47ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155286Reviewed-by:
-
Andrey Kosyakov authored
Bug: 1016278 Change-Id: Icd80e3b287f090ffb4ac67437e7e1ebae392c98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154228Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#760266}
-
Chris Mumford authored
M81 is still deleting backup files, so keeping this metric active until the end of 2020. Will review then and determine if the quantity deleted is low enough to remove this feature (and UMA). Bug: 975751 Change-Id: I43926c27e4ce4dd4d6a06d6a5fa612c1db3bd303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152887 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#760265}
-
Sam Bowen authored
* Remove an extra code block ending. * Remove a reference to a part of the page that no longer exists. Change-Id: I59d4979d97070f5396ba4b818ccaba208c584b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155249Reviewed-by:
-
dpapad authored
Bug: 1069258 Change-Id: I80674d8534d9773ac9329fde6d931425f3e2b5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154822 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#760263}
-
Gabriel Charette authored
CPU stack sampling profiler jank analysis is hinting at these methods is this a bias or is there really jank in here? Add trace events to balance stack sampling with slow reports. Added trace events to both MessagePumpForUI::ProcessNextWindowsMessage and MessagePumpForUI::WaitForWork's lookups. The stack sampling analysis seems to be hinting more at ProcessNextWindowsMessage for now, but a lot of this gets inlined in Release builds so it's hard to tell for sure. This CL also highlights a discrepancy between the checks in ProcessNextWindowsMessage and WaitForWork. WaitForWork uses MSG msg = {0} whereas ProcessNextWindowsMessage uses an uninitialized MSG object. It doesn't seem necessary for this structure to be initialized, will make it consistent in a follow-up CL. R=fdoray@chromium.org Bug: 899897 Change-Id: Ibd8a43e0346e6eb7e09432582a76235ed350ae6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153321 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:oysteine <oysteine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#760262}
-
Jesse McKenna authored
This change adds the WebApp.Launcher.UpdateResult metric, which will report failures updating Progressive Web App (PWA) launcher executables. On Windows, each PWA has a separate launcher executable in its web-app data directory (located at <User Data dir>/<profile>/Web Applications/_crx_<app ID>/). When Chrome is launched by an out-of-date PWA launcher, it updates all PWA launchers for the current profile. Because these updates involve file operations and take place in the user-data directory, they may fail due to permissions errors, etc. This metric will allow us to monitor how often PWA-launcher update is failing, and handle common failure causes if necessary. Bug: 1067241 Change-Id: Ie2ea99ea2f1c284a2388e3eb52b664c6ba5af8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146084Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#760261}
-
- 17 Apr, 2020 25 commits
-
-
dpapad authored
Also removing obsolete TODO (already addressed), as well as the unused "showOsSettings" loadTimeData boolean. Bug: 967888 Change-Id: I36a99fae23e5369b01c9610b837866fce5a7934f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155182Reviewed-by:
-
Jia authored
Bug: 1064424,1018613 Change-Id: I203d857986e6c27c2171ecb4148e3ea928a1b758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153454 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
This CL wires the API with ash::FpsCounter to report smoothness. Bug: 1062124 Change-Id: I5df059da64a507ee4349f0717df81633d063a7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147864 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#760258}
-
rbpotter authored
Bug: 1069258 Change-Id: I35c918448fe62894cb1c1c088776c9a628f64c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153004Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#760257}
-
Nnamdi Theodore Johnson-Kanu authored
This CL is in preparation for enabling Polymer3 in ChromeOS settings pages. It fixed issues in os_settings_ui/ folder that break semi-automatic Polymer3 migration. These changes include adding missing #cr_define_end comments to JS file which were missing them, as well as making sure that files which use cr.define() include the entire file's content within the cr.define() call, since this is required by Polymer3 conversion tools. Bug: 1045266 Change-Id: Iaf3379cc76c4eab1efff139dd5d7542adf5f2293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153338Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6af2de8b2aa5..4c0fac2e6b05 git log 6af2de8b2aa5..4c0fac2e6b05 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 thestig@chromium.org Replace CPDF_CharPosList class with a standalone function. 2020-04-17 thestig@chromium.org Mark CFX_Font::IsSubstFontBold() as Skia-only. 2020-04-17 thestig@chromium.org Add a basic embedder test for FPDF_LoadMemDocument64(). 2020-04-17 thestig@chromium.org Reorder parameters in PWL and related events code. 2020-04-17 thestig@chromium.org Merge and extend FocusableAnnotSubtypes tests. 2020-04-17 thestig@chromium.org Assert timer IDs are unique. 2020-04-17 thestig@chromium.org Call FORM_DoDocumentAAction() in EmbedderTest::CloseDocument(). 2020-04-17 tsepez@chromium.org Put remaining uint16_t vectors into data partition Created with: gclient setdep -r src/third_party/pdfium@4c0fac2e6b05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071689 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I984d04b182f19dd40674e930499371c901d22c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154977Reviewed-by:
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/9b3cba4056fc..aa36e6c02780 $ git log 9b3cba405..aa36e6c02 --date=short --no-merges --format='%ad %ae %s' 2020-04-17 fayang gfe-relnote: In QUIC, rewrite part of QuicSession::OnStreamClosed to make it simpler. Refactoring only. No functional change expected. Protected by existing gfe2_reloadable_flag_quic_break_session_stream_close_loop. 2020-04-17 vasilvv Add support for signing to the CertificateView API. 2020-04-17 fayang gfe-relnote: In QUIC, break QuicStream::CloseRWSide -> QuicSession::CloseStream -> QuicStream::OnClose -> CloseRWSide loop. Protected by gfe2_reloadable_flag_quic_break_session_stream_close_loop. 2020-04-16 ianswett gfe-relnote: Add support for 1RTT and 2RTT connection options in BBRv2, which reduce the number of rounds in STARTUP without a 25% bandwidth increase to 1 and 2 round trips, respectively. Protected by gfe2_reloadable_flag_quic_bbr2_fewer_startup_round_trips. 2020-04-16 fayang gfe-relnote: Remove draining_streams_ from QuicSession. Protected by gfe2_reloadable_flag_quic_deprecate_draining_streams. 2020-04-16 fayang gfe-relnote: In QUIC, remove QuicStream::set_fin_received while move QuicStream::set_fin_sent to protected (renamed to SetFinSent and this should only be used by Google QUIC). No functional change expected, not protected. 2020-04-16 nharper Check for nullptr before calling OnProofVerifyDetailsAvailable 2020-04-16 dschinazi Allow new MOCK_METHOD in QUIC 2020-04-16 wub gfe-relnote: In QUIC BBRv2's PROBE_BW mode, make sure the cwnd upper bound is at least BDP + AckHeight. Protected by --gfe2_reloadable_flag_quic_bbr2_avoid_too_low_probe_bw_cwnd. 2020-04-16 renjietang Upon receiving SETTINGS for a QuicSpdyClientSession, serialize the frame and cache it in tls_client_handshaker. 2020-04-16 dschinazi Make PSK handshake fail with QUIC+TLS 2020-04-16 dschinazi Prepare QboneSessionTest for TLS Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I9a97fb94455b9e8715f3e17f1a7287ab6901e6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155020 Auto-Submit: Renjie Tang <renjietang@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#760254}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I80a8e0a68105bb338d5f9fa50d06aa1358312d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155196Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b0aab2c7d1dc..c632aa633792 git log b0aab2c7d1dc..c632aa633792 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 jvanverth@google.com Flesh out more D3D command list and barrier code. 2020-04-17 michaelludwig@google.com Reland "Rename GrShape to GrStyledShape" 2020-04-17 michaelludwig@google.com Reland "Respect wrap mode when decimating for blur" Created with: gclient setdep -r src/third_party/skia@c632aa633792 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I58b4df24eaec5c4269fe2d28b4713934439b147b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154903Reviewed-by:
-
Devlin Cronin authored
(Revive and) mark Extensions.ExtensionInstalled and Extensions.ExtensionLocation as never expiring; they are useful for monitoring core extension usage. While we're at it, improve the summaries for each. Bug: 1037093 Change-Id: Id682992393e3ea14683caf341b2bac9222b1a287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153947Reviewed-by:
-
Nicolás Peña Moreno authored
This CL adds the 'target' attribute to PerformanceEventTiming under the disabled-by-default EventTiming flag. Note that this is needed since first input timing is already shipped. The implementation simply sets the value upon finishing running event handlers, which guarantees that the very last target is the one used. In addition, the webexposed value needs to perform some checks to make sure that the target can be exposed. These are the same checks as the ElementTiming currently does for its 'element' attribute, and that the LayoutInstability API will need to perform as well, so these are moved to a static method in Performance. Bug: 543598 Change-Id: I10fa259713406c3898eebc0b682fe3d48ca7f641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152999 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#760250}
-
Lei Zhang authored
PaintManager has a DCHECK that disallows this, but it can happen. To prevent the DCHECK failure, keep track of whether OutOfProcessInstance is painting or not. While painting, defer all invalidation requests until after the painting finishes. Bug: 1021800 Change-Id: I4326106df5c2bba30f8412f4d710aefb04e0aa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154387 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#760249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78f5b9ddeb5d..0f1cadb29473 Created with: gclient setdep -r src-internal@0f1cadb29473 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069208 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: I71ef7560e976e1ee76d20ef5dc42efbf3b24bef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760248}
-
Matt Menke authored
Add splitting the DNS cache experiment, prior to updating the server-side field trial to include that feature. Also fix NetInternalsTest test fixture to be compatible with splitting the DNS cache by NetworkIsolationKey. Bug: 963480 Change-Id: Iba98d8e27a9692ab2fe2bcbbe73a15bfd3415bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150685Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Dominic Farolino authored
R=sclittle@chromium.org Bug: 1072018 Change-Id: Ifad7a576917c638f9106cda93d14ff3996eb9a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155269 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#760246}
-
Shakti Sahu authored
This CL adds a fake tile provider that fakes out the backend and provides a set of example topics and images. The images are fetched directly from the URLs by image fetcher in Java layer. TBR=dtrainor@chromium.org Bug: 1069864 Change-Id: I441aa5d8e63c6c5924199748f3b7d175228dbee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145678Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760245}
-
Vasilii Sukhanov authored
Bug: 1049200 Change-Id: Id9aa8e0f60fe010360b0f7c20d456b0375f6e1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153108Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). Callers don't care about error_code, other than == or != JSON_NO_ERROR. Bug: 1069271 Bug: 1070409 Change-Id: I5483d116ee9d5813815118c495474ba50f4255e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154435Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#760243}
-
Robert Liao authored
Change-Id: I29dc8309d545b4fbc7f51e21573b2582f6c82954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154924 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#760242}
-
Jonah Ryan-Davis authored
Push back expiry for several ANGLE-related histograms to M85 Bug: chromium:1037116 Bug: chromium:1037111 Change-Id: Ie9cc0aa851d0346f5ea4f7f46eeb0de2e9925398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155012Reviewed-by:
-
Sami Kyostila authored
We're seeing some crashes during removing cancelled tasks from work queues. Add some debug annotations to help understand where these invalid tasks are coming from. Bug: 1071475 Change-Id: Ic4ba31b8a9585e44e70c7151f461615253291ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153117 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#760240}
-
Badhri Ravikumar authored
Support for opening a link in new tab/window exists using mouse. But after setting focus over link by pressing Tab key, we do not have the provision to open the link in new tab/window using keyboard shortcut. This new API carries keyboard modifier value whenever URI action needs to be performed. Unit tests are added to validate the newly added API. Bug: chromium:994500 Change-Id: Id7936c0ec42115f92a790f4d469f65c6194f9d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154432Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Badhri Ravikumar <bravi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760239}
-
Ayu Ishii authored
This change adds CookieStoreAPI to UKM use counters to record usage of the API and observe how it is being used to help with improvements to the shape of the API. CookieStoreAPI Explainer: https://github.com/WICG/cookie-store/blob/master/explainer.md Change-Id: Ib27ee0d5c228eb8a3e67540a4f0a4bb8a513187d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149866Reviewed-by:
-
Lei Zhang authored
OnUpdatePrintSettings() handles an IPC message with a base::Value. Bad base::Value inputs can trigger crashes, as found by the ipc_fuzzer. Add some sanity checks to prevent one such crash. Bug: 1013764 Change-Id: I41bdece8766152065808c55260ec1e9884cc4673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154367Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760237}
-
dpapad authored
Bug: 1069258 Change-Id: I7bc517d3a4a105e79ddf3572573a518dbb8e0a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155006 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
