GitLab

Moving the DirectiveHandler to be owned by CopresenceManager. This also adds the ability to queue Directives. Tests will be forthcoming.

BUG=424253

Review URL: https://codereview.chromium.org/684273004

Cr-Commit-Position: refs/heads/master@{#302362}

GCC thinks that the create_flags parameter in the templated class
gin::Invoker constructor is going unused, even though it is definitely
being used as a part of a variadic template expansion. Convince GCC
that it is in fact being used by casting it to a void.

BUG=424334
TEST=Linux GN build of gin with is_clang=false
R=aa

Review URL: https://codereview.chromium.org/694063002

Cr-Commit-Position: refs/heads/master@{#302361}

BUG=159847

Review URL: https://codereview.chromium.org/690213003

Cr-Commit-Position: refs/heads/master@{#302360}

BUG=webrtc:3868

Review URL: https://codereview.chromium.org/689243002

Cr-Commit-Position: refs/heads/master@{#302359}

BUG=429372
NOTRY=true

Review URL: https://codereview.chromium.org/697783002

Cr-Commit-Position: refs/heads/master@{#302358}

options_ui is available.

For now this will be hosted on a new page options2.html since the
new options aren't stable yet. When they are, I'll switch over the
URLs.

R=mkearney@chromium.org
BUG=406890

Review URL: https://codereview.chromium.org/691283003

Cr-Commit-Position: refs/heads/master@{#302357}

We can't fix all instances of this warning at the moment (because of gmock
and because of blink apis, see bug). We've fixed many, but our bots still
show almost 20k warnings due to this warning, most of them in v8. That's already
fixed upstream, but v8 rolls don't happen often. Turn the warning off for now.

BUG=428099
NOTRY=true

Review URL: https://codereview.chromium.org/687343003

Cr-Commit-Position: refs/heads/master@{#302356}

This adds a page set that is useful to measure how good a browser
is at producing new content when scrolling a page fast.

MAX_SCROLL_LENGTH_PIXELS is changed into MAX_SCROLL_LENGTH_TIME_MS
to allow fast scrolling of large pages.

BUG=406404

Review URL: https://codereview.chromium.org/688423002

Cr-Commit-Position: refs/heads/master@{#302355}

$ git log bcb3bc303..41036ec83 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-10-31 jbauman Fix termination of initially-suspended processes at end of tests.
2014-10-24 maruel Quick fix to support query parameters in GETs.
2014-10-24 maruel Make test resilient to any umask and add workarounds for strace 2.8.

R=jbauman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/690333004

Cr-Commit-Position: refs/heads/master@{#302354}

TBR=isherman@chromium.org
BUG=429343

Review URL: https://codereview.chromium.org/692263002

Cr-Commit-Position: refs/heads/master@{#302353}

storage.sync MAX_SUSTAINED_WRITE_OPERATIONS_PER_MINUTE limit. I'll be relaxing
the quota over a few CLs and having 2 limiting mechanisms just complicates
things.

BUG=406406
R=zea@chromium.org

Review URL: https://codereview.chromium.org/685603003

Cr-Commit-Position: refs/heads/master@{#302352}

BUG=

Review URL: https://codereview.chromium.org/694573003

Cr-Commit-Position: refs/heads/master@{#302351}

The issue is after enabling sending device_id for LST, IssueToken
endpoint started returning "issueAdvice": "consent" for scope marked
 with per_device_authorization_required:true.

The solution is to pass the same device_id/device_type to approval url.

Tests:
Tested that for LST with device_id consent screen is only shown once.
After restart access token is issued without user interaction.

Tested that for LST without device_id no consent screen is shown.

BUG=403718
R=courage@chromium.org

Review URL: https://codereview.chromium.org/693203003

Cr-Commit-Position: refs/heads/master@{#302350}

Local search function has the same logic with how omnibox retrieves
bookmarks for a given keyword.

BUG=415774

Review URL: https://codereview.chromium.org/695493005

Cr-Commit-Position: refs/heads/master@{#302349}

Since these events are no longer used by the unprefixed EME code,
there is no need to pass them to blink. Full removal will happen
when the prefixed EME code is removed.

BUG=418260
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/685373003

Cr-Commit-Position: refs/heads/master@{#302348}

Review URL: https://codereview.chromium.org/687903003

Cr-Commit-Position: refs/heads/master@{#302347}

The santizer target is empty if no sanitizers are defined, otherwise
it contains the necessary targets. Because of this we can always
depend on it. Without this dep asan builds fail.

BUG=none
TEST=none
R=brettw@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/694053002

Cr-Commit-Position: refs/heads/master@{#302346}

Webkit roll b7fb61d76a24485ae49be3c9a2597fed6126181e(r184749):9eddd919681ed3642ac37d811e6b3f30e0f152db(r184753)

TBR=morrita
BUG=

Review URL: https://codereview.chromium.org/695023002

Cr-Commit-Position: refs/heads/master@{#302345}

For consistency with other VDAs, and to make sure that Chromium's GL state is in sync with reality.

BUG=642453003

Review URL: https://codereview.chromium.org/645713002

Cr-Commit-Position: refs/heads/master@{#302344}

/analyze pointed out that the bit testing in gles2_cmd_decoder.cc was
always returning true due to the wrong operator being used.

Warnings were:

src\gpu\command_buffer\service\gles2_cmd_decoder.cc
(3128) : warning C6316: Incorrect operator:  tested expression is constant and non-zero.  Use bitwise-and to determine whether bits are set.
(5103) : warning C6316: Incorrect operator:  tested expression is constant and non-zero.  Use bitwise-and to determine whether bits are set.

BUG=427616

Review URL: https://codereview.chromium.org/690943004

Cr-Commit-Position: refs/heads/master@{#302343}

Previously it didn't, and perhaps there was no need for
it to, but it seems like NaCl has a need. Specifically,
NaCl has two targets A and B with both run fine on their
own, but A can delete the output of B, and so needs to run
before B.

R=brettw@chromium.org
BUG=428576

Review URL: https://codereview.chromium.org/693443002

Cr-Commit-Position: refs/heads/master@{#302342}

BUG=428816
NOTRY=true

Review URL: https://codereview.chromium.org/696843002

Cr-Commit-Position: refs/heads/master@{#302341}

The incorrectly placed parentheses means that failure of the first
function didn't stop the others from executing, and overall failure was
evaluated incorrectly -- always succeeding I think.

Warnings were:

d:\src\chromium2\src\media\audio\win\core_audio_util_win.cc(361) :
C6215: Cast between semantically different integer types: Boolean type to HRESULT.
C6230: Implicit cast between semantically different integer types:  using HRESULT in a Boolean context.

BUG=427616

Review URL: https://codereview.chromium.org/688663004

Cr-Commit-Position: refs/heads/master@{#302340}

Otherwise it will leave dangling pointers in the SurfaceManager. Also add a DestroyAll method to allow owners to ensure every surface in the factory is destroyed.

BUG=428127

Review URL: https://codereview.chromium.org/693623004

Cr-Commit-Position: refs/heads/master@{#302339}

BUG=424650

Review URL: https://codereview.chromium.org/686983002

Cr-Commit-Position: refs/heads/master@{#302338}

BUG=

Review URL: https://codereview.chromium.org/669783003

Cr-Commit-Position: refs/heads/master@{#302337}

With this CL, the ServiceWorkerCacheListener holds a reference to the
caches that it calls async functions on to ensure that the callbacks
are called.

Note: Keeping the cache alive longer does not alter cache deletion
behavior as cache deletion destroys the cache's backend but not the
ServiceWorkerCache object itself.

BUG=429161

Review URL: https://codereview.chromium.org/682383005

Cr-Commit-Position: refs/heads/master@{#302336}

BUG=none
TEST=none
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/689143002

Cr-Commit-Position: refs/heads/master@{#302335}

CL https://codereview.chromium.org/633373010 added some output files
but did not update the expected output files in the corresponding GN
files.

BUG=429299
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/694853003

Cr-Commit-Position: refs/heads/master@{#302334}

Also includes changes from https://codereview.chromium.org/695953002/ to
update html_viewer for API changes.

Review URL: https://codereview.chromium.org/694923002

Cr-Commit-Position: refs/heads/master@{#302333}

Revert of WebView Guest should use ZOOM_MODE_ISOLATED. (patchset #2 id:100001 of https://codereview.chromium.org/645153002/)

Reason for revert:
This CL seems to be at the root of several other issues, including https://code.google.com/p/chromium/issues/detail?id=429004.

In particular, it seems to be allowing re-entrancy into ZoomController that was unexpected due to the timing with which OnGuestReady() is called.

Original issue's description:
> WebView Guest should use ZOOM_MODE_ISOLATED.
>
> In order that changes to zoom levels in a WebView Guest don't affect
> the embedder, set the WebView Guest's WebContents to use
> ZOOM_MODE_ISOLATED.
>
> BUG=418605
>
> Committed: https://crrev.com/f71a5dc79473cc74990d1e288c66ac282c2926a1
> Cr-Commit-Position: refs/heads/master@{#299493}

TBR=fsamuel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418605

Review URL: https://codereview.chromium.org/690373002

Cr-Commit-Position: refs/heads/master@{#302332}

BUG=428055

Review URL: https://codereview.chromium.org/688973004

Cr-Commit-Position: refs/heads/master@{#302331}

Revert of Roll src/third_party/skia d8aa7b7:3bdd7dc (patchset #1 id:1 of https://codereview.chromium.org/683733007/)

Reason for revert:
XP tests are crashing again. See https://code.google.com/p/chromium/issues/detail?id=429207

Original issue's description:
> Roll src/third_party/skia d8aa7b7:3bdd7dc
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/d8aa7b7..3bdd7dc
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
> TBR=hcm@google.com
>
> Committed: https://crrev.com/a0a1b16124cb5c4340cf56e6df92fef846fb0337
> Cr-Commit-Position: refs/heads/master@{#302311}

TBR=hcm@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/696833002

Cr-Commit-Position: refs/heads/master@{#302330}

## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:445: ERROR - Property wifiCredentialsSynced never defined on args
##         $('wifi-credentials-checkbox').checked = args.wifiCredentialsSynced;
##                                                  ^
##
## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:447: ERROR - Property wifiCredentialsSynced never defined on args
##             args.wifiCredentialsSynced;
##             ^
##
## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:449: ERROR - Property wifiCredentialsEnforced never defined on args
##             args.wifiCredentialsEnforced;
##             ^

BUG=none
TEST=green closure bot
TBR=quiche@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/696013002

Cr-Commit-Position: refs/heads/master@{#302329}

Now that prefixed EME code can add event handlers before calling
generateRequest(), the flakiness problems with these tests is
fixed.

BUG=402766
TEST=re-enabled tests pass

Review URL: https://codereview.chromium.org/689153003

Cr-Commit-Position: refs/heads/master@{#302328}

BUG=429205

Review URL: https://codereview.chromium.org/695753003

Cr-Commit-Position: refs/heads/master@{#302327}

BUG=408772

Review URL: https://codereview.chromium.org/530593002

Cr-Commit-Position: refs/heads/master@{#302326}

The NSS dependency should be guarded by a use_openssl check. BoringSSL and NSS
cannot be linked together as they define some of the same symbols. Update BUILD.gn
analogously by depending on //crypto:platform.

Also condition nss in build/all.gyp on use_openssl in preparation for
https://codereview.chromium.org/694643002/ which will disable the nss and nspr
targets altogether.

BUG=429021

Review URL: https://codereview.chromium.org/686693004

Cr-Commit-Position: refs/heads/master@{#302325}

This is useful for instrumentations required for jankiness investigations. See the .h file comment for details.

In fact, one of my investigations is blocked on this feature.

BUG=401560

Review URL: https://codereview.chromium.org/683283004

Cr-Commit-Position: refs/heads/master@{#302324}

Removes some dependencies from codegen.cc as it now only deals with
emitting programs, not with disassembling them too.

BUG=414363

Review URL: https://codereview.chromium.org/694013002

Cr-Commit-Position: refs/heads/master@{#302323}