GitLab

When the controller forwards the stashed TapDown event after
tapDownTimer expiration, it should forward the next TapCancel event as
well to maintain a valid input stream. The rest of the tap ending events
should get suppressed till the next TapDown event.

BUG=674602
TEST=TapSuppressionControllerTest.GFCAckBeforeTapSufficientlyLateTapCancel

Review-Url: https://codereview.chromium.org/2613533003
Cr-Commit-Position: refs/heads/master@{#441396}

This change replaces the implementation in SkImageEncoder_none.cpp with
an implementation that allows the layer above to define an image
encoding function.

Background:  Skia's (experimental) XPS backend needs a PNG encoder.
Skia for Chromium does not compile its PNG encoder, but there is one
available in Chrome's gfx component.  To make layering work right,
I allow the layer above skia (gfx) to define an encoding function
that can be installed into skia.

TODO: initialize the function pointer in printing process.

Also: Revert "SK_SUPPORT_LEGACY_IMAGE_ENCODER_CLASS"
This reverts commit 1430e85b.

BUG=chromium:616763

Review-Url: https://codereview.chromium.org/2527833002
Cr-Commit-Position: refs/heads/master@{#441395}

Also clean up/streamline AppListView.
1. Remove code that supported arrows + view anchoring
2. Remove code that supported !CrOS
3. Remove dead code for making bubble borders accept events
4. Remove AppListViewObserver which is dead and who knows what it was used for.
5. Stop building //ui/app_list on all aura (just build on CrOS)

BUG=608852
TBR=derat@chromium.org

Review-Url: https://codereview.chromium.org/2588103004
Cr-Commit-Position: refs/heads/master@{#441394}

WebControllerProvider is not used anymore, it can be removed.

BUG=546231

Review-Url: https://codereview.chromium.org/2612433002
Cr-Commit-Position: refs/heads/master@{#441393}

BUG=675977

Review-Url: https://codereview.chromium.org/2612023003
Cr-Commit-Position: refs/heads/master@{#441392}

Reland [Mojo Video Capture] Replace method OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt()

This is exactly the same as reviewed previously
https://codereview.chromium.org/2592303002/

The reason for the revert was a crash in a performance test on Android, which
pointed to a bad file handle while Mojo-unwrapping a shared buffer. This was
most likely caused by the same bug 675528 that was just fixed for the previous
CL1.9.8. I ran the test on a local Android device an confirmed that it is no
longer crashing.

Description of original CL:

In interface media:VideoCaptureDevice::Client, replaced the method
OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt(). Compared to
method OnIncomingCaptureBuffer(), the VideoFrame parameter in
OnIncomingCapturedVideoFrame() was only used for passing along a bit of extra
information, namely a custom |visible_rect| as well as some
|additional_metadata|. The new method makes the intent clear and eliminates the
need for passing a media::VideoFrame that is partly redundant with the also
passed media::VideoCaptureDevice::Client::Buffer.

This CL breaks the video_capture_unittests, because current implementation of
the video_capture service wants to use VideoCaptureDeviceClient with buffers
that are backed by MojoSharedMemoryBufferTracker instances instead of the "regular" shared memory buffers. With this CL, VideoCaptureDeviceClient is
dropping support for this. We are working towards making the video_capture
service work with the regular buffers. To keep CLs small, we defer changes
to the service to after refactorings of VideoCaptureController and
VideoCaptureManager are complete and deactive the video_capture_unittests
temporarily. This is acceptable for the time being, since they are not run on
the bots yet. The CL that re-enables them is currently labeled CL1.9.22 in the
design doc.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.9

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*",
  video_capture_unittests,
  Apprtc loopback on Debug,
  Desktop Capture Example extension on Release

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2592303002
Cr-Commit-Position: refs/heads/master@{#441391}

Caret blinking is an internal feature, so move it to the unpecced timer
task queue for now. In the future, this may change to be driven by
BeginFrame updates.

Similarly, spellcheck is also an internal feature of Chromium, so it
also uses the unspecced timer task queue.

BUG=624694

Review-Url: https://codereview.chromium.org/2612713002
Cr-Commit-Position: refs/heads/master@{#441390}

BUG=655311

Review-Url: https://codereview.chromium.org/2594393003
Cr-Commit-Position: refs/heads/master@{#441389}

It is equivalent to checking the result of GetNativeDrawingContext(), so
do that instead, in NativeThemeWin::Paint().

Also remove an unused param of NativeThemeWin::PaintIndirect().

BUG=675977
R=reed@google.com

Review-Url: https://codereview.chromium.org/2610003002
Cr-Commit-Position: refs/heads/master@{#441388}

RecentTabsManager#getCurrentlyOpenTabs() always returns null,
and from that point on all this other code seems to be unused.

BUG=659631

Review-Url: https://codereview.chromium.org/2604453004
Cr-Commit-Position: refs/heads/master@{#441387}

Revert of [Android] Disable mid perf run device recovery on n7 devices. (patchset #2 id:20001 of https://codereview.chromium.org/2606343003/ )

Reason for revert:
Did not fix the issue.

Original issue's description:
> [Android] Disable mid perf run device recovery on n7 devices.
>
> Speculative disabling to see if it causes failures to stop.
>
> BUG=667470
>
> Committed: https://crrev.com/3b402227aa7e5c1851893cf8d7090dc456af8ac6
> Cr-Commit-Position: refs/heads/master@{#441217}

TBR=mikecase@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=667470

Review-Url: https://codereview.chromium.org/2614723002
Cr-Commit-Position: refs/heads/master@{#441386}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a559520b..652319fc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2615633003
Cr-Commit-Position: refs/heads/master@{#441385}

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2609423002
Cr-Commit-Position: refs/heads/master@{#441384}

Only the tests using Audit are converted here, using the script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
done

Additional manual changes were needed to replace methods defined by
js-test.

Expected results files also removed.

BUG=676355
TEST=audiobuffer-copy-channel.html, audiobuffer-getChannelData.html

Review-Url: https://codereview.chromium.org/2593083002
Cr-Commit-Position: refs/heads/master@{#441383}

This change adds retry logic for applying resolution changes when the session
is first started.  The RDP API we rely on can return E_UNEXPECTED for a few
seconds after the user logs in.  This is not documented on MSDN but has been
experienced by other users of the API.  This change adds a timer which is
used to retry the resolution update until it succeeds or reaches the max
number of attempts.  Once the user is logged on, we do not use the retry
logic as calls after that point are expected to succeed.

BUG=392220

Review-Url: https://codereview.chromium.org/2600623002
Cr-Commit-Position: refs/heads/master@{#441382}

BUG=678108
TEST=manual

Review-Url: https://codereview.chromium.org/2614583002
Cr-Commit-Position: refs/heads/master@{#441381}

This CL removes the temporary hack to disable the sync confirmaton page
on linux and windows as the sync confirmation dialog is browser modal on
these platforms and thus the dialog is no longer dismissed on page
navigation.

BUG=657924

Review-Url: https://codereview.chromium.org/2614703002
Cr-Commit-Position: refs/heads/master@{#441380}

https://pdfium.googlesource.com/pdfium.git/+log/4741b291f462..fff400a5df03

$ git log 4741b291f..fff400a5d --date=short --no-merges --format='%ad %ae %s'
2017-01-04 tsepez Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2615533003
Cr-Commit-Position: refs/heads/master@{#441379}

This was a result of the FRE refactor work for first run experiments,
which had moved FirstRunActivity creation to be before native init.
As a result of that, the removeBackground() ChromeTabbedActivity ended
up happening when the activity was not foreground, which apparently
caused the bug.

This change fixes it by making the removeBackground() call happen
later, when the ChromeTabbedActivity is visible. The logic is such
that we do it once both native init and window focus events have
been received.

BUG=673831

Review-Url: https://codereview.chromium.org/2613573003
Cr-Commit-Position: refs/heads/master@{#441378}

BUG=None

Review-Url: https://codereview.chromium.org/2612733004
Cr-Commit-Position: refs/heads/master@{#441377}

https://skia.googlesource.com/skia.git/+log/9ea894b4d030..671163843681

$ git log 9ea894b4d..671163843 --date=short --no-merges --format='%ad %ae %s'
2017-01-03 caryclark fix fuzz

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2615633002
Cr-Commit-Position: refs/heads/master@{#441376}

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None

Review-Url: https://codereview.chromium.org/2609213002
Cr-Commit-Position: refs/heads/master@{#441375}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a067dd2f2b17..9e6944a8f310

$ git log a067dd2f2..9e6944a8f --date=short --no-merges --format='%ad %ae %s'
2017-01-04 perezju [dashboard] Do not use --story-filter on webrtc.* benchmarks

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2617483002
Cr-Commit-Position: refs/heads/master@{#441374}

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes. Also
remove the helper method ::IsOffTheRecordSessionActive and directly
call the real implementation from BrowserListIOS.

Convert naked "new" call initializing std::unique_ptr<> to instead
use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)").

BUG=676278

Review-Url: https://codereview.chromium.org/2615433002
Cr-Commit-Position: refs/heads/master@{#441373}

This CL prefixes the DidStartLoading and DidStopLoading methods in
RenderFrameImpl, so they don't conflict with the WebFrameClient versions
which currently start with lowercase letter. As part of the Blink rewrite
to match Chromium style, those will be conflicting.

BUG=582312

Review-Url: https://codereview.chromium.org/2612653002
Cr-Commit-Position: refs/heads/master@{#441372}

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Update includes from webrtc/ to third_party/webrtc
* Update includes of webrtc/base/logging.h to third_party/webrtc_overrides/webrtc/base/logging.h
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539

Review-Url: https://codereview.chromium.org/2443903004
Cr-Commit-Position: refs/heads/master@{#441371}

Local tests on a svelte device show the test is no longer failing.

BUG=676338

Review-Url: https://codereview.chromium.org/2601533002
Cr-Commit-Position: refs/heads/master@{#441370}

Most of this CL was automated using the following commands:
tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges
tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType

Also renames some methods to have less generic names, now that they are no
longer in the ios_internal namespace.

BUG=677941

Review-Url: https://codereview.chromium.org/2608253003
Cr-Commit-Position: refs/heads/master@{#441369}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0ef5214e..a559520b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2613713003
Cr-Commit-Position: refs/heads/master@{#441368}

This helper no longer provides any scoped/RAII functionalty, and can be
replaced with a GetNativeDrawingContext() function.

BUG=675977
R=reed@google.com
TBR=sky@chromium.org,danakj@chromium.org

Review-Url: https://codereview.chromium.org/2613583002
Cr-Commit-Position: refs/heads/master@{#441367}

- Remove mixin code as we don't support those cases
- Remove markAndTraceWrappers as it is not needed anymore

BUG=468240

Review-Url: https://codereview.chromium.org/2609383002
Cr-Commit-Position: refs/heads/master@{#441366}

Even with a password, the encryption scheme used here is really not what
we'd want people to use. This does two things:

1. Cut down on the number of ways to use ExportEncryptedPrivateKey and
   makes it less likely someone will mistakenly use it for security
   purposes.

2. When we ported to BoringSSL, we added "raw" versions of
   PKCS8_{encrypt,decrypt} to account for confusion about two ways to
   encode the empty password. But PKCS8_{encrypt,decrypt} already
   handled this by treating NULL and "" differently. Limiting to just
   the empty password lets us trim BoringSSL's API surface in
   preparation for decoupling it from crypto/asn1.

BUG=603319

Review-Url: https://codereview.chromium.org/2608453002
Cr-Commit-Position: refs/heads/master@{#441365}

Switch to using a 'mere' HashSet<> for these event listeners. Mainly
done to diagnose GC instability, but removing the use of an involved
abstraction like HeapListHashSet<> is something wanted regardless.

R=
BUG=677654

Review-Url: https://codereview.chromium.org/2609413002
Cr-Commit-Position: refs/heads/master@{#441364}

The expected error message on Mac is:
  fatal error: call to implicitly-deleted copy constructor
On Linux, it's:
  fatal error: call to deleted constructor

BUG=676800

Review-Url: https://codereview.chromium.org/2603573002
Cr-Commit-Position: refs/heads/master@{#441363}

It turns out the tests are flaky.

TBR=guidou@chromium.org
BUG=611620

Review-Url: https://codereview.chromium.org/2615583002
Cr-Commit-Position: refs/heads/master@{#441362}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/661a53a2..0ef5214e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2610153002
Cr-Commit-Position: refs/heads/master@{#441361}

Hitting the escape key on the bluetooth keyboard closes the history and the
reading list views.

BUG=676994

Review-Url: https://codereview.chromium.org/2611543002
Cr-Commit-Position: refs/heads/master@{#441360}

This CL adds an observer for the web contents of the sign-in email
confirmation dialog and closes the sign-in confirmation dialog when
the renderer process is killed.

BUG=671983

Review-Url: https://codereview.chromium.org/2603493003
Cr-Commit-Position: refs/heads/master@{#441359}

In-between TraceEpilogue and performCleanup the write barrier used to fire in
the tri-color marking scheme because we eagerly mark but lazily cleanup. This
change avoids marking new headers after TraceEpilogue has been called.

BUG=468240, 676700

Review-Url: https://codereview.chromium.org/2609883003
Cr-Commit-Position: refs/heads/master@{#441358}

Found while checking performance for issue 603621.

Style sharing is done during style recalc at which point we know that
the active style is up-to-date. Instead of using the API for
document.styleSheets, compare active stylesheets in ScopedStyleResolver
directly.

BUG=603621

Review-Url: https://codereview.chromium.org/2610513003
Cr-Commit-Position: refs/heads/master@{#441357}