GitLab

When a sequence of preserved space is longer than the line size, we are
handle it as trailing space. The HandleTrailingSpace function creates a
new ItemResult to handle this trailing preserved spaces. In general, it
doesn't need to enable the 'should_create_line_box' flag, since the
previous ItemResult associated to that line already has it.

However, in case of a ItemResult longer than the line, we would end up
with this newly created instance, which flag is disabled by default.

This CL enables the 'should_create_line_box' flag for ItemResult with
'end' offset exceeding the line size. This ensures that lines that are
all preserved spaces will required a LineBox, hence it should account
for computing the box's size.

Bug: 1136748
Change-Id: I0df602d3c13129e4369e351c142601c1806214c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503550
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821530}

Currently, when Sync tries to delete the Default Search Provider,
Chromium will uniquify the keyword by appending an underscore, and send
sync an ACTION_ADD for the deleted engine.

The CL that originally added this logic was here:
https://chromiumcodereview.appspot.com/10694096

In that CL, there's not an explicit reason why the client is sending
an ACTION_ADD to undelete the deleted entry, but I suspect this is
attempting to make sure that all clients have the same set of search
engines.

Instead, I recommend the browser ignore the ACTION_DELETE and leave the
existing search engine entry alone. It's not a big deal to have a
lingering deleted search engine in this edge case, and it's certainly
better than creating a duplicated search engine with an underscore
appended to the keyword.

If we were really extremely clever, we could mark the attempted deleted
TemplateURL as pending deletion, and then later delete it when the
default provider pref update comes in, but I think that's
over-engineering and creating potentially more problems.

Bug: 1022775
Change-Id: Ibc5ab594b5506d27b32334d8f34696479c504c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454833Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821529}

Currently, in Chrome when trying to cast the screen we check for
permission and tell the user to check System settings if we aren't
allowed to cast the screen.  However, apps don't show up in System
settings until the user has already approved or denied permission for
them through a modal dialog that only appears if you try to capture a
stream in your application without checking permission.

This patch adds a call to CGDisplayStreamCreate in a new method in
permissions_utils.h,  TryPromptUserForScreenCapture.

Bug: 1139695
Change-Id: I719aa6fb4188e723faa1fee3d3b51243edb0059e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495824
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821528}

Fixes:
- Close button shifting on focus
- Button ripple behavior for different platforms
- Remove outline from focused tab search item

Related CL:
https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3314941

Bug: 1128599
Change-Id: I5904e2050b3714b38d4b928197512e81714878f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503193Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821527}

Bug: 984851
Change-Id: Iea0ec1919e8950adb01e9e2410f5268eea9d68af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503326Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#821526}

Screenshot: http://shortn/_mzhvW5izxD

Bug: 1059779
Test: browser_tests --gtest_filter=ScanningUIBrowserTest.All
Change-Id: I21ca4135a98534b83ddbf7f419ad6b28f03686ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500950Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Michael Checo <michaelcheco@google.com>
Cr-Commit-Position: refs/heads/master@{#821525}

Change expriy date of Apps.AppList.SearchSuccess.Apps

Bug: 1127943
Change-Id: I2bb10c24fbdcab8c80bd654082a827ea45449c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500641Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821524}

To help declutter the top-level chromeos/dbus directory, move
all of the lorgnette-related files to their own directory.

Bug: b:169573779
Change-Id: I4937b50c4ef1dffaf677c090aa4e864367555040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495354
Commit-Queue: Paul Moy <pmoy@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821523}

It must be a list of simple tokens from a known list, formatted as an
HTTP structured header list. All unknown items are ignored, including
parameterized items, inner lists, and non-tokens.

Unit tests included.

This is the "parser" described in:
  https://docs.google.com/document/d/1IpqYg1Y4BX9U9LBELNUAaKlygFvOKo6MAmS8nXMLVlE/edit

Bug: 1141083
Change-Id: I914220bf6110c789c921965b65100823b9a11df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492882
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821522}

Bug: 1140015
Change-Id: Ife0330b6c187d5693fdc24c44b7930416d35eb5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502370Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821521}

Using wpt-import in Chromium b2e824a0.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: I17a05b3f9ae48399ca78edf6708adc5a4875c1d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503352Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821520}

startup

Bug: b/168173947
Test: manually tested. See bug for repro step.
Change-Id: Ia90d8373a88ee2230444e069d93000d07aa9f5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501965Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821519}

This CL replaces all uses of blink::Manifest::ImageResource::Purpose with
blink::mojom::ManifestImageResource_Purpose in order to reduce type
conversion between them.

Bug: 919392
Change-Id: I8f68fa8ae09df7550b48384dd77f6eec7637a1a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500686Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#821518}

* Changed all Chromium projects using |dynamic_guid| to use the new
|dynamic_guids| multiple guid substitution enhancements.
* Removed the legacy |dynamic_guid| code.

Bug: 1109612
Change-Id: I2fb012884db39ad5489e988aef75113dd8c0258f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500952Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Joe Downing <joedow@google.com>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821517}

Add a SharedImageInterfaceInProcess to use for SkiaRenderer on Viz.
This is put on the shared data structure of
DisplayCompositorMemoryAndTaskController.

R=rjkroege, Khushal
TBR=boliu@chromium.org

Bug: 1042538
Change-Id: I37e2778e4c5576e4f9fbd33e0997d9e93030ca19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485281
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821516}

This includes the basic functionality for commander (sans multi-step
commands).

Styling is WIP.

Bug: 1014639
Change-Id: I809d11c851df0b4849bdb3c8ac0930ed37308d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468680Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821515}

Sometimes the first attempt to create a simulator might fail. Add
second attempt when first one fails.

Bug: 1119591
Change-Id: Ie516a664c919160233b81dad995b04a3d23ceae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367778Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821514}

Remove CheckUmaHistogramChangesOnUpload. This check is only based on
simple regex match so it's not that reliable and might report a lot of
false positives.

The best way to do this is to merge all xmls and extract all histogram
names from it. It can be done in a way that similar to
https://source.chromium.org/chromium/chromium/src/+/master:PRESUBMIT.py;drc=015291ed0b8742662afb9431f176f033a0504a44;l=3610

However, merging xmls and extracting names is an expensive operation so
in order not to confuse users, we should remove this check for now and
we can re-implement a similar check once we have an efficient way to do
so.

Bug: 1138055
Change-Id: Iad81a9331d971b9260559b0e33fcced149c5334c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500269
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821513}

Previously a new IpcNetworkManager was created for each PeerConnection.
IpcNetworkManager calls StartNetworkNotifications on the
p2p_socket_manager_ which is not re-created for each PeerConnection. The
second call failed and ended up blocking ice candidate gathering because
it was waiting for the network list to come through which it never did.
The simple solution here is to just re-used the IpcNetworkManager for
each new peer connection in the same way the socket_factory_ is reused.
See the bug for more details.

Fixed: 1142717
Change-Id: I033e986361a7c3a7acce3a7dea12e1f51c3b3b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503889Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#821512}

Bug: 1141739
Change-Id: I3b41c6328bf328b6734c6eadc422c45534fe42da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503330Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821511}

This is required because when the virtual desks takes screenshot,
old layer is already detached, so it'll be copyed as a black.

Bug: 1083951
Test: maually testsed. See bug for repro step.

Change-Id: Ia26398d2d88557a70a970748623f665ac065c46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501970Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821510}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ib233eb5054f8c8d04e34228e04f9ddaee977208e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821509}

All TableNG painting related code:

- NGTablePainter family of painters
- Legacy methods that support painting
  - getting correct border widths for collapsed borders.
  - invalidation in StyleDidChange
  - visual overflow for table/row
  - misc paint-specific legacy methods (ex: BackgroundIsKnownToBeOpaqueInRect)

Bug: 958381
Change-Id: I6e6b5d0145e51e8819df7958578505a2d04bbcea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494024
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821508}

Bug: 772945
Change-Id: Iade9be1584a696fe14680b829085c02add99d64a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502779
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821507}

Change-Id: I014d211b395ec217c72c7b1ff5105a2f44fbfdac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503817
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821506}

This reverts commit 80a372d9.

Reason for revert: To diagnose performance regressions.

Original change's description:
> Remove GraphicsLayer::SetNeedsDisplay()
>
> With unified PaintController, to support SetNeedsDisplay() we would
> need to add PaintController mechanism to invalidate all display items
> in a range for a GraphicsLayer. Removing SetNeedsDisplay() can avoid
> that. We instead use the normal paint invalidation code path. For
> needed invalidation, now invalidate the display items of and in the
> GraphicsLayer. Some invalidations are not needed because we have
> already invalidated the DisplayItemClients.
>
> Also rename SetContentsNeedsDisplay() to InvalidateContents(), and
> SetNeedsDisplayInrect() to InvaldiateRaster() which is only called by
> RasterInvalidator.
>
> Bug: 1132717
> Change-Id: I535cdcc7ee1d07e23a490fdf2aa267573a54d0ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478026
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#818673}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1132717, 1140634
Change-Id: Ife45cc8b39b6aac762f228d80634a33b6b4889b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503322Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821505}

R=sky
BUG=1066670

Change-Id: Ibced1b861c9090d4a8b5d49b81f62c4aeec1a6ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473839
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821504}

Rename local search service proxy for the new LSS.
Please see go/lss-sandboxing-impl for more details

Bug: 1137560
Change-Id: I92a9b38f425462f6b771e835f6afd0cc4666b3a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500382Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Rachel Carpenter <carpenterr@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821503}

Bug: 1133016
Change-Id: Ia40222beff775014959a6b52ce25ef36893d713d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503816Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821502}

Bug: None
Change-Id: I231f11b9c2ac392473d6ef837fafdc12a8be7478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497902Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821501}

* Added support to prefix replacement guids with a fixed
'PLACEHOLDER-GUID-' string in the template file. This makes it easier to
see the GUIDs that are being replaced.
* Added support to regenerate the checked-in IDL files with the
replaceable guids. This is needed when the IDL template changes and the
checked-in IDL files need to be refreshed.

Bug: 1109612
Change-Id: Ie113d2504c1a44f408641e34422bb081733a7458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495396Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821500}

The original cl was reverted due to test failures on dbg build
(CL:2500688) - landed CL:2503628 to address the failures.

Introduces a concept of partially initialized HoldingSpaceItem - this
state will be used when loading items from persistent storage in case
the item file system URL cannot immediately be resolved (e.g. if the
associated mount point hasn't been loaded yet).
HoldingSpacePersistenceDelegate will deserialize persisted items into
partial state when they are first loaded from the storage, and
"finalize" them when their file system URL can be resolved.

Compared to an alternative approach where items whose initialization has
to be deferred, this approach keeps the order in which items are added
to the model.

Updates holding space UI not to show partially initialized items.

BUG=1140150

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493323
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#821024}
Change-Id: I53bf0140a92e702a9baf59fd0a8be4739973a182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504070
Cr-Commit-Position: refs/heads/master@{#821499}

This CL updates the VideoCaptureDeviceMFWin/VideoCaptureDeviceFactoryWin
implementations to use an NV12 output buffer format when MF D3D11
capture is enabled (for zero-copy capture).

This requires ensuring that the input media type set on the Media
Foundation CaptureEngine preview sink is NV12. In order to do this, we:
1. Expose PIXEL_FORMAT_NV12 as the sole supported capture pixel format
   from VideoCaptureDeviceFactoryWin::GetSupportedFormatsMediaFoundation
   when hardware capture is enabled.
2. Ensure that the VideoCaptureDeviceMFWin implementation sets an MF
   subtype of MFVideoFormat_NV12 on the video capture preview sink when
   the requested capture pixel format is PIXEL_FORMAT_NV12.

This CL also makes some other minor changes to helpers in
video_capture_system_impl.cc and capability_list_win.cc to prevent the
NV12 pixel format from being filtered out before reaching the
VideoCaptureDeviceMFWin implementation.

Change-Id: Ie9bb7c9ef35281b4edecb3007f16faae2a892ac7
Bug: 1120900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434924
Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#821498}

In order for OutputSurface and OverlayProcessor to work together, they
need to share the same memory and task controller. This CL uses the
same data structure for Android WebView to share these controls, so
that WebView could use this to enable overlay in the future.

R=boliu, rjkroege
TBR=vollick@chromium.org

Bug: 1093440
Change-Id: I2bcefe178906ede25dc0b962448e2ba6168128a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450494
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821497}

crrev.com/c/2490252 adds new portal states when the connection state is
kPortal. Integrate these new states into this routine.

BUG=chromium:956783
TEST=unit_tests --gtest_filter=CaptivePortalRoutineTest.*

Change-Id: I181127d60179e1439a1fb39a9bc5994ee631c871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499623Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821496}

Also fix 1 test to make it pass.

I expect most of these were fixed by the proactive browsing instance
swap work, although
NavigationControllerBrowserTest.NoHistoryOnNavigationToSameUrl is a
bit of a puzzle. There is still another reload failure remaining.

Bug: 1102358,1100745,1068965,1064944
Change-Id: I0026f32f7f0ab6a3d75466b53a5815d8bff5facd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494244
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821495}

Currently overview can create overview items for transient children of
the browser. This can cause bugs where if the transient child is
destroyed, its respective overview item is as well. This leaves the
transient root of this child without an overview item, resulting in
this bug.

This CL makes it so overview uses the transient roots of any transient
child returned by BuildMruWindowList() to create overview items. It also
prevents MessageBoxDialog from closing if it deactivates but is being
shown in overview.

Test: manual + added
Bug: 972015
Change-Id: I90b2f94528a4a695a784fd5a1596111dc0103021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495642
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821494}

TetherControllerImpl will now mark the tether feature ineligible if
it is notified by the PhoneModel that the SIM state has changed to
anything other than kSimWithReception.

Fixed: 1140812
Bug: 1106937
Change-Id: Ia18c5e06c57805541b03b29afea1762e85b8304f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500182
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821493}

This CL moves two helper functions that extracts IDs and creates trials
and associate IDs into their own file.

Bug: 1134444
Change-Id: I056871f2245ba3e9c72a05ffd019f2e96499a45e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500434
Commit-Queue: Karthika Pai <karthikapai@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821492}

Add support for passing in a progress callback to
LorgnetteScannerManager::Scan(). This allows clients to receive progress
updates for in-progress scan jobs.

Bug: 1059779
Change-Id: Ib787c925fbd8033f85e349cb9387168306cd83e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503313Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821491}