Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 14 Mar, 2020 32 commits
  3. 13 Mar, 2020 8 commits
    • Vitaly Buka's avatar
      Fix blink_perf.layout performance with -ftrivial-auto-var-init=pattern · 9b5df929
      Vitaly Buka authored 
      NGLineLayoutOpportunity is large class but inlining
ComputeLineLayoutOpportunity lets compiler completely eliminate stores.

The rest is vectors or classes with vectors.

https://pinpoint-dot-chromeperf.appspot.com/job/153f79d3620000

Bug: 1055705

Change-Id: I09401148710df3bb4b830835651286036706ee2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101943
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750350}
      9b5df929
    • chromium-autoroll's avatar
      Roll src/third_party/swiftshader 7d09824f5aa1..f6e439f96c7f (1 commits) · ea8d10bb
      chromium-autoroll authored 
      https://swiftshader.googlesource.com/SwiftShader.git/+log/7d09824f5aa1..f6e439f96c7f

git log 7d09824f5aa1..f6e439f96c7f --date=short --first-parent --format='%ad %ae %s'
2020-03-13 sugoi@google.com Compile Vulkan library with Subzero in Chromium

Created with:
  gclient setdep -r src/third_party/swiftshader@f6e439f96c7f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1060139
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Id3f26c47fd2465efdad1d73edc66045d5ec40fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103363Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750349}
      ea8d10bb
    • Mila Green's avatar
      Dial the correct updater xpc service. · e33b3916
      Mila Green authored 
      Refactor code for mach service name. Call the common code from all appropriate sites.

Bug: 1048653
Change-Id: Iccaa5cc6703152a2f4ab24e289008dbe12331473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101848Reviewed-by: default avatarSorin Jianu <sorin@chromium.org>
Commit-Queue: Mila Green <milagreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750348}
      e33b3916
    • Samuel Huang's avatar
      [SuperSize] Refactor file_format.py, and fix redundant space added. · 07a432de
      Samuel Huang authored 
      This CL refactors file_format.py, so the code can be more easily
transitioned to Python 3. Specifically:
* Add class _Writer that wraps |file_obj.write()| and supplies more
  interfaces for different write cases.
  * Specifically, |file_obj| will require type byte, but for most cases
    the caller supply str.
* Split write_numeric() into smaller pieces, using generators.
  * Write numbers to line: _Writer.writeNumberList().
  * Delta encoding: gen_delta() (optionally).
  * Visit |group| and map with |func|: itertools.imap().
  * New helper: write_groups(), to loop over sections & choose delta.
* Update callers to call the proper interfaces.

Relevant bugs and fixes:
* In Python 2, json.dumps(..., indent=2) injects extra space at end of
  each line. This is fixed in Python 3, thereby causing superficial
  differences in .size (and .sizediff) files.
  * Fix: Manually remove space. This causes minor .size file changes.
* cStringIO.StringIO disappears in Python 3 (will need io.BytesIO).
  The previous _LogSize() check for |fileno| won't work: The pass will
  pass, but for io.BytesIO (or io.StringsIO), the function call fails.
  * Fix: Simply use |file_obj_.tell()| for all cases.

Other bug fixes:
* nm.py: Fix missed-a-spot error in "concurrent" -> "parallel" change.

Bug: 1054018
Change-Id: I2b2c34cc43d4bffd6e1239cd2c0817711e47d26d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102589
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750347}
      07a432de
    • Kevin Babbitt's avatar
      Enable web content accessibility when any UI Automation fragment root is requested · c3f53423
      Kevin Babbitt authored 
      One of our detection points for enabling web content accessibility was
when a UI Automation element was requested from the legacy window. On
non-desktop Windows devices such as Hololens where HWND support is
limited, the OS may not talk to the legacy window, and it won't hit any
of the other existing detection points either, since they're tied to
MSAA/IA2 and UI Automation is the only supported API on these devices.

This CL moves the legacy window point of detection to where we obtain
a platform object for any fragment root, including either the top-level
window or the legacy window.

Bug: 928811
Change-Id: I8867258f4d1e2109c27066f978e9f5cf70766137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101257Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: default avatarIan Prest <iapres@microsoft.com>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#750346}
      c3f53423
    • Manu Cornet's avatar
      CrOS Shelf: Add a test that would have caught crbug/1050383c · 1d2286a2
      Manu Cornet authored 
      This bug used to happen when switching back to clamshell mode from
tablet mode: the hotseat's translucent background failed to get hidden.

The bug has been fixed but this will prevent future regressions.

Bug: 1050383c
Change-Id: Id9721209c2144fade3248f9d236306e97041e41a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102552Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750345}
      1d2286a2
    • dpapad's avatar
      Settings: Remove obsolete Polymer3 related TODO. · 1fc9535a
      dpapad authored 
      Bug: 1026426
Change-Id: I21afcc4961fc68eded190d8cbe8b72d2796aab6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103145
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750344}
      1fc9535a
    • Andrey Kosyakov's avatar
      Revert "[DevTools] Roll inspector_protocol (Chromium)" · d8d217c2
      Andrey Kosyakov authored 
      This reverts commit c29bddc2.

Reason for revert: this has broken exposeDevToolsProtocol somehow.

Original change's description:
> [DevTools] Roll inspector_protocol (Chromium)
> 
> Upstream PR:
> Introduce a crdtp/dispatch.{h,cc} library.
> https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1974680
> 
> New Rev: 8c2064ea99cffdb5647760ad3953c43e612e07fc
> 
> Notable downstream changes:
> - ChromeDevToolsManagerDelegate::HandleCommand no longer carries
>   a method. Reason being, the shallow parser (crdtp::Dispatchable)
>   should be efficient enough to parse an incoming message a couple
>   of times, e.g. once for the content layer and once for the
>   embedder, and if we felt differently then we'd quite possibly
>   want to carry more than just the method - e.g., we'd want to also
>   pass the params. Anyway, for now simplifying this interface.
> - crdtp::FrontendChannel::FallThrough; here, it's advantagueous
>   to keep the method around, but now it's a crdtp::span. This is
>   much better than const std::string& because the generated code
>   knows exactly which method is going to fall through and we
>   can pass a C++ string literal via this span.
> - The crdtp/dispatch library presents a somewhat different surface
>   between the UberDispatcher and the session implementations.
>   The session implementations are responsible for creating a
>   crdtp::Dispatchable instance (the shallow parser) which
>   it then hands to the dispatcher for dispatching. Rather than
>   querying for whether it can dispatch and then doing it,
>   the result of the Dispatch indicates whether a method was
>   found and can be executed. There's no more need to instantiate
>   protocol::Value in a devtools session class.
> - Since the dispatch library uses crdtp::span to represent
>   method names, we no longer need to reference platform specific
>   routines for finding strings and making substrings. As a result,
>   v8_inspector_string.h is losing a few more methods
>   (and same for base_string_adapter_h.template).
> - crdtp::DispatchResponse (also known as protocol::Response) has
>   some renames for consistency (
>   Response::Error -> Response::SeverError,
>   Response::OK -> Response::Success). Touches all domain handlers
>   but is mechanical.
> - All protocol error messages, such as the parameters passed
>   to DispatchResponse::ServerError are required to be UTF8 strings,
>   even for Blink, so when code generates them as WTF::String,
>   we convert them to std::string using WTF::String::Utf8()
>   before passing them to DispatchResponse::ServerError.
> - We're better about checking messages and sending errors when we
>   can't parse them - esp. we no longer drop messages on the floor
>   if we can't make sense of them; the LOG statements are gone,
>   because we can either send an error or assume that we've
>   previously parsed the message elsewhere and put a DCHECK (e.g.,
>   a message received by blink has always been shallow-parsed by the
>   browser before).
> - DevToolsAgentHost::DispatchProtocolMessage no longer has a boolean
>   return value. Reason being, it's not well defined what the
>   boolean should indicate. If we reject the message and send
>   an error, arguably we've also handled it. And of course, we
>   always do that (now). So it's not useful to generate or check
>   this return value, and there is only one DCHECK on it currently,
>   which is also not covered by tests.
> - content::DevToolsSession uses binary searches to match method names
>   (e.g. in ShouldSendOnIO).
>   This is because I've switched the method names to span, and
>   implemented similar searches for the dispatching library, so
>   it's best to be consistent. It will also scale better if we add
>   more methods.
> - The additional unittests added to the CRDTP library upstream cover
>   shallow parsing, dispatching, etc. and are now also part of
>   the content_unittests.
> - Improves Android binary size by about 36k, by reducing code
>   duplication. There's now just one UberDispatcher, for example,
>   as opposed to one for blink, one for content, one for headless,
>   one for chromium, ...
> - Speeds up execution by 1-2% (based on internal measurements),
>   because message serialization no longer takes a detour via
>   protocol::Value.
> 
> Change-Id: I422fe527d6f8a6ffb098b3992728ecba408b571f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047966
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Commit-Queue: Johannes Henkel <johannes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750284}

TBR=dgozman@chromium.org,caseq@chromium.org,gogerald@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org

Change-Id: I122738b9057cf6ab48b904a6ee0e67c7c9610b95
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103517Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750343}
      d8d217c2