GitLab

1) glGetUniformBlocksCHROMIUM

This is Chromium GPU command buffer internal command. The purpose is to
fetch UniformBlock related information in a linked program from service side
in one command instead of multiple ones.

2) glGetUniformBlockIndex
3) glGetActiveUniformBlockName

Get value from client side cache (retrieved by GetUniformBlockCHROMIUM);
if that fails, send the command to service side.

What's missing: glGetActiveUniformBlockiv.  It requires some extra tuning, so
leave that for a separate CL.

BUG=453127,429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/895933004

Cr-Commit-Position: refs/heads/master@{#314897}

A more efficient way to draw a simple oval with alpha.
It saves memory too since the view's layer no longer needs a backing buffer.

Also simplified fade out animation code when dismissing.

Review URL: https://codereview.chromium.org/894423003

Cr-Commit-Position: refs/heads/master@{#314896}

Add new flag to disable screen orientation locking. Update ScreenOrientationController to be enabled by default, and to check flag state for disabling.

TEST=Set flag to check feature was disabled.
BUG=396760

Review URL: https://codereview.chromium.org/901963002

Cr-Commit-Position: refs/heads/master@{#314895}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/abac64f..d953d07

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/902793006

Cr-Commit-Position: refs/heads/master@{#314894}

Also changes copyright notices to the new style.

BUG=455409

Review URL: https://codereview.chromium.org/885803003

Cr-Commit-Position: refs/heads/master@{#314893}

Also, try enabling swarming for base_unittests on CrOS MSan.

BUG=454828
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/899283003

Cr-Commit-Position: refs/heads/master@{#314892}

BUG=455467

Review URL: https://codereview.chromium.org/872033003

Cr-Commit-Position: refs/heads/master@{#314891}

This CL breaks out into its own function the parsing of a DictionaryValue to
AlternateProtocolInfo.  This is only called once now, but as soon as we start
storing multiple entries per server, we'll need to call it multiple times.  See
https://codereview.chromium.org/665083009/#ps460001.

BUG=392575

Review URL: https://codereview.chromium.org/897313002

Cr-Commit-Position: refs/heads/master@{#314890}

The change in the chrome_autofill_client.cc is needed to enable the autofill popup on
Mac.

BUG=447938
TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username
with an incorrect password. After the password error appears, you should be able
to autofill that username.

Review URL: https://codereview.chromium.org/866523002

Cr-Commit-Position: refs/heads/master@{#314889}

BUG=

Review URL: https://codereview.chromium.org/878413007

Cr-Commit-Position: refs/heads/master@{#314888}

R=kalman@chromium.org
BUG=none (yet)

Review URL: https://codereview.chromium.org/899163007

Cr-Commit-Position: refs/heads/master@{#314887}

BUG=385874
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/897133002

Cr-Commit-Position: refs/heads/master@{#314886}

Mechanical change that adds instrumentation required to locate the source of
jankiness (i.e. a long-running fragment of code executed as a part of the task
that causes jank) in the code. See the bug for details on what kind of jank we
are after.  A number of similar CLs were landed, and none of them caused issues.
The code of the instrumentation is highly optimized and is not expected to
affect performance. The code simply creates a diagnostic task which is identical
to ones created by PostTask or IPC message handlers.

This also updates the existing instrumentation for bug 418183 to include the bug
number everywhere.

BUG=418183,455423,455434,455469
TEST=none
R=vadimt@chromium.org
TBR=jochen, mmenke, rockot, thestig

Review URL: https://codereview.chromium.org/901773002

Cr-Commit-Position: refs/heads/master@{#314885}

Revert of Suppress accessibility events when user is navigating away. (patchset #6 id:100001 of https://codereview.chromium.org/830053004/)

Reason for revert:
NavigationAccessibilityTest.TestNavigateToNewUrl is failing on Win7 Tests (dbg)(1).

Sample failure:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35087

Original issue's description:
> Suppress accessibility events when user is navigating away.
>
> When the user navigates to a new page, stop sending accessibility
> events on the old page.
>
> BUG=421116,450409
>
> Committed: https://crrev.com/6ce40a1e561892849c1f6ac070dda140f6cc0115
> Cr-Commit-Position: refs/heads/master@{#314812}

TBR=nasko@chromium.org,dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=421116,450409

Review URL: https://codereview.chromium.org/892513004

Cr-Commit-Position: refs/heads/master@{#314884}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/797f58a..5e1378d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899333002

Cr-Commit-Position: refs/heads/master@{#314883}

This CL is an follow-up CL to crrev.com/861193007. This CL makes sure state
transitions and comments match the latest trace.

BUG=452657

Review URL: https://codereview.chromium.org/891013002

Cr-Commit-Position: refs/heads/master@{#314882}

A compromised renderer can pass an arbitrary |provider_id|, so we should ensure that |provider_host| is not NULL and remove the DCHECK.

See https://cluster-fuzz.appspot.com/testcase?key=4713217552023552

R=falken@chromium.org,nhiroki@chromium.org

Review URL: https://codereview.chromium.org/901243002

Cr-Commit-Position: refs/heads/master@{#314881}

The expectation is that GLSurface resize operations succeed, so pretend
that surfaceless resizes succeed as well, otherwise the state in
SurfacelessEGL will not be updated correctly.

BUG=none

Review URL: https://codereview.chromium.org/884183007

Cr-Commit-Position: refs/heads/master@{#314880}

QUIC Proxy servers are valid HTTP proxies and should be treated
as such. This is required for using Chrome with a QUIC-based data
reduction proxy.

BUG=343579

Review URL: https://codereview.chromium.org/880483004

Cr-Commit-Position: refs/heads/master@{#314879}

The eglWaitSyncKHR function should only be expected to exist if the
EGL_KHR_wait_sync extension is supported. The code prior to this patch
triggered a DCHECK if only the EGL_KHR_fence_sync extension was available.

BUG=None

Review URL: https://codereview.chromium.org/900233003

Cr-Commit-Position: refs/heads/master@{#314878}

$ git log c698ea2a7..e6677c870 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-02-05 maruel Further limit archival on 32 bits.
2015-02-03 maruel Update /get_slave_code to /bot_code new url.

R=vadimsh@chromium.org
BUG=419862

Review URL: https://codereview.chromium.org/895903004

Cr-Commit-Position: refs/heads/master@{#314877}

BUG=452602

Review URL: https://codereview.chromium.org/891703004

Cr-Commit-Position: refs/heads/master@{#314876}

BUG=455273

Review URL: https://codereview.chromium.org/904513002

Cr-Commit-Position: refs/heads/master@{#314875}

Revert of NaCl: Remove the IRT's Gyp dependency on libsrpc (patchset #1 id:1 of https://codereview.chromium.org/878623004/)

Reason for revert:

I was a bit too eager about removing the dependency on libsrpc.  I'm
preparing a NaCl change that will make the IRT depend on SRPC again
(https://codereview.chromium.org/883393005/), as a step towards
removing SRPC later.

Unfortunately, untrusted.gypi doesn't support transitive library
dependencies, so it's not enough just for the NaCl side to declare the
dependency on libsrpc.

Original issue's description:
> NaCl: Remove the IRT's Gyp dependency on libsrpc
>
> Since I removed the IRT's calls to NaClSrpcModuleInit() and
> NaClPluginLowLevelInitializationComplete(), the IRT no longer depends
> on SRPC.
>
> BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864
> TEST=build
>
> Committed: https://crrev.com/65a326a734d413e2124c6782b2e32a81ceca74c1
> Cr-Commit-Position: refs/heads/master@{#313664}

BUG=302078
TEST=build

Review URL: https://codereview.chromium.org/901053008

Cr-Commit-Position: refs/heads/master@{#314874}

With this change the Debug version of the PNaCl plugin will be copied to
the webapp directory allowing to debug PNaCl plugin (using nacl-gdb).

Also updated build-webapp.py to process all *.jinja2 input files as jinja2
templates.

This patch was previously reverted because of a problem that should be
fixed now by https://codereview.chromium.org/872673006/ .

BUG=451643

Review URL: https://codereview.chromium.org/872633006

Cr-Commit-Position: refs/heads/master@{#314873}

This CL added the image fetching code that previously lived in clank private repository.

Also I moved android enhanced_bookmark_bridge from
chrome/browser/android/enhanced_bookmarks/ to chrome/browser/enhanced_bookmarks/android,
since the latter is a more unified place to put all files in.(I deleted the
android/enhanced_bookmarks folder).

Last but not least, I made some small changes to the internal implementation of
bookmark_image_service, making it more readable.

The previously private code can be found in code search:
https://cs.corp.google.com/#clankium/src/clank/native/framework/chrome/enhanced_bookmarks/

Downstream CL: https://chrome-internal-review.googlesource.com/#/c/195438/
BUG=454623

Review URL: https://codereview.chromium.org/899653003

Cr-Commit-Position: refs/heads/master@{#314872}

This reverts commit ad352651.

It causes video on peach_pit to lock up/reboot machine.

BUG=chromium:449920, chromium:448208
TEST=test_that 100.96.59.64 video_VideoSanity.bvt doesn't reboot anymore

Review URL: https://codereview.chromium.org/898553004

Cr-Commit-Position: refs/heads/master@{#314871}

* AppBannerManager will now keep a pointer to the
  AppBannerInfoBar that gets created for it, which
  will allow it to update the UI as needed.

* Gets rid of AppBannerInfoBarDelegate; that design
  pattern doesn't make much sense even for ConfirmInfoBars.

* AppBannerManager becomes an EmptyTabObserver.

- Breaks native app promos: they won't show up until
  a follow up CL lands. Functions related to the
  AppBannerView will be removed soon.

BUG=453170

Review URL: https://codereview.chromium.org/901203003

Cr-Commit-Position: refs/heads/master@{#314870}

This pulls in the following Native Client changes:

0f2d722: (phosek@chromium.org) Removes the now-unused reverse service from the service runtime
2363d1a: (mcgrathr@chromium.org) Update DEPS for Chrome LKCR

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/885183003

Cr-Commit-Position: refs/heads/master@{#314869}

Replaces the v8_stats metric with a v8_gc_times
measurement.  This new measurement measures the amount of
time spent in GC during the whole benchmark rather than
just during gestures.

The following gc metrics are measured:
  v8_gc_incremental_marking
  v8_gc_incremental_marking_idle_deadline_overrun
  v8_gc_incremental_marking_outside_idle
  v8_gc_incremental_marking_percentage_idle
  v8_gc_mark_compactor
  v8_gc_mark_compactor_idle_deadline_overrun
  v8_gc_mark_compactor_outside_idle
  v8_gc_mark_compactor_percentage_idle
  v8_gc_scavenger
  v8_gc_scavenger_idle_deadline_overrun
  v8_gc_scavenger_outside_idle
  v8_gc_scavenger_percentage_idle
  v8_gc_total
  v8_gc_total_idle_deadline_overrun
  v8_gc_total_outside_idle

It also measures the duration of the measurement and the
amount of CPU time used.

The v8_garbage_collection_cases benchmark is modified to
use this new v8_gc_times measurement, and v8.top_25_smooth
and v8.key_mobile_sites_smooth benchmarks have been added.

Since v8_garbage_collection_cases was the only benchmark to
use the is_fast metric type, and these measurements are now
done as part of the v8_gc_times measurement now, this CL
also removes the fast metric type.

Perf Sherrifs: Since this CL changes he way in which the GC
measurements are done it may cause a movement in the
v8_garbage_collection_cases benchmarks.

Review URL: https://codereview.chromium.org/898673005

Cr-Commit-Position: refs/heads/master@{#314868}

This declares dcheck_always_on argument (false by default) so users can
override it. If set to true this will make a compiler define
(DCHECK_ALWAYS_ON=1). This mirrors GYP counterpart.

Debug:

$ gn gen out_gn/Debug --args='dcheck_always_on=true'
$ ninja -v -C out_gn/Debug base

Release:

$ gn gen --args='is_debug=false dcheck_always_on=true' out_gn/Release
$ ninja -v -C out_gn/Release base

Manually checked that -DDCHECK_ALWAYS_ON=1 is passed on the command line
to the compiler.

BUG=None
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/896413003

Cr-Commit-Position: refs/heads/master@{#314867}

Eliminate some duplicate code now that PermissionContextBase is the base class
for all other permission contexts and we have a helper function
GetPermissionContext to obtain the proper permission context class depending
on permission type. Also move PermissionToContentSetting to anonymous namespace.

BUG=

Review URL: https://codereview.chromium.org/896173002

Cr-Commit-Position: refs/heads/master@{#314866}

As some kind of optimization the yuv decoder replaced some pointers
to point to decoder-internal memory when an API user asked for
yuv data. That often worked, but failed if the data needed to
outlive the decoder. It was also a violation of the API contract.

This replaces that with a buffer copy. It will be slower but will avoid
random bitmap errors that also happened randomly on cq try bots.

This is a stopgap solution while a better solution is designed, coded and
tested.

BUG=455235
R=sugoi@chromium.org,dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/901573004

Cr-Commit-Position: refs/heads/master@{#314865}

BUG=455818

Review URL: https://codereview.chromium.org/872433005

Cr-Commit-Position: refs/heads/master@{#314864}

Spacing adjusted according to spec: http://goo.gl/vGZOmm
See screenshot(fixed version) at http://imgur.com/xptLuWK

BUG=452940
R=felt@chromium.org

Review URL: https://codereview.chromium.org/905543002

Cr-Commit-Position: refs/heads/master@{#314863}

This fixes some cases of the cursor disappearing temporarily after a
bounds change that started after r313336 ("Constrain the cursor when
overscan insets are set").

We hide the cursor during bounds changes, so we must make sure to show
it again afterwards.

BUG=427619
TEST=On link_freon, change the display resolution via Ctrl+Shift+Plus or
Ctrl+Shift+Minus, and make sure the cursor is visible afterwards.

Review URL: https://codereview.chromium.org/896343002

Cr-Commit-Position: refs/heads/master@{#314862}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/de358a9..797f58a

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/897343002

Cr-Commit-Position: refs/heads/master@{#314861}

The IME code in ui/base/ime depends on ui/ozone to support keyboard
control (via the InputController interface). This dependency is
currently missing from the build.

Unfortunately, we cannot simply add this dependency, because ui/ozone
depends on code from ui/base/cursor and ui/base/resource
(for cursor bitmaps).

Break this cycle by componentizing ui/base/ime & add a dependency
from the new ui/base/ime component to ui/ozone.

This also helps clean things up a bit because iOS builds ui/base
but not ui/base/ime. So there is already a fault line here.

The handful of IME tests are left as part of ui_base_unittests.

BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
  ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)
TBR=jam

Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82
Cr-Commit-Position: refs/heads/master@{#314815}

Review URL: https://codereview.chromium.org/889323003

Cr-Commit-Position: refs/heads/master@{#314860}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/481edde..abac64f

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/897233005

Cr-Commit-Position: refs/heads/master@{#314859}

The uploaded trace is currently inaccessible because of the stray
newline.

BUG=455782
TEST=upload a feedback report with trace & download tracing.zip

Review URL: https://codereview.chromium.org/869853004

Cr-Commit-Position: refs/heads/master@{#314858}