GitLab

Media control requests should default to hide instead of auto.

BUG=881738

Change-Id: I0aca9635aed16e7ca6d4a9f99607257344a14454
Reviewed-on: https://chromium-review.googlesource.com/1217404Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590392}

This reverts commit a8e9bac6.

Reason for revert: We have a crash in issue 876900 which we're not sure how it
happens. Based on when the crash started happening, this CL may be relevant.
We're reverting this CL to see if the crashes stop.

Original change's description:
> [Harmony Cast Dialog] Close dialog after starting a page-initiated route
>
> The dialog needs to be closed when a PresentationRequest is fulfilled,
> so that the user cannot attempt to cast again using the same request.
>
> Bug: 868186
>
> Change-Id: I9d00cc5119257bba046e67c750210104123f0bdb
> Reviewed-on: https://chromium-review.googlesource.com/1151890
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579129}

TBR=imcheng@chromium.org,takumif@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 868186,876900
Change-Id: I419a343cf8ea85cc92e219b0c5422fa9d095b805
Reviewed-on: https://chromium-review.googlesource.com/1218162Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590391}

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie3803bca746854934ab992d49aa48b1718220aad
Reviewed-on: https://chromium-review.googlesource.com/1219907
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590390}

Preparation for landing webrtc cl
https://webrtc-review.googlesource.com/c/src/+/95103.

Bug: webrtc:9378
Change-Id: Ia2510f51392ee7ce7a4c12a791a0efc120f06524
Reviewed-on: https://chromium-review.googlesource.com/1219586
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590389}

This is a reland of 87036e9b

The compile failure were caused by unhandled redundant initializations
which are now blocking (see https://crbug.com/877443#c8).
The CL landed between dryrun and submit which explains the late failure.

TBR=tedchoc@chromium.org,joedow@chromium.org

Original change's description:
> [Android] Use a delegate for all keyboard visibility functions
>
> This CL extends the use of the visibility delegate from affecting
> only the isKeyboardShown() function to all keyboard-related methods.
>
> Using a delegate is also the first step to move towards binding
> the keyboard detection to WindowAndroid. This enables other
> components like the keyboard accessory to affect the visibility on
> an activity-specific level (instead of global and static).
>
> These changes require more work and will follow in further CLs.
>
> TBR=joedow@chromium.org
> TBR Reason: Renamed an interface which doesn't change any behavior.
>
> Bug: 857460
> Change-Id: Ia878e84221d68c4a7c90a0dd2bbce9c8858d98bf
> Reviewed-on: https://chromium-review.googlesource.com/1190523
> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590243}

Bug: 857460
Change-Id: I89fc9eee5e263328b3d89ea6d908209fafa5a144
Reviewed-on: https://chromium-review.googlesource.com/1219107
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590388}

This adds TestBrowserThreadBundles to unittests that will need it when
we replace BrowserThread::PostTask() and friends with base/post_task.h.

The TestBrowserThreadBundle initializes globals that are required for
things like posting a task to or obtaining a TaskRunner for a BrowserThread.

I'm making this change in a separate patch to make review of the
future automated refactoring patches easier.

Bug: 878356
Change-Id: I100eefb16afa5490c9c7dee56c9a0bdb72501524
Reviewed-on: https://chromium-review.googlesource.com/1208170Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590387}

Change-Id: I779cece06dc42004da5382fa75f5062d38a4e7d4
Reviewed-on: https://chromium-review.googlesource.com/1220267Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590386}

$ ninja -C out/Release base
$ tools/clang/scripts/generate_compdb.py -p out/Release \
  > out/Release/compile_commands.json
$ cd out/Release
$ ~/dev/llvm/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
  -p . -clang-tidy-binary ~/dev/llvm/build/bin/clang-tidy \
  -clang-apply-replacements-binary \
  ~/dev/llvm/build/bin/clang-apply-replacements
  -checks=readability-else-after-return -fix ~/dev/chromium_official/src/base/
$ cd ../..
$ git checkout base/third_party
$ git cl format

R=thestig

Change-Id: Ifc44900f372ed4027027ba50f7a7de22d0e2f0ec
Reviewed-on: https://chromium-review.googlesource.com/1214691
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590385}

This adds an ImportCatalogTask that will take a proto directly from the
service API and add records to the database.  It has the following
behavior:
* If the timestamp matches the "current" version, it does nothing. This
  prevents stomping on the currently viewable catalog.
* If the timestamp matches the "downloading" version, it overwrites it,
  since that version is not yet viewable by the user.
* Sets the "downloading" version number to the input version timestamp.

Bug: 867488
Change-Id: I1c1725a664f348eb5399da2d42d0d8c22c44e1c0
Reviewed-on: https://chromium-review.googlesource.com/1213707Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590384}

The extra waiting is unnecessary now, and breaks due to change 1136804,
since we don't always get didSwapFrame.

Bug: internal b/113850356
Test: repro
Change-Id: Icc1d1119d3e451e009951441ede8405884f31fd9
Reviewed-on: https://chromium-review.googlesource.com/1214749Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590383}

https://skia.googlesource.com/skia.git/+log/2473d9472049..5831e1113332


git log 2473d9472049..5831e1113332 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 caryclark@google.com fix another pathmeasure fuzz
2018-09-11 caryclark@google.com Revert "Base Gradient FP Refactor"
2018-09-11 halcanary@google.com SkPDF:  Device subclass no longer tracks size.


Created with:
  gclient setdep -r src/third_party/skia@5831e1113332

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I0ba497881f4e7e4503ef9f1e2ae9c1f6c582d17c
Reviewed-on: https://chromium-review.googlesource.com/1220226Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590382}

Bug: 881214
Change-Id: I21675325deaf351bf2431935652c8bb2247bdb32
Reviewed-on: https://chromium-review.googlesource.com/1217352Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590381}

The notification pref is sent when device starts. At this time the
kVoiceInteractionEnabled is not enabled for the first time user.

Bug: 881608, b/112853995
Test: manual.
Change-Id: I4753dbaa79dca7aaa0dd0781bbee25abef825371
Reviewed-on: https://chromium-review.googlesource.com/1211876Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590380}

The local_state_ pointer was initializing to garbage memory when Chrome was run
in debug mode, causing a check if local_state_ == nullptr to incorrectly return false.
leading to a crash. This issue was preventing developers from running Chrome in debug
mode if Smart Lock is enabled.

Bug: 881958
Change-Id: Ia796eefe244ca17a1905e489aeee9a310828802c
Reviewed-on: https://chromium-review.googlesource.com/1218442Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590379}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I913cf7a647c70e54c296ce488192a163a2668b3a
Reviewed-on: https://chromium-review.googlesource.com/1219777Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590378}

Historically the Closure compiler was compiled from scratch, because it was
modified to include a Chrome-specific pass. ChromePass.java has been upstreamed
to the canonical repo for a while now, so there is no need to keep building the
compiler from scratch anymore (as of r445661)

Benefits: Rolling a new Closure compiler version is now much
 - Faster (before it took a few minutes, now it takes a few seconds).
 - Easier (no more dependencies to mvn and jdk, no setup required)

Cons:
 - No automated changelog link between previous and new versions.
 - Can't pull in closure-compiler master branch anymore, instead only what's at
   https://dl.google.com/closure-compiler/compiler-latest.zip is available.

This CL also rolls a new Closure compiler version as a proof that the new
roll_closure_compiler script works.

Bug: 867683
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I19671593a32c379ce9c3fb919f889aab56d939cf
Reviewed-on: https://chromium-review.googlesource.com/1214746Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590377}

https://chromium.googlesource.com/catapult.git/+log/c80faf456d4c..b7f5c6989122


git log c80faf456d4c..b7f5c6989122 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 simonhatch@chromium.org Dashboard - Defer emailing outside of tasklet


Created with:
  gclient setdep -r src/third_party/catapult@b7f5c6989122

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib13e06869bffbb22408c2d541796fd67375764be
Reviewed-on: https://chromium-review.googlesource.com/1220227Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590376}

Since kitkat, layouting is automatically invoked whenever a view changes
relevant properties (e.g. LayoutParams).

This isn't the case in JellyBean which caused changes to the views to be
propagated to late. By requesting the layout changes at the end of every
view update, a timely draw call happens.
This affects JellyBean only and with KitKat, it would cause redundant
layouting calls, therefore, guard it by version.

Bug: 877443
Change-Id: I050d245fae0e13d6f7a55ca984a993373d34287e
Reviewed-on: https://chromium-review.googlesource.com/1219932Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590375}

Right now the TouchActionFilter::num_of_active_touches_ are incremented
in two places.
1. At InputRouterImpl::TouchEventHandled if the touch event is a touch
   sequence start.
2. At InputRouterImpl::OnTouchEventAck if it is touch sequence start and
   the ack result is NO_CONSUMER_EXISTS

The regression is due to the WebTouchEventTraits::IsTouchSequenceStart
at TouchEventHandled. Because for every touch event (touch start, touch
move, touch end), we have to go through this check.

This CL fixes this issue. Note that InputRouterImpl::TouchEventHandled
eventually calls the InputRouterImpl::OnTouchEventAck. Since the
OnTouchEventAck already checks whether the event is a touch sequence
start or not, we should put the increment in this function.

Bug: 882369, 880289
Change-Id: I88838c31f97e17512b64387296de4c803a0228f6
Reviewed-on: https://chromium-review.googlesource.com/1216702Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590374}

In case of a non-ideal scan (user puts the same area of their finger
over and over again), the percentage goes up and we should advance
progress bar in UI to match Android's behavior.

Bug: 880105, b:112692311
Change-Id: I031eca6c2b2450f651784866ffb7ffa105a25ef1
Reviewed-on: https://chromium-review.googlesource.com/1217912Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590373}

The BrowserPlugin related tests in the file were to test features that
affect BP-based GuestViews; this only includes MimeHandlerViewGuest.

This CL moves one more such test to
'chrome_mime_handler_view_browsertest.cc'. This also involves adapting
the test such that it creates a MimeHandlerViewGuest instead of
WebViewGuest based on BrowserPlugin.

The last remaining test in 'web_view_browsertest.cc' will be removed and
adapted in a followup CL (to make sure the process is easily reversible
in case the new tests end up having issues on bots).

Bug: 553069, 330264
Change-Id: Iaa7ba33189ecb8b23e8489dab8e9b2b5e378a9be
Reviewed-on: https://chromium-review.googlesource.com/1217147Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590372}

Allowed the navigation data and params to be passed directly to
DidFailProvisionalLoadInternal, instead of revolving around obscure
pending_navigation_params_ management.

Explicited the forwarding to observers without relying on nullptr
DocumentLoader in DidFailProvisionalLoadInternal.

Finally, modified a test expectation that would otherwise cause a very
ugly hack to become necessary.

Bug: 882800
Change-Id: I6ba713939a1ed192e1212e888323b55b1c6e6af5
Reviewed-on: https://chromium-review.googlesource.com/1169464Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590371}

This reverts commit 3a16d8d9.

Reason for revert: The method used to identify virtual key events with the old virtual keyboard UI no longer holds true with the new virtual keyboard UI.

I'm investigating why that's true, but to unblock progress on SwitchAccess typing, I am reverting this change.


Original change's description:
> Ignore virtual KeyEvents in SwitchAccess
> 
> Switch access should only use KeyEvents from physical keyboards as
> switches; virtual keyboard events should be ignored.
> 
> Added a browser test for SwitchAccess
> 
> BUG=864802
> 
> Change-Id: Ia50bacafe0c0740b4eea6c9f290c8679b61d79bc
> Reviewed-on: https://chromium-review.googlesource.com/1114069
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580321}

TBR=dtseng@chromium.org,katie@chromium.org,zhelfins@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864802
Change-Id: I698bbb745e2e1371ecf4e7c800cf8d832919f927
Reviewed-on: https://chromium-review.googlesource.com/1217717Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590370}

This CL adds generated files for test cases added in
https://chromium-review.googlesource.com/1212744.

Only manual change in this CL is mixed-content/spec.src.json
and all other files are generated by generic/tools/generate.py.

Bug: 880986, 880023, 880015
Change-Id: I7be98407c527883176ab6a2e9cfc1fedb1f8bfbe
Reviewed-on: https://chromium-review.googlesource.com/1212746
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590369}

R=stevenjb@chromium.org

Bug: None
Change-Id: I70094707baab64a2831c3c1413ea64535ab2e74f
Reviewed-on: https://chromium-review.googlesource.com/1185082Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590368}

Change HostScanScheduler's primary ScheduleScan() method to allow
clients to specify if a Tether host scan should only be performed if
the device is offline. TetherComponentImpl's call on this method has
been appropriately changed -- Tether now only kicks off a host scan
on component creation if the device is offline.

Additionally, add a NetworkTypePattern argument to the
NetworkStateHandlerObserver::ScanRequested() method that
HostScanSchedulerImpl overrides. This allows HostScanSchedulerImpl to
only scan if the request matches NetworkTypePattern::Tether(). Relevant
Settings and System Tray callsites have been tweaked to request the
network types they are actually trying to scan for.

Bug: 881820
Change-Id: I72833f821dcb4575e4b28c104fa1a731144fa1b0
Reviewed-on: https://chromium-review.googlesource.com/1217707Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590367}

Add blacklist for CrSettingsResetPageTest.All (flaky) and
ExtensionWebRequestApiTest.WebRequestTypes (failing on ASAN bot).

Bug: 874090
Bug: 882631
Bug: 880584
Change-Id: Ie2a5bee8de4497a470a064ea853805a0e74b685a
Reviewed-on: https://chromium-review.googlesource.com/1217710Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ryan Cui <rcui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590366}

To avoid a useless reference add/decrease

R=eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic1c7fe92164a4249ce7b5c8642bd5efa7a5c8e1d
Reviewed-on: https://chromium-review.googlesource.com/1217713Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590365}

This reverts commit 7c5aa07b.

Reason for revert: we don't need it. The hardcoded string works probaly better for Canary/Beta channels.

Original change's description:
> Use install_static::GetAppGuid instead of the hardcoded string in BrandcodeConfigFetcher.
> 
> Bug: 769756
> Change-Id: Ifdcb0a5145ffad1d563562e2b2ea2390ff074cdc
> Reviewed-on: https://chromium-review.googlesource.com/1213178
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590275}

TBR=battre@chromium.org,vasilii@chromium.org,engedy@chromium.org

Change-Id: I3819f79aa36e61bfe61a825618496751b11a03ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 769756
Reviewed-on: https://chromium-review.googlesource.com/1219616Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590364}

This is a follow on of [1], where the sync::HttpBridge logic switched
away from URLFetcher to SimpleURLLoader, as part of the network
servicification effort.

[1] https://crrev.com/c/1174655/

It turns out that the way sync::HttpBridge interpreted the response
of an upload request changed after the migration:

By default, SimpleURLLoader does not pass a valid response body in case
of either HTTP or network errors. What is more, the new logic in
HttpBridge::OnURLLoadComplete relied precisely on null-checking the responsebody
to verify whether the upload was successful or not.

This CL changes this particular check logic so that it matches the
previous behavior: only actual network errors account for sync failures
(which map to "network connection unavailable" errors) whereas HTTP errors
(>= 400 && < 600) still account as a successful uploads.
401 specifically is handled to request expired user credentials in [2].

[2] https://cs.chromium.org/chromium/src/components/sync/engine_impl/net/sync_server_connection_manager.cc?l=84

BUG=844968,878718,880633

Change-Id: I9d0b93b527f103149a7c78ba405dde27cae779f2
Reviewed-on: https://chromium-review.googlesource.com/1217122
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590363}

In order to not discard sites with potential unsaved user state it is necessary
to run beforeunload handlers to see if they return the empty string or not. When running
handlers in this context it is undesirable to launch a modal dialog, but rather to
silently block the discard and continue running the page.

This CL adds a new BeforeUnloadType to RenderFrameHostImpl in support of this. A
follow-up change will expose functionality for invoking DispatchBeforeUnload with
this BeforeUnloadType, and returning the results of the unload via a callback.

BUG=877550

Change-Id: Iad029fb0f70f9f44695f15c5ca0c0f6e4ed7ff78
Reviewed-on: https://chromium-review.googlesource.com/1208962
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590362}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/5185d85264d2..4c916c947ab7

$ git log 5185d8526..4c916c947 --date=short --no-merges --format='%ad %ae %s'
2018-09-03 junyer Adjust a couple of the limits for fuzzing.
2018-08-30 junyer Keep the assert(3) call at the top of the function.
2018-08-30 junyer Check before matching in order to avoid wasting time.
2018-08-30 junyer That didn't fix the error. Trying something else.
2018-08-30 junyer Address MSVC error and warnings. Sigh.
2018-08-30 junyer Add PODArray<> and make BitState use it.
2018-08-28 dsturtevant Move some function documentation closer to the documented functions.
2018-08-25 junyer Tweak a couple of comments.
2018-08-16 lietar Remove NULL case from search_test.
2018-07-11 junyer Fix the "DFA out of memory" error for the reverse Prog.
2018-06-23 keller.e.ben Include operator<<() for StringPiece in libre2.so
2018-06-17 junyer Update Unicode data to 11.0.0.
2018-05-16 junyer Address `-Wclass-memaccess' warnings from GCC 8.x.
2018-05-14 junyer MSVC still needs the pragma in util/logging.h. Sigh.
2018-05-14 junyer Add GCC 8.x to the Travis CI matrix.
2018-05-14 junyer Tweak the FALLTHROUGH_INTENDED macro. Add the ATTRIBUTE_NORETURN macro.
2018-05-05 junyer Use the standard first-byte analysis for the DFA too.
2018-04-23 junyer Add more support for empty prefilter_vec_ to PrefilterTree.
2018-03-15 junyer Note more languages' package sites.
2018-03-06 junyer Try to suppress warnings with FALLTHROUGH_INTENDED.
2018-03-06 junyer We need ubuntu-toolchain-r-test again?
2018-03-06 junyer travis-ci/apt-source-whitelist is no longer updated.
2018-03-06 junyer Add Clang 6.0 to the Travis CI matrix.
2018-03-04 junyer Kludge around System Integrity Protection on Darwin.
2018-02-22 junyer Oops, not in DeBruijnString() though.
2018-02-22 junyer Use ASSERT* macros instead of CHECK* macros in tests.
2018-02-18 junyer Configure CI using Bazel on macOS and on Windows.
2018-02-18 sayrer Omit -pthread option on Darwin
2018-02-18 junyer Try to make windows-cmake.bat more readable.
2018-02-18 junyer regexp_benchmark doesn't need linkopts.
2018-02-15 ckennelly Use sized deallocation for RE2's DFA.
2018-02-13 junyer Don't #include <sys/resource.h> anymore.
2018-02-08 junyer Stop using StringPiece::ToString().
2018-02-06 junyer Fix some formatting inconsistencies.
2018-01-28 hansenr Add a std::nullptr_t ctor overload to RE2::Arg.
2018-01-11 junyer Tweak the BUILD file formatting.
2018-01-10 loorongjie [Bazel] Do not set -pthread etc. on Windows
2017-12-19 junyer Just /source-charset:utf-8 didn't work. Try /utf-8.
2017-12-19 junyer Specify the source character set for MSVC.
2017-12-13 junyer Try to appease MSVC another way. Sigh.
2017-12-13 junyer Address a couple of MSVC warnings.
2017-12-13 junyer Fix a silly off-by-one error.
2017-12-13 junyer Require Visual Studio 2015 or later.
2017-12-13 junyer Try specifying Visual Studio 14 2015 instead.
2017-12-13 junyer Make CTest extra verbose temporarily.
2017-12-13 junyer Make Regexp::FactorAlternation() not recursive.
2017-12-11 junyer Tweak factoring code and comments for consistency.
2017-12-11 junyer Split Regexp::FactorAlternationRecursive() into rounds.
2017-12-11 junyer Fix the Regexp::FactorAlternation*() argument names.
2017-12-08 junyer Retire Regexp::FactorAlternationRecursive() round 4.
2017-12-07 junyer Write size_t{4} for brevity.
2017-12-07 junyer Adjust the comment to be about GCC 6.x (for x >= 1).
2017-12-06 junyer Test past kFactorAlternationMaxDepth (8).

Created with:
  roll-dep src/third_party/re2/src

Bug: 874727
Change-Id: I33fdf09b753e80e0d375c62344a1150595e523f9
Reviewed-on: https://chromium-review.googlesource.com/1219232Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590361}

This CL avoids spawning a spare renderer process, when the system
is under moderate or higher memory pressure.

Bug: 852905
Change-Id: If01e293ed9b53eb2e861146ffa2a0bbb3e2a210f
Reviewed-on: https://chromium-review.googlesource.com/1207572Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590360}

New icons are circular an have correct padding.
Replaced 32 and 64px with 48 and 192px icons to cover a wider range
of scales.

Bug: 882176
Test: manual
Change-Id: Ib3d084297bdbd81d778bc15ee64cb1cf8578669a
Reviewed-on: https://chromium-review.googlesource.com/1219774Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590359}

Bug: 881961
Change-Id: Ie58d071b3a80f48274991eaed799fc144da1d6a1
Reviewed-on: https://chromium-review.googlesource.com/1214046Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590358}

Currently we select the input element contents when focusing back
to a <cr-input> element with shift-tab, but focusing forward to
a <cr-input> element does not select its contents. This fixes that
behavior to always select the contents to be consistent with the
behavior of <input>.

Bug: 882612
Change-Id: Iecfbd984928571ca7041133f5621d82fd32f4f35
Reviewed-on: https://chromium-review.googlesource.com/1217747Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590357}

Bug: None
Change-Id: Iab00c7254288d0b1e3d033fa6c3b41a4f3d8ee1e
Reviewed-on: https://chromium-review.googlesource.com/1213531
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590356}

The previous tweak did not disable all possible webview browsers like,
e.g., android-webview-google.

Bug: 879151
Change-Id: Ic2b0e22b06893d7e7e769dd50fb86f46bbc9c936
Reviewed-on: https://chromium-review.googlesource.com/1219614
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#590355}

Bug: 865947
Change-Id: I82057800a73057435e8ad11c64ba2374e2ef3210
Reviewed-on: https://chromium-review.googlesource.com/1219608
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590354}

https://android.googlesource.com/platform/external/perfetto.git/+log/1f658fe0d651..56de9d6b2972


git log 1f658fe0d651..56de9d6b2972 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 taylori@google.com Merge "trace_processor: Fix parsing bug"


Created with:
  gclient setdep -r src/third_party/perfetto@56de9d6b2972

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ia401e8e9f8e78b05c2b90fe38f7557a849ba671b
Reviewed-on: https://chromium-review.googlesource.com/1219417Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590353}